Commit Graph
71 Commits
Author SHA1 Message Date
Sven Grossmann 9a4c7ef758 Logs: Fix LogContext scrolling behavior (#66654)
fix logrowcontext scrolling behavior
2023-04-17 13:05:56 +02:00
Sven GrossmannandMatias Chomicki a6a7cebbe5 Logs: Redesign and improve LogContext (#65939)
* Logs: Add new LogRowContext types to grafana/data

* use right type for `RowContextOptions`

* add missing renames

* add show context modal

* no need to call

* removed unused css

* sort properties

* rename

* use correct

* use

* add tests for

* wip

* remove add/minus buttons

* add tests

* disable processing of context results in Loki

* moved into table to align properly

* remove imports

* add highlighting of opened logline

* improve scrolling behavior

* correct style for the table

* use correct query direction

* fix text

* use LoadingBar

* use overflow auto

* rename `onToggleContext` to `onOpenContext`

* add missing import

* mock scrollIntoView

* update unused props

* remove unused import

* no need to process context dataframes

* only show `LogRowContextModal` if `getRowContext` is defined

* remove unused param

* use `userEvent` rather `fireEvent`

* change to `TimeZone`

* directly use style classes

* revert change to public_dashboard_service_mock.go

* improved styling

* add missing await in test

* fix lint

* fix lint

* remove LogRow scrolling when context is opened

* remove references to `scrollElement`

* Update public/app/features/logs/components/log-context/LogRowContextModal.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* fix lint

* add comment explaining `onCloseContext`

* add comment about debounced onClose

* add comments and remove `showRowMenu`

* scroll twice to correctly center the element

* revert double scrolling

* remove unnecessary `processDataFrame`

* trigger drone

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-04-14 17:05:43 +02:00
Sven GrossmannandShirley Leu 8567ec92b0 Cloudwatch: Change type of ts field in log responses to time (#66525)
* make timestamp field time type

* Add test for type on handleLogEvents data frame field response

---------

Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>
2023-04-14 16:21:16 +02:00
Sven Grossmann fef43fff7b Logs: Use DataQuery from @grafana/schema (#66403)
Logs: Use `dataQuery` from schema
2023-04-13 13:35:23 +02:00
Sven Grossmann 7bc0692801 Logs: Add new LogRowContext types to @grafana/data (#66404)
* Logs: Add new LogRowContext types to grafana/data

* use right type for `RowContextOptions`

* add missing renames
2023-04-13 13:07:28 +02:00
Sven Grossmann 89f23fcbc9 Logs: Fix typo in filename of loki/LogContextProvider (#66410)
change filename to match class name
2023-04-13 09:39:55 +02:00
Sven Grossmann e9b15eff72 Logs: Move components to dedicated directory (#65936)
* move log-context components to dedicated directory

* fix any

* add right format of lerna.json
2023-04-11 12:19:28 +02:00
Sven Grossmann d790cb1c09 Loki: Add unpack query builder hint (#65608)
* add unpack hint

* use `hasOwnProperty`

* add unpack completion to monaco

* adjust test name

* fix tests

* fix tests
2023-03-30 15:18:02 +02:00
Sven Grossmann 07d960ac26 Logs: Position LogRowMenu sticky to be able to use it in scrollable containers (#65502)
* fix logrowmenu

* remove comment

* add comment

* get rid of absolute positions

* remove `inExplore` check
2023-03-29 15:55:28 +02:00
Sven Grossmann b01194f81e Loki: Fix autocomplete situations with multiple escaped quotes (#65520)
fix situations with multiple quotes
2023-03-29 15:00:42 +02:00
Sven Grossmann 3335d46c5f Theme: Fix wrong code segment in theme.md (#62488)
* fix wrong markdown

* fix prettier
2023-03-28 12:18:50 +01:00
Sven Grossmann 68551ac9ca Loki: Add lokiQueryChunkingOption feature flag (#65057)
* add `lokiQueryChunkingOption` feature flag

* be safe and also rely on `config.featureToggles.lokiQuerySplitting`

* renamed to `lokiQuerySplittingConfig`

* fix typo
2023-03-20 16:51:36 +01:00
Sven Grossmann 7a17a8f02d QueryStats: Fix comparison of relative and absolute timeranges (#65035)
* add missing fix of relative timeranges

* add doc
2023-03-20 11:35:03 +01:00
Sven Grossmann 6ae373b8c7 QueryStats: Fix comparison of timeranges (#65025)
* fix timerange comparison

* remove import
2023-03-20 10:04:41 +01:00
Sven Grossmann 7261c6f7cd DataSourceWithBackend: Add queryGroupId to find correlated/related queries (#64587)
* add `correlationId` to queries

* trace correlation id in backend

* add correlation id to loki's span

* add correlation id to query chunks

* fix test

* fix DataSourceWithBackend test

* change to `queryGroupId`

* remove empty line

* fix test in `DataSourceWithBackend`
2023-03-17 15:48:13 +01:00
Sven Grossmann 6f83a45e1b Logs: Fix variant of Download logs button (#64962)
fix button variant
2023-03-17 16:31:32 +02:00
Sven Grossmann 15804234d6 QueryHistory: Fix filter strings being regular escaped (#64879)
* fix wrong regex escape in query history

* fix import

* disable regexescape on `RichHistoryStarredTab`
2023-03-17 10:21:58 +01:00
Sven GrossmannandMatias Chomicki 40014f1454 Loki: Add option to define chunk duration per query (#64834)
* add query option to configure chunk ranges

* remove `isValidDuration` check

* Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* change to `chunkDuration`
added tests

* no need to call `toString`

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-03-16 16:30:12 +01:00
Sven Grossmann 652e7334c8 Loki: Remove unnecessary type extension (#64883)
remove unnecessary type extension
2023-03-16 11:28:40 +01:00
Sven Grossmann 7cde6acbef LogContext: Fix height of upper group when using logsContextDatasourceUi (#64602)
fix wrong height being set
2023-03-10 15:59:53 +01:00
Sven Grossmann b46771cbfe Loki: Always fetch for new label keys in the QueryBuilder (#64597)
* always fetch new labels

* remove refreshLogLabels
2023-03-10 13:13:51 +01:00
Sven Grossmann 6cbc956b5c LogContext: Fix border radius to be consistent (#64589)
fix border radius in LogRowContext
2023-03-10 09:58:29 +01:00
Sven GrossmannandGareth Dawson 976568a337 Loki: Fix labels in LabelBrowser being wrongly cached (#64482)
* remove label cache from label browser

* fix spelling

Co-authored-by: Gareth Dawson <gareth.dawson@grafana.com>

---------

Co-authored-by: Gareth Dawson <gareth.dawson@grafana.com>
2023-03-09 11:36:07 +01:00
Sven Grossmann 473013e3f5 Loki: Add error handling to CallResource (#64439)
* surface loki error message for `CallResource`

* use `data.Message` instead or `errorMessage`

* change struct coming from Loki

* remove whitespace
2023-03-09 11:12:33 +01:00
Sven Grossmann 42c32504be Logs: Add millisecond to timestamp in log line (#64372)
* add milliseconds to logrow

* adjust tests to also have milliseconds
2023-03-08 11:39:56 +01:00
Sven Grossmann 5db0d14606 LokiContextUi: Add loading indicator (#64167)
add loading indicator to LokiContextUi
2023-03-06 17:25:04 +01:00
Sven Grossmann 2076282064 Logs: Log samples not being ordered correctly (#64097)
* fix log samples being unsorted and multiple results when chunking

* use `SortDirection` enum

* changed to `sortDataFrame` to support other datasources than loki

* update tests

* change capitalization
2023-03-03 16:02:14 +01:00
Sven Grossmann b3c0e7e977 TestData: Fix bug when selecting "Log" streaming (#63190)
* fix wrong fields getting populated

* fix bug not being able to select another streaming type

* add correct arg type

* remove unused import
2023-02-24 14:13:56 +01:00
Sven Grossmann 3f144924d1 Loki: Do not chunk when refid contains do-not-chunk (#63276)
add ref-id to not chunk requests
2023-02-10 18:00:49 +01:00
Sven Grossmann 0bd326d846 LogsVolume: Make log volume work with chunking (#63181)
* aggregate logs volume on streaming

* enable log volume queries to be split

* add streaming indicator

* added tests

* also chunk logs queries

* change extraInfo back to undefined
2023-02-10 14:43:41 +01:00
Sven Grossmann 00edc1c6b1 Loki Context UI: Do not disable last label (#62866)
* improved text

* prevent all labels removed

* use `structuredClone` instead of lodash

* update test

* get `structuredClone` in test?

* fix using structuredClone
2023-02-10 14:23:17 +01:00
Sven GrossmannandGábor Farkas d7026900bd LokiContext: Add feature tracking (#62344)
* add feature tracking to LokiContextUi

* only depend on `row.uid`

Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>

---------

Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
2023-01-30 11:30:39 +01:00
Sven Grossmann 7eb01b1813 MultiSelect: Fix actionMeta not available in onChange callback (#62339)
add `ActionMeta` to `onChange` callback
2023-01-30 11:17:02 +01:00
Sven Grossmann ae8c61c0b2 Logs: Fix stats not being updated when log results change (#62317)
update stats in logdetails
2023-01-30 10:54:20 +01:00
Sven GrossmannandIvana Huckova da7065d3dc LokiContext: Fix wrong queries being run when reopened (#62353)
* fix wrong query being run when reopened

* fix typo

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* and test for `onClose`

* rename functions

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-01-30 09:26:27 +01:00
Sven Grossmann df2db3bb23 LogContext: Fix setting wrong height for ElasticSearch (#62330)
fix wrong height for elastic
2023-01-27 15:41:16 +01:00
Sven Grossmann 7c02d9bb8a Logs: Add experimental support to display a datasource custom UI in LogContext (#62189)
* add loki contextfilter component

* add `getLogRowContextUi` support to DataSourceAPI

* add `runContextQuery` to LogRowContextProvider

* pass `getRowContextUi` to `LogRowContext`

* adapt LogRowContext to show datasource ui

* implement LogRowContextUi in Loki

* add `logsContextDatasourceUi` feature flag

* change state to `Alpha`

* disable the feature if `logsContextDatasourceUi` is not set

* don't fetch labels in the constructor

* adjust to right height

* remove unnecessary eslint disable

* add test for LokiContextUi

* move code down in datasource.ts

* rename `refresh` to `runContextQuery`

* update datasource tests

* don't update if `updateFilter` fn changes

* organized imports in datasource.test.ts

* don't trigger on intialization changes

* change tag to `experimental`

* move `getLogRowContextUi` to props
2023-01-27 15:12:01 +01:00
Sven Grossmann 01e6a0b4df Codeowners: Assign logs files to @grafana/observability-logs (#62239)
assign "logs" files to logs squad
2023-01-26 16:50:56 +01:00
Sven Grossmann c5610450b2 Elasticsearch: Fix failing requests when using SigV4 (#61923)
fix setting of `es` servicename
2023-01-23 16:43:55 +01:00
Sven GrossmannandChristopher Moyer 6a7cbeae6c Logs: Adjust documentation for new log details (#61311)
* update doc

* fix capitalisation and formatting of headings

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* fix capitalisation and formatting

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-01-20 10:16:50 +01:00
Sven Grossmann fd70f6034f Logs: Lines with long words do not break properly (#61707)
really break anywhere
2023-01-19 12:56:44 +01:00
Sven Grossmann dd8f95a201 Elasticsearch: Fix toggle-settings are not shown correctly (#61751)
* changed `checked` propery to `value`

* revert changing the prop in the event
2023-01-19 12:32:02 +01:00
Sven Grossmann faf07716ee Loki: Use tsdb index in devenv (#61737)
update loki config to use new TSDB
2023-01-19 09:29:09 +01:00
Sven Grossmann 6c566a391d Loki: Use queries maxLines if configured, even if it is zero (#61652)
* user `query.maxLines` even if it is zero

* remove unnecessary comment
2023-01-18 10:14:42 +01:00
Sven Grossmann a5d577eca1 Logs: Make no logs found text more visible in Explore (#61651)
* move scan buttons up

* update test
2023-01-18 09:52:18 +01:00
Sven Grossmann 82d8b2036f Logs: Add possibility to download logs in JSON format (#61394)
* add implementation of `logRowsToReadableJson`

* add test for logRowsToReadableJson

* add json, txt download buttons

* changed downloadmenu to `Menu`

* set closed state when menu closes

* removed unused css

* removed unused imports

* remove isOpen state

* remove unused import

* add tests

* remove untouched file
2023-01-16 17:20:19 +01:00
Sven GrossmannandMatias Chomicki 5fe23b4964 Loki: Track obfuscated query (#61325)
* obfuscate query

* also conver numbers and comments

* query obfuscation: simplify obfuscation and keep some identifiers

* Query obfuscation: replace placeholder string with node name

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-01-13 16:16:47 +00:00
Sven Grossmann b3f28dea71 Logs: Change detected to selected label (#61487)
change `detected` to `selected`
2023-01-13 13:36:45 +00:00
Sven Grossmann b816538e09 Loki: Fix misaligned derived fields settings (#61475)
* fix loki datasource settings

* remove unnecessary spacing

* remove unused import
2023-01-13 14:25:03 +01:00
Sven Grossmann 9fa98dbbca Logs: Fix alginment of meta items (#61349)
fix items to be center
2023-01-12 10:42:28 +01:00
Sven Grossmann 5b2184c485 Logs: Unify detected fields and labels in Log Details (#60448)
* removed js-fields

* added buttons

* rename detectedField to field

* removed unused things from `logParser.ts`

* improve comment

* wip

* better way for statistics

* better hide-stats button

* update tests

* updated tests and var names

* made props optional again

* fix padding

* fix unused import

* removed test

* close elements

* renamed `LogRowMessageDetectedFields` to `LogRowMessageDisplayedFields`

* add active style to menu button

* changed comment in logParser

* updated ToolbarButton colors

* rename `Data Links` to `Links`

* fix stats button being wrongly highlighted
2023-01-11 19:20:11 +01:00
Sven Grossmann b1a8e4f2b8 Logs: Add usage tracking to new download-logs button (#61177)
* add usage tracking to new download-logs buttom

* changed 'dimension' to 'area'
2023-01-09 17:25:19 +01:00
Sven Grossmann 5ad95a2952 Loki: Fix tracking of queries_with_changed_line_limit_count (#60091)
* change line limit tracking

* updated test
2023-01-09 09:54:57 +01:00
Sven Grossmann ece0c121a5 Logs: Fix line not being selectable in Firefox (#61081)
fix log line not being selectable
2023-01-06 11:15:12 +01:00
Sven Grossmann 9f9bf4650d Loki: Fix missing parameters on Query Builder operations (#60677)
* add missing mandatory params

* improve naming

* change let to const
2022-12-22 15:31:41 +01:00
Sven Grossmann 01c4783c0b Logs: Fix height of logs component when used with topnav (#60669)
fix height for topNav
2022-12-22 14:43:02 +01:00
Sven Grossmann ae05c6180c Loki/ES: Add further items to query tracking (#60347)
* add more tracking to queries from ES and Loki

* improve tracking elasticsearch

* update type assertion

* remove unused import
2022-12-15 09:59:50 +01:00
Sven Grossmann 386faf5958 OpenSearch: Use aoss servicename if OpenSearch is configured as serverless (#60344)
* Use `aoss` if opensearch is configured as `serverless`
2022-12-14 20:22:26 +01:00
Sven Grossmann 6f64dd533f Devenv: Add back loki-promtail (#60282)
* add back loki-promtail

* update README

* add MacOS note
2022-12-14 15:02:12 +01:00
Sven Grossmann ebd728a99a Logs: Fix Logs Pagination Button styling (#60219)
use css class rather css strings
2022-12-13 16:23:16 +01:00
Sven Grossmann 8356df081d Loki/Prometheus: Fix wrong queries executed in split view (#60172)
* add context to monaco editors
2022-12-12 17:50:00 +01:00
Sven GrossmannandIvana Huckova d0eeff2fa0 Loki: Add tracking of executed queries (#59887)
* add query tracking

* add app

* add comment

* use `reportInteraction` not `console.log`

* add test to `queryUtils`

* organize imports

* add datasource tests

* change `metrics` to `metric`

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* change `parseToArray` to `parseToNodeNamesArray`

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2022-12-06 15:54:20 -05:00
Sven Grossmann 932349b5ab Loki: Fix wrongly escaped label values when using LabelFilter (#59812)
* change backticks to quotes

* add unescaping to `addFilterAsLabelFilter`

* fix removal of wrong quotes

* change unescape order
2022-12-06 12:30:03 +01:00
Sven Grossmann 400ada1ad0 Logs: Fix misalignment of LogRows (#59279)
* add default display flex

* changed to `text-align: left`
2022-11-24 13:21:55 +01:00
Sven Grossmann 08e87a217c Loki: Add gzip compression to resource calls (#59059)
* Loki: Add compression to `callResource`

* add missing tests

* fix formatting
2022-11-22 14:02:30 +01:00
Sven Grossmann a62e437eb3 DevEnv: Add default loki configuration (#59058)
add local default config
2022-11-21 17:12:27 +01:00
Sven Grossmann 4b1ddba0a8 fixed explain handlers for label- and lineformat (#58135) 2022-11-03 14:57:29 +01:00
Sven Grossmann 842b629cd1 use inherited colors on svg (#57427) 2022-10-21 15:24:02 +02:00
Sven Grossmann 598da14d88 disable double stringify (#57243) 2022-10-19 11:58:16 +02:00
Sven Grossmann 4b1b0344e4 Chore: update latest.json to 9.2.1 (#57185) 2022-10-18 15:26:17 +02:00
Sven Grossmann efe214a293 LogContext: Change line highlighting to match the hover state (#56811)
* add hover background also to logs with context

* add inherit display
2022-10-13 11:42:40 +02:00