Commit Graph

44765 Commits

Author SHA1 Message Date
Jo
a307582212
Revert "Replace signed in user for identity.requester (#73750)" (#73962)
This reverts commit 9b9c9e83dc.
2023-08-28 21:05:59 +02:00
Sven Grossmann
07eb4b1b90
Loki: Remove distinct operation (#73938)
* remove distinct

* trigger ci

* update yarn.lock

* fix import
2023-08-28 19:26:59 +02:00
linoman
9b9c9e83dc
Replace signed in user for identity.requester (#73750)
* Make identity.Requester available at Context

* Clean pkg/services/guardian/guardian.go

* Clean guardian provider and guardian AC

* Clean pkg/api/team.go

* Clean ctxhandler, datasources, plugin and live

* Question: what to do with the UserDisplayDTO?

* Clean dashboards and guardian

* Remove identity.Requester from ReqContext

* Implement NewUserDisplayDTOFromRequester

* Fix tests

* Change status code numbers for http constants

* Upgrade signature of ngalert services

* log parsing errors instead of throwing error

* Fix tests and add logs

* linting
2023-08-28 12:04:36 -05:00
Aditi Patel
b043d8d0e8
PublicDashboards: Warnings when creating a public dashboard are not properly aligned (#73794) 2023-08-28 12:52:49 -03:00
ismail simsek
cfe3d6346f
Chore: Fix the command in comments (#73872)
Fix the command in comments
2023-08-28 17:47:54 +02:00
Brendan O'Handley
4e2710670e
Prometheus: fix auth component select for sigv4 option (#73647)
* fix sigV4 selected auth option bug

* use precommit hooks
2023-08-28 11:47:44 -04:00
Brendan O'Handley
8dbd70b91b
Prometheus: Explore expand raw results in split panel bug fix (#73864)
* make switch id unique

* tests

* tests

* use useId for switch id

* space
2023-08-28 11:43:59 -04:00
Adam Simpson
b69c858b07
CloudMonitoring: Update docs with instructions for multiple projects (#73862)
* CloudMonitoring: Update docs with instructions for multiple projects

* change title case for service account

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>

* change title case for default service account

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>

---------

Co-authored-by: lwandz13 <126723338+lwandz13@users.noreply.github.com>
2023-08-28 14:59:22 +00:00
Ivana Huckova
a80fd02f95
Elasticsearch: Unify default value for geo hash grid precision across the code to 3 (#73922)
* Unify default value

* Use variable to keep default precisions in sync

* Use default precision variable

* Update precision description

* Update defaultPrecisionString and move

* Be more specific in naming of variabkle

* Revert "Merge remote-tracking branch 'origin' into ivana/es-precision-default-value"

This reverts commit 599f236a77, reversing
changes made to 6742be0c6d.

* Revert wrong merge

* Revert wrong merge with turned off lefthook
2023-08-28 16:38:44 +02:00
Samuel Roberts
116337f474
Correct path for repo on RHEL based distros (#73840) 2023-08-28 09:24:54 -05:00
Joey
59e4c257bb
Tempo: Metrics summary (#73201)
* Metrics summary

* Update query

* Remove colors

* Update states

* Add group by into its own component

* Add group by to search and traceql tabs

* Add spacing for group by

* Update span kind values

* Update span status code values

* Update query based on target + group by

* Cleanup

* Only add targetQuery if not empty

* Add kind=server to table

* Update groupBy query logic

* Add feature toggle

* Use feature toggle

* Self review

* Update target query

* Make gen-cue

* Tweak query

* Update states

* useRef for onChange

* Fix for steaming in search tab

* Add loading state tests

* metricsSummary tests

* Datasource tests

* Review updates

* Update aria-label

* Update test

* Simplify response state

* More manual testing and feedback from sync call

* Prettier and fix test

* Remove group by component from traceql tab

* Cleanup, tests, error messages

* Add feature tracking
2023-08-28 15:02:12 +01:00
Ivana Huckova
6742be0c6d
Elasticsearch: Fix respecting of precision in geo hash grid (#73917)
* Elasticsearch: Fix ignoring precision when running queries trough backend

* Unify default value

* Revert "Unify default value"

This reverts commit d8e1d207a2.

* Update test
2023-08-28 15:28:28 +02:00
Joan López de la Franca Beltran
81a639bd1b
Secrets: Add user_auth.o_auth_id_token column to migrator (#72239) 2023-08-28 15:20:20 +02:00
Juan Cabanas
36d7cc9384
Dashboards: Show repeated row with Dashboard ds warning (#73787) 2023-08-28 10:00:11 -03:00
Torkel Ödegaard
5bd58cac57
Eslint: Update grafana/eslint-config that allows public accessability modifier (#73906) 2023-08-28 14:57:49 +02:00
Kyle Brandt
38603b1a9e
Prometheus: Check for errors on json response parsing (#73788)
- The util/converter Prometheus response json parse was not checking for errors while parsing. It now does. In particular, if `[dataproxy]/response_limit` is set in Grafana's config, it will now recognize the limit error.
- Fixes #73747
- Adds `jsonitere` package, which wraps json-iterator/go's Iterator's Methods with methods that return errors, so errcheck linting can be relied upon
- Impact:
  - If something was sending malformed JSON to the prometheus or loki datasources, the previous code might have accepted that and partially processed the data
  - Before there may have been partial data with no error, where as no there may be errors but they will have no partial results, just the error.
2023-08-28 15:53:50 +03:00
Alexa V
97c3cd1af3
Dashboard: Fix Variable Dropdown to Enforce Minimum One Selection when 'All' Option is Configured (#69839) 2023-08-28 14:38:32 +02:00
Dimitris Sotirakis
e100fc927e
Security: Authenticate to GCR for trivy scans (#72658)
* Authenticate to GCR for trivy scans

# Conflicts:
#	.drone.yml

* verify-starlark

* Change secret

# Conflicts:
#	.drone.yml
2023-08-28 13:52:08 +02:00
Carl Bergquist
bd7523381e
web: removes unused function from request metadata (#73910)
Signed-off-by: bergquist <carl.bergquist@gmail.com>
2023-08-28 13:40:21 +02:00
Tobias Skarhed
2a93b6d93f
CODEOWNERS: Assign Tempo in grafana-schema (#73893)
Update CODEOWNERS
2023-08-28 12:46:57 +02:00
Torkel Ödegaard
74d453f056
DashboardSchema: Remove old unused legacy props style and timepicker.enable (#73879)
* DashboardScheam: Remove old unused legacy props style and timepicker.enable

* Update

* fix test
2023-08-28 12:18:17 +02:00
Josh Hunt
f95405d3c3
Plugins: Allow async panel migrations (#73782)
* Plugins: Allow async panel migrations

* comment
2023-08-28 10:06:55 +00:00
Ivan Ortega Alba
7543a28ae2
Rename "Add new data source" to "Connect data" (#73688)
* DS Picker: Rename "Add new data source" to "Connect data"

* DS Picker: Center empty list CTA
2023-08-28 11:54:51 +02:00
Joao Silva
6c7b46ed1d
DashList: Add tooltip for star dashboard icon (#73490) 2023-08-28 10:37:42 +01:00
Alex Khomenko
c6f0adf12d
Dashboard embed: Use port instead of callbackUrl (#73883) 2023-08-28 12:35:26 +03:00
Giuseppe Guerra
4ef98449ff
Plugins: Dynamic angular patterns: Add random offset to GCOM API calls, handle HTTP errors (#73494)
* Plugins: Dynamic angular patterns: Return error for != 2xx status code

* Add test for status code check

* Plugins: Dynamic angular patterns: Add random skew to periocic GCOM api calls

* Add test for random skew

* Changed randomSkew signature, ensure it is always positive
2023-08-28 11:34:05 +02:00
Andres Martinez Gotor
aa0d4b3e45
Chore: Fix Random Walk scenario for Grafana DS (#73889) 2023-08-28 10:53:30 +02:00
Jo
1a281ac49d
Experiment: tag UI devices for anon stats (#73748)
* experiment: attempt to tag only UI devices

* lint frontend

* use await

* use shorthand check

* do not assume build info exists

* do not assume build info exists

* Apply suggestions from code review

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>

---------

Co-authored-by: Alexander Zobnin <alexanderzobnin@gmail.com>
2023-08-28 10:49:23 +02:00
Jo
5eed495cce
Chore: Port user services to identity.Requester (#73851)
* port api key api to signedinuser

* port users to signed in user interface

* fix tests
2023-08-28 10:42:24 +02:00
Karl Persson
01d98114b9
Authz: fix snapshot tests legacy guardian (#73823)
* Guardian: remove unused dependencies

* API: rewrite tests to use access control guardian
2023-08-28 09:49:10 +02:00
Horst Gutmann
372f32963d
CI: Run gen-cue on bump-version (#73885) 2023-08-28 09:35:38 +02:00
Owen Williams
7b347fd12a
Prometheus: Add $__rate_interval_ms to go along with $__interval_ms (#69582)
* Add $__rate_interval_ms to go along with $__interval_ms

Fixes https://github.com/grafana/grafana/issues/69581

* update doc

* PoC add rate_interval_ms as rate range in prometheus

* Revert "PoC add rate_interval_ms as rate range in prometheus"

This reverts commit 7d4ec700d7.

* Update docs/sources/dashboards/variables/add-template-variables/index.md

grammar nit

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/dashboards/variables/add-template-variables/index.md

---------

Co-authored-by: Galen <galen.kistler@grafana.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
2023-08-27 16:44:58 +02:00
Ezequiel Victorero
a0e8cf8b66
PublicDashboards: Remove query expressions from dashboard model (#72468) 2023-08-25 15:35:22 -05:00
Torkel Ödegaard
3ee26df41e
PublicDashboards: Variables refactor (#73476)
Co-authored-by: Juan Cabanas <juan.cabanas@grafana.com>
Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2023-08-25 13:56:02 -05:00
Alexander Weaver
2245a3d0d1
Tracer: Export ContextWithSpan (#73715)
Export ContextWithSpan
2023-08-25 13:48:58 -05:00
Gilles De Mey
39077769a8
Alerting: Fix data source copy when switching alert rule types (#73854) 2023-08-25 20:24:50 +02:00
Galen Kistler
5ed3ddf344
Prometheus: Fix dropdowns truncating from start of array (#73643)
* move truncating to helper function, to start of array

* Prometheus: Add 1000 result warning as sticky footer in metric select (#73649)

add 1000 result warning as sticky footer in metric select

* Prometheus: Only show truncated results warning if results have been truncated (#73650)

only show truncated warning if results have been truncated

* add test to metric select

---------

Co-authored-by: Brendan O'Handley <brendan.ohandley@grafana.com>
Co-authored-by: bohandley <brendan.ohandley@gmail.com>
2023-08-25 12:58:35 -04:00
Gilles De Mey
70dc5610c0
Alerting: Fix delete cloud rule from detail page (#73850) 2023-08-25 17:39:35 +02:00
Ieva
ca46a5c1af
Chore: prepare for removing RBACenabled config option (#73845)
prepare for removing RBACenabled config option
2023-08-25 17:13:46 +02:00
Chris Bedwell
31e29de024
A11y: Fix toggletip predictable focus for keyboard users (#72100)
* Updated toggletip to use strategy fixed, added tests and temporary story so it can easily be checked

* Added FocusScope restoreFocus and appropriate tests to toggletip

* Open toggletip in test for making sure focus remains when using escape

* Add aria-expanded to toggletip toggle child

* Added to temp story for Toggletip

* Remove focusScope for toggletip and handle focus restoration manually

* Remove toggletip temp story and add toggletip long content story

---------

Co-authored-by: joshhunt <josh@trtr.co>
2023-08-25 15:00:58 +00:00
bojankezele
cb040a72bd
access control api: Correction of typo in list your permissions endpoint (#64399)
Correction of API endpoint

Correction of an API endpoint in 'List your permissions' section. Current endpoint results in 404 page
2023-08-25 16:40:09 +02:00
Gabriel MABILLE
9e52414a91
LDAP: Fix active sync with large quantities of users (#73834) 2023-08-25 16:10:48 +02:00
Ben Sully
4ce8fff98a
Fix Grafana ML icon (#73813)
`grafana-ml` was added to the `availableIconsIndex` object in
<commit> but no corresponding SVG was added, nor was the Icon
bundle updated.

This commit adds the real Grafana ML icon as gf-ml.svg, renames
the key in the availableIconsIndex accordingly, and updates the
Icon bundle using the documented script. Note that the name
was changed to `gf-ml` rather than `grafana-ml` because otherwise
the wrong directory is used (unicons rather than custom).

The main motivation for adding this is because plugin extensions
need to specify a valid icon name, and we want to use the Grafana ML
icon for our extensions, which requires the icon to be part of
core Grafana.
2023-08-25 14:59:38 +01:00
lwandz13
b654e5642c
Docs: change headings on 2 data source pages for SEO (#73792)
* changed grafana alerting titles and headings

* changed H1 heading for SEO
2023-08-25 08:48:09 -05:00
Ieva
6885b3d577
Chore: remove checks for whether RBAC is disabled (#73812)
* remove checks for whether access control is disabled, as it is always enabled now

* linting
2023-08-25 14:19:58 +01:00
George Robinson
972da629ab
Update Alertmanager to latest main (6af7ccb) (#73827) 2023-08-25 15:08:09 +02:00
Hugo Kiyodi Oshiro
c69dd41bf9
Plugins: Forward feature toggles to plugins (#72995) 2023-08-25 15:01:54 +02:00
Matias Chomicki
3170ed2dcc
Loki config: update doc links (#73690) 2023-08-25 15:54:53 +03:00
George Robinson
20172f6af1
Fix codeowners (#73829) 2023-08-25 15:42:08 +03:00
George Robinson
9f827a8278
Update grafana/alerting to 0025eb4 (#73808) 2023-08-25 15:20:17 +03:00