Commit Graph
51413 Commits
Author SHA1 Message Date
Leonor Oliveira ade96dbdbd Introduce Comparator interface (#88016)
* Introduce Comparator interface

* Add compare implementation everywhere

* Add comment explaining what Compare should do

* Lint
2024-05-29 09:42:24 +02:00
Tobias Skarhed 06304894a1 Dashboard: Keyboard and mouse panel shortcuts improvement (#87317)
* Add custom attention state to dashboard

* Add attention state to DashboardGrid

* Remove old functionality

* Add attention state to keybindingSrv

* Create PanelAttentionService

* Add PanelAttentionService with scenes support

* Remove unused code

* Use viz panel key instead of VizPanel

* Add type assertion

* Add e2e test

* Update comments

* Use panel id for non-scenes use case

* Support undefined service use case

* Memoize singleton call

* Debounce mouseover

* Set panelAttention with appEvents

* Use AppEvents for Scenes

* Remove panelAttentionSrv

* Wait in e2e to handle debounce

* Move subscription to KeybindingSrv

* Remove imports and reset keyboardShortcuts from main

* Fix on* event handlers
2024-05-29 09:11:23 +02:00
Larissa WandzuraandJack Baldry 66d6b3d83b Docs: Update Grafana Teams documentation (#86942)
* added config doc

* added content

* added new topic docs and made updates

* minor updates

* updates based on feedback

* ran prettier , made updates

* removed original doc, updates to topic docs

* removed old index doc

* fixed format issue

* Update docs/sources/administration/team-management/administering-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/administering-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/_index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* edits based on feedback

* updates based on feedback

* improved some wording

* ran prettier

* minor correction

* added aliases

* Update docs/sources/administration/team-management/configure-grafana-teams.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* added contractions

* Removed .nx

---------

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2024-05-29 08:22:45 +03:00
3eea71cc6b Azure: Basic Logs support (#88025)
* Azure monitor: Basic Logs frontend (#85905)

* adds datasource level config for enabling basic logs

* add basiclogsquery type to query json

* add toggle between basic and analytics

* adds basic logs toggle from UI, blocks time picker to only dashboard if basic logs is selected

* add check to remove UI if alerting

* tests for logsmanagement component

* tests for logs query editor

* tests for time mangement control

* remove unused imports

* clears query whenever toggle changes from basic <-> analytics

* add test to account for clearning query

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/BasicLogsToggle.tsx

wording

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* update dependency list

* clear basic logs if resources change

* fix tests

---------

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Azure Monitor: Basic Logs modal acknowledgement (#86244)

* adds datasource level config for enabling basic logs

* add basiclogsquery type to query json

* add toggle between basic and analytics

* adds basic logs toggle from UI, blocks time picker to only dashboard if basic logs is selected

* add check to remove UI if alerting

* tests for logsmanagement component

* tests for logs query editor

* tests for time mangement control

* remove unused imports

* add confirm modal

* clears query whenever toggle changes from basic <-> analytics

* add test to account for clearning query

* adds modal acknowledgement for basic logs query

* tests for handling modal logic

* basic logs ack type

* Update public/app/plugins/datasource/azuremonitor/components/ConfigEditor/BasicLogsToggle.tsx

wording

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsQueryEditor.tsx

spelling

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* update dependency list

* clear basic logs if resources change

* remove modal from config page

* remove basic logs query ack type

* add modal acknowledgement to toggle between basic and analytics

* clear query if resources change

* fix tests

* fix tests

* Update public/app/plugins/datasource/azuremonitor/components/LogsQueryEditor/LogsManagement.tsx

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* fix tests

---------

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Azure Monitor: Basic Logs Backend (#87653)

* fix logic for showingBasicLogsToggle

* move to utils function and add basiclogsquery in apply template variable

* add backend safeguards for basiclogsqueries

* adds support for calling search or query apis based on whether it is basic logs or not

* add tests for utils

* initial test for basic logs query in the backend

* tests for basic logs

* remve comment

* simplify checks for basic logs

* adds fromAlert prop for azure monitor backend services

* adds fromAlert check fo basic logs

* fix working and empty tags

* add telemetry for basic logs

* remove import from grafana core package

* change fromAlert true in tests

* change the way tests catch errors

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/utils.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* Update pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* restructure code to only run basic logs checks if basiclogsflag is true

* data retention warning

* tests for calculate time range

* Simplify determining if request is from alerting

* Fix lint and bool check

* Fix tests

* clarify data retention

---------

Co-authored-by: Jocelyn <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>

* Azure Monitor: Basic Logs data volume notification (#88009)

* frontend changes for data ingested warning

* initial logic for getResource

* payload processing

* create basicLogs usage function

* add utils for converting time and getting the data volume query for basic logs

* frontend updates for showing the data ingested for the given query

* frontend tests

* add check for when no dataIngested is returned

* remove backend.logger prints

* comment on what function does

* fix merge

* make resource URI regex case insensitive

* add support for workspace variables in basic logs flow

* add undefined check

* structure and add tests for variable support

* Update pkg/tsdb/azuremonitor/loganalytics/azure-log-analytics-datasource.go

Co-authored-by: Andreas Christou <andreas.christou@grafana.com>

* add tracing for basic logs usage request

* clean up data volume query struct

* use async/await instead of callback

* fix parameters for getApiURL

* restrict time on usage query to 8 days max

* add time to dependency array to refetch basic logs usage

* move time check implementation to backend

* fix utils tests

---------

Co-authored-by: Jocelyn <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>

---------

Co-authored-by: jcolladokuri <jcolladokuri@microsoft.com>
Co-authored-by: jcolladokuri <jocelyncollado52@gmail.com>
2024-05-28 18:06:27 +01:00
Stephen J. Smith 0b2fab9967 Azure Monitor: Fix typo that may cause an API request to fail (#88320)
Fix typo
2024-05-28 17:58:06 +01:00
Alexander WeaverandSteve Simpson b926b6336d Alerting: Scheduled recording rules execute their queries (#88309)
* Basic eval flow

* Wiring-up

* fix

* Extend todo

* Start with tests

* Include some relevant tests, skip ones that seem to have timing-based race conditions

* Some tests, touch up linter and todo

* Solve TODO

* Add tracing

* Tests to make sure an eval went through

* Wire up feature toggles

* Update pkg/services/ngalert/schedule/recording_rule.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

* Update pkg/services/ngalert/schedule/recording_rule_test.go

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

---------

Co-authored-by: Steve Simpson <steve.simpson@grafana.com>
2024-05-28 10:59:21 -05:00
Eric Leijonmarck 910553df20 Actionsets: Add cfg option for only writing actionsets (#88367)
* test

* test

* missed test

* fix review comments
2024-05-28 16:32:23 +01:00
Andrej Ocenas 5f326e98c1 NodeGraph: Add msagl and the layered layout code (#88375) 2024-05-28 17:04:03 +02:00
Bruno 07debd66c2 Ephemeral instances: fetch the grafana version from the package.json file (#88300) 2024-05-28 11:52:00 -03:00
Matthew Jacobson 8418aca823 Alerting: Add single rule checks to alert rule access control (#88307)
* Alerting: Add single rule checks to alert rule access control

Modifies ruler api single rule read to no longer fetch entire groups and instead
 use the new single rule ac check.
Simplifies provisioning api getAlertRuleAuthorized logic to always load a single
 rule instead of conditionally loading the entire group when provisioning
 permissions are not present.

* Swap out Has/AuthorizeAccessToRule for Has/AuthorizeAccessInFolder
2024-05-28 10:49:24 -04:00
Eric Leijonmarck ebbb64059f LBAC datasource: Add swagger updates (#88383)
add swagger updates
2024-05-28 15:28:12 +01:00
Jack Baldry 26c2391c7e [docs/sources/datasources] Replace docs/reference shortcode with ref URIs (#88078) 2024-05-28 15:17:49 +01:00
Jeroen Op 't Eynde e1685cb44b fix: set schemaVersion on dashboard schema (CUE) (#87712)
* fix: set schemaVersion on dashboard schema (CUE)

* docs: add comment to migration code

* fix: run make gen-cue
2024-05-28 16:16:20 +02:00
Leonor Oliveira ef07dfa3bb Add latency metrics to mode2 (#88011)
* Also call storage on mode1. Add metrics

* Update comment

* Don't use compare function for now

* Remove very important space

* Improve code readability on modes 1 and 2

* Fix tests

* Return error from legacy write

* Renume useless defer

* Start adding logging for mode2

* Retrurn errors is storage read fails

* Finish adding latency metrics to mode2

* Emit kind to metrics instead

* Fix var name

* Return if legacy delete list fails

* Unify latency calls

* Fix get function
2024-05-28 16:15:53 +02:00
Alex Khomenko c4aca053e5 DateTimePicker: Return cleared value in onChange (#88377)
* DateTimePicker: Return cleared value in onChange

* Update story
2024-05-28 17:11:15 +03:00
Mihai Doarna 12e4a94d63 SSO: Use removeSecrets() instead of setting.RedactedValue() (#88180)
* use removeSecrets() instead of setting.RedactedValue()

* replace with redacted value only if secret is not empty
2024-05-28 17:03:54 +03:00
Andres Martinez Gotor 60ce523b72 Refactor plugin context initialization (#88343) 2024-05-28 16:59:06 +03:00
Ashley Harrison ecfe50439b Chore: Remove last of the SCSS from grafana/ui (#88302)
* remove last of scss from grafana/ui

* add comment about legacySelect classes
2024-05-28 14:58:51 +01:00
Ashley Harrison b4e49e3114 Select: Ensure screenreader correctly narrates options (#88118)
* replace select aria-label with data-testid

* update in copy pasted places as well

* update plugin-e2e to 1.2.2
2024-05-28 14:51:47 +01:00
timoandAndrej Ocenas 6205236f25 NodeGraph: Use values from fixedX/fixedY column for layout (#86643)
* NodeGraph: Use values from fixedX/fixedY column for layout

* Cleanup some code, typings and naming

* Add test

---------

Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>
2024-05-28 15:34:35 +02:00
a738cb42d8 Prometheus: Update dependency to v0.52.0 (#87809)
* Prometheus: Update dependency to v0.52.0

* go work sync

* fix panics in tests

* go work sync

* prometheus v0.52.0

* handle errors

* Update pkg/services/ngalert/sender/sender_test.go

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>

* Update pkg/services/ngalert/sender/sender_test.go

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>

---------

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
2024-05-28 15:22:20 +02:00
Leonor OliveiraandArati R. 502bd5612e Storage: Extract returned object hydration into function (#88012)
* Extract returned object hydration into function

* Finish writing tests for utils func

* Lint

* Update pkg/apiserver/rest/dualwriter_mode2.go

Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>

* Better var naming

* Remove duplicated logic

* Lint

* Fix test

* Lint

* Make type private

* Fix one more test

* Fix test

---------

Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>
2024-05-28 15:14:27 +02:00
Andreas Christou 4f3ab51d69 AzureMonitor: Fix service selection in E2E tests (#88378)
Use selectall to replace text
2024-05-28 14:09:20 +01:00
Sofia Papagiannaki d2f44816fd TeamLBAC: add missing swagger tag (#88374) 2024-05-28 15:34:30 +03:00
Jack WestbrookandMarcus Efraimsson 5ce68c50e3 Docs: add decoupled plugin commands to developer guide (#88286)
* docs(developer-guide): add development commands for building decoupled plugins

* docs(developer-guide): add subheading, tidy up tone

* Apply suggestions from code review

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* docs(developer-guide): plugins section to identify which plugins need additional cmds

---------

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2024-05-28 14:28:18 +02:00
Ashley Harrison f1dbe39533 Chore: Improve typings (#88282)
* remove some type assertions

* some more type assertion fixes

* nicer

* shortcircuit while loop when hitting something that isn't an HTMLElement
2024-05-28 13:20:57 +01:00
Tobias Skarhed c8ab138dbf TimeRangePicker: Use native scrollbar (#88327)
* Use native scrollbar

* Native overflow scroll

* Fix feedback

* Make scrollbars thin
2024-05-28 13:41:31 +02:00
Ashley Harrison 7e25ff5756 Select: Support option groups in virtualised Selects (#88232)
* change select group headers to always be visible

* remove unnecessary SelectOptionGroup

* hacky change to work with virtualised lists

* undo this change

* add top border

* remove children from the category header

* don't virtualize story

* bit of renaming

* comments

* add new story for virtualized options
2024-05-28 10:49:43 +01:00
Jack Westbrook cd3c10d905 Chore: Sync sass with theme (#88340)
chore(sass): run theme:generate to sync sass with theme
2024-05-28 11:49:02 +02:00
github-actions[bot]andgithub-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> 4817156ba3 I18n: Download translations from Crowdin (#88365)
New Crowdin translations by GitHub Action

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-05-28 12:18:19 +03:00
Matias Chomicki 97cb92eb1e Logs: Added multi-line display control to the "wrap lines" option (#88144)
* LogRowMessage: strip new lines when wrapping is disabled

* LogRowMessage: prevent conflicts between failed json parsing and unwrapping

* LogRowMessage: expand multi-line unwrapped logs when opening details

* Add unit test

* Prettier

* chore: update comment
2024-05-28 11:59:11 +03:00
Ashley Harrison 6f9527b4c2 DashboardGrid: Ensure drag handle always follows the cursor (#88099)
use flushSync in react-grid-layout
2024-05-28 09:46:04 +01:00
Gabriel MABILLEandClaudiu Dragalina-Paraipan 3d9908f363 Fix: Prevent ExtSvcTokens from containing nil characters (#88243)
* Fix: Prevent ExtSvcTokens from containing nil characters

* Rebase

* Add more logs

* Nit. nil -> NUL

* Nit. Part -> Parts

* Back to const

* Account for comments

Co-authored-by: Claudiu Dragalina-Paraipan <claudiu.dragalina@grafana.com>

---------

Co-authored-by: Claudiu Dragalina-Paraipan <claudiu.dragalina@grafana.com>
2024-05-28 10:39:46 +02:00
Laura Benz f6a83432a5 RestoreDashboards: Create trash section (#88278)
* feat: add feature toggle to docs

* feat: create page in BE

* feat: create page in FE

* refactor: set feat toggle as a condition

* refactor

* refactor

* refactor

* feat: add permission conditions

* refactor

* feat: add subtitle to translations

* feat: add to codeowners

* refactor: fix docs situation

* refactor

* Merge main branch into feat branch
2024-05-28 10:26:06 +02:00
gng0 f772056296 DataLinks: Fixes datalinks with onClick and variables in url not being interpolated (#86253)
* Use replaceVariables method on link url, fix and add unit tests

* Refactor href processing for links

* Prettier
2024-05-28 08:16:55 +02:00
Andres Martinez Gotor 0b526acf09 Fix provisioning for a missing plugin (#88354) 2024-05-28 01:47:45 +03:00
Sofia Papagiannaki 39298a656a Swagger: sync specs with enterprise (#88355) 2024-05-28 01:12:54 +03:00
Laura Fernández 6d98f53e8b Chore: Remove returnToPrevious feature toggle (#88332) 2024-05-27 17:47:57 +02:00
Steve SimpsonandSantiago 08b18113d2 Alerting: Wire up alertmanagerRemoteOnly feature toggle. (#88329)
* Alerting: Wire up alertmanagerRemoteOnly feature toggle.

Though the mode isn't feature complete yet, it will be useful to have the
feature toggle wired up in order to start testing.

* Apply suggestions from code review

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>

* Formatting

---------

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
2024-05-27 16:18:46 +02:00
Misi aac6e6dfd9 Auth: Update SAML lib to improve HTTP-Post binding (#88287)
* Update lib and docs for HTTP-Post binding

* Improve docs

* fix spelling

* Regenerate go.sum and go.work.sum
2024-05-27 14:56:52 +02:00
Dominik Prokop 6e9543e0ad Preserve variables and time range when navigating between dashboards (#87966)
* POC preserve filters and group by when navigating between dashboards

* Save all variables and time range

* minor refactor

* Add feature toggle

* Update feature toggle usage

* Delete local storage item if nothing to preserve

* Structural changes

* Simplify restore params code

* Use session storage

* Add tests

* Merge fix

* Remove unused code

* And make it better, errrrrr

* Minor deduplication refactor

* last minor
2024-05-27 14:28:06 +02:00
Marcus Efraimsson 0b1aec6767 Tracing: Various improvements (#88308) 2024-05-27 14:21:40 +02:00
Ivan Ortega Alba 66950c96f6 Dashboards: Discard the entire panel if it is newly added (#87562) 2024-05-27 13:46:02 +02:00
kay delaney c0881cc970 Dashboards: Detect unsaved folder change (#88293) 2024-05-27 12:43:31 +01:00
Luis Felipe Dominguez Vega 4248ff4688 ValueFormats: Add Uruguay peso currency (#88260) 2024-05-27 11:45:37 +01:00
Giuseppe Guerra 2b54ce6c51 Chore: Bump google.golang.org/grpc to 1.64.0 (#88219)
* Bump google.golang.org/grpc to 1.64.0

* Address grpc.Dial deprecation notices

* go mod tidy

* Update go.work.sum

* go work sync
2024-05-27 12:44:39 +02:00
Piotr Jamróz 0530b296d0 Correlations: Enable feature toggle by default (on-prem) (#88208)
* Correlations: Enable feature toggle for on-prem

* Update Loki test
2024-05-27 12:04:37 +02:00
Joao Silva 45faefa8b3 TimeRangePicker: Allow users to navigate quick ranges with arrows instead of Tab (#88138) 2024-05-27 10:33:53 +01:00
Joao Silva 3014103f41 Chore: Remove gf-form from OrganizeFieldsTransformerEditor (#88240) 2024-05-27 10:26:47 +01:00
Levente Balogh f77f47ff00 Plugins: Update the plugin.json schema with UI extensions meta-data (#88288)
* feat: change the `generated` property

* refactor: update the schema description for the "extensions" field
2024-05-27 11:13:46 +02:00