Commit Graph
46970 Commits
Author SHA1 Message Date
Kyle Cunningham b42d652106 Transformations: Move transformation addition into drawer (#78299)
* Start splitting out code

* Use flag

* A bit of rocket surgery

* Prettify

* Cleanup behavior

* Work through behaviors

* Move empty message from other PR

* Import fixes and prettier

* Clean things up

* Add selector for tests

* Cleanups

* Working with transformation redesign

* Some more tweaks to make sure of correct behavior

* Update betterer/eslint exceptions

* Localization

* Remove unecessary fragments

* Spacing and prettier

* Update tests for new UI

* Update e2e tests

* One more e2e test fix

* Update selectors

* Fix one test and break another
2023-12-01 14:08:54 -06:00
Isabella Siu d894f4cc79 CloudWatch: Correctly quote metric names with special characters (#78958) 2023-12-01 14:37:09 -05:00
Sven GrossmannandGalen af05fdc806 Transformations: Fill array with undefined to prevent mismatching length (#78911)
* fill array with `undefined` to prevent matching length

* update unit test to include sortBy transformation

---------

Co-authored-by: Galen <galen.kistler@grafana.com>
2023-12-01 13:33:05 -06:00
Piotr Jamróz b64802ed3b Correlations: Add error logging (#78272)
* Add error logging when parsing correlations

* Make orgId optional

* Add module property and move source and target to context for better readability
2023-12-01 20:26:05 +01:00
Gilles De Mey 58d0c51cf4 Alerting: Add note to the docs that GMA rules are evaluated concurrently (#78902) 2023-12-01 18:32:48 +01:00
ismail simsek 2b0e7afb4e InfluxDB: Fix an edge case while parsing table response (#78802)
* Prepare the test files

* use json files everywhere

* update golden json files

* disable update

* update test file

* fix naming

* lint

* InfluxDB: Add metadata information to first frame only (#78664)

* executedString in first frame only

* lint

* fix tests

* update tests

* don't update

* linting

* update

* update again

* handle nil values

* append in the right array

* add comments

* remove redundant if condition
2023-12-01 18:31:49 +01:00
Alexander Weaver ab0ef5276f Alerting: Decouple quota configuration logic from API interfaces and add tests (#78930)
* Separate usage reporter from API

* Extract quota registration

* Decouple from API store interface

* Move to ngalert package and add tests

* linter
2023-12-01 10:47:19 -06:00
Joey Orlando ea7a179f2a Plugins: Add grafana/user/profile/tab plugin extension point (#77863)
* add grafana/user/profile/settings
plugin extension point

* changes to support plugins having their
own settings tabs

* WIP

* add comment

* add unit tests

* allow setting open tab based on tab query param

* update name of extension point

* add some more unit tests

* address PR comments

* PR comments
2023-12-01 15:18:27 +00:00
Laura Fernández 517746dc83 Internationalization: Add information about the process to send feedback to Crowdin (#78755) 2023-12-01 16:10:23 +01:00
Ivan Ortega Alba e56a252158 GeneralSettings: Edit general dashboards settings to scenes (#78492) 2023-12-01 17:04:56 +02:00
Ieva c354c7bfff RBAC: Update fixed annotation roles (#78756)
* update fixed annotation roles if FlagAnnotationPermissionUpdate is enabled

* add dashboard type scope back in the fixed roles to make the migration easier
2023-12-01 14:50:55 +00:00
MisiandGabriel MABILLE d3a269ab3b Auth: Load ini/env vars settings in the fallback strategy (#78495)
* Return data in camelCase from the OAuth fb strategy

* changes

* wip

* Add defaults for oauth fb strategy

* revert other changes

* Add tests

* Add Defaults to cfg and use it in OAuthStrategy

* Return *OAuthInfo from OAuthStrategy

* lint

* Remove unnecessary Defaults

* Introduce const for fields, fix import order

* Align failing tests

* clean up

* Changes requested by @gamab

* Update pkg/services/ssosettings/strategies/oauth_strategy_test.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* Load data on startup

* Rename + simplify

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2023-12-01 15:35:44 +01:00
ismail simsek 46044efdf8 Fix: Use dashboard time range in prometheus variable editor (#78950)
Use dashboard time range in variable editor
2023-12-01 15:30:47 +01:00
Fabrizio ae3f1506df Tempo: Fix read-only access error (#78801) 2023-12-01 13:55:48 +01:00
Steve Simpson 520c927931 Alerting: Only warm alert state cache if execute_alerts=true. (#78895)
* Alerting: Only warm alert state cache if execute_alerts=true.

If the Grafana instance is not executing alerts, then Warm()-ing the state
manager is wasteful and could lead to misleading rule status queries, as the
status returned will be always based on the state loaded from the database at
startup, and not the most recent evaluation state.

* Move Warm() down to shared conditional.
2023-12-01 10:17:32 +01:00
Ivan Ortega Alba 8d7314bb9a DeleteDashboard: Redirect to home after deleting a dashboard (#78918) 2023-12-01 10:15:41 +01:00
Dominik Prokop 303c3ddc24 DashboardScene: Pass hashed panelId to query runner if a panel is a clone (#78820)
* DashboardScene: Pass hashed panelId  to query runner if a panel is a clone

* Test

* Nit
2023-12-01 01:07:55 -08:00
Gilles De Mey 69e1046ed3 Alerting: Hide error messages for failing HTTP calls to Grafana OnCall (#78919) 2023-11-30 22:30:24 +01:00
Galen Kistler 243c7583c9 Logs Panel: Table UI - Logs.tsx clean up mutation in react lifecycle (#78925)
* remove prop mutation in componentWillUnmount
2023-11-30 20:04:42 +00:00
Giordano Ricci 5af7b451d0 docs: Reword shortened link expiration explainer (#78922)
docs: reword shortened link expiration explainer
2023-11-30 18:54:56 +00:00
Virginia Cepeda 148e1c1588 Alerting: Change create/update permissions for silences (#78920)
* Change create/update permissions for silences

* Add comment
2023-11-30 20:28:37 +02:00
Domas b40e61d935 Timeseries to table transformation: Fix misaligned table field values if some frames are missing a label (#78909)
* fix bug with time series table transform when a frame is missing a label

* prettier format
2023-11-30 19:09:52 +02:00
e361839261 Tooltip: Improved Heatmap tooltip (#75712)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-11-30 11:04:56 -06:00
Matthew JacobsonandChristopher Moyer 5a80962de9 Alerting: Add clean_upgrade config and deprecate force_migration (#78324)
* Alerting: Add clean_upgrade config and deprecate force_migration

Upgrading to UA and rolling back will no longer delete any data by default. 
Instead, each set of tables will remain unchanged when switching between 
legacy and UA. As such, the force_migration config has been deprecated 
and no extra configuration is required to roll back to legacy anymore.

If clean_upgrade is set to true when upgrading from legacy alerting to Unified
Alerting, grafana will first delete all existing Unified Alerting resources,
thus re-upgrading all organizations from scratch. If false or unset,
organizations that have previously upgraded will not lose their existing Unified
 Alerting data when switching between legacy and Unified Alerting.

 Similar to force_migration, it should be kept false when not needed as it may
 cause unintended data-loss if left enabled.

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-11-30 11:01:11 -05:00
Karl Persson 0f0249abea RBAC: Fix filter so that check for access on service account is correct (#78907)
Fix filter so that check for access on service account is in correct place
2023-11-30 17:32:04 +02:00
Matthew Jacobson cdad712547 Alerting: Keep track of individual org migration status (#78369)
* Alerting: Keep track of individual org migration status

Save migration status per migrated org.

Change the meaning (and key/value) of the org_id=0 entry 
to store the current (previous) config value used by alerting. 
This is so we can know when to upgrade/downgrade by 
comparing with the new config value in 
UnifiedAlerting.IsEnabled.
2023-11-30 10:25:59 -05:00
Ashley Harrisonandeledobleefe 329d0e79ec Navigation: Rearrange IA based on tree test (#78804)
* rearrange IA

* add landing page routes and subtitles

* Translate menu items

* add frontend-observability icon

* proper frontend-observability icon

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
2023-11-30 15:18:05 +00:00
Gilles De Mey 7ccdea6f67 Alerting: Fixes combination of multiple predicates for rule search (#78910) 2023-11-30 16:13:05 +01:00
Gabriel MABILLEandMarcus Efraimsson ef2c79d22a Chore: use errutil for pluginRepo errors (#78647)
* Chore: use errutil for pluginRepo errors

* Update pkg/util/errutil/status.go

* Use errutil helper functions

Co-Authored-By: Marcus Efraimsson <marcus.efraimsson@gmail.com>

* Forgot the log level

* Use entity

---------

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2023-11-30 15:49:27 +01:00
Santiago d64c2b6f4e Alerting: Implement ApplyConfig in the forked Alertmanager (#78684)
* Alerting: Add a sync interval for ApplyConfig in remote secondary mode

* remove out of scope code

* remove parentheses after CleanUp for consistency in test comments

* Add comment to ApplyConfig
2023-11-30 15:36:41 +01:00
Kristina aa2f74a6c6 Navigation: More updates to the docs for admin subsections (#78857)
* Add more subnav to docs

* Add bold around UX text
2023-11-30 08:19:07 -06:00
Santiago 316c8b50bc Alerting: Add SaveAndApply methods to the forked Alertmanager (remote secondary) (#78827)
* Alerting: Add configuration methods to the forked Alertmanager for remote secondary modes

* update comments
2023-11-30 15:18:56 +01:00
Eric LeijonmarckandGabriel MABILLE 3311467210 Auth: AzureAD surface error from group claims (#78808)
* Add error to surface for groups groups not valid

* Update pkg/login/social/azuread_oauth.go

---------

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2023-11-30 15:08:15 +01:00
Virginia Cepeda 588f87ef1e Alerting: Filter insights panels (grafanacloud-usage ds) by instance_id (#78657)
* Filter grafana-managed panels by instance_id

* Filter grafana alertmanager panels by instance_id

* Filter mimir managed panels by instance_id

* Filter mimir managed per group by instance id

* Filter mimir alertmanager panels by instance id

* Fix typos in queries
2023-11-30 10:42:53 -03:00
ismail simsek dff5022021 Chore: Return executedString information even with frames has no time column (#78906)
* return executedString for no time column responses

* remove comment
2023-11-30 14:25:15 +01:00
Gilles De Mey 7cbf5ae78d Alerting: Remove old contact points view (#78704) 2023-11-30 13:37:14 +01:00
Matias Chomicki 24082d61c2 Query splitting: add key to merged response (#78522)
* Query splitting: add key to response

* Query splitting: use queryGroupId as key

* Add unit test
2023-11-30 14:27:44 +02:00
Andreas Christou f26ad881ed Plugins: Only set non-existing headers for core plugin requests (#78633)
* Only set non-existing headers

- Add test scenario

* Fix test
2023-11-30 11:51:40 +00:00
Oscar Kilhed af7de68c65 Transformations: Add regression analysis gdev dashboard (#78720)
* add regression analysis gdev dashboard

* Update jsonnet

* set time to fixed
2023-11-30 11:52:04 +01:00
Joey ea3dda60ce TraceView: Improve small screen design in TracePageSearchBar (#78807)
Improve small screen design in TracePageSearchBar
2023-11-30 10:26:52 +00:00
Torkel Ödegaard d33a624ba6 DashboardScene: View panel scene (#78718)
* DashboardScene: View panel fixes

* Update

* Update

* Update

* works and added tests

* Update

* Update
2023-11-30 11:20:15 +01:00
Alexander Zobnin 8e01932166 RBAC: Fix permissions for dashboard import (#78891) 2023-11-30 12:01:01 +02:00
brendamuirandGilles De Mey 1b2a621533 Docs: adds docs on excluding labels (#78806)
* Docs: adds docs on excluding labels

* run prettier

* Update docs/sources/alerting/fundamentals/annotation-label/labels-and-label-matchers.md

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>

* adds table for display

* ran prettier

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-11-30 10:26:22 +01:00
github-actions[bot]andgrafanabot 12b624313c Update make docs procedure (#78877)
Co-authored-by: grafanabot <bot@grafana.com>
2023-11-30 08:50:38 +00:00
Misi 79577e4929 Auth: Remove oAuthProviders from Social service (#78732)
* Remove oauthProviders from social svc

* Add EnabledFn to supportbundles.Collector
2023-11-30 09:30:35 +01:00
ShirleyandFiona Liao 86311e3a33 CloudWatch: Refactor query batching (#78581)
Co-authored-by: Fiona Liao <fiona.y.liao@gmail.com>
2023-11-29 22:43:34 +01:00
Dan CechandMarcus Efraimsson 3c89e68fc1 Chore: Fix timeout issues when gathering prometheus datasource stats (#74618)
* fix timeout issues when gathering prometheus flavor stats

* workaround data race in sdk tracing middleware

* cap concurrency at 10

---------

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2023-11-29 16:01:54 -05:00
Alexander Weaver 8a56a94781 Usagestats: Add stat group for alert rule groups (#78825)
* Add rule group support to usagestats service

* Quote column name
2023-11-29 14:37:36 -06:00
Sven Grossmann a50be7ea0a Loki: Fix derived fields with undefined matcherType (#78849)
Loki: Fix derived fields with no `matcherType`
2023-11-29 20:55:00 +01:00
Galen KistlerandSven Grossmann 25c152c4d8 Logs panel: Logs table UI - add datasource type to events (#78850)
* add datasource type to logs table ui events

---------

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-11-29 21:50:32 +02:00