Artur Wierzbicki
ef401f5d62
Storage: improve path validation, add tests ( #50441 )
...
* improve path validation
* add test case
2022-06-09 21:09:06 +04:00
Artur Wierzbicki
58a783c0e4
Previews: improve docs phrasing ( #50405 )
2022-06-08 13:50:59 +02:00
Artur Wierzbicki and Ryan McKinley
49112c8356
Search: fix 'Clear filters' button ( #50227 )
...
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
2022-06-07 11:57:23 +04:00
Artur Wierzbicki
fac8db8ff6
Previews: update docs for the new search layout ( #50130 )
...
* #44449 : update docs, remove the mention of `Show previews` toggle
* #44449 : remove formatting of `grid`
* #44449 : review
* review https://github.com/grafana/grafana/pull/50130#discussion_r888449621
2022-06-06 11:09:16 +04:00
Artur Wierzbicki
03fe1435a0
Storage: store uploaded files in SQL rather than on the disk ( #49034 )
...
* #48259 : set up storages per org id
* #48259 : migrate to storage_sql
2022-05-21 16:55:11 -07:00
Artur Wierzbicki and JitaC
156e14e296
Previews: beta docs ( #47993 )
...
* #44449 : preview docs draft
* #44449 : remove localhost
* #44449 : fixes
* #44449 : remove localhost
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* #44449 : update link
* #44449 : review comment https://github.com/grafana/grafana/pull/47993#discussion_r866363311
* #44449 : https://github.com/grafana/grafana/pull/47993#discussion_r866363825
* #44449 : https://github.com/grafana/grafana/pull/47993#discussion_r866364182
* #44449 : https://github.com/grafana/grafana/pull/47993#discussion_r866365003
* #44449 : https://github.com/grafana/grafana/pull/47993#discussion_r866359611
* #44449 : https://github.com/grafana/grafana/pull/47993#discussion_r866361949
* #44449 : add note about the first crawler run
* #44449 : https://github.com/grafana/grafana/pull/47993/files#r866355629
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* fix up
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* typo
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* Update docs/sources/dashboards/previews.md
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
* rephrase
* replace gifs with webms
* reword
Co-authored-by: JitaC <70489351+achatterjee-grafana@users.noreply.github.com >
2022-05-17 13:02:50 -07:00
Artur Wierzbicki
7a05941ea0
Previews: improve logging, add time measurements to the crawler ( #49043 )
...
* #44449 : log times taken for various things in previews service / crawler
* #44449 : remove stale log
2022-05-16 18:09:46 -07:00
Artur Wierzbicki
5c321599c8
Storage: enable SQL backend ( #48095 )
...
* #45498 : add String util to ListResponse for better UX
* #45498 : refactor db_filestorage FS API backend - use path_hash in DB schema
* #45498 : enable DB backend fs api tests
* #45498 : add comment
* #45498 : enable Storage feature flag during integration tests
* remove fmt.println
* #45498 : reduce sizes of hash columns
* separate conditions
* #45498 : make it easy to ignore backends when running fs api integration tests
* #45498 : quote `key` column name
* #45498 : reduce path_hash size
* #45498 : verify `/{orgId}/{storageName}/` prefix convention in integration tests
* #45498 : add etag to the sql table
* #45498 : add etag to the sql table
* remove feature flag check (storage isn't dev-mode only)
* add cacheControl and content disposition
* add comments
* add path_hash comment
* explicitly set `path` column collation in `file` table for postgres
2022-05-16 10:26:40 -07:00
Artur Wierzbicki
de75dd6aad
Search: remove dev-mode from the feature flag
2022-05-02 23:01:29 +04:00
Artur Wierzbicki
d4616cfe26
Search: support auth filter based on access control/rbac ( #48350 )
...
* #45498 : add rbac support in searchv2
* to revert: fix dependency cycle
* Revert "to revert: fix dependency cycle"
This reverts commit 1ffbee73ec
2022-04-28 22:16:23 +04:00
Artur Wierzbicki
484bd0b557
Storage: use FlagStorageLocalUpload for HTTP API
2022-04-28 18:33:02 +04:00
Artur Wierzbicki
736be74128
Chore: Add Usage stats providers registry ( #48357 )
...
* add usage stats providers
* migrate thumbnails service to `registry.ProvidesUsageStats`
* snake -> camel
* lint fix
* migrate accesscontrol to `registry.ProvidesUsageStats`
* add accesscontrol to usage stats providers registry
* fix test
* added a note about errors
2022-04-28 13:06:49 +04:00
25e153e4e7
Search: in-memory index ( #47709 )
...
* #45498 : add entity events table
* #45498 : add entity events service
* #45498 : hook up entity events service to http server
* #45498 : use `dashboards.id` rather than `uid` and `org_id` in grn
* Update pkg/services/entityevents/service.go
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
* #45498 : move entityeventsservice to services/store
* #45498 : add null check
* #45498 : rename
* #45498 : fix comment
* #45498 : switch grn back to uid
* Search: listen for updates (#47719 )
* #45498 : wire entity event service with searchv2
* load last event id before building index for org 1
* fix service init in integration tests
* depend on required subset of event store methods
* Update pkg/services/sqlstore/migrations/entity_events_mig.go
Co-authored-by: Alexander Emelin <frvzmb@gmail.com >
* #45498 : pointer receiver
* #45498 : mockery!
* #45498 : add entity events service to background services
* dashboard query pagination, allow queries while re-indexing
* log level cleanups, use rlock, add comments
* fix lint, check feature toggle in search v2 service
* use unix time for event created column
* add missing changes for created column
* fix integration tests init
* log re-index execution times on info level
* #45498 : fix entityEventsService tests
* #45498 : save events on dashboard delete
* use camel case for log labels
* formatting
* #45498 : rename grn to entityid
* #45498 : add `IsDisabled` to entityEventsService
* #45498 : remove feature flag from migration
* better context usage, fix capacity, comments/cleanups
* replace print with logger
* Revert "#45498 : remove feature flag from migration"
This reverts commit ed23968898ryantxu@gmail.com >
Co-authored-by: Alexander Emelin <frvzmb@gmail.com >
2022-04-27 12:29:39 +04:00
Artur Wierzbicki
2e599643f6
Previews: refactor ( #47728 )
...
* #44449 : return standard thumb service even if auth setup fails
* #44449 : remove dashboardPreviewsScheduler feature flag
* #44449 : externalize dashboardPreviews config
* #44449 : disable previews by default
* #44449 : rename logger
* #44449 : dashboardPreviewsAdmin feature requires dev mode
* #44449 : retrigger CII
2022-04-25 01:55:10 +04:00
Artur Wierzbicki
87dc1bfc88
Chore: enforce feature naming convention ( #48053 )
...
* enforce feature naming convention
* fix link
* add comment
* fix lint
* move the feature name check test to toggles_gen_test
2022-04-22 08:23:30 +04:00
Artur Wierzbicki
9f0b6a5754
Storage: refactor filtering, improve performance ( #47403 )
...
* Storage: refactor filtering, improve performance
* added a comment to `newpathfilter`
* after merge fixes
2022-04-21 23:27:43 +04:00
Artur Wierzbicki
46dc1e98fa
Previews: track oss adoption
2022-04-13 11:54:49 +02:00
Artur Wierzbicki
a4381ebc91
Previews: create crawler auth setup service ( #47349 )
...
* #46968 : add `RetrieveServiceAccountIdByName` to serviceaccounts service
* #46968 : improve error logging in rendering service
* #46968 : add oss crawler account setup
* #46968 : fix tests
* #46968 : switch back to ROLE_ADMIN
* #46968 : rename to crawlerAuth
* comment crawler_auth.go
2022-04-12 19:34:04 +02:00
Artur Wierzbicki
712b239d5a
Storage: remove pointer on write path ( #47580 )
...
* remove pointer to contents in UpsertFileCommand
* add command to UpsertFileCommand
* fix client after API refactor
2022-04-12 16:58:09 +02:00
Artur Wierzbicki
f1a1070d41
UsageStats: track enabled features ( #47407 )
...
* #47127 : include enabled features in the usage stats reports
* #47127 : convert feature names to snake cased metric names
* #47127 : remove dead code
* #47127 : lint fix
* #47127 : convert GetUsageStats to return `map[string]interface{}`
* #47127 : fix testssssssss
* #47127 : fix testssssssss
2022-04-08 12:42:33 +02:00
Artur Wierzbicki
60984881ec
Previews: fix crawler in multi-org deployments ( #46967 )
...
* Previews: fix crawler in multi-org deployments
* Previews: fix statement ordering
2022-03-29 13:40:11 +01:00
Artur Wierzbicki
5881127319
Storage: fix filestorage.Wrapper PathFiltering and non-recursive folder listing ( #46469 )
...
* fix pathFilters in wrapper - apply rootPath changes before filtering
* fix non-recursive folder listing
2022-03-11 23:16:46 +04:00
Artur Wierzbicki
ed924b3d0c
Storage: list filtering and root folder support ( #46453 )
...
* git the things: FS api internal changes
* remove filestorage/service.go
* remove filestore flag
* remove dummy fs
* readd fileblob import
2022-03-11 22:08:19 +04:00
Artur Wierzbicki
bdbb9ed54a
Live: Fix support for StreamingFrameAction.Replace ( #46086 )
...
* fix StreamingFrameAction.replace
* simplify
* beautify
* cover `streamingDataFrame.ts` changes with unit tests
* formatting
* cover `LiveDataStream.ts` changes with unit tests
* update frame length after pushing new values
2022-03-04 14:04:30 +04:00
Artur Wierzbicki and Ryan McKinley
a8b90d9a25
FileStore: add basic file storage API ( #46051 )
...
* #45498 : fs API alpha
* #45498 : remove grafanaDS changes for filestorage.go
* #45498 : fix lint
* #45498 : fix lint
* #45498 : remove db file storage migration
* #45498 : linting
* #45498 : linting
* #45498 : linting
* #45498 : fix imports
* #45498 : add comment
* remove StorageName abstractions
* FileStore: add dummy implementation (#46071 )
* #45498 : bring back grafanaDs changes, add dummy filestorage
* #45498 : rename grafanaDs to public
* #45498 : modify join
* #45498 : review fix
* #45498 : unnecessary leading newline (whitespace) IMPORTANT FIX
* #45498 : fix belongsToStorage
* #45498 : fix removeStoragePrefix so that it works with abs paths
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
2022-03-03 10:53:26 +04:00
Artur Wierzbicki
c04b0179ff
Previews: prevent scheduler from running when image renderer is outdated ( #45623 )
...
* #44449 : prevent crawler from running when rendering service is outdated
* #44449 : simplify
2022-02-18 21:29:18 +04:00
Artur Wierzbicki
7643ae6c5e
Rendering: periodically refresh remote plugin version ( #45505 )
...
* #44449 : refresh image renderer version on a schedule
* #44449 : simplify
2022-02-18 20:25:01 +04:00
Artur Wierzbicki
3e53a08090
#44449 : hide dashboard preview admin UI ( #45493 )
2022-02-17 12:34:07 +04:00
6c76aa71e8
Previews: capability check ( #44601 )
...
* add SQL migrations
* dashboard previews from sql: poc
* added todos
* refactor: use the same enums where possible
* use useEffect, always return json
* added todo
* refactor + delete files after use
* refactor + fix manual thumbnail upload
* refactor: move all interactions with sqlStore to thumbnail repo
* refactor: remove file operations in thumb crawler/service
* refactor: fix dashboard_thumbs sql store
* refactor: extracted thumbnail fetching/updating to a hook
* refactor: store thumbnails in redux store
* refactor: store thumbnails in redux store
* refactor: private'd repo methods
* removed redux storage, saving images as blobs
* allow for configurable rendering timeouts
* added 1) query for dashboards with stale thumbnails, 2) command for marking thumbnails as stale
* use sql-based queue in crawler
* ui for marking thumbnails as stale
* replaced `stale` boolean prop with `state` enum
* introduce rendering session
* compilation errors
* fix crawler stop button
* rename thumbnail state frozen to locked
* #44449 : fix merge conflicts
* #44449 : remove thumb methods from `Store` interface
* #44449 : clean filepath, defer file closing
* #44449 : fix rendering.Theme cyclic import
* #44449 : linting
* #44449 : linting
* #44449 : mutex'd crawlerStatus access
* #44449 : added integration tests for `sqlstore.dashboard_thumbs`
* #44449 : added comments to explain the `ThumbnailState` enum
* #44449 : use os.ReadFile rather then os.Open
* #44449 : always enable dashboardPreviews feature during integration tests
* #44449 : add /previews/system-requirements API
* #44449 : remove sleep time, adjust number of threads
* #44449 : review fix: add `orgId` to `DashboardThumbnailMeta`
* #44449 : review fix: automatic parsing of thumbnailState
* #44449 : update returned json
* #44449 : UI changes - dashboard previews sytem req check
* #44449 : lint fixes
* #44449 : fix tests
* #44449 : typo
* #44449 : fix getSystemRequirements API: return 200 even if we plugin version is invalid
* #44449 : fix getSystemRequirements API: don't return SemverConstraint on error
* #44449 : fix getSystemRequirements API
* #44449 : fix previews sytem requirements text
* #44449 : add `doThumbnailsExist` to repo
* #44449 : remove redux api
* #44449 : add missing model
* #44449 : implement frontedsettings-driven capability check
* #44449 : simplify
* #44449 : revert test changes
* #44449 : add dummy setup settings
* #44449 : implicit typing over `FC<Props>`
* #44449 : refactor conditionals
* #44449 : replace `getText` with a react component
* #44449 : fix component interface
* #44449 : add onRemove to `PreviewsSystemRequirements` alert
* #44449 : add bottom/top margin to previewSystemRequirements modal
* #44449 : merge conflict fix
* #44449 : remove console.log
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
Co-authored-by: Alexander Emelin <frvzmb@gmail.com >
2022-02-16 21:49:50 +04:00
0276b029fc
Previews: crawler as a background service ( #44891 )
...
* add SQL migrations
* dashboard previews from sql: poc
* added todos
* refactor: use the same enums where possible
* use useEffect, always return json
* added todo
* refactor + delete files after use
* refactor + fix manual thumbnail upload
* refactor: move all interactions with sqlStore to thumbnail repo
* refactor: remove file operations in thumb crawler/service
* refactor: fix dashboard_thumbs sql store
* refactor: extracted thumbnail fetching/updating to a hook
* refactor: store thumbnails in redux store
* refactor: store thumbnails in redux store
* refactor: private'd repo methods
* removed redux storage, saving images as blobs
* allow for configurable rendering timeouts
* added 1) query for dashboards with stale thumbnails, 2) command for marking thumbnails as stale
* use sql-based queue in crawler
* ui for marking thumbnails as stale
* replaced `stale` boolean prop with `state` enum
* introduce rendering session
* compilation errors
* fix crawler stop button
* rename thumbnail state frozen to locked
* #44449 : fix merge conflicts
* #44449 : remove thumb methods from `Store` interface
* #44449 : clean filepath, defer file closing
* #44449 : fix rendering.Theme cyclic import
* #44449 : linting
* #44449 : linting
* #44449 : mutex'd crawlerStatus access
* #44449 : added integration tests for `sqlstore.dashboard_thumbs`
* #44449 : added comments to explain the `ThumbnailState` enum
* #44449 : use os.ReadFile rather then os.Open
* #44449 : always enable dashboardPreviews feature during integration tests
* #44449 : remove sleep time, adjust number of threads
* #44449 : review fix: add `orgId` to `DashboardThumbnailMeta`
* #44449 : review fix: automatic parsing of thumbnailState
* #44449 : lint fixes
* #44449 : crawler as a background service v0.1
* #44449 : use ServerLockService
* #44449 : use ServerLockService
* #44449 : review fix: prefer `WithDbSession` over `WithTransactionalDbSession`
* #44449 : review fix: add a comment explaining source of the filepath
* #44449 : review fix: added filepath validation
* #44449 : fix FindDashboardsWithStaleThumbnails to include `theme` and `kind` in search params
* #44449 : fix FindDashboardsWithStaleThumbnails to include `theme` and `kind` in search params
* #44449 : create function for crawler on demand
* #44449 : improve crawler logging
* #44449 : fix wire
* #44449 : uncomment dummy thumb service, fix ticker interval
* #44449 : prevent race condition
* #44449 : improve logging
* #44449 : fix theme
* #44449 : review fixes https://github.com/grafana/grafana/pull/45063/files @fzambia
* #44449 : add missing unlock
* #44449 : merge
* #44449 : review fix - logger @fzambia https://github.com/grafana/grafana/pull/45063/files
* #44449 : formatting
* #44449 : merge conflict fix
* #44449 : merge conflict fix
* #44449 : merge conflict fix
* #44449 : naming fix
* #44449 : update authOpts
* #44449 : change authOpts.role back to admin
* #44449 : fix `walk` signature, move ctx to a first argument
* #44449 : add `dashboardPreviewsScheduler` feature flag
Co-authored-by: Ryan McKinley <ryantxu@gmail.com >
Co-authored-by: Alexander Emelin <frvzmb@gmail.com >
2022-02-10 22:45:00 +04:00
Artur Wierzbicki
d60c2dff40
Chore: export closestIdx from StreamingDataFrame ( #45162 )
...
* #41993 : export closestIdx function
* #41993 : formatting
* #41993 : formatting v2
2022-02-09 22:12:24 +04:00
ArturWierzbicki
45a8701cb5
Chore: Updated the link to the plugin developer guide docs - it used to point to an old version ( #40710 )
2021-10-25 12:11:44 +04:00
Artur Wierzbicki
