Commit Graph

19009 Commits

Author SHA1 Message Date
Ashley Harrison
0325fdecb8
Chore: Fix main build (#70424)
add check for empty object
2023-06-21 11:33:09 +03:00
RoxanaAnamariaTurc
3c88868fe5
Internationalization: Mark up phrases for translation on Dashboards page (#70361)
* Internationalization:Mark up phrases for translation on Dashboards page

* Internationalization: Mark up phrases for translation on Dashboards page
2023-06-21 09:07:42 +01:00
Sonia Aguilar
e6243f72fd
Alerting: Add file and rule_group query params in request for filtering the res… (#70379)
* Add file and rule_group query params in request for filtering the response when loading rule in view mode

* Fix test
2023-06-21 09:08:20 +02:00
Ashley Harrison
13e3308959
Chore: some type fixes (#69860)
* some type fixes

* restore empty object

* undo 1 fix for now

* commit betterer update

* explicitly type slug and uid as string | undefined
2023-06-20 17:13:49 +01:00
Piotr Jamróz
a94ba7784a
Explore: Remove storing derived "loading" property (#70324)
* Remove storing derived state (loading property) and use a selector instead

* Remove redundant tests

There's no way to change the interval while live streaming

* Remove check for isLive when deriving waiting for data

It was introduced in #18804

* Remove unused props
2023-06-20 17:38:05 +02:00
Matias Chomicki
fd6836e326
Cloud rules: fix hardcoded conditional (#70387) 2023-06-20 16:39:48 +02:00
Ivana Huckova
60f6538bad
Loki: Use getNormalizedLokiQuery to get queryType (#70237)
* Loki: Use getNormalizedLokiQuery to get queryType

* Simplify

* Remove unused import

* Refactor, improve and add tests

* Update
2023-06-20 16:27:32 +02:00
Sven Grossmann
90b621be20
Logs: Add tracking for permalinking (#70334)
* add permalink tracking

* move location override to beforeAll

* add `logLevel` to tracking
2023-06-20 14:55:51 +02:00
Gilles De Mey
5c4571f231
Alerting: Align notification policies design (#70345) 2023-06-20 15:49:54 +03:00
Matias Chomicki
912c5ccb6a
Elasticsearch: fix type-related bug within targetContainsTemplate (#69798)
* Elasticsearch: fix type-related bug within targetContainsTemplate

* Refactor to fix found regression
2023-06-20 15:43:49 +03:00
Sarah Zinger
65d85ca9bf
Suggestions: Prioritize preferred visualizations for suggestion list (#67326)
Prioritize preferred visualizations for suggestion list.
2023-06-20 14:40:28 +02:00
Giordano Ricci
d5d3db9a6e
DSPicker: Respect datasource & mixed props (#70377) 2023-06-20 14:21:49 +02:00
Torkel Ödegaard
7b9e047ffd
TopNav: Cleanup theme flags (#67990)
* TopNav: Cleanup theme flags

* Update

* update
2023-06-20 13:58:57 +02:00
Sven Grossmann
bdc1d666f4
Insights: Fix optional buildInfo type (#70372)
fix unnecessary optional type
2023-06-20 13:04:54 +02:00
Sven Grossmann
ae1da1a38d
Insights: Add Grafana version to rudderstack events (#70105)
add build info to rudderstack
2023-06-20 12:25:37 +02:00
Gilles De Mey
87884f4d41
Alerting: Allow selecting the same custom group when swapping folders (#70337) 2023-06-20 11:28:24 +02:00
Sven Grossmann
fc39dadf62
Logs: Change permalink icon back to link (#70362)
change icon to link-icon
2023-06-20 11:50:43 +03:00
Gareth Dawson
b552595e0a
Logs: Add new scroll behaviour to logs samples panel (#70320)
update log sample scroll with new bahaviour
2023-06-20 09:40:10 +01:00
Ivana Huckova
750630626e
Loki: Add step input field validation (#70319)
* Loki: Add step inpout field validation

* Show invalid step in Options

* Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* Update test

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-06-20 09:24:01 +02:00
Zoltán Bedi
39433b5b9a
Candlestick: Migrate to schema (#62113)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-06-20 07:18:40 +03:00
Andrej Ocenas
5ca03a82f0
FlameGraph: Add sandwich view (#70268) 2023-06-19 16:34:06 +02:00
Ashley Harrison
db44ba305e
Command palette: Include help links (#70234)
enrich help node with frontend links
2023-06-19 13:29:26 +01:00
Joey
06a4b6da62
Tempo: Use pipe in TraceQL by default for multi-value variables (#70051)
* Use pipe in traceQL by default for multi value variables

* Use constant
2023-06-19 13:28:56 +01:00
Sonia Aguilar
9a252c763a
Alerting: Add notification policies preview in alert creation (#68839)
* Add notification policies preview in alert rule form
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>

* Refactor using new useGetPotentialInstances hook and apply some style changes

* Add notification policy detail modal

* Use backtesting api for simulating  potential alert instances

* Fix logic to travserse all the children from the root route

* Split notification preview by alert manager

* Add instance count to matching policy header and fix some styles

* Move some logic to a new hook useGetAlertManagersSourceNames to make the code more clean

* Fix some tests

* Add initial test for NotificationPreview

* Use button to preview potential instances

* Add link to contact point details

* Add route matching result details

* Show AlertManager image in the routing preview list

* Add tests setup, add single AM preview test

* Handle no matchers and no labels use case

* Update some style in collapse component and fix policy path in modal

* Update modal styles

* Update styles

* Update collapse header styling

* Normalize tree nodes should happen before findMatchingRoutes call

* Fix findMatchingRoutes and findMatchingAlertGroups methods after reabasing

* Move instances matching to the web worker code

* Fix config fetching for vanilla prometheus AMs

* Add tests

* Add tests mocks

* Fix tests after adding web worker

* Display matching labels for each matching alert instance

* Add minor css improvements

* Revert changes added in Collapse component as we don't use it anymore

* Move the route details modal to a separate file

* Move NotificationRoute and preview hook into separate files

* Fix Alertmanager preview tests

* Fix tests

* Move matcher code to a separate file, improve matcher mock

* Add permissions control for contact point edit view link

* Fix from and to for the temporal use of backtesting api

* Fix tests, add lazy loading of the preview component

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>

* Fix preview test

* Add onclick on the header div so it collapse and expands when clicking on it, and update styles to be consistent with the rest of tables

* Adapt the code to the new rule testing endpoint definition

* Fix tests

* small changes after reviewing the final code

* compute entire inherited tree before computing the routes map

* Throw error in case of not having receiver in routesByIdMap and add test for the use case of inheriting receiver from parent to check UI throws no errors

* Add list of labels in the policy route path that produces the policy matchers to match potential instances

* Use color determined by the key, in label tags when hovering matchers in the policy tree

* Remove labels in modal and handle empty string as receiver to inherit from parent as we do with undefined

* Revert "Add list of labels in the policy route path that produces the policy matchers to match potential instances"

This reverts commit ee73ae9cf9.

* fix inheritance for computeInheritedTree

* Fix message shown when preview has not been executed yet

* First round for adressing PR review comments

* Adress the rest of PR review commments

* Update texts and rename id prop in NotificaitonStep to alertUid

---------

Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-06-19 13:32:17 +02:00
Sven Grossmann
1a985c488c
Logs: Fix scrolling with exploreScrollableLogsContainer feature flag (#70164)
correct scrolling with `exploreScrollableLogsContainer`
2023-06-19 13:15:22 +02:00
Gábor Farkas
271cdb4baa
loki: rename experimental feature flag (#70306) 2023-06-19 10:03:51 +00:00
Giordano Ricci
6a3c6eb174
Explore: Ensure datasource is present in the URL for every query (#70307) 2023-06-19 10:46:59 +01:00
Matias Chomicki
a75752b085
Elasticsearch: remove usages of any (#69575)
* Elasticsearch: remove usages of any

* Elasticsearch: check for filter type when accessing field aggs

* Elasticsearch: use type guards instead of checking types

* Use unknown for isPrimitive function

* Add deprecation notice

* Remove unused type

* Fix bug in "isPrimitive" function

* Remove unused import

* Revert "Fix bug in "isPrimitive" function"

This reverts commit 27f9874cce.
2023-06-19 11:01:08 +02:00
Nicolas DUPEUX
cb7e18938b
[opentsdb] Allow custom tag key in OpenTSDB Query editor (#62762) 2023-06-17 10:01:14 -04:00
Ivan Ortega Alba
565ed09f6b
Explore: Use new DS picker (#70054) 2023-06-17 10:12:29 +02:00
Nathan Marrs
d7a8892f3a
Canvas: Migrate to schema (#70205) 2023-06-17 05:56:23 +03:00
Brendan O'Handley
3425012ee4
Prometheus: Variable query editor improvements (#69884)
* refactor metric select and label filters, add variables to label names dropdown

* use MetricsLabelsSection in variable editor

* use variable editor UI with MetricsLabelsSection

* filter label names by optional metric and allow metric to be cleared

* fix tests

* testing types for onChangeLabels

* testing types for onChangeLabels

* testing types for onChangeLabels

* Ismails review, remove comment and indent

* wrap label filters

* improved behavior for selects and inputs, add tests and document behavior
2023-06-16 15:03:34 -04:00
Virginia Cepeda
160ff360c4
Alerting: Make QueryEditor not collapsable (#70112)
* Add option to make QueryEditor not collapsable

* Make QueryEditor not collapsable in Alerting

* Change query editor border to weak

The medium border is really only for inputs, everything else should use weak border

* Add tests
2023-06-16 15:14:00 -03:00
Leon Sorokin
66b0e6b77f
XYChart/Trend: Fix min/max and units/decimals x-field overrides (#70214) 2023-06-16 11:10:53 -05:00
Ivana Huckova
82c125d450
Loki: Implement step editor (#69648)
* Loki: Implement step editor

* Update to keep value

* Remove console.log

* Remove white space

* Update public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* Import trim

* Update using of step in split queries

* Add tests

* Add tests

* Remove step interpolation

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-06-16 19:08:29 +03:00
Ivan Ortega Alba
6be0ca396f
DS Picker: first item is always active when filtering (#70071)
* Select always the first item by default when filtering

* Avoid re-render when updating the selected item state
2023-06-16 18:30:49 +03:00
Giordano Ricci
520cd55d54
Explore: Improve logs volume panel empty state (#70240) 2023-06-16 15:58:36 +01:00
Gilles De Mey
69b1153205
Alerting: Contact Points v2 feature flag (#70165) 2023-06-16 16:19:44 +02:00
George Robinson
35d455e931
Show the alertname for each alert in plain text email (#70183) 2023-06-16 10:06:43 -04:00
Ivan Ortega Alba
9b1f1df9e8
Mixed DS: Use new DS picker (#70052) 2023-06-16 15:12:52 +02:00
Simon Podlipsky
6f880b713a
Variables: allow {} type in VariableWithOptions.current (#64358) 2023-06-16 14:31:12 +02:00
Sven Grossmann
68637059c4
Logs: Add permalink to log lines (#69464)
* create explore panel state for logs

* add props to LogRows and unify

* pass properties from explore to logs

* add css

* implement button and scrolling

* export and use `getUrlStateFromPaneState`

* make `scrollIntoView` optional

* change state handling for permalinks

* change link icon

* removed unused state

* add tests for `LogRowMessage`

* remove unused prop

* fix name

* reorg component

* add `LogRow` tests

* add test for `Logs`

* Update public/app/features/logs/components/LogRow.test.tsx

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* Update public/app/features/explore/Logs/Logs.test.tsx

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* improve types in test

* fix props export in Logs.tsx

* fix props export in LogRowMessage.tsx

* fix props export in LogRow.tsx

* fixed import

* fix theme import

* remove hidden style

* add better test names

* change to `log line` rather logline

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* fix tooltips

* remove unused css

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-06-16 14:07:51 +02:00
Galen Kistler
c1fe8e8927
Prometheus: Expr undefined at runtime (#70010)
* null/undefined expression default to empty string
2023-06-16 07:01:40 -05:00
Ida Štambuk
2d4db2fd64
Cloudwatch: Wrap filters and tag inputs in Variable Editor (#69862)
Add shrink to ec2 filters + resource tags
2023-06-16 13:44:22 +02:00
Gilles De Mey
7952907e48
Alerting: Allow executing "hidden" queries (#70064) 2023-06-16 13:14:46 +02:00
Matias Chomicki
6e2c811fd8
Elasticsearch: Update error message shown when testing the datasource (#70189)
* Elasticsearch: update error message shown when testing the datasource

* Elasticsearch: update successful test message

* Update e2e test
2023-06-16 12:56:34 +02:00
George Robinson
a773b722b1
Alerting: Fix newlines in text/plain template (#70207)
Alerting: Fix newlines in text/plain template at last
2023-06-16 09:02:58 +01:00
Leon Sorokin
7d4f7e5ffc
XYChart: Fix variable interpolation in datalinks/toggletip (#70195) 2023-06-15 19:04:41 -06:00
Leon Sorokin
94881597d8
XYChart: Fix formatting of axis ticks (units, decimals) (#70190) 2023-06-15 11:32:20 -05:00
Ivan Ortega Alba
5b97670f11
DS Picker: Support width and hideTextValue (#70074) 2023-06-15 16:34:20 +02:00
George Robinson
a3845c9e2e
Fix unwanted newlines in plain text email (#70141) 2023-06-15 15:04:10 +01:00
Giordano Ricci
2675f90eaa
Chore: Skip Explore flaky test (#70157) 2023-06-15 14:55:25 +01:00
Sven Grossmann
25b65cce25
Log Context: Fix component height to fit revert-button (#70159)
fix item height
2023-06-15 15:48:24 +02:00
Victor Marin
f06ccbdf6e
Fix BarGaugePanel to not show unnecessary scrollbar when links are set (#69989) 2023-06-15 16:34:54 +03:00
Ieva
21f8dd9599
Auth: Show invite button if disable login form is set to false (#69946)
* show invite button if disable login form is set to false

* fix test

* Update public/app/features/users/UsersActionBar.tsx

Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>

---------

Co-authored-by: Misi <mgyongyosi@users.noreply.github.com>
2023-06-15 13:17:45 +01:00
kay delaney
5c152e5a24
PanelTypeCard: Improve contrast for disabled cards (#69907) 2023-06-15 13:00:14 +01:00
kay delaney
a65c3c1ebc
DynamicConfigValueEditor: Pass ID to dynamic component and label (#69910)
Closes #66337
2023-06-15 12:59:52 +01:00
kay delaney
367faf8102
VariableEditorListRow: Adjust icon styles (#70014) 2023-06-15 12:59:40 +01:00
Gareth Dawson
cda10fae52
Logs: Make logs container scrollable (#69371)
* feat: make logs container scrollable

* fix container height

* add a feature toggle

* fix: scroll behaviour with wrap lines on

* Update public/app/features/logs/components/getLogRowStyles.ts

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>

* rename feature toggle

---------

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-06-15 12:25:34 +01:00
Josh Hunt
57d7288fe4
TextPanel: Fix <summary> styling missing the disclosure triangle (#70133)
TextPanel: Fix <summary> styling
2023-06-15 10:12:27 +00:00
Josh Hunt
1f6a44f58b
TextPanel: Add unit tests for interpolating variables before converting markdown (#70090) 2023-06-15 10:06:03 +00:00
George Robinson
1154720df2
Run make in emails folder (#70113) 2023-06-15 01:24:43 +03:00
George Robinson
c1e3362e21
Alerting: Fix email template for text/plain emails (#69951)
This commit fixes the email template for text/plain emails to
support custom messages. It also fixes the default template,
removing extra whitespace and showing Summary and Description
annotations separate from the other annotations.
2023-06-14 23:09:06 +01:00
Ezequiel Victorero
fc374f93a3
PublicDashboards: Support timezone on query API (#68560) 2023-06-14 17:35:01 -03:00
Nathan Marrs
e7d8d48407
Canvas: Tweak inline editor border styling (#70099) 2023-06-14 21:39:59 +03:00
Haris Rozajac
a40e589db7
Explore: Fixed Starred query history tab to show all starred queries (#69914)
* Starred queries shouldn't have from and to params

* Update request id when starred is true

* Update tests
2023-06-14 11:14:03 -06:00
Alexander Zobnin
6c7d5bf95f
Authn UI: Remove feature toggle (#70073)
* Authn UI: Remove feature toggle

* remove feature flag usage
2023-06-14 19:58:15 +03:00
Kristina
3850f7b334
Correlations: UX updates (#69313)
* Round 1

* Add comma

* Remove validate query from editor

* Slightly change headings

* Change text
2023-06-14 08:34:06 -05:00
Sven Grossmann
87eb76947b
Revert "LogsPanel: Remove bottom margin" (#69999)
Revert "LogsPanel: Remove bottom margin (#69850)"

This reverts commit 66851d5d87.
2023-06-14 13:24:23 +02:00
Jaroslav Benc
12cd99ae8d
Pass testing status to the data source plugin extension (#69988) 2023-06-14 13:18:24 +02:00
Kostas Pelelis
9f065a8835
EchoBackend: Make EchoSrvTransport batched (#70012)
Make EchoSrvTransport batched

With the update of faro web sdk to 1.1.0, batching was introduced, in
which several telemetry signals can be grouped together in a fixed
interval or buffer length. The current setup in which the
EchoSrvTransport was proxying signals through the Echo Backend was
yielding the following issue.

The updated Fetch transport is batched but the way it was being used by
the `GrafanaJavascriptAgentBackend` was pushing single items.
2023-06-14 13:18:28 +03:00
Alexa V
b60b43640f
Revert "Variables: Show description instead of definition in table" (#70043) 2023-06-14 12:50:38 +03:00
Joey
5c45b8724b
Tracing: Use new DataSourceDescription component (#69443)
Use new DataSourceDescription component
2023-06-14 10:45:36 +01:00
Ivan Ortega Alba
1e75c9c514
DS Picker: Use new built-in DS icons (#69797) 2023-06-14 12:36:21 +03:00
Ivan Ortega Alba
908b248e10
DS Picker: Built-in datasources are not marked as selected (#70020) 2023-06-14 10:52:49 +02:00
Adela Almasan
9e198ba745
Barchart: Fix tooltip for normal/percentage stacking(2) (#69956) 2023-06-13 14:16:41 -05:00
Nathan Marrs
feb2b5878b
Geomap: Optimize panel rendering behavior (#69827) 2023-06-13 10:15:51 -07:00
Ivan Ortega Alba
bc48622919
DS Picker: Fix React key issue for built-in data source list (#70018) 2023-06-13 16:06:49 +00:00
Victor Marin
073c961330
Datagrid usage tracking (#69826)
datagrid usage tracking
2023-06-13 16:48:11 +03:00
Gilles De Mey
a00d7770bc
Alerting: Show disabled provisioned evaluation group (#69932) 2023-06-13 11:26:01 +02:00
Galen Kistler
fb290235fd
Prometheus: Fix empty query string (expr) breaking dashboard panel (#69938)
* empty string if query.expr is undefined or null
2023-06-12 14:42:59 -05:00
Adela Almasan
a4d8049999
Barchart: Fix tooltip for normal/percentage stacking (#69931) 2023-06-12 13:56:20 -05:00
Ashley Harrison
266751b96d
NestedFolders: stay in the modal whilst actions complete (#69730)
* stay in the modal whilst actions complete

* don't return anything here to fix types

* ensure we're always resetting button state
2023-06-12 16:53:17 +01:00
Ashley Harrison
9799a28fad
Nested folders: add analytics tracking for some features (#69901)
* add analytics for folder creation

* add interaction tracking for move/delete

* add tracking for item clicked in the new browse view

* review comments

* emit counts instead
2023-06-12 16:52:08 +01:00
Tobias Skarhed
b1da3dd202
Chore: Remove some SASS classnames from SubMenu (#69302)
Remove classNames from SubMenu
2023-06-12 17:25:38 +02:00
Nathan Marrs
8bb8b9b29a
Canvas: Update inline edit to use theme shadow (#69926) 2023-06-12 08:11:42 -07:00
Ashley Harrison
9eb8ec9fa9
Command Palette: Links opened in a new tab now route correctly when Grafana is served under a subpath (#69845)
don't strip base from url since we're not using locationSrv.push anymore
2023-06-12 15:58:38 +01:00
Isabella Siu
5a831d877a
CloudWatch Logs: add monaco editor feature flag and types (#69871) 2023-06-12 09:49:52 -04:00
Sven Grossmann
15d55c371c
Loki: Add feature tracking to reduce repetition (#69900)
add tracking to predefined queries
2023-06-12 13:03:47 +02:00
Dominik Prokop
1de8f48a53
Repeats: Set scoped vars correctly for collapsed panel when toggled (#69707) 2023-06-12 02:59:05 -07:00
Ivana Huckova
38fc22538a
Loki: Don't split queries if they use $__range variables (#69852)
* Loki: Don't split queries if they use  variables

* Update public/app/plugins/datasource/loki/querySplitting.ts

Co-authored-by: Matias Chomicki <matyax@gmail.com>

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-06-12 11:22:04 +02:00
Sven Grossmann
66851d5d87
LogsPanel: Remove bottom margin (#69850)
drop margin-bottom
2023-06-12 11:21:18 +02:00
Torkel Ödegaard
3cb14074a9
Dashboard: Clear current dashboard when moving away from dashboard (#66538) 2023-06-12 11:18:37 +02:00
Darren Janeczek
d61af3adde
Dashboards: Data source template variable options now specify a current value using uid. (#69259)
* feat: template data source option current by uid

* fix: e2e with explicit uid for "slow-prometheus"

* revert: unrelated change

* revert: unreverted the actually related change

* chore: e2e support for testing ${variable:text}

* fix: use `:raw` instead of `:value` in e2e dashboard
2023-06-12 01:05:50 -07:00
Nathan Marrs
3f6d55b041
Geomap: Fix tooltip bug (#69773) 2023-06-11 04:17:27 -07:00
Leon Sorokin
cc8bedc173
Heatmap: Sort fields by numeric names when single frame (#69879) 2023-06-10 23:12:29 -05:00
Ashley Harrison
d29124214a
NestedFolders: Ensure New dashboard page has the correct breadcrumb hierarchy (#69758)
ensure new dashboard page has the correct breadcrumb hierarchy
2023-06-09 16:22:57 +01:00
Alex Khomenko
516baf59fb
StyleGuide: Add testing guide (#69403)
* StyleGuide: Testing Select

* Add mocking section

* Fixes

* Add examples of backendSrv mocks

* Minor tweaks

* Updates after review

* Update examples
2023-06-09 18:21:32 +03:00
Ashley Harrison
ca8d0ef041
NestedFolders: Move New folder into a drawer (#69706)
* make New folder a drawer

* use sentence case

* extract strings and update tests

* use sm drawer
2023-06-09 16:00:16 +01:00
Ibrahim
a5b9eac88e
Transformations: Config overrides being lost when config from query transform is applied (#69720)
fix config overides being lost by transforms
2023-06-09 10:57:56 -04:00