Commit Graph

50811 Commits

Author SHA1 Message Date
Konrad Lalik
2db56b9c85
GrafanaUI: Add minWidth and maxWidth props to the Box component (#86607)
* Add minWidth and maxWidth props to the Box component

* Add height props, use theme spacing for sizing
2024-04-24 10:52:00 +02:00
Serge Zaitsev
522a98c126
Chore: Make Cfg field private in SQLStore (#85593)
* make cfg private in sqlstore

* fix db init in tests

* fix case

* fix folder test init

* fix imports

* make another Cfg private

* remove another Cfg

* remove unused variable

* use store cfg, it has side-effects

* fix mutated cfg in tests
2024-04-24 10:38:40 +02:00
Piotr Jamróz
f6e472f879
Explore: Show a drawer with tabs for the library and query history (#86279)
* Create basic feature toggle

* Rename context to reflect it contains query history and query library

* Update icons and variants

* Rename hooks

* Update tests

* Fix mock

* Add tracking

* Turn button into a toggle

* Make dropdown active as well

This is required to have better UI and an indication of selected state in split view

* Update Query Library icon

This is to make it consistent with the toolbar button

* Hide query history button when query library is available

This is to avoid confusing UX with 2 button triggering the drawer but with slightly different behavior

* Make the drawer bigger for query library

To avoid confusion for current users and test it internally a bit more it's behind a feature toggle. Bigger drawer may obstruct the view and add more friction in the UX.

* Fix tests

The test was failing because queryLibraryAvailable was set to true for tests. This change makes it more explicit what use case is being tested

* Remove active state underline from the dropdown

* Allow closing Query Library drawer from the toolbar

* Simplify dropdown design
2024-04-24 10:32:11 +02:00
Alexa V
de589b98c7
Dashboard: Migration [Panel Edit] Missing Query Editor when datasource is not found (#86789)
* Return default datasource if datasource is not found

* Set query runner datasource state to default, else refreshing will not work
2024-04-24 10:21:01 +02:00
Sven Grossmann
a8424f4831
LogContext: Fix structured metadata labels being added as stream selectors (#86825)
* LogContext: Fix structured metadata labels being added as stream selectors

* use row index
2024-04-24 10:00:39 +02:00
Karl Persson
0fa983ad8e
AuthN: Use typed namespace id inside authn package (#86048)
* authn: Use typed namespace id inside package
2024-04-24 09:57:34 +02:00
Marcus Andersson
804c726413
PluginExtensions: Make the extensions registry reactive (#83085)
* feat: add a reactive extension registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: add hooks to work with the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: start using the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "command palette" extension point to use the hook

* feat: update the "alerting" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "explore" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "datasources config" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "panel menu" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "pyroscope datasource" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "user profile page" extension point to use the hooks

* chore: update betterer

* fix: update the hooks to not re-render unnecessarily

* chore: remove the old `createPluginExtensionRegistry` impementation

* chore: add "TODO" for `PanelMenuBehaviour` extension point

* feat: update the return value of the hooks to contain a `{ isLoading }` param

* tests: add more tests for the usePluginExtensions() hook

* fix: exclude the cloud-home-app from being non-awaited

* refactor: use uuidv4() for random ID generation (for the registry object)

* fix: linting issue

* feat: use the hooks for the new alerting extension point

* feat: use `useMemo()` for `AlertInstanceAction` extension point context

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2024-04-24 09:33:16 +02:00
Clément Boudereau
d48b5ea44d
Docs: Fix data source (jaeger, zipkin, tempo) provisioning yaml TracesToLog query example (#86606) 2024-04-24 07:42:29 +01:00
nextMJ
309adcaa7f
Typo fix in User API doc example (#81890)
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2024-04-24 06:13:51 +01:00
kay delaney
b7995ae18a
Chore: Rewrite grafana-flamegraph css using object styles (#86816) 2024-04-23 23:28:37 +01:00
Nathan Marrs
5dea949433
Canvas: Match connection anchor points to elements (#85421)
Co-authored-by: Ihor Yeromin <yeryomin.igor@gmail.com>
2024-04-23 14:26:53 -07:00
Josh Hunt
fc5007b0d5
Dashboards: Fix minor i18n papercuts that snuck through (#86802)
* fix two issues in dashboards i18n

* import

* fix another
2024-04-23 19:30:11 +01:00
dependabot[bot]
2c5b684b85
Chore(deps): Bump google.golang.org/api from 0.162.0 to 0.176.0 (#86794)
* Chore(deps): Bump google.golang.org/api from 0.162.0 to 0.176.0

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.162.0 to 0.176.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.162.0...v0.176.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* but does it work across all workspaces

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2024-04-23 12:32:16 -04:00
Pepe Cano
14789db1b7
Docs: add Provisioning section to Install on Kubernetes docs (#83875)
* Docs: add `Provisioning` section to `Install on Kubernetes` docs

* prefix k8s object names with `grafana-`

* Fix `suplying` typo
2024-04-23 18:24:25 +02:00
Nathan Marrs
709d78b8b5
Chore: Fix CVE-2024-22363 (#86738) 2024-04-23 09:24:02 -07:00
Kyle Cunningham
37d086d49c
Table Panel: Fix images not showing on hover with multiple data links (#86732)
* Fix issue

* Prettier

* codeincarnate/image-table-fix/ lint

* Make linter happy by using div with role of button + improve a11y

---------

Co-authored-by: jev forsberg <jev.forsberg@grafana.com>
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2024-04-23 23:03:24 +07:00
dependabot[bot]
ca7f41be11
Chore(deps): Bump buf.build/gen/go/parca-dev/parca/protocolbuffers/go from 1.28.1-20221222094228-8b1d3d0f62e6.4 to 1.33.0-20240414232344-9ca06271cb73.1 (#86092)
Chore(deps): Bump buf.build/gen/go/parca-dev/parca/protocolbuffers/go

---
updated-dependencies:
- dependency-name: buf.build/gen/go/parca-dev/parca/protocolbuffers/go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-23 12:02:36 -04:00
dependabot[bot]
18a4c56539
Chore(deps): Bump go.opentelemetry.io/collector/pdata from 1.0.1 to 1.5.0 (#86091)
* Chore(deps): Bump go.opentelemetry.io/collector/pdata

Bumps [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) from 1.0.1 to 1.5.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG-API.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-collector/compare/pdata/v1.0.1...pdata/v1.5.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector/pdata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* go work sync

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2024-04-23 11:58:17 -04:00
Kristin Laemmert
9553923eb7
Chore: Fix failing ssosettingimpl test (#86792)
Chore: Fix failing ssosetting test
2024-04-23 11:36:34 -04:00
Drew Slobodnjak
173ba73a8a
Canvas: Ensure tangency for first segment (#86543) 2024-04-23 07:54:42 -07:00
George Robinson
2049f766c6
Remove fmt.Println of client certificate (#86773) 2024-04-23 15:15:52 +01:00
Laura Fernández
2fb38a34ac
Navigation: Add a return to previous button when navigating to different sections (#86764) 2024-04-23 15:56:04 +02:00
Mihai Doarna
3dabc3ff5d
SSO: filter out SAML from the SSO providers in UI (#86768)
* filter out saml from sso providers

* fix lint error
2024-04-23 16:55:01 +03:00
Ashley Harrison
a1321d17ca
TimeOfDayPicker: Fix text colours in light mode (#86771)
fix text colours in light mode
2024-04-23 14:50:42 +01:00
Mihai Doarna
bf15329492
SSO: run the validation on upsert with all secrets in settings (#86579)
* run the validation on upsert with all secrets in settings

* rename social to reloadable
2024-04-23 16:50:16 +03:00
Santiago
a6be12c037
Alerting: Implement SaveAndApplyConfig in the forked Alertmanager (remote primary) (#84659)
* Alerting: Implement SaveAndApplyConfiguration in the forked Alertmanager struct

* call SaveAndApplyConfig on the remote first, log errors for the internal

* add comments explaining why we ignore errors in the internal AM

* restore go.work.sum
2024-04-23 15:45:35 +02:00
Torkel Ödegaard
b28e6bc5d8
DashboardScene: Fixes issue with editing panels that uses instanceState (#86687)
* DashboardScene: Fixes issue with editing panels that uses instanceState

* Minor tweak

* Update

* Update
2024-04-23 15:25:16 +02:00
antonio
7067e37971
alerting:labels-annotations elaboration (#86663)
* alerting:labels-annotations elaboration

* applied suggestions

* applied suggestions 2

* modified intro, and labels sections

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update docs/sources/alerting/fundamentals/alert-rules/annotation-label.md

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* pretty

---------

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2024-04-23 15:07:29 +02:00
Steve Simpson
a6ad2380bf
Alerting: Refactor api_prometheus.go request handlers. (#86639)
This splits the request handlers into two functions, one which is the actual
handler and one which is independent from the Grafana `ReqContext` object. This
is to make it easier to reuse the implementation in other code.

Part of the refactoring changes the functions which get query parameters from
the request to operate on a `url.Values` instead of the request object.

The change also makes the code consistently use `req.Form` instead of a
combination of `req.URL.Query()` and `req.Form`, though I have left
`api_ruler` as-is to avoid this PR growing too large.
2024-04-23 14:50:26 +02:00
Sonia Aguilar
68564b1940
Alerting: Gops labels integration (#85467)
* Show list of labels on the alert rule form in a more visual way, and use a modal for managing them

* fix test

* Fix more tests

* Show orange badge when no labels are selected

* Remove unused datasource property in LabelsField

* Remove unused div and add comment

* Use button instead of icon for editing labels

* Use subform for labels

* Move logic fetching labels from different places in a separate hook

* Fix tests

* remove unused getLabelInput const in test

* Add ellispis and tooltip for long labels and move labels list in modal to the bottom

* Use text instead of badge when no using labels

* Fix tests after adding ellipsis and tooltip to the labels

* simplify styles

* Fix fetching values from gops when new key is used

* Address pr review comments

* Address pr review comments part2

* Fix tag on rtkq

* Remove color for no labels selected text

* Disable already used keys in the labels sub form

* Fix typo

* use the UseFieldArrayRemove type from react-hook-form

* Update some styles and text in the labels modal

* Address some review comments (nits)

* Address review comments part1

* Move logic getting labels in useCombinedLabels hook

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2024-04-23 14:38:31 +02:00
Santiago
c77ab53819
Alerting: implement SaveAndApplyConfig in the remote Alertmanager struct (#84642)
* implement SaveAndApplyConfig in the remote Alertmanager struct

* remove ID from CreateGrafanaAlertmanagerConfig call

* decrypt, test that we decrypt, refactor

* fix duplicated declaration in test

* rephrase comment, remove unnecessary conversion to slice of bytes

* fix test
2024-04-23 14:37:10 +02:00
Santiago
8b7c2a459b
Alerting: Implement SaveAndApplyDefaultConfig in the forked Alertmanager (remote primary mode) (#85668)
* Alerting: Implement SaveAndApplyDefaultConfig in the forked Alertmanager (remote primary)

* log the error for the internal AM instead of returning it
2024-04-23 14:36:40 +02:00
Esteban Beltran
0ec9c3e01a
FE Sandbox: Fix worker post message not handling proxy objects correctly (#86654)
* FE Sandbox: Fix worker post message not handling proxy objects correctly

* use expect error instead of ignore

* use assertion instead of ignore

* Fix formatting
2024-04-23 14:08:34 +02:00
github-actions[bot]
3d55602fde
Update make docs procedure (#86746)
Co-authored-by: grafanabot <bot@grafana.com>
2024-04-23 12:52:16 +01:00
Torkel Ödegaard
835b968b08
DashboardScene: Fixes deleting dirty dashboard (#86479)
* DashboardScene: Fixes deleting dirty dashboard

* refactor + unit test
2024-04-23 12:35:16 +02:00
Jack Westbrook
e6799be13c
Chore: Bump webpack-dev-middleware to 6.1.3 (#86482)
chore(npm): bump version of webpack-dev-middleware to 6.1.3
2024-04-23 12:32:17 +02:00
Jack Westbrook
d10303fb05
Chore: Bump ip to 2.0.1 (#86486)
chore(npm): bump ip to 2.0.1
2024-04-23 12:31:27 +02:00
Jack Westbrook
c1f70219b5
Chore: Bump express to 4.19.2 (#86487)
chore(npm): bump express to 4.19.2
2024-04-23 12:31:10 +02:00
Tom Ratcliffe
349df74578 Rename debug target to "UI" rather than Jest 2024-04-23 11:26:56 +01:00
Tom Ratcliffe
97b66c2a95 Apply prettier fixes to VSCode debug config 2024-04-23 11:26:56 +01:00
Tom Ratcliffe
37a86872db Remove port and add NODE_ENV to VSCode debug config 2024-04-23 11:26:56 +01:00
Josh Hunt
467d4231f1
E2C: Remove ModalController from MigrationTokenPage (#86709)
* Remove ModalController from MigrationTokenPage

* Dont show modal or toast for error response

* better
2024-04-23 11:23:06 +01:00
renovate[bot]
c849b6beaa
Update dependency react-i18next to v14 (#86753)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 11:11:25 +01:00
Tom Ratcliffe
08200bc533
Nav: Fix alerting links/special cases not selecting the right MegaMenu item (#85336)
* Render current MegaMenu link as `aria-current=page`

* Add overrides capability for mega menu links

* Pass pageNav into getActiveItem so we can use override capability

* Test MegaMenu special cases for starred & dashboards

* Test that overrides for megamenu util works correctly

* Alpha-sort megamenu overrides

* Refactor util for getting active item for megamenu

Update parameters to getActiveItem

Update tests for getActiveItem

* Fix test for starred dashboard and remove query param test

Query param case happens differently in real app and is fiddly to test here

* handle edge cases

* restore handling home page test

* fix dashboard settings

* handle starring properly

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2024-04-23 11:04:53 +01:00
Nicki de Wet
2d9d0e61b1
Added Caveat regarding inheritance of Mute timings (#86678)
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
2024-04-23 10:27:24 +02:00
Thomas Wikman
99cbb5281c
Grafana UI: Add timezone selector to Storybook toolbar (#86703)
* Add timezone selector to Storybook toolbar

So that it's possible to preview how components that are using date functions, behave when timezone differs from browser/client.

* Re-order imports
2024-04-23 09:09:08 +01:00
renovate[bot]
6c777519d8
Update dependency style-loader to v4 (#86749)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 09:08:46 +01:00
renovate[bot]
b224be5940
Update dependency @grafana/scenes to v4.12.0 (#86747)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 08:50:02 +01:00
renovate[bot]
579cf9bd7d
Update dependency esbuild to v0.20.2 (#76342)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-23 08:26:02 +01:00
Mihai Doarna
4d9e35ba57
SSO: add configurableProviders list to SSO service (#86622)
* add configurableProviders list to sso service

* address feedback
2024-04-23 10:00:43 +03:00