Commit Graph

4204 Commits

Author SHA1 Message Date
Ashley Harrison
55dfc76b23
Chore: replace General with Dashboards (#89017)
replace General with Dashboards
2024-06-11 13:10:25 +01:00
Drew Slobodnjak
694499ae6d
StateTimeline: Fix bug with state labels using stale y position cache during panel resize (#88818)
* StateTimeline: Check for change in height

* probably it!

---------

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2024-06-07 09:12:25 -07:00
Joao Silva
c2dd44bc5a
AppChrome: Add display flex to prevent multiple scrollbars (#88512) 2024-06-06 15:34:28 +01:00
Josh Hunt
51b3116730
Keybinds: E2E tests (#88752)
* Attempt at a keybinds e2e test

* another one, thank you

* polish e2e tests, remove console.log

* an extra test

* remove anti-patterns
2024-06-06 14:10:11 +03:00
Ryan McKinley
41e0430f83
K8s/Dashboards: Add frontend api to switch between implementations (#88632) 2024-06-05 17:34:23 +03:00
Ashley Harrison
2297687ae1
Chore: Ensure all react-transition-group animations use nodeRef (#88604)
* ensure all react-transition-group animations pass nodeRef

* clone children instead of wrapping in div

* remove div wrapper

* revert back to div
2024-06-05 15:01:50 +01:00
Andrej Ocenas
048194597f
Explore: Align time filters properly to day boundaries in query history (#88498) 2024-06-04 15:04:36 +02:00
Ashley Harrison
3f7017a471
Chore: Remove nestedFolderPicker toggle (#88660)
remove nestedFolderPicker toggle
2024-06-04 12:16:12 +03:00
Josh Hunt
407bbe1f4b
Keybinds: Vendor Mousetrap (#88603)
* vendor mousetrap

* fix js lint errors

* name to .ts - start refactoring to typescript

* refactor Mousetrap to valid typescript

rename local functions/variables
update types of CallbackInfo
Specify MouseCallback and cleanup types

* Use vendored mousetrap

* use vendored mousetrap

* add globalBind, and remove dependency on external mousetrap

* Update public/app/core/services/keybindingSrv.ts

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>

---------

Co-authored-by: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com>
2024-06-04 09:35:19 +01:00
Laura Benz
b6bd9e5352
Laura/refactor/rename trash section (#88617)
* refactor: move and rename page component

* refactor: change codeowners

* refactor: change naming in backend

* refactor: change wording of subtitle
2024-06-04 10:03:33 +03:00
Ashley Harrison
e781716a38
Chore: move PageHeader component to angular folder (#88556)
move page-header component to angular folder, scss to angular.scss
2024-06-03 11:47:47 +01:00
Ashley Harrison
8c88f605e4
Chore: Migrate some more scss styles (#88484)
* migrate some more styles

* migrate typeahead styles

* migrate tagsinput styles
2024-05-31 10:04:25 +01:00
Gilles De Mey
781f67dfb6
Alerting: Support alertingDisableSendAlertsExternal feature toggle (#88384) 2024-05-29 13:54:07 +02:00
Tobias Skarhed
06304894a1
Dashboard: Keyboard and mouse panel shortcuts improvement (#87317)
* Add custom attention state to dashboard

* Add attention state to DashboardGrid

* Remove old functionality

* Add attention state to keybindingSrv

* Create PanelAttentionService

* Add PanelAttentionService with scenes support

* Remove unused code

* Use viz panel key instead of VizPanel

* Add type assertion

* Add e2e test

* Update comments

* Use panel id for non-scenes use case

* Support undefined service use case

* Memoize singleton call

* Debounce mouseover

* Set panelAttention with appEvents

* Use AppEvents for Scenes

* Remove panelAttentionSrv

* Wait in e2e to handle debounce

* Move subscription to KeybindingSrv

* Remove imports and reset keyboardShortcuts from main

* Fix on* event handlers
2024-05-29 09:11:23 +02:00
Ashley Harrison
b4e49e3114
Select: Ensure screenreader correctly narrates options (#88118)
* replace select aria-label with data-testid

* update in copy pasted places as well

* update plugin-e2e to 1.2.2
2024-05-28 14:51:47 +01:00
Laura Benz
f6a83432a5
RestoreDashboards: Create trash section (#88278)
* feat: add feature toggle to docs

* feat: create page in BE

* feat: create page in FE

* refactor: set feat toggle as a condition

* refactor

* refactor

* refactor

* feat: add permission conditions

* refactor

* feat: add subtitle to translations

* feat: add to codeowners

* refactor: fix docs situation

* refactor

* Merge main branch into feat branch
2024-05-28 10:26:06 +02:00
Laura Fernández
6d98f53e8b
Chore: Remove returnToPrevious feature toggle (#88332) 2024-05-27 17:47:57 +02:00
Agnès Toulet
f866157f99
Page: add scrollbar ID to use in image renderer (#88214) 2024-05-24 17:28:43 +02:00
Ashley Harrison
82eb160f5c
Chore: SCSS tidy up (#87956)
* more scss tidy up

* replace some scss
2024-05-16 11:20:29 +01:00
Piotr Jamróz
fd218edca4
Explore: List query templates (#86897)
* Create basic feature toggle

* Rename context to reflect it contains query history and query library

* Update icons and variants

* Rename hooks

* Update tests

* Fix mock

* Add tracking

* Turn button into a toggle

* Make dropdown active as well

This is required to have better UI and an indication of selected state in split view

* Update Query Library icon

This is to make it consistent with the toolbar button

* Hide query history button when query library is available

This is to avoid confusing UX with 2 button triggering the drawer but with slightly different behavior

* Make the drawer bigger for query library

To avoid confusion for current users and test it internally a bit more it's behind a feature toggle. Bigger drawer may obstruct the view and add more friction in the UX.

* Fix tests

The test was failing because queryLibraryAvailable was set to true for tests. This change makes it more explicit what use case is being tested

* Remove active state underline from the dropdown

* Add basic types and api methods

This is just moved from the app. To be cleaned up and refactored later.

* Move API utils from Query Library app to Grafana packages

* Move API utils from Query Library app to Grafana packages

* Move API utils from Query Library app to Grafana packages

* Add basic table for query templates

* Add sorting

* Style cells

* Style table cells

* Allow closing Query Library drawer from the toolbar

* Remove Private Query toggle

It will be moved to the kebab

* Add empty state

* Remove variables detection for now

Just to simplify the PR, it's not needed for Explore yet.

* Simplify getting useDatasource.tsx

* Rename cell

* Move QueryTemplatesTable to a separate folder

* Use RTK Query to get list of query templates

* Clean up query templates table

* Simplify useDatasource hook

* Add a test

* Retrigger the build

* Remove unused code

* Small clean up

* Update import

* Add reduxjs/toolkit as a peer dependecy

* Revert "Add reduxjs/toolkit as a peer dependecy"

This reverts commit aa9da6e442.

* Update import

* Add reduxjs/toolkit as a peer dependecy

* Revert "Add reduxjs/toolkit as a peer dependecy"

This reverts commit 2e68a62ab6.

* Add @reduxjs/toolkit as peer dependency

* Add @reduxjs/toolkit as peer dependecy

* Move reactjs/toolkit to dev dependecies

* Minor clean up and use react-redux as a peer dependency

* Move query library code to core features

* Update code owners

* Update export

* Update exports

* Use Redux store instead of APIProvider

* Await for query templates to show during the test

* Add more explicit docs that the feature is experimental

---------

Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>
2024-05-14 10:05:39 +02:00
Ashley Harrison
9bf3adabd8
Spinner: Change spinner icon when prefers-reduced-motion is set (#87641)
* change spinner icon when prefers-reduced-motion is set

* update mock

* remove outdated comment

* fix matchMedia mocks

* update spinner aria label
2024-05-13 11:32:02 +01:00
Tom Ratcliffe
08884f16af
Chore: Remove redux-rtl test helper (#87596) 2024-05-13 11:03:21 +01:00
Ashley Harrison
670960f70c
Chore: Upgrade redux (#86877)
* update packages

* fix type errors

* upgrade redux toolkit as well

* don't need eslint-disable command

* remove comment

* fix unit tests

* call rtk query selector directly

* remove unnecessary checks
2024-05-10 14:28:51 +01:00
kay delaney
cbe868b118
Chore: Use getNextRefId instead of deprecated getNextRefIdChar (#87460) 2024-05-10 12:00:17 +01:00
Josh Hunt
c41ec46b29
I18n: Fix and reenable verify-i18n CI check (#87496)
* I18n: Change verify-i18n script to use node_deb image with make in it

* remove swagger from i18n make

* make verify-i18n fail ci

* fix incorrect and unextracted nav translations

* fix more copy paste
2024-05-08 14:01:17 +01:00
Tobias Skarhed
ef37b78631
Revert "Panel: Keyboard focus shortcuts prioritization" (#87213)
Revert "Panel: Keyboard focus shortcuts prioritization (#86772)"

This reverts commit 3e450ec4bf.
2024-05-08 14:53:20 +02:00
Ashley Harrison
37ef6df3b2
Chore: replace calls to defaultProps (#87310)
* replace calls to defaultProps

* make linksGetter optional
2024-05-07 10:07:16 +01:00
Ashley Harrison
1d6d5cc2cd
Chore: improve typings (#87306)
* some fixes

* some more fixes

* some canvas fixes

* use removeProperty instead

* few more

* fixy fix

* undo changes to ticks for now
2024-05-03 17:21:37 +01:00
Gilles De Mey
5e25afe6e9
Alerting: New settings page (#84501) 2024-05-03 17:42:42 +02:00
Juan Cabanas
d1434fad3a
ShareModal: Share link redesign under newDashboardSharingComponent FF (#87011) 2024-05-03 12:02:18 -03:00
Ashley Harrison
8afaea8a56
Navigation: show img as backup if icon doesn't exist (#87247)
show img as backup if icon doesn't exist
2024-05-02 16:24:06 +01:00
Krishna Dhakal
deb6d27406
Core: Replace deprecated jest matcher toBeCalledWith (#86635)
* Replace depredated matcher from jest

* perform rechecks

---------

Co-authored-by: joshhunt <josh@trtr.co>
2024-05-01 15:33:26 +01:00
Laura Benz
f806b9749d
refactor: replace static placeholders with translatable ones (#87130)
* refactor: replace static placeholders with translatable ones

* refactor

* refactor: keep default option

* refactor: improve expression

* refactor: run extraction after merging fix
2024-05-01 13:17:53 +02:00
kay delaney
6f875188b7
Chore: Clean up package.json files (#86951)
* Chore: Clean up package.json files

Removes any unused packages, adds missing peer dependencies
2024-04-29 14:03:01 +01:00
Ashley Harrison
c151a97110
Chore: Enable no-unreduced-motion and fix errors (#86572)
* enable `no-unreduced-motion` in betterer

* move all animation calls inside handleReducedMotion

* fix violations + enable rule

* update rule README

* remove unnecessary transition from <Collapse>

* remove handleReducedMotion utility and add handleMotion to theme

* update to use new theme value

* handle Dropdown and IconButton

* handle AppChromeMenu and update lint message

* keep rotation at a reduced speed

* handle DashboardLoading
2024-04-29 13:12:36 +01:00
Kristina
e6f51536bf
Explore: Add tests around query history errors (#86810)
* WIP build tests

* Fix one test :D

* Unskip, remove console logging, fix limit test

* Add back whitespace
2024-04-26 08:09:31 -05:00
Alex Khomenko
8117aad9af
Stack: Add size props (#86900)
* Abstract sizing styles from Box

* Upd name

* Stack: Add sizing props

* Revert

* Update LoginServiceButtons
2024-04-26 08:17:16 +03:00
Tobias Skarhed
3e450ec4bf
Panel: Keyboard focus shortcuts prioritization (#86772)
* Panel: Keyboard shortcuts prio

* Remove redundant Array.from

* Simplify

* Handle Scenes use case
2024-04-24 13:46:40 +02:00
Oscar Kilhed
e7f40493e4
DashboardScene: Measure and report scene load time (#86267)
* measure scene load time

* Fix tests that fail due to performance not being the proper global performance object in jest

* add isScene parameter to tracking test
2024-04-24 11:45:32 +02:00
Marcus Andersson
804c726413
PluginExtensions: Make the extensions registry reactive (#83085)
* feat: add a reactive extension registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: add hooks to work with the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: start using the reactive registry

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "command palette" extension point to use the hook

* feat: update the "alerting" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "explore" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "datasources config" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "panel menu" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "pyroscope datasource" extension point to use the hooks

Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>

* feat: update the "user profile page" extension point to use the hooks

* chore: update betterer

* fix: update the hooks to not re-render unnecessarily

* chore: remove the old `createPluginExtensionRegistry` impementation

* chore: add "TODO" for `PanelMenuBehaviour` extension point

* feat: update the return value of the hooks to contain a `{ isLoading }` param

* tests: add more tests for the usePluginExtensions() hook

* fix: exclude the cloud-home-app from being non-awaited

* refactor: use uuidv4() for random ID generation (for the registry object)

* fix: linting issue

* feat: use the hooks for the new alerting extension point

* feat: use `useMemo()` for `AlertInstanceAction` extension point context

---------

Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
2024-04-24 09:33:16 +02:00
Tom Ratcliffe
08200bc533
Nav: Fix alerting links/special cases not selecting the right MegaMenu item (#85336)
* Render current MegaMenu link as `aria-current=page`

* Add overrides capability for mega menu links

* Pass pageNav into getActiveItem so we can use override capability

* Test MegaMenu special cases for starred & dashboards

* Test that overrides for megamenu util works correctly

* Alpha-sort megamenu overrides

* Refactor util for getting active item for megamenu

Update parameters to getActiveItem

Update tests for getActiveItem

* Fix test for starred dashboard and remove query param test

Query param case happens differently in real app and is fiddly to test here

* handle edge cases

* restore handling home page test

* fix dashboard settings

* handle starring properly

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2024-04-23 11:04:53 +01:00
Alex Khomenko
cad9e23e54
Login page: Fix button width (#86680)
* Fix login buttons width

* Login page: Fix button width

* Add todo
2024-04-22 15:31:11 +03:00
Laura Fernández
b5335f0910
Chore: ChangePassword - Replace VerticalGroup with Stack (#86614) 2024-04-19 17:37:51 +02:00
Laura Fernández
db4f7cd21d
Chore: UserSignup and LoginServiceButtons - Replace VerticalGroup with Stack (#86616) 2024-04-19 17:24:09 +02:00
Laura Fernández
a057e8be06
Chore: AppNotificationList- Replace VerticalGroup with Stack (#86612) 2024-04-19 16:21:45 +02:00
Ashley Harrison
63427ccd98
CommandPalette: Fix keyboard shortcut alignment (#86540)
* use full typography properties

* use Text component
2024-04-19 11:52:27 +01:00
linoman
1d1ebee36b
RolePicker: Adjust dynamic position (#86424)
* Adjust dynamic position
2024-04-18 17:53:34 +02:00
Josh Hunt
fe24404432
I18n: Support for Enterprise translations (#86215)
* I18n: Support for Enterprise translations

* don't attempt to link to enterprise in tests

* move extract script to makefile to optionally support enterprise

* update references to old extract script

* update docs

* thank god for unit tests
2024-04-18 16:25:27 +01:00
Tom Ratcliffe
a5c75c5ffb Remove explicit imports of whatwg-fetch from individual test files 2024-04-18 12:23:38 +01:00
Kristina
7112f1effc
Explore: Deprecate local storage singular datasource key (#86250)
* add a note?

* Let Explore own the core/history folder
2024-04-17 09:48:27 -05:00