Commit Graph

215 Commits

Author SHA1 Message Date
Erik Sundell
0140dfdddf
Chore: Add e2e selectors to alert rule page (#86909)
wip
2024-04-25 10:00:11 +02:00
Khushi Jain
5dd8353ab1
Dashboards: Migrate from aria-label e2e selectors to data-testid (#78536)
* Dashboards: Migrate from aria-label e2e selectors to data-testid

* more changes

* addPanelwidget

* Test: Update .betterer.results

* refactor: fix e2e tests

* refactor: fix failing test

* refactor: update plugin-e2e after adding selector changes to the packege

---------

Co-authored-by: Laura Benz <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: Laura Benz <laura.benz@grafana.com>
2024-04-24 15:16:19 +02:00
Josh Hunt
fc5007b0d5
Dashboards: Fix minor i18n papercuts that snuck through (#86802)
* fix two issues in dashboards i18n

* import

* fix another
2024-04-23 19:30:11 +01:00
Tobias Skarhed
1c2065af60
PanelChrome: Improve accessibility landmark markup (#85863)
* Add section and use Text component to get h2 for panel

* Remove heading when collapsible

* Make button text truncate

* Update test

* Remove labelledby as it is not needed anymore

* Use testid selectors in test

* Remove async
2024-04-17 16:44:07 +02:00
Kristina
5305316f5a
Explore: Move Query History to be screen wide (#84321)
* WIP

* Use splitpanewrapper for drawer

* Get rich history pulling from multiple datasources

* highlight pane

* Fix datasource data handling

* create ds/explore map, move around ds lookup

* Handle no filters

* Fix tests and some errors

* Fix context menu issue

* (Poorly) enable scrolling, fix onClose to function

* Remove highlighting, use legacy key, fix casing

* fix filtering to handle non-simple data

* Fix linter, add translations

* Fixing tests~~

* Move to explore drawer and fix some more tests

* Kinda fix drawer stuff?

* Fix remaining card tests

* Fix test

* Fix tests

* Partially fix starred tab tests

* Fix integration tests

* Fix remaining tests 🤞

* Add a test and a clarifying comment behind a couple hooks

* Remove unused code

* Fix button styling and fix animation (but break width)

* Make Drawer using parent width (100%)

* Fix tests and some small catches

* Add tests for selectExploreDSMaps selector

---------

Co-authored-by: Piotr Jamroz <pm.jamroz@gmail.com>
2024-04-09 07:36:46 -05:00
Bogdan Matei
9d44c8e8cf
Add auto to refresh picker (#85584) 2024-04-05 18:31:40 +03:00
Nick Richmond
559fab9dc6
Prometheus: Fuzzy search for metric names in Code Mode (#85396)
* perf: limit metric names in Code Mode suggestions

* feat: configurable metric names limit

* feat: code mode autocomplete info/disclaimer

* chore: put new functionality behind new feature toggle

* refactor: avoid type assertions

* refactor: avoid explicit `any`

refactor: type guards

* refactor: type guards

* chore: add testdata results

* fix: add missing feature toggle guard

* perf: prefer array access to `Array.prototype.at`

* test: add missing config override

* test: refactor for brevity & clarity

* perf: avoid unnecessary mapping

* chore: undo testdata changes

* fix: use correct limit; perf optimizations

* refactor: avoid unnecessary `async`s

* types: simplify

* test: add missing tests

* fix: avoid hardcoding

* test: update mock path

* docs: fix typo

style: remove formatting artifact

style: remove formatting artifact

style: remove formatting artifact

* fix: event scope regression

* style: refactor for clarity

* refactor: prefer `useCallback` to in-effect handler

* refactor: simplify & broaden `filter`

* refactor: rename file to keep with conventions

* chore: mirror Prometheus package changes in app

* refactor: prefer no `@ts-ignore`

* chore: update betterer results

* docs: use type in TSDoc `@link` without `@ts-ignore`

* test: add missing provider

* test: fix jest mock path

* fix: display disclaimer in empty input case
2024-04-04 23:38:23 +03:00
Juan Cabanas
8d4ca72f2a
PublicDashboards: Scene migration (#84409) 2024-03-22 11:48:21 -03:00
Laura Benz
d8a116e696
ReturnToPrevious: Add e2e test (#83115)
* feat: add incomplete unit test

* refactor: add idea for unit test

* feat: create new e2e test

* feat: add some steps

* feat: add comment

* feat: complete prep work

* feat: complete clean up

* rebase

* feat: add more steps to test flow

* refactor: remove unit test

* refactor: clean up

* refactor: create a provisioned alert rule

* refactor: change location and content

* refactor: e2e test

* refactor: betterer

* refactor: move provisioned alert rule

* refactor: make provisioning file available remote

* refactor: clean up test

* refactor: move provisioned alert rule

* refactor: remove wait()

* feat: restructure first test and add more tests

* feat: add another provisioned alert rule

* feat: add a new test

* feat: complete new test

* refactor: replace data-testid in alert rules

* refactor: replace data-testid

* refactor: fix tests for drone

* refactor: fix third test after review

* refactor: fix last test

* temp

* refactor: improve some things

* refactor: adjust unit tests

* refactor: remove assertions for alert rule details view

* refactor: remove assertions

* refactor: add check for button text

* refactor: remove session storage

* refactor: apply changes from code review

* refactor: add codeowner

* refactor

* refactor

* refactor: clean up

* refactor: clean up

* refactor: clean up

* refactor: increase pa11y threshold for /alerting/list
2024-03-21 09:05:51 +01:00
Zoltán Bedi
a4fe7f39ea
E2E: Rewrite mysql tests to playwright (#83424)
* E2E: Rewrite mysql tests to playwright

* Fix lint

* Add more selectors and address comments

* Scope locators when locating text

* Don't run it 20 times

* Update new-datasource-variable to assert mysql
2024-03-19 23:07:48 +01:00
Ashley Harrison
b1b65faf02
Variables: Support static keys in AdHocFiltersVariable (#83157)
* initial start

* don't use getTagKeysProvider

* some cleanup

* undo kinds adjustment

* simplify

* remove async declaration

* add description and a couple of unit tests

* add transformSaveModelToScene test

* add tests for AdHocVariableForm

* add tests for AdHocFiltersVariableEditor

* update to defaultKeys

* fix snapshots

* update to 3.13.3
2024-03-18 16:12:00 +00:00
Erik Sundell
ebcca97052
Annotation query: Render query result in alert box (#83230)
* add alert to annotation result

* cleanup

* add tests

* more refactoring

* apply pr feedback

* change severity

* use toHaveAlert matcher
2024-03-18 14:26:56 +01:00
Erik Sundell
8c06c0dea7
Panel edit: Add e2e selectors to input fields (#83246)
add selectors for input fields
2024-03-12 09:17:41 +01:00
Ivan Ortega Alba
4a81a0388b
Playlist: run on Scenes (#83551)
* DashboardScene: Implement playlist controls

* Mock the runtime config properly

* PlaylistSrv: with state you can subscribe to (#83828)

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2024-03-11 13:33:32 +01:00
Erik Sundell
a722b2608a
TimeZonePicker: Add e2e selector to change time zone settings button (#83248)
add selector to change time zone settings
2024-03-07 07:25:48 +01:00
Dominik Prokop
f016f95298
GroupBy variable core integration (#82185)
* Bump scenes

* Make GroupByVariableModel a VariableWithOptions

* Serialise/deserialise group by variable

* WIP: Group by variable editor

* WIP tests

* Group by variable tests

* add feature toggle and gate variable creation behind it

* Fix types

* Do not resolve DS variable

* Do not show the message if no DS is selected

* Now groupby has options and current

* Update public/app/features/dashboard-scene/settings/variables/components/GroupByVariableForm.test.tsx

Co-authored-by: Ivan Ortega Alba <ivanortegaalba@gmail.com>

* don't allow creating groupby if toggle is off + update tests

* add unit tests

* remove groupByKeys

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Ivan Ortega <ivanortegaalba@gmail.com>
2024-02-14 09:18:04 -08:00
Ivan Ortega Alba
3d86d101b7
Dashboards: Use auto and only use AdHocFiltersVariable to manage filters (#81318) 2024-02-13 22:38:26 +02:00
Victor Marin
1fe32479d7
Scenes: Annotations functionality in settings (#81361)
* wip listing/viewing annotations

* list annotations in settings

* fix tests

* wip edit mode

* PR mods

* move, delete, edit, add new

* edit annotation in settings

* Annotations functionality

* revert change

* add ui tests, move angularEditorLoader

* remove flaky test

* refactor

* bump scenes version, refactor getVizPanels, refactor edit page

* fix nav breadcrumbs

* annotation set dirty flag, add overlay to edit view

* PR mods

* PR mods

* remove flaky test

* change dirty flag setting logic for anotations

* change button variants
2024-02-12 16:06:46 +02:00
Sergej-Vlasov
3605d85c4c
Dashboards: Remove advancedDataSourcePicker feature toggle (#81790)
* remove advancedDataSourcePicker feature toggle from DataSourcePickerWithPrompt

* remove advancedDataSourcePicker toggle from DataSourcePicker and adjust tests that relied on old picker

* adjust failing tests in QueryVariableEditorForm

* move DataSourceDropdown to DataSourcePicker file

* covert style declaration syntax to object style in DataSourcePicker

* remove advancedDataSourcePicker  feature flag from registry

* remove .only from test

* adjust QueryVariableEditor test to avoid console.error
2024-02-06 09:20:07 +00:00
Ashley Harrison
a30f8645d1
Chore: Migrate frontend platform code to use data-testid for selectors (#81787)
* migrate some stuff from aria-label to data-testid

* convert styles to objects

* fix unit tests

* empty commit to kick drone now enterprise branch is there
2024-02-02 13:26:37 +00:00
Ivan Ortega Alba
a9f17a3f24
QueryVariable: Be able to edit the variable using scenes (#80847) 2024-01-31 13:31:08 +01:00
Alexa V
e3a648e107
Dashboard: Migration - EditVariable Settings: Implement Interval Variable (#81259)
* Extract logic from core IntervalEditor and create a new Form to be shared between scenes and core
* Implement IntervalVariableEditor and refactor some utils functions
* Add unit test
2024-01-29 16:53:09 +01:00
Nathan Marrs
138079bbd8
Transformations: Fix regression where disabling single transformation would display "No data" (#81320) 2024-01-26 09:14:59 -08:00
Oscar Kilhed
57ba8dc75d
Scenes: Add transformation flow for panel edit (#80738)
* Adding transformations works

* Use source data as data input for transformation settings, add search box suffix

* remove useCallback that are probably not needed, fix tests

* remove unused import

* add tests for adding and removing transformations

* use view all constant

* Add reordering functionality

* Fix removing one transformation removes all consecutive transformations

* use closeDrawer function

* Add tests for changing transformations

* Remove any

---------

Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
2024-01-24 14:14:48 +01:00
Brendan O'Handley
639bf3036d
Prometheus: Add e2e tests for decoupling (#80333)
* update selectors for prom

* add selector to switch component, needs id instead of testid

* add testid and ids to Prom settings

* add e2e tests for prom config

* add config to editor test

* export select function

* start query editor spec

* clean up describe

* add selectors for general query editor

* add selectors to components in options in best locations

* wrap header switch in id because component doesn't accept testid nor id

* add id to wrap legend components in one selector

* update selector in shared folder component, note to change in shared library

* update selector in shared folder component, note to change in shared library

* add notes for selectors in shared folder

* add tests and file for query editor

* add selectors for metrics browser in code editor

* add selector to component to open metrics browser

* add selectors to components within the metrics browser

* add tests for metrics browser and stub resource calls

* add selectors to query builder components

* add e2e tests for query builder

* generic query builder test with hints

* add selectors for more code editor parts

* add test for code and update selector

* fix tests with selector

* remove shared folder changes and use data-testid where possible

* remove unused import

* share getResources

* create variable query editor selectors

* add selectors to the variable query editor

* add e2e tests for the Prometheus variable query editor

* fix test function

* refactor add data source method

* add annotation selectors

* add selectors to annotation components

* add annotation e2e tests

* commit for yarn i18n:extract error in drone
2024-01-22 08:42:24 -06:00
Kyle Cunningham
4d6069583e
Transformations: Move transformation help to drawer component (#79247)
* Move help to drawer component

* Update component name

* Flip hierarchy of transformation name and help description
2024-01-19 12:47:05 +02:00
Haris Rozajac
f285eb6717
Time Range: Copy-paste Time Range (#80107)
* Working copy-paste functionality with validation

* WIP; uses 't c' shortcut to copy time range

* shortcuts working for explore and dashboards

* cleanup

* Don't update url when pasting in explore

* Error handling, sync pane functionality, add to help modal

* cleanup

* add tests

* fix i18n

* Diferrentiate between explore and dashboard paste events; make on error prop generic

* Fix

* extract getting the copied time range logic into a function

* Remove comments

* Make error handling generic; markup for translations

* Additional translation markup

* markup for aria-label

* Fix test

* Replace fireEvent with userEvent

* fix translations to match the standard pattern

* Refactor keybindingSrv and TimeSrv to remove PasteTimeContext

* Fix test

* Remove unneccessary aria labels; update icons; buttons inline
2024-01-18 14:06:27 -07:00
Ivan Ortega Alba
3b401d0d4d
CustomVariable: Be able to edit them using scenes (#80193)
---------
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
2024-01-17 19:14:01 +02:00
Eric Leijonmarck
3979ea0c47
Anonymous Access: Pagination for devices (#80028)
* first commit

* add: pagination to anondevices

* fmt

* swagger and tests

* swagger

* testing out test

* fixing tests

* made it possible to query for from and to time

* refactor: change to query for ip adress instead

* fix: tests
2024-01-15 12:13:38 +00:00
Jamin
66c85d9826
Frontend: Migrate LoadingIndicator.tsx from aria-label e2e selectors to data-testid (#79664)
* refactor: update component to use data-testid

* refactor: update loading indicator e2e selector

* oops - forgot to update betterer results

* update loading indicator in variable picker

---------

Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
2024-01-12 18:30:11 +02:00
Ivan Ortega Alba
e9f1b41d23
EditVariable: Add base form to edit variables (#80172) 2024-01-12 12:01:11 +02:00
Jamin
71b98163e5
Frontend: Migrate DataSourceHttpSettings.tsx from aria-label e2e selectors to data-testid (#79615) 2024-01-10 11:51:16 +00:00
Ezequiel Victorero
25ff4baa76
UI: New share button and toolbar reorganize (#77563) 2024-01-08 10:42:24 -03:00
Jamin
576b8ccff6
Frontend: Migrate PageToolbar.tsx from aria-label e2e selectors to data-testid (#79663)
* refactor: update PageToolbar to use data-testid

* refactor: update selector text

---------

Co-authored-by: joshhunt <josh@trtr.co>
2024-01-04 13:52:38 +02:00
Brendan O'Handley
a9f4ffab5d
Prometheus: Migrate from aria-label to data-testid for selectors (#78554)
* migrate from aria-label to data-testid for selectors

* fix e2e tests with shared components

* fix e2e tests with more shared components

* pass data-testid to SelectBase component

* pass data-testid to value container and traverse the dom to access the input in e2e
2023-12-26 13:43:06 -06:00
Jamin
f41a0559fa
Frontend: Migrate NewsContainer.tsx from aria-label e2e selectors to data-testid (#79666) 2023-12-26 15:06:33 +00:00
Jamin
38f176edfb
Frontend: Migrate SubMenu.tsx: from aria-label e2e selectors to data-testid (#79662) 2023-12-21 11:52:57 +00:00
Khushi Jain
54dc5846c2
Chore: Refactor dataviz aria-label e2e selectors to data-testid (#78938)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
2023-12-17 02:10:04 +02:00
Esteban Beltran
46142da4db
Chore: Migrate from aria-label to data-testid in plugin-related tests (#79272)
* Update basicsettings for datasource

* Change aria-label for data-testid

* Update more tests

* Update betterer

* Remove unnecessary data-testid

* Put back aria label for some datasource selectors

* Try to use data-testid with alerts

* Update betterer
2023-12-11 15:05:54 +01:00
Kyle Cunningham
b42d652106
Transformations: Move transformation addition into drawer (#78299)
* Start splitting out code

* Use flag

* A bit of rocket surgery

* Prettify

* Cleanup behavior

* Work through behaviors

* Move empty message from other PR

* Import fixes and prettier

* Clean things up

* Add selector for tests

* Cleanups

* Working with transformation redesign

* Some more tweaks to make sure of correct behavior

* Update betterer/eslint exceptions

* Localization

* Remove unecessary fragments

* Spacing and prettier

* Update tests for new UI

* Update e2e tests

* One more e2e test fix

* Update selectors

* Fix one test and break another
2023-12-01 14:08:54 -06:00
Joey Orlando
ea7a179f2a
Plugins: Add grafana/user/profile/tab plugin extension point (#77863)
* add grafana/user/profile/settings
plugin extension point

* changes to support plugins having their
own settings tabs

* WIP

* add comment

* add unit tests

* allow setting open tab based on tab query param

* update name of extension point

* add some more unit tests

* address PR comments

* PR comments
2023-12-01 15:18:27 +00:00
Eric Leijonmarck
59bdff0280
Auth: Add anonymous users view and stats (#78685)
* Add anonymous stats and user table

- anonymous users users page
- add feature toggle `anonymousAccess`
- remove check for enterprise for `Device-Id` header in request
- add anonusers/device count to stats

* promise all, review comments

* make use of promise all settled

* refactoring: devices instead of users

* review comments, moved countdevices to httpserver

* fakeAnonService for tests and generate openapi spec

* do not commit openapi3 and api-merged

* add openapi

* Apply suggestions from code review

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* formatin

* precise anon devices to avoid confusion

---------

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
Co-authored-by: jguer <me@jguer.space>
2023-11-29 17:58:41 +01:00
Josh Hunt
eea35b9eb7
Login: Improve accessibility of Login form (#78652)
* Chore: Fix a11y debt in Login form

* fix tests

* token styles

* more styles

* pa11y

* fix pa11y
2023-11-28 10:22:20 +00:00
Khushi Jain
b7c74a1af6
Alerting: Migrate from aria-label e2e selectors to data-testid (#78437)
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-11-27 16:24:31 +01:00
Laura Fernández
e422a92eae
RadioButton: Make description appear in a Tooltip component (#78010) 2023-11-27 13:54:07 +01:00
Josh Hunt
05070385cd
Chore: Refactor TimeRangePicker for aria-label selectors (#78399)
* Change from aria-label to data-testid for e2e selectors

* translate

* update tests

* swap buttons:
2023-11-23 10:39:26 +00:00
Jev Forsberg
4275f2dc8c
Chore: Update e2e selectors for Transformations (#78426)
* baldm0mma/e2e_selector_migration/ update labels

* baldm0mma/e2e_selector_migration/ run prettier

* baldm0mma/e2e_selector_migration/ add test

* baldm0mma/ update results

* baldm0mma/e2e_selector_migration/ update betterer
2023-11-21 09:31:56 -07:00
Zoltán Bedi
22035565d2
SQL: Add timeFilter macro to query builder (#74575)
* Add timeFilter macro to query builder

* Only render SQLWhereRow when fields are there

* Change the default query to timeseries and remove 50 limit

* Add timeFilter macro for the first time when timeSeries

* Add test for timeFilter macro

* Lint fix

* Annotation query format should be table

* Set order by as default

* Revert changes that made time series default

* Fix e2e test

* Fix e2e test

* Make sure to reset the date value when operator is changed

* Add docs
2023-11-09 09:23:26 +01:00
Juan Cabanas
fa468fb17c
TimePicker: Close overlay content when toolbar button is clicked for the second time (#77796)
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-11-08 11:39:37 -03:00
Ashley Harrison
d68d31c63c
Navigation: Hide Undock menu button when docked (#76965)
* small dock menu exploration

* fix e2e tests

* revert back to web-section-alt
2023-11-03 17:07:15 +00:00