Fix five more English source typos found while writing descriptions

Tracing all 295 new keys to their usage surfaced eight typos in user-facing
English, not the one already fixed. Five are corrected here:

  remote users are not allow to log in   -> not allowed
  Missing require user property          -> Missing required
  Unable to get know users               -> known users
  Please check you provider's docs (x8)  -> your provider's
  Seperate multiple domains              -> Separate

All five preserve meaning, so the translations that already exist for these
keys stay correct and nothing needs re-translating. The server strings live in
i18n/en.json, which is hand-maintained; the webapp ones are defaultMessage
values in source, so en.json and the authoring catalog are regenerated.

Deliberately NOT fixed: audit_table.userRemoved reads 'Removed {username} to
the {channelName} channel'. That is not a typo but a wrong preposition -- it
says the opposite of what it means -- and correcting it invalidates the
existing translation in all 21 locales. It wants its own change.

Also drops the 'source contains a typo' notes from the descriptions of the
keys that are no longer wrong.
This commit is contained in:
Jesse Hallam
2026-08-26 14:05:54 -03:00
parent 03045153d5
commit 04b25296b6
5 changed files with 17 additions and 17 deletions
+3 -3
View File
@@ -4888,7 +4888,7 @@
},
{
"id": "api.user.login.remote_users.login.error",
"translation": "Login failed because remote users are not allow to log in."
"translation": "Login failed because remote users are not allowed to log in."
},
{
"id": "api.user.login.use_auth_service.app_error",
@@ -7538,7 +7538,7 @@
},
{
"id": "app.import.validate_user_import_data.username_missing.error",
"translation": "Missing require user property: username."
"translation": "Missing required user property: username."
},
{
"id": "app.import.validate_user_teams_import_data.invalid_auth_service.error",
@@ -9768,7 +9768,7 @@
},
{
"id": "app.user.get_known_users.get_users.app_error",
"translation": "Unable to get know users from the database."
"translation": "Unable to get known users from the database."
},
{
"id": "app.user.get_new_users.app_error",
@@ -5544,7 +5544,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'GitLabSettings.Id',
label: defineMessage({id: 'admin.openid.clientIdTitle', defaultMessage: 'Client ID:'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.gitlab.clientIdExample', defaultMessage: 'E.g.: "jcuS8PuvcpGhpgHhlcpT1Mx42pnqMxQY"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.GITLAB_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5553,7 +5553,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'GitLabSettings.Secret',
label: defineMessage({id: 'admin.openid.clientSecretTitle', defaultMessage: 'Client Secret:'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.gitlab.clientSecretExample', defaultMessage: 'E.g.: "jcuS8PuvcpGhpgHhlcpT1Mx42pnqMxQY"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.GITLAB_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5572,7 +5572,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'GoogleSettings.Id',
label: defineMessage({id: 'admin.openid.clientIdTitle', defaultMessage: 'Client ID:'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.google.clientIdExample', defaultMessage: 'E.g.: "7602141235235-url0fhs1mayfasbmop5qlfns8dh4.apps.googleusercontent.com"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.GOOGLE_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5581,7 +5581,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'GoogleSettings.Secret',
label: defineMessage({id: 'admin.openid.clientSecretTitle', defaultMessage: 'Client Secret:'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.google.clientSecretExample', defaultMessage: 'E.g.: "H8sz0Az-dDs2p15-7QzD231"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.GOOGLE_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5614,7 +5614,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'Office365Settings.Id',
label: defineMessage({id: 'admin.openid.clientIdTitle', defaultMessage: 'Client ID:'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.office365.clientIdExample', defaultMessage: 'E.g.: "adf3sfa2-ag3f-sn4n-ids0-sh1hdax192qq"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.OFFICE365_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5623,7 +5623,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'Office365Settings.Secret',
label: defineMessage({id: 'admin.openid.clientSecretTitle', defaultMessage: 'Client Secret:'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.office365.clientSecretExample', defaultMessage: 'E.g.: "shAieM47sNBfgl20f8ci294"'}),
isHidden: it.not(it.stateEquals('openidType', Constants.OFFICE365_SERVICE)),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5661,7 +5661,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'OpenIdSettings.Id',
label: defineMessage({id: 'admin.openid.clientIdTitle', defaultMessage: 'Client ID:'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientIdDescription', defaultMessage: 'Obtaining the Client ID differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.openid.clientIdExample', defaultMessage: 'E.g.: "adf3sfa2-ag3f-sn4n-ids0-sh1hdax192qq"'}),
isHidden: it.any(it.not(it.stateEquals('openidType', Constants.OPENID_SERVICE)), it.licensedForCloudStarter),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -5670,7 +5670,7 @@ const AdminDefinition: AdminDefinitionType = {
type: 'text',
key: 'OpenIdSettings.Secret',
label: defineMessage({id: 'admin.openid.clientSecretTitle', defaultMessage: 'Client Secret:'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check you provider\'s documentation.'}),
help_text: defineMessage({id: 'admin.openid.clientSecretDescription', defaultMessage: 'Obtaining the Client Secret differs across providers. Please check your provider\'s documentation.'}),
placeholder: defineMessage({id: 'admin.openid.clientSecretExample', defaultMessage: 'E.g.: "H8sz0Az-dDs2p15-7QzD231"'}),
isHidden: it.any(it.not(it.stateEquals('openidType', Constants.OPENID_SERVICE)), it.licensedForCloudStarter),
isDisabled: it.not(it.userHasWritePermissionOnResource(RESOURCE_KEYS.AUTHENTICATION.OPENID)),
@@ -71,7 +71,7 @@ const AllowedDomainsSelect = ({allowedDomains, setAllowedDomains, setHasChanges,
onChange={handleOnChangeDomains}
handleNewSelection={updateAllowedDomains}
isClearable={false}
description={formatMessage({id: 'general_tab.AllowedDomainsTip', defaultMessage: 'Seperate multiple domains with a space, comma, tab or enter.'})}
description={formatMessage({id: 'general_tab.AllowedDomainsTip', defaultMessage: 'Separate multiple domains with a space, comma, tab or enter.'})}
/>
}
</>
@@ -90,14 +90,14 @@ describe('components/TeamSettings', () => {
test('should not show allowed domains input if allowed domains is empty', () => {
const props = {...defaultProps, team: TestHelper.getTeamMock({allowed_domains: ''})};
renderWithContext(<AccessTab {...props}/>);
const allowedDomainsInput = screen.queryByText('Seperate multiple domains with a space, comma, tab or enter.');
const allowedDomainsInput = screen.queryByText('Separate multiple domains with a space, comma, tab or enter.');
expect(allowedDomainsInput).toBeNull();
});
test('should show allowed domains input if allowed domains is not empty', () => {
const props = {...defaultProps, team: TestHelper.getTeamMock({allowed_domains: 'test.com'})};
renderWithContext(<AccessTab {...props}/>);
const allowedDomainsInput = screen.getByText('Seperate multiple domains with a space, comma, tab or enter.');
const allowedDomainsInput = screen.getByText('Separate multiple domains with a space, comma, tab or enter.');
expect(allowedDomainsInput).toBeInTheDocument();
const allowedDomainsInputValue = screen.getByText('test.com');
expect(allowedDomainsInputValue).toBeInTheDocument();
+3 -3
View File
@@ -2289,10 +2289,10 @@
"admin.openid.buttonTextDesc": "The text that will show on the login button.",
"admin.openid.buttonTextEx": "Custom Button Name",
"admin.openid.buttonTextTitle": "Button Name:",
"admin.openid.clientIdDescription": "Obtaining the Client ID differs across providers. Please check you provider's documentation.",
"admin.openid.clientIdDescription": "Obtaining the Client ID differs across providers. Please check your provider's documentation.",
"admin.openid.clientIdExample": "E.g.: \"adf3sfa2-ag3f-sn4n-ids0-sh1hdax192qq\"",
"admin.openid.clientIdTitle": "Client ID:",
"admin.openid.clientSecretDescription": "Obtaining the Client Secret differs across providers. Please check you provider's documentation.",
"admin.openid.clientSecretDescription": "Obtaining the Client Secret differs across providers. Please check your provider's documentation.",
"admin.openid.clientSecretExample": "E.g.: \"H8sz0Az-dDs2p15-7QzD231\"",
"admin.openid.clientSecretTitle": "Client Secret:",
"admin.openid.discovery.placeholder": "https://id.mydomain.com/.well-known/openid-configuration",
@@ -5421,7 +5421,7 @@
"general_tab.allowedDomains.ariaLabel": "Allowed Domains",
"general_tab.AllowedDomainsExample": "corp.mattermost.com, mattermost.com",
"general_tab.AllowedDomainsInfo": "When enabled, users can only join the team if their email matches a specific domain (e.g. \"mattermost.org\")",
"general_tab.AllowedDomainsTip": "Seperate multiple domains with a space, comma, tab or enter.",
"general_tab.AllowedDomainsTip": "Separate multiple domains with a space, comma, tab or enter.",
"general_tab.AllowedDomainsTitle": "Users with a specific email domain",
"general_tab.codeLongDesc": "The Invite Code is part of the unique team invitation link which is sent to members youre inviting to this team. Regenerating the code creates a new invitation link and invalidates the previous link.",
"general_tab.codeTitle": "Invite Code",