IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes for the /echo command (#4843)

Browse Source
This commit is contained in:
Joram Wilander
2016-12-20 09:28:00 -05:00
committed by Christopher Speller
parent 1f67c91fce
commit 2da388d297
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/command_echo.go
View File

@@ -40,6 +40,10 @@ func (me *EchoProvider) GetCommand(c *Context) *model.Command {
}
func (me *EchoProvider) DoCommand(c *Context, args *model.CommandArgs, message string) *model.CommandResponse {
if len(message) == 0 {
return &model.CommandResponse{Text: c.T("api.command_echo.message.app_error"), ResponseType: model.COMMAND_RESPONSE_TYPE_EPHEMERAL}
}
maxThreads := 100
delay := 0

7
api/command_echo_test.go
View File

@@ -17,8 +17,11 @@ func TestEchoCommand(t *testing.T) {
echoTestString := "/echo test"
r1 := Client.Must(Client.Command(channel1.Id, echoTestString)).Data.(*model.CommandResponse)
if r1 == nil {
if r1 := Client.Must(Client.Command(channel1.Id, echoTestString)).Data.(*model.CommandResponse); r1 == nil {
t.Fatal("Echo command failed to execute")
}
if r1 := Client.Must(Client.Command(channel1.Id, "/echo ")).Data.(*model.CommandResponse); r1 == nil {
t.Fatal("Echo command failed to execute")
}

4
i18n/en.json
View File

@@ -491,6 +491,10 @@
"id": "api.command_echo.create.app_error",
"translation": "Unable to create /echo post, err=%v"
},
{
"id": "api.command_echo.message.app_error",
"translation": "A message must be provided with the /echo command."
},
{
"id": "api.command_echo.delay.app_error",
"translation": "Delays must be under 10000 seconds"