Revert "Added GetPluginID method and tests (#27281)" (#27540)

This reverts commit 4acc4796ed.
This commit is contained in:
Ben Schumacher 2024-07-04 19:13:15 +02:00 committed by GitHub
parent 3e4d91590f
commit 6d427cf005
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 27 deletions

View File

@ -322,10 +322,6 @@ func (m *Manifest) IsValid() error {
return nil
}
func (m *Manifest) GetPluginID() string {
return m.Id
}
func (s *PluginSettingsSchema) isValid() error {
for _, setting := range s.Settings {
err := setting.isValid()

View File

@ -81,29 +81,6 @@ func TestIsValid(t *testing.T) {
}
}
func TestGetPluginIdReturnsCorrectId(t *testing.T) {
testCases := []struct {
Title string
Id string
manifest *Manifest
ExpectEqual bool
}{
{"Ids are Different", "not-same.com.company.test", &Manifest{Id: "com.company.test"}, false},
{"Ids are the same", "com.company.test", &Manifest{Id: "com.company.test"}, true},
}
for _, tc := range testCases {
t.Run(tc.Title, func(t *testing.T) {
id := tc.manifest.GetPluginID()
if tc.ExpectEqual {
assert.Equal(t, tc.Id, id)
} else {
assert.NotEqual(t, tc.Id, id)
}
})
}
}
func TestIsValidSettingsSchema(t *testing.T) {
testCases := []struct {
Title string