Stopped rerendering CreatePost/CreateComment when blurring textbox (#5026)

This commit is contained in:
Harrison Healey
2017-01-10 09:08:37 -05:00
committed by GitHub
parent 78cadf7d60
commit 7846036c77
2 changed files with 11 additions and 8 deletions

View File

@@ -67,9 +67,10 @@ export default class CreateComment extends React.Component {
fileInfos: draft.fileInfos,
submitting: false,
ctrlSend: PreferenceStore.getBool(Constants.Preferences.CATEGORY_ADVANCED_SETTINGS, 'send_on_ctrl_enter'),
showPostDeletedModal: false,
lastBlurAt: 0
showPostDeletedModal: false
};
this.lastBlurAt = 0;
}
componentDidMount() {
@@ -145,7 +146,7 @@ export default class CreateComment extends React.Component {
});
const fasterThanHumanWillClick = 150;
const forceFocus = (Date.now() - this.state.lastBlurAt < fasterThanHumanWillClick);
const forceFocus = (Date.now() - this.lastBlurAt < fasterThanHumanWillClick);
this.focusTextbox(forceFocus);
}
@@ -405,7 +406,7 @@ export default class CreateComment extends React.Component {
}
handleBlur() {
this.setState({lastBlurAt: Date.now()});
this.lastBlurAt = Date.now();
}
render() {

View File

@@ -76,9 +76,10 @@ export default class CreatePost extends React.Component {
ctrlSend: PreferenceStore.getBool(Constants.Preferences.CATEGORY_ADVANCED_SETTINGS, 'send_on_ctrl_enter'),
fullWidthTextBox: PreferenceStore.get(Preferences.CATEGORY_DISPLAY_SETTINGS, Preferences.CHANNEL_DISPLAY_MODE, Preferences.CHANNEL_DISPLAY_MODE_DEFAULT) === Preferences.CHANNEL_DISPLAY_MODE_FULL_SCREEN,
showTutorialTip: false,
showPostDeletedModal: false,
lastBlurAt: 0
showPostDeletedModal: false
};
this.lastBlurAt = 0;
}
handlePostError(postError) {
@@ -154,7 +155,8 @@ export default class CreatePost extends React.Component {
this.setState({message: '', submitting: false, postError: null, fileInfos: [], serverError: null});
const fasterThanHumanWillClick = 150;
const forceFocus = (Date.now() - this.state.lastBlurAt < fasterThanHumanWillClick);
const forceFocus = (Date.now() - this.lastBlurAt < fasterThanHumanWillClick);
this.focusTextbox(forceFocus);
}
@@ -438,7 +440,7 @@ export default class CreatePost extends React.Component {
}
handleBlur() {
this.setState({lastBlurAt: Date.now()});
this.lastBlurAt = Date.now();
}
showPostDeletedModal() {