IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-08-26 13:17:29 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix nil context panic in TestDoSetupSessionAttributesProperties (#38123)

Browse Source 
UpdatePropertyFields panics when passed a nil context because
RequestContextWithMaster dereferences it. Use SystemCallerContext
to match the other sub-tests in the same function.
This commit is contained in:
Jesse Hallam
2026-08-24 20:56:59 +00:00
committed by GitHub
parent 9b4ab46cc2
commit 84414404a1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/channels/app/migrations_test.go
+1 -1
View File
@@ -545,7 +545,7 @@ func TestDoSetupSessionAttributesProperties(t *testing.T) {
}
require.Len(t, trimmed, len(persisted)-1)
field.Attrs[model.PropertyFieldAttributeOptions] = trimmed
_, _, _, err := th.Server.propertyService.UpdatePropertyFields(nil, group.ID, []*model.PropertyField{field})
_, _, _, err := th.Server.propertyService.UpdatePropertyFields(properties.SystemCallerContext(th.Context), group.ID, []*model.PropertyField{field})
require.NoError(t, err)
before := sessionAttributeOptionIDsByName(t, sessionAttributeFieldByName(t, th, group.ID, model.SessionAttributesPropertyFieldUserAgentPlatform))