IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-08-26 13:17:29 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update comments to reference generic use cases

Browse Source
This commit is contained in:
Miguel de la Cruz
2026-08-26 17:02:10 +02:00
parent da638e58bd
commit 847ca29662
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/channels/api4/properties_test.go
+8 -9
View File
@@ -962,11 +962,10 @@ func TestCreatePropertyField(t *testing.T) {
require.Equal(t, model.PermissionLevelMember, *created.PermissionOptions)
})
t.Run("channel admin can create the PostAttributes field shape", func(t *testing.T) {
// The motivating use case, end to end: a channel admin defines a post
// attribute on their channel whose field and options only the
// channel's admins may manage, and whose values each post's author may
// set on their own post.
t.Run("channel admin can create an admin-managed field with creator-set values", func(t *testing.T) {
// A channel admin defines a channel-scoped field whose definition and
// options only the channel's admins may manage, and whose values each
// object's creator may set on their own object.
channelAdmin := th.CreateUser(t)
th.LinkUserToTeam(t, channelAdmin, th.BasicTeam)
_, appErr := th.App.AddUserToChannel(th.Context, channelAdmin, th.BasicChannel, false)
@@ -1022,10 +1021,10 @@ func TestCreatePropertyField(t *testing.T) {
require.Equal(t, model.PermissionLevelAdmin, *fetched.PermissionOptions)
})
t.Run("system admin can create the PostAttributes field shape", func(t *testing.T) {
// The motivating use case, as it can actually be provisioned today:
// field and options managed by the channel's admins, values settable by
// each post's author.
t.Run("system admin can create an admin-managed field with creator-set values", func(t *testing.T) {
// The same shape provisioned by a system admin: definition and options
// managed by the channel's admins, values settable by each object's
// creator.
adminLevel := model.PermissionLevelAdmin
creatorLevel := model.PermissionLevelCreator
field := &model.PropertyField{
server/channels/app/authorization_test.go
+1 -2
View File
@@ -3005,8 +3005,7 @@ func TestSessionHasPermissionToSetPropertyFieldValues_PostCreator(t *testing.T)
groupID := registerTestPropertyGroup(t, th)
// System-target field so the dispatch is driven purely by ObjectType plus
// the value's target — the shape post attributes use: one field, per-post
// values.
// the value's target — one field definition, one value per object.
field := &model.PropertyField{
ID: model.NewId(),
GroupID: groupID,