IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-52955] Fix panic for not found posts (#23561)

Browse Source
This commit is contained in:
Ben Schumacher
2023-06-05 10:00:06 +02:00
committed by GitHub
parent c94e8c2134
commit 9a55280d7a
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/channels/store/sqlstore/reaction_store.go
View File

@@ -41,6 +41,11 @@ func (s *SqlReactionStore) Save(reaction *model.Reaction) (re *model.Reaction, e
if err != nil {
return nil, errors.Wrap(err, "failed while getting channelId from Posts")
}
if len(channelIds) == 0 {
return nil, store.NewErrNotFound("Post", reaction.PostId)
}
reaction.ChannelId = channelIds[0]
}
err = s.saveReactionAndUpdatePost(transaction, reaction)

10
server/channels/store/storetest/reaction_store.go
View File

@@ -118,6 +118,16 @@ func testReactionSave(t *testing.T, ss store.Store) {
_, nErr = ss.Reaction().Save(reaction5)
require.Error(t, nErr, "should've failed for invalid reaction")
t.Run("channel not found", func(t *testing.T) {
// invalid reaction
reaction5 := &model.Reaction{
UserId: reaction1.UserId,
PostId: model.NewId(), // Unknown PostId
EmojiName: model.NewId(),
}
_, nErr = ss.Reaction().Save(reaction5)
require.Error(t, nErr, "should've failed because postId doesn't belong to a stored post")
})
}
func testReactionDelete(t *testing.T, ss store.Store) {