[MM-15220] Add generic error field to SubmitDialogResponse (#12081)

This will allow integrations to return an generic error message that is
not tied to a specific dialog field.
This commit is contained in:
Paulo Bittencourt
2019-09-11 11:35:51 -04:00
committed by Ben Schumacher
parent 98489b9e67
commit 9c3fc4ab9f
3 changed files with 4 additions and 0 deletions

View File

@@ -430,6 +430,7 @@ func TestSubmitInteractiveDialog(t *testing.T) {
assert.Equal(t, "value1", val)
resp := model.SubmitDialogResponse{
Error: "some generic error",
Errors: map[string]string{"name1": "some error"},
}
@@ -444,6 +445,7 @@ func TestSubmitInteractiveDialog(t *testing.T) {
resp, err := th.App.SubmitInteractiveDialog(submit)
assert.Nil(t, err)
require.NotNil(t, resp)
assert.Equal(t, "some generic error", resp.Error)
assert.Equal(t, "some error", resp.Errors["name1"])
submit.URL = ""

View File

@@ -222,6 +222,7 @@ type SubmitDialogRequest struct {
}
type SubmitDialogResponse struct {
Error string `json:"error,omitempty"`
Errors map[string]string `json:"errors,omitempty"`
}

View File

@@ -141,6 +141,7 @@ func TestSubmitDialogRequestToJson(t *testing.T) {
func TestSubmitDialogResponseToJson(t *testing.T) {
t.Run("all fine", func(t *testing.T) {
request := SubmitDialogResponse{
Error: "some generic error",
Errors: map[string]string{
"text": "some text",
"float": "1.2",