IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

PLT-3242 Fixed clicking on input labels on iOS (#3417)

Browse Source 
* Prevented channel notification settings radiobuttons from multi-selecting

* Fixed clicking on input labels on iOS
This commit is contained in:
Harrison Healey
2016-06-27 08:21:24 -04:00
committed by Christopher Speller
parent 459eee85a9
commit b9cf09b5a4
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webapp/components/channel_notifications_modal.jsx
View File

@@ -132,6 +132,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='desktopNotificationLevel'
checked={notifyActive[0]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'default')}
/>
@@ -149,6 +150,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='desktopNotificationLevel'
checked={notifyActive[1]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'all')}
/>
@@ -160,6 +162,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='desktopNotificationLevel'
checked={notifyActive[2]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'mention')}
/>
@@ -171,6 +174,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='desktopNotificationLevel'
checked={notifyActive[3]}
onChange={this.handleUpdateNotifyLevel.bind(this, 'none')}
/>
@@ -285,6 +289,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='markUnreadLevel'
checked={this.state.unreadLevel === 'all'}
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'all')}
/>
@@ -299,6 +304,7 @@ export default class ChannelNotificationsModal extends React.Component {
<label>
<input
type='radio'
name='markUnreadLevel'
checked={this.state.unreadLevel === 'mention'}
onChange={this.handleUpdateMarkUnreadLevel.bind(this, 'mention')}
/>

6
webapp/sass/responsive/_mobile.scss
View File

@@ -1051,3 +1051,9 @@
}
}
}
// on iOS, allow clicks within an input's label to actually propagate through to the input itself
// http://stackoverflow.com/a/34810294/6325807
label span {
pointer-events: none;
}