IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

[MM-34164] Fix flaky TestS3FileBackend (#17229)

Browse Source 
* Fix flaky test

* Disable dumping data on error
This commit is contained in:
Claudio Costa
2021-03-25 16:58:29 +01:00
committed by GitHub
parent 5329eac020
commit cd0f92e2e7
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shared/filestore/filesstore_test.go
View File

@@ -94,7 +94,13 @@ func (s *FileBackendTestSuite) SetupTest() {
s.backend = backend
// This is needed to create the bucket if it doesn't exist.
s.Nil(s.backend.TestConnection())
if err := s.backend.TestConnection(); err == ErrNoS3Bucket {
s3Backend, ok := s.backend.(*S3FileBackend)
s.True(ok)
s.NoError(s3Backend.MakeBucket())
} else {
s.NoError(err)
}
}
func (s *FileBackendTestSuite) TestConnection() {
@@ -350,7 +356,7 @@ func (s *FileBackendTestSuite) TestAppendFile() {
read, err := s.backend.ReadFile(path)
s.Nil(err)
s.EqualValues(len(b)+len(b2), len(read))
s.EqualValues(append(b, b2...), read)
s.True(bytes.Equal(append(b, b2...), read))
b3 := make([]byte, 1024)
for i := range b3 {
@@ -364,7 +370,7 @@ func (s *FileBackendTestSuite) TestAppendFile() {
read, err = s.backend.ReadFile(path)
s.Nil(err)
s.EqualValues(len(b)+len(b2)+len(b3), len(read))
s.EqualValues(append(append(b, b2...), b3...), read)
s.True(bytes.Equal(append(append(b, b2...), b3...), read))
})
}