IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2025-02-25 18:55:24 -06:00
Code Issues Packages Projects Releases Wiki Activity

MM-26514: Fix ALTER PRIMARY KEY migration for Postgres <9.3 (#14912)

Browse Source 
* MM-26514: Fix ALTER PRIMARY KEY migration for Postgres <9.3

We work around the lack of LATERAL keyword by making the query separately.

* Complete full WHERE clause just to be sure
This commit is contained in:
Agniva De Sarker
2020-06-26 21:14:37 +05:30
committed by GitHub
parent 4bfad26614
commit dd40d59c84
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
store/sqlstore/supplier.go
View File

@@ -786,7 +786,8 @@ func (ss *SqlSupplier) AlterPrimaryKey(tableName string, columnNames []string) b
var currentPrimaryKey string
var err error
// get the current primary key as a comma separated list of columns
if ss.DriverName() == model.DATABASE_DRIVER_MYSQL {
switch ss.DriverName() {
case model.DATABASE_DRIVER_MYSQL:
query := `
SELECT GROUP_CONCAT(column_name ORDER BY seq_in_index) AS PK
FROM
@@ -798,13 +799,13 @@ func (ss *SqlSupplier) AlterPrimaryKey(tableName string, columnNames []string) b
GROUP BY
index_name`
currentPrimaryKey, err = ss.GetMaster().SelectStr(query, tableName)
} else if ss.DriverName() == model.DATABASE_DRIVER_POSTGRES {
case model.DATABASE_DRIVER_POSTGRES:
query := `
SELECT string_agg(a.attname, ',') AS pk
FROM
pg_constraint AS c
CROSS JOIN LATERAL
UNNEST(c.conkey) AS cols(colnum)
CROSS JOIN
(SELECT unnest(conkey) FROM pg_constraint WHERE conrelid='` + strings.ToLower(tableName) + `'::REGCLASS AND contype='p') AS cols(colnum)
INNER JOIN
pg_attribute AS a ON a.attrelid = c.conrelid
AND cols.colnum = a.attnum
@@ -812,7 +813,7 @@ func (ss *SqlSupplier) AlterPrimaryKey(tableName string, columnNames []string) b
c.contype = 'p'
AND c.conrelid = '` + strings.ToLower(tableName) + `'::REGCLASS`
currentPrimaryKey, err = ss.GetMaster().SelectStr(query)
} else if ss.DriverName() == model.DATABASE_DRIVER_SQLITE {
case model.DATABASE_DRIVER_SQLITE:
// SQLite doesn't support altering primary key
return true
}