IntenseWebs/mattermost
3
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-08-26 21:27:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update mmctl-test-template.yml to conditionally execute docker login for mattermost repository owner (#33920)

Browse Source 
* Update mmctl-test-template.yml to conditionally execute docker login for mattermost repository owner

* Update build-server-image.yml and server-test-template.yml to conditionally execute docker login for mattermost repository owner

* Update workflow files to conditionally execute docker login for pull requests from mattermost/mattermost

* Enhance CI workflows to conditionally execute jobs for pull requests from mattermost/mattermost

* Remove conditional check for docker login in CI workflows to streamline execution across all pull requests

* Add conditional check for docker login in CI workflows for pull requests from mattermost/mattermost

* Refactor CI workflows to gracefully skip tests for external pull requests, enhancing clarity and execution flow

* revert checks

* skip fips testing for forks

* Fix fork detection in FIPS tests to allow push events

The previous condition `github.repository_owner == 'mattermost'` was
incorrect as it would always be false for forks. Updated to properly
detect forks using `github.event.pull_request.head.repo.full_name == github.repository`
and allow FIPS tests to run on push events.

---------

Co-authored-by: Jesse Hallam <jesse@mattermost.com>
This commit is contained in:
Angelos Kyratzakos
2025-09-19 18:00:38 +00:00
committed by GitHub
co-authored by Jesse Hallam
parent e87ee7fd9e
commit eabea443a4
3 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/mmctl-test-template.yml
+2
View File
@@ -30,6 +30,8 @@ jobs:
COMPOSE_PROJECT_NAME: ghactions
steps:
- name: buildenv/docker-login
# Only FIPS requires login for private build container. (Forks won't have credentials.)
if: inputs.fips-enabled
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
.github/workflows/server-ci.yml
+5 -1
View File
@@ -205,6 +205,8 @@ jobs:
go-version: ${{ needs.go.outputs.version }}
fips-enabled: false
test-postgres-normal-fips:
# Skip FIPS testing for forks, which won't have docker login credentials.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository
name: Postgres (FIPS)
needs: go
uses: ./.github/workflows/server-test-template.yml
@@ -217,9 +219,9 @@ jobs:
go-version: ${{ needs.go.outputs.version }}
fips-enabled: true
test-coverage:
name: Generate Test Coverage
# Skip coverage generation for cherry-pick PRs into release branches.
if: ${{ github.event_name != 'pull_request' || !startsWith(github.event.pull_request.base.ref, 'release-') }}
name: Generate Test Coverage
needs: go
uses: ./.github/workflows/server-test-template.yml
secrets: inherit
@@ -245,6 +247,8 @@ jobs:
fips-enabled: false
test-mmctl-fips:
name: Run mmctl tests (FIPS)
# Skip FIPS testing for forks, which won't have docker login credentials.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name == github.repository
needs: go
uses: ./.github/workflows/mmctl-test-template.yml
secrets: inherit
.github/workflows/server-test-template.yml
+2
View File
@@ -43,6 +43,8 @@ jobs:
COMPOSE_PROJECT_NAME: ghactions
steps:
- name: buildenv/docker-login
# Only FIPS requires login for private build container. (Forks won't have credentials.)
if: inputs.fips-enabled
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}