* MM-19663 | Migrate brand_test and cluster_test to testify
* Use require.Fail instead of require.FailNow
Co-Authored-By: Ben Schumacher <ben.schumacher@mattermost.com>
* [MM-16437] add a check so that we don't write an invalid header
* better solution
* * passing in the logger; logging the error; fixed a spelling mistake
* trigger jenkins
* When patching a bot, perform these two additional steps:
1. Update the user.UpdateAt value for the user/bot.
2. send the websocket event so all clients know a user update has
occured. This will tell clients to update the displayname
* Add check for UpdateAt. Check that createdBot.UpdateAt is not equal
to patchedBot.UpdateAt
* re-add unintentional empty line delete in previous commit
* Don't create a fake updateAt time. Let the Update() method handle the
change. User the returned updateUser for sending updated user event
* Include user_name, team_domain and channel_name when clicking an interactive button
* Fixed api4's TestPostActionCookies test
* Moved team database request to improve concurrency.
Renamed TeamDomain to TeamName.
* Further optimizations to database requests
* Removed useless goroutine when fetching channel
This changes the bulk import so when it needs to generate a password
because no password or auth data was supplied, it now takes into account
the configured minimum length, as well as assuming all other distinct
character types are configured to be required. It should now generate
valid passwords regardless of the password policy configuration in the
Mattermost configuration file.
- Add stringutils with method that "stringify" object slices
- "stringify" means convert each object to its string representation
- Move plugin.Log* implementations to client_rpc, use stringify method before calling server method
- Exclude Log* methods from generated RPC methods
- No signature change for plugin.Log* API
- Add test in plugin_api_test to use plugin.Log* methods with RPC
* Migrate tests for store/storetest/channel_store.go
* Corrected variable declaration
* corrected nilf to nil
* Reordered parameters to Equal and EqualValues
Corrected few tests to use Len, NotNil to improve readability
* Removed third parameter from require.Nil()
* Corrected failing tests
* migrate tests to use testify
* check resp error
* require empty auth
* fix based on comment
* change to require
* change all assert to require
* remove line
To start off with, we are using the new-from-rev=HEAD~ option which just checks the current
commit. This allows us to quickly integrate golangci-lint and not spend time in fixing all the
outstanding issues.
Things pending:
- Slowly fix the existing issues. To test them, just uncomment the "new-from-rev: HEAD~" line
from .golangci.yml and have at it.
- There are a number of unused functions and methods which are only invoked from enterprise code.
We are ignoring them for now because removing them will stop enterprise build from working.
The correct solution here is to use a build tag to separate TE and EE code. As a long term goal,
we would want to use that build tag throughout the EE codebase and remove the TE_PACKAGES and
EE_PACKAGES variables in the Makefile and just use the build tag. That makes things a lot cleaner
and avoids the need to spawn a "go list" every time to get the correct list of packages.
