Commit Graph

13196 Commits

Author SHA1 Message Date
Ibrahim Serdar Acikgoz
40e16ba07f [MM-31359] remove duplicated error logs (#16583)
* remove duplicated error logs

* reflect review comments

* add context

* add error details
2020-12-29 09:48:36 +03:00
Agniva De Sarker
727a158e9a MM-31511: Fix incorrect replace repo (#16603)
The package paths were changed. Therefore, go mod tidy
on master failed with:

```
go: finding module for package github.com/hmhealey/go-opengraph/opengraph
go: found github.com/hmhealey/go-opengraph/opengraph in github.com/hmhealey/go-opengraph v0.0.0-20201209151214-f2d823730dba
go: github.com/hmhealey/go-opengraph@v0.0.0-20201209151214-f2d823730dba used for two different module paths (github.com/dyatlov/go-opengraph and github.com/hmhealey/go-opengraph)
```

https://mattermost.atlassian.net/browse/MM-31511

```release-note
NONE
```
2020-12-24 15:26:22 +05:30
Ibrahim Serdar Acikgoz
bd5616557d [MM-30978] avoid parsing nil PostAction in SlackAttachments (#16556)
* avoid parsing nil PostAction in SlackAttachments

* reflect review comments

* improve tests

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-24 09:00:11 +03:00
Agniva De Sarker
c54b262351 MM-31356: Add a minimum required version check for Postgres (#16597)
* MM-31356: Add a minimum required version check for Postgres

To keep conformance with our failing fast and obvious philosophy,
we add a check to prevent Mattermost server from starting
if the postgres version is below 10.0.

This gives customers a chance to upgrade their database before upgrading
their Mattermost version, than to run into weird compatibility issues
after they have finished the upgrade.

https://mattermost.atlassian.net/browse/MM-31356

```release-note
NONE
```

* fix lint errors

* Use a function to pretty-print version string

* rectify comment
2020-12-23 22:06:13 +05:30
Mattermost Build
83afd756b6 Bump version (#16592)
* Bump version

* Uncomment shouldPerformUpgrade

Co-authored-by: Mmbot <mmbot@mattermost>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
2020-12-23 16:33:07 +01:00
Ibrahim Serdar Acikgoz
8036ba86e7 [MM-31398] upgrade error level to critical in case of panic or os.Exit (#16584)
* upgrade error level to critical in case of panic or os.Exit

* reflect revivew comments

* fix error capitalization
2020-12-23 13:11:35 +03:00
Ibrahim Serdar Acikgoz
8ca880d1cc [MM-31512] Downgrade 4xx and 501 errors to info/debug level (#16585)
* Downgrade 4xx and 501 errors to info/debug level

* use switch instead
2020-12-23 13:08:35 +03:00
Agniva De Sarker
6487d0ca91 MM-31062: Rewrite empty string checks to be more idiomatic (#16587)
https://mattermost.atlassian.net/browse/MM-31062

```release-note
NONE
```
2020-12-22 19:20:59 +05:30
Agniva De Sarker
1a131b54af MM-31064: Simplify indentation (#16565)
* MM-31064: Simplify indentation

Reduce indentation where possible.

```release-note
NONE
```

Command ran to verify:
golangci-lint run --disable-all --enable golint --max-issues-per-linter=10000 --max-same-issues=100000 ./... | grep "block ends with a return state"

https://mattermost.atlassian.net/browse/MM-31064

* incorporate review comments

* enable golint for outdent rule

* fix remaining issues

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-21 18:50:47 +03:00
Jesús Espino
7419898449 Remove usages of AppError on filesstore service (#15841)
* Remove usages of AppError on filesstore service

* Fixing a golint error

* Fixing shadowed variable

* Adding err.Error() to the NewAppError calls

* Fixing tests

* Adding missed translations

* Fix error handling and updating the translation that affects it

* Fixing two typos
2020-12-20 12:53:07 +01:00
Claudio Costa
10be00f005 Update db schema version for MM-31401 and MM-27312 (#16580) 2020-12-18 22:25:52 +01:00
Jesse Hallam
7773b17eff MM-30450: Pre-pacakge Incident Management v1.2.0 (#16576) 2020-12-18 13:57:56 -04:00
Mario de Frutos Dieguez
94fe01dc1d [MM-30539] New renewal link logic (#16539)
* New renewal link logic

Endpoint and logic that returns the renewal link to be used to start the
license renewal process.

* Limit access for restricted sysadmins

* Include active users in the renewal token
2020-12-18 16:40:46 +01:00
Miguel de la Cruz
e057e5b10b [MM-31085] Create a db init command to initialize the database (#16489)
Automatic Merge
2020-12-16 20:45:17 +01:00
Doug Lauder
6a3bc50f13 MM-31401 Add Shared flag to Channels table (#16568)
* add Shared flag to Channels table
2020-12-16 14:02:16 -05:00
Nick Misasi
2447ce9bca [MM-30984] Change default footer for copyright in 2 emails (#16508)
* Change default footer for copyright in 2 emails

* Change copyright date to 2020

* Add something back

* Put back to 2020

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-16 13:51:40 -05:00
Martin Kraft
d2ad98bffd MM-30005: Require manage_system to patch system_admin role. (#16096)
* MM-30005: Require manage_system to patch system_admin role.

* MM-30005: Updates logic to include other new system roles.

* MM-30005: Removes unused translation.

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-16 13:01:15 -05:00
Eli Yukelzon
18ac6af9b3 MM-31154 Add CI step to validate store mocks (#16551) 2020-12-16 16:32:06 +02:00
Mohammed Salman
6b7e261e06 Remove model.AppError from searchlayer/post_layer.go (#16452)
* Remove model.AppError from searchlayer/post_layer.go

* change nErr to err

* fix tautological condition

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-16 19:19:18 +05:30
Agniva De Sarker
eb7c4580f8 MM-28549: Bump up postgres version (#16564)
https://mattermost.atlassian.net/browse/MM-28549

```release-notes
Mattermost does not support Postgres 9.4 anymore. The minimum
required version for Postgres will be 10.
```
2020-12-16 09:26:49 +00:00
Agniva De Sarker
dae95dd373 MM-30826: Sentry crash: nil deference in model.AuthorizeRequest (#16563)
The return statement after setting c.InvalidParam was missing

https://mattermost.atlassian.net/browse/MM-30826

```release-note
NONE
```
2020-12-16 09:56:06 +01:00
Scott Bishel
8496cb6977 update einterface mocks (#16555) 2020-12-15 08:50:50 -07:00
Miguel de la Cruz
35e459227b [MM-30016] Allows to create incoming and outgoing webhooks for a different user (#16425)
* [MM-30016] Allows to create an incoming webhook for a different user

* [MM-30021] Allows to create an outgoing webhook for a different user

* Fix update test

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-15 15:56:42 +01:00
Agniva De Sarker
0cf37d0f3c MM-3124: Fix racy test TestPluginPanicLogs (#16541)
We shutdown all plugins prior to checking the log buffer
so that there are no active plugins writing to the buffer
when we read the contents.

https://mattermost.atlassian.net/browse/MM-31324

```release-note
NONE
```
2020-12-15 19:19:53 +05:30
Miguel de la Cruz
ec5c33cf14 [MM-31357] Do not return empty appError as part of users autocompletion (#16550)
Automatic Merge
2020-12-15 14:45:17 +01:00
Elisabeth Kulzer
fe1c42d399 Enable circleci test only for master (#16548) 2020-12-15 14:36:00 +01:00
Jason Blais
8e221c1895 [MM-31018] Update email address for admin advisor contact requests to support-advisor@mattermost.com (#16443)
Automatic Merge
2020-12-15 05:15:17 +01:00
Weblate (bot)
dc561546d6 Translations update from Weblate (#16546)
* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/

* Translated using Weblate (Dutch)

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/nl/

* Translated using Weblate (Romanian)

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/ro/

* Translated using Weblate (Spanish)

Currently translated at 94.3% (1989 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/es/

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/

Translated using Weblate (Portuguese (Brazil))

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/pt_BR/

* Translated using Weblate (Turkish)

Currently translated at 100.0% (2107 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/tr/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 99.9% (2106 of 2107 strings)

Translation: mattermost-languages-shipped/mattermost-server_master
Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-server_master/zh_Hans/

Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: Viorel-Cosmin Miron <cosmin@uhlhost.net>
Co-authored-by: Elias  Nahum <elias@mattermost.com>
Co-authored-by: rodrigocorsi <rodrigocorsi@gmail.com>
Co-authored-by: Kaya Zeren <kayazeren@gmail.com>
Co-authored-by: aeomin <lin@aeomin.net>
2020-12-14 22:10:17 +01:00
Agniva De Sarker
fa1f2a8504 MM-31323: Fix racy test TestHandleCommandResponsePost (#16542)
In https://github.com/mattermost/mattermost-server/pull/16089,
we added logic to modify the notification text in the presence
of fallback text.

Unfortunately, that created a race condition during publishing
the post via websockets. To fix this, we create a clone of the post
before sending it off for push notifications.

https://mattermost.atlassian.net/browse/MM-31323

```release-note
NONE
```
2020-12-14 14:24:12 +05:30
Diogo Nicolau
8e2986e5ed MM-27312 Allow uploading 10 files per post (#16235)
* Allow uploading 10 files per post

* Increase Post.Fileids column size to fit 10 files

* Add Post.Fileids column changes to DB v531

* Fix current_schema_version

Co-authored-by: Claudio Costa <cstcld91@gmail.com>

* Update store/sqlstore/upgrade.go

Co-authored-by: Claudio Costa <cstcld91@gmail.com>

* Fix schema version

Co-authored-by: Diogo Lima Nicolau <diogo.lima.nicolau@cern.ch>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: Claudio Costa <cstcld91@gmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-14 09:30:02 +01:00
Haardik Dharma
609c8166f2 [MM-30911]: Change receiver name for (me *TestHelper) in app/slashcommands/helper_test.go to be more idiomatic. (#16387)
Automatic Merge
2020-12-12 15:45:17 +01:00
Haardik Dharma
0dee08fa31 Update command_me.go (#16522)
Automatic Merge
2020-12-12 07:15:17 +01:00
Haardik Dharma
caaa5690b6 Update command_echo.go (#16521)
Automatic Merge
2020-12-12 06:15:17 +01:00
Haardik Dharma
0b012ad468 [MM-31079]: Change receiver name for (me *TestHelper) in api4/apitestlib.go to be more idiomatic (#16501)
Automatic Merge
2020-12-12 05:15:17 +01:00
Haardik Dharma
625185cb5b Update command_online.go (#16493)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-11 22:51:06 +05:30
Haardik Dharma
93a4c7bc7e Update command_groupmsg.go (#16487)
Automatic Merge
2020-12-11 17:45:18 +01:00
Haardik Dharma
b8e9bac921 Update command_code.go (#16486)
Automatic Merge
2020-12-11 16:45:18 +01:00
Jason Paul Deland
b363ff3fad Update Jenkinsfile.branch
Revert changes to the branch used for saml libs
2020-12-10 19:48:34 -05:00
Claudio Costa
6c976c3b06 Generate preview regardless of HasPreviewImage value (#16535)
Automatic Merge
2020-12-11 00:15:17 +01:00
Harrison Healey
1367418e3c MM-31171 Fork OpenGraph library to handle bad HTML from YouTube (#16528) 2020-12-10 15:42:23 -05:00
Jason Paul Deland
599e8f67e6 Update Jenkinsfile.branch
Update the saml libs branch to master also
2020-12-10 13:00:25 -05:00
Haardik Dharma
7fb5476c64 Update command_channel_header.go (#16485)
Automatic Merge
2020-12-10 17:15:17 +01:00
Haardik Dharma
f2aafac0c9 Update cluster_discovery.go (#16484)
Automatic Merge
2020-12-10 16:15:18 +01:00
Haardik Dharma
a3db701ccc Update cluster_stats.go (#16483)
Automatic Merge
2020-12-10 15:45:17 +01:00
Agniva De Sarker
44eb3e3f97 MM-31326: Fix Striped LRU to have minimum of 1 bucket (#16531)
* MM-31326: Fix Striped LRU to have minimum of 1 bucket

https://mattermost.atlassian.net/browse/MM-31236

```release-note
NONE
```

* Using a maxInt function
2020-12-10 19:51:52 +05:30
John Tzikas
1fe003aa36 Add shared channels related configuration under a E20 license check (#16415)
* Add shared channels related configuration under a E20 license check

* Apply PR suggestions; Default config value for shared channels

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-10 11:25:38 +02:00
Ibrahim Serdar Acikgoz
5d41bffe5e [MM-30092] api4/image: add support for protocol rel. urls (#16189)
* api4/image: add support for protocol rel. urls

* reflect review comments

* Update api4/image.go

Co-authored-by: Juho Nurminen <juho.nurminen@mattermost.com>

* api4/image: prevent opaque urls to be processed

Co-authored-by: Juho Nurminen <juho.nurminen@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-10 09:54:13 +03:00
Haardik Dharma
522181a957 Update data_retention_policy.go (#16495)
Automatic Merge
2020-12-09 16:15:18 +01:00
Haardik Dharma
5f0f5a7a7f Update command_shortcuts.go (#16494)
Automatic Merge
2020-12-09 15:45:18 +01:00
Florent Peterschmitt
349b83f23a implement and use striped LRU cache to lower mutex contention (#15764)
* Implement Striped LRU cache

* ci

* fix

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2020-12-09 19:25:14 +05:30