Commit Graph

11618 Commits

Author SHA1 Message Date
Sheshagiri Rao Mallipedhi
894b124bc6 Migrate tests from "model/analytics_row_test.go" to use testify (#12601) 2019-10-08 09:36:15 -05:00
Vitalii Ananichev
13b28b7a20 MM-19132 Migrate tests from "model/channel_view_test.go" to us… (#12579)
* Migrate tests from "model/channel_view_test.go" to use testify

* Replace require to assert
2019-10-08 09:22:06 -05:00
Martin Kraft
598f7c7255 MM-17767: Remove ExperimentalLdapGroupSync config. (#12388) 2019-10-08 08:03:39 -04:00
Pradeep Murugesan
488ae1abad turned off email notification for the status DND (#12502)
* turned off email notification for the status DND

* extracted the userAllows email logic as a separate function

* removed the unused function
2019-10-08 09:57:20 +02:00
Carlos Tadeu Panato Junior
ae3f112874 upgrade db to 5.16 (#12260)
* upgrade db to 5.16

* set current schema version
2019-10-08 09:32:51 +02:00
boonwj
e5ea44afcb [MM-19158] Migrate to testify in model/cluster_message_test.go (#12615) 2019-10-08 09:02:50 +02:00
Aliaksandr Kantsevoi
041c914de7 Migrate tests from "model/switch_request_test.go" to use testi… (#12554) 2019-10-08 08:27:53 +02:00
Ogundele Olumide
f21b7618a4 MM-19015 Migrate tests from "cmd/mattermost/commands/config_te… (#12627)
- change t.fatal to require package of the testify toolkit
2019-10-08 00:09:39 -06:00
Victor Hugo Avelar Ossorio
bb203bad4a MM-19163 - Refactored team search tests to testify (#12607) 2019-10-07 09:27:53 -04:00
Clément Collin
2ef5712a08 [MM-19120] Migrate tests from "model/security_bulletin_test.go… (#12567) 2019-10-07 07:54:51 +02:00
Deepak Sah
6c55f79ca7 [MM-19119] Migrate tests from "model/access_test.go" to use testify (#12611)
* Changed tests to use require

* Removed redundant messages
2019-10-06 21:22:30 +02:00
Marc Argent
1a126b5133 GH-12335 Refactor app/session.go to use structured logging (#12529)
* GH-12335 Refactor app/session.go to use structured logging

* Remove placeholders
2019-10-06 16:01:42 +03:00
Karan Nadagoudar
cbb25838a6 [MM-19165] Migrate tests from "model/utils_test.go" to use tes… (#12610) 2019-10-05 08:01:50 +02:00
Vitalii Ananichev
51b5776fd0 MM-19133 Migrate tests from "model/terms_of_service_test.go" t… (#12578) 2019-10-04 19:03:07 +02:00
Sheshagiri Rao Mallipedhi
8e86ec969e refactor tests in model/reaction_test.go and move to testify t… (#12603) 2019-10-04 18:43:27 +02:00
George Felix
f97ed668ba Migrated tests from "model/incoming_webhook_test.go" to use testify (#12602)
* Replaced test assertions with testify

* Changes based on suggestions https://github.com/mattermost/mattermost-server/pull/12602#pullrequestreview-296859312

* Unused variable replaced with blank identifier
2019-10-04 17:36:26 +02:00
Lev
293d4c762e Bumped GitHub plugin to 0.11.0 (#12613) 2019-10-04 07:46:37 -07:00
Ogundele Olumide
fa166f13bf chore: migrate test to testify (#12507)
- replace calls to t.fatal with require assertion of testify toolkit
2019-10-04 07:43:29 -07:00
SezalAgrawal
e1fae73e85 [MM-19123] Migrate tests from "model/push_notification_test.go" to use testify (#12557)
* [MM-19123] Migrate tests from model/push_notification_test.go to use testify

* [MM-19123] Re-arranged the import package
2019-10-04 15:30:04 +01:00
Sascha Andres
aa4a7e71dd MM-19117 Migrate tests from "model/system_test.go" to use testify #12550 (#12574) 2019-10-04 14:18:14 +02:00
Eli Yukelzon
3ea8540586 Added validation of schema migration to CircleCI (#12322)
* circleci support for schema diffing
2019-10-04 14:46:43 +03:00
Nicholas Lim
928b07f940 change model/suggest_command_test.go to use assert (#12575)
Merging! happy hacktoberfest! 🥇
2019-10-04 11:07:01 +02:00
Lev
54c4bef0d9 Bumped Zoom plugin version to 1.1.1 (#12403)
* Bumped Zoom plugin version to 1.1.0

* Bumped Zoom plugin version to 1.1.1
2019-10-03 10:22:30 -07:00
Agniva De Sarker
20ff7032a6 Fixed some ineffective assignments (#12543) 2019-10-03 15:45:27 +03:00
SezalAgrawal
eebe1fc290 [MM-19118] Migrate tests from "model/websocket_message_test.go… (#12577)
* [MM-19118] Migrate tests from model/websocket_message_test.go to use testify

* [MM-19118] Ran go fmt on websocket_message_test.go file
2019-10-03 02:48:37 -06:00
Aliaksandr Kantsevoi
f010346945 Migrate tests from "cmd/mattermost/commands/team_test.go" to use test… (#12509)
* Migrate tests from "cmd/mattermost/commands/team_test.go" to use testify #12410

* #12410: Simplify if checks

Migrate tests from "cmd/mattermost/commands/team_test.go" to use testify #12410
2019-10-03 16:38:41 +08:00
Ogundele Olumide
714a5c3c29 chore: convert calls to t.fatal to testify (#12506)
- use require testfify assertions to replace calls to t.fatal
2019-10-03 10:09:29 +02:00
Lev
0186fdf9e7 Bumped Autolink plugin version to 1.1.1 (#12404) 2019-10-02 15:34:21 -07:00
Nilesh Kevlani
1f6cf84bb2 Replaced t.Fatal with require.Equal (#12536) 2019-10-03 00:25:36 +03:00
Jesús Espino
2f77622b89 Upgrading server package dependencies (#12559) 2019-10-02 20:13:38 +02:00
Dennis Nguyen
c19bddb51b update config/file test to use testify (#12534) 2019-10-02 19:24:10 +02:00
Christopher Poile
f9025818b6 redirect stderr to stdout (#12516) 2019-10-02 19:23:25 +02:00
Lev
053ce34605 Bumped Welcome bot plugin version to 1.1.1 (#12407) 2019-10-02 10:09:22 -07:00
Nikhil Ranjan
3e0da03310 Convert app/user_test.go t.Fatal calls into assert/require calls (#12219)
* Convert app/user_test.go t.Fatal calls into assert/require calls

* arrange expected and actual arguments as per semantics

* arrange expected and actual arguments as per go semantics

* fix for notEqual
2019-10-02 10:00:42 -07:00
Agniva De Sarker
8ab0e80b77 MM-19022: Convert config/watcher_test.go t.Fatal calls into require calls (#12524)
* Convert config/watcher_test.go t.Fatal calls into require calls

* Moved wasCalled to a public helper function

Now the testutils package has a new function WasCalled
that can be used by anywhere.
2019-10-02 18:57:43 +02:00
Dennis Nguyen
013a81a33d migrate memory_test to use testify (#12531) 2019-10-02 18:43:16 +02:00
Lev
cc82cc990e Bumped Custom Attributes plugin version to 1.0.2 (#12405) 2019-10-02 09:35:01 -07:00
Dennis Nguyen
c859807b70 update database test to use testify (#12532) 2019-10-02 08:51:13 -04:00
Aliaksandr Kantsevoi
80633ef475 Migrate tests from "cmd/mattermost/commands/webhook_test.go" to use t… (#12510) 2019-10-02 11:03:37 +02:00
Lev
838f1de9e4 Bumped the Jira plugin to v2.2.0 (#12402) 2019-10-01 13:43:46 -07:00
Jesús Espino
6ba961a480 Embedding avatar in guest invite emails (#12328)
* Embedding avatar in guest invite emails

* Fixing tests

* Improving mailservice tests

* Fixing shadow variables

* Fixing styles for gmail

* Keep spacing on invite messages

* Fixing spacing
2019-09-30 23:27:07 +02:00
Jesús Espino
8cea561ba6 More robust team exists api endpoint (#12130)
* More robust team exists api endpoint

* Making the code more concise

* Better handling of errors on GetTeamByName
2019-09-30 21:39:21 +02:00
Jesús Espino
89b7b2d99b Adding MM_NO_DOCKER env variable to Makefile (#12384)
* Adding MM_NO_DOCKER env variable to Makefile

* Making it consisten tiwh the previous IS_CI value
2019-09-30 20:50:56 +02:00
Jesse Hallam
beef13ae46 MM-18721: disable SIGPIPE handling (#12394)
We recently added support for handling SIGPIPE cleanly, in order to safely shutdown plugins in the event that the STDOUT/STDERR had been closed unexpectedly. Unfortunately, this signal is also emitted when writing to a closed socket connection: an event that occurs frequently for a webserver. Normally, if no signal handler is registered for same, the Go subsystem distinguishes the file descriptor and ignores those from the network. But once a handler is registered, all SIGPIPEs are passed through: and sadly there is no way to distinguish the original file descriptor.

We don't strictly need the SIGPIPE handling for development any longer since `make stop-server` no longer shuts down the logrus process which explained the majority of hanging plugin processes. It remains suboptimal that a signal can terminate the server and leave plugin processes hanging, but the current symptoms are worse.
2019-09-30 15:44:56 -03:00
Jesse Hallam
841099194d MM-18636: fix wrong merge conflict (#12386)
I resolved a merge conflict incorrectly when submitting MM-18636, and
want to remove the unused code I left behind.
2019-09-30 14:23:00 -03:00
Nikhil Ranjan
e5ba0a0a18 Converting to structured logging the file app/oauth.go (#12135) 2019-09-29 12:42:53 +02:00
Scott Bishel
cee19b0332 MM-18013 Allow configuration of SAML crypto hashing algorithms (#12362)
* MM-18013 Add SAML Algorithms to config.

* set defaults to current values, add validation for settings

* update to use simplier config entry
2019-09-27 12:13:31 -06:00
Claudio Costa
de8e798052 [MM-18638] Send mlog console output to stderr (#12366)
* Send server logs to stderr

* Update comment
2019-09-27 17:40:16 +02:00
Jesse Hallam
340287890a MM-18636: limit configuration writes to 4Mb (#12266)
* MM-18636: limit configuration writes to 4Mb

By default, MySQL silently truncates writes that exceed the column type in question. Change the column type from `TEXT` to `MEDIUMTEXT` to allow writes to the `Configurations` and `ConfigurationFiles` table to exceed 65535 bytes.  This is a backwards compatible migration, but does require a rewrite of the table.

However, MySQL is further constrained by the default `max_allowed_packet` value of 4Mb, so limit writes accordingly.

Fixes: https://mattermost.atlassian.net/browse/MM-18636

* simplify unit tests

* fix import
2019-09-27 09:10:38 -03:00
Jesse Hallam
975055a7e7 MM-18894: Update production marketplace URL (#12378) 2019-09-26 23:59:44 -03:00