Commit Graph

16941 Commits

Author SHA1 Message Date
Michael Kochell
d403c034d4
[MM-48014] Auto-enable Apps Bar by moving EnableAppBar setting to DisableAppBar (#23010)
* auto-enable Apps Bar by moving EnableAppBar setting to DisableAppBar

* update playwright config

* remove EnableAppBar config setting to avoid confusion

* small fixes

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
2023-06-15 12:33:06 -04:00
Agniva De Sarker
747b4cf26c
MM-53058: Move cache layer out of timer layer (#23660)
Having cache layer as part of the store call
Prometheus metrics can be somewhat misleading
because cache-backed methods can have very high
volume and yet not cause any load on the DB at all.

However, if the admin is not aware which calls
are cache-backed and which are not, then
it can be hard to understand why a store call
of high volume isn't causing any stress on the DB at all.

Therefore, for simplicity we reorder the layers
such that cache layer is handled outside the timer layer.

We already have cache related metrics like hit/miss
which can be used to monitor cache usage.

https://mattermost.atlassian.net/browse/MM-53058

```release-note
NONE
```

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-15 21:08:14 +05:30
Saturnino Abril
75a0e61de7
fix failed e2e tests (#23741) 2023-06-15 21:58:00 +08:00
Nick Misasi
d7a3d14c5e
Add theming support to one of the dropdown input components (#23734)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-15 09:43:01 -04:00
Doug Lauder
d655ab94a3
Sanitize post for audit with preview links (#23745)
* sanitize post for audit with preview links

* add unit test

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-15 08:23:56 -04:00
Miguel de la Cruz
5d66883b04
Fixes CI (#23753)
* Fixes CI

* Fix client jest dependency
2023-06-15 09:45:54 +02:00
mvitale1989
b8858c4582
CLD-5835 - Do not use the mattermost-build-webapp image from ECR (#23748)
* Only use mattermostdevelopment images
* Fix docker mirroring workflow
* Reenable insights feature for E2E tests
2023-06-15 08:43:39 +02:00
Saturnino Abril
5881c7dac5
fix e2e about compliance test (#23742) 2023-06-15 14:19:38 +08:00
Miguel de la Cruz
44a99d1736
Move playbooks to plugin (#23732)
* Remove build references

* Remove playbooks webapp and server, and add the prepackaged plugin

* Remove translations

* Add ProductSettings to the playwright type

* Restore playbooks as a prepackaged plugin for cypress e2e tests
2023-06-14 23:33:26 +02:00
Harrison Healey
f386ef1ea8
Add PostComponent tests involving thread footer (#23679) 2023-06-14 16:33:48 -04:00
LeonardJouve
c7895c6f41
MM-52881: Fix date picker selected day (#23391) 2023-06-14 09:51:37 -07:00
ilies-bel
8e13e7fffe
[MM-52821] Migrate components/app.jsx to Typescript (#23605)
Co-authored-by: Iliès BELDJILALI <ibeldjilali@takima.fr>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-14 12:21:04 -04:00
Pablo Andrés Vélez Vidal
e60e2dc040
Mm 52259 system message ignore colorize (#23630)
* MM-52259 - fix system message using not themed color

* fix unit tests and code clean up
2023-06-14 18:02:54 +02:00
Christopher Poile
c06c47f22e
MM-52805 - Calls: Add calls ringing & settings panel option (#23444)
* add calls sounds; add calls options to settings panel

* i18n

* fix types; tests

* tests

* expose notificationSounds to plugins

* fix bad version reference

* the real fix

* turn off any currentRing if new ring is requested

* refactor isCallsEnabled into a selector

* fix version fallback

* remove unused vars

* merge conflicts

* stop notification rings on exits

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-14 10:57:37 -04:00
Harshil Sharma
79abeb6382
[MM-53026] - Disabled insights by default (#23702)
* Insights disabled by default

* fixed tests

* fixed tests

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-14 19:40:12 +05:30
Maria A Nunez
4021098456
Removed onboarding feature flag (#23726) 2023-06-14 08:58:02 -04:00
Pablo Andrés Vélez Vidal
6a5bb53963
[MM-52969] Revert "MM-51482_Create Apps Category and link to bots DM (#22918)" (#23647)
* Revert "MM-51482_Create Apps Category and link to bots DM (#22918)"

This reverts commit 1051925eec.

* Revert "MM-51711_Feature flag: APPS sidebar category (#22766)"

This reverts commit 9156205178.
2023-06-14 11:05:21 +02:00
Saturnino Abril
16ad573979
fix: known failed E2E tests (#23708) 2023-06-14 07:56:23 +08:00
Scott Bishel
bc66807acc
MM-53028 - Swap out todo plugin with snow in onboarding (#23681)
* swap out todo plugin with snow in onboarding

* Updating servicenow svg

* update name to be single word

---------

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
2023-06-13 17:48:27 -06:00
Scott Bishel
6063f51b0f
MM-53029 - Remove default (true) for channelExport and Apps plugin (#23682)
* remove default (true) for channelExport and Apps plugin

* readd constant, still used

* more cleanup of constants

* revert usage, constants changes

* update tests expecting Apps on by default

* remove defaults from tests

* revert package-lock.json

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-13 17:48:11 -06:00
Harrison Healey
d693f88043
Migrate actions/views/profile_popover to TS (#23663)
* Migrate actions/views/profile_popover to TS

* Fix typing
2023-06-13 16:32:08 -04:00
Ben Cooke
151b3243b7
Removing /api/v4/users/stats network request from InviteMembersButton (#23564)
Co-authored-by: Julien Tant <julien@craftyx.fr>
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-13 13:05:27 -07:00
Ben Cooke
eb8efc59cc
[MM-49088] Catching file upload issue when the response doesn't contain JSON (#23654)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-13 12:56:11 -07:00
mvitale1989
0d81e5eb40
CLD-5770 - Fix smoketests workflow (#23713)
* fix: Fix proper status update since job.status depicts current job status which is always success
* Rename status check for smoketests
* Allow localhost origin for local testing
* Increase instance size for smoketest job, better status check name

---------
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
2023-06-13 17:29:36 +02:00
Scott Bishel
be590a1f0c
MM-53005 Fix Duplicate Entry in System Console (#23685)
* remove duplicate entry in system console

* update text

* correct fix, one should show, one should hide
2023-06-13 07:58:10 -06:00
Agniva De Sarker
c249ba4a66
MM-52532: Fix golangci warnings (#23709)
https://mattermost.atlassian.net/browse/MM-52532

- Replace golint with revive
- Add makezero linter
- Fix all the required linter failures

Some issues in enterprise and public modules
are yet to be fixed. We send this to expediate things.
2023-06-13 14:08:36 +05:30
Claudio Costa
62a3ee8adc
[MM-52924] Implement ConfigurationWillBeSaved plugin hook (#23567)
* Implement ConfigurationWillBeSaved plugin hook

* Add comment

* Update comment

* Fix potential nil dereference if plugin environment is unset

* Address PR review
2023-06-12 18:23:02 -06:00
Scott Bishel
d0ad46b496
MM-52915 - Remove boards product config setting and system console (#23526)
* Remove boards product config setting and system console

* create config setting to enable/disable playbooks product

* fix to config name

* fix typo

* remove lingering ProductSettings references

* remove lingering ProductSettings references

* revert changes to package-lock.json

* Revert "revert changes to package-lock.json"

This reverts commit 1a7d98ace3.

* revert changes to package-lock.json

* fix build issues

* another fix

* update webap test

* i18n-extract

* Revert "i18n-extract"

This reverts commit c0a98c74ea.

* fix bad i18n-extract

* fix bad i18n-extract

* fix tests from bad merge

* more translation fixes

* more translation fixes

* updates from self-review

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-12 18:52:19 +02:00
Miguel de la Cruz
1215584665
Prevent boards product from being included automatically (#23539)
* Prevent boards product from being included automatically

* Fix config diff test

* Update prepackaged plugin version

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>

* Readd boards/dist to the gitignore

* Does not enable the focalboard plugin by default

* Update plugin version to v7.10.3

---------

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
2023-06-12 18:51:43 +02:00
Maria A Nunez
d8cb5f3a6e
Update prepackaged version for NPS (#23699) 2023-06-12 12:30:10 -04:00
Harrison Healey
dfdc0e28d0
MM-52536 Webpack unification part 2 (#23557)
* Remove unused bundle-loader

* Remove broken webpack-live-reload-plugin

* Remove unused terser-webpack-plugin

* Remove unused dotenv-webpack

* Update and share type definition for Webpack global values

* Share eslint-import-resolver-webpack

* Remove unused pmmmwh/react-refresh-webpack-plugin

* Remove webpack-cli/serve since it's already part of webpack-cli

* Remove unused Webpack packages from Components

* Share and update style-loader

* Remove unused image-webpack-loader from Boards
2023-06-12 11:50:34 -04:00
Ben Cooke
c2417efc33
[MM-52618] Adding generic error to handle network issues when fetching groups (#23495)
* adding generic error to handle network issues
---------
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-12 11:42:30 -04:00
Nick Misasi
37196a6a26
Enforce PermissionSysconsoleWriteBilling in self serve workspace deletion (#23691) 2023-06-12 10:33:11 -04:00
Harrison Healey
59d5df6bce
MM-51528 Fix new messages line overlapping date lines (#23525)
* MM-51528 Fix new messages line overlapping date lines

* Improve clarity of CSS for New Messages and Date separators

* Remove doubled padding above date the New Messages line

* Remove ThreadViewer-specific CSS for separators
2023-06-12 09:57:41 -04:00
mvitale1989
0445d8348c
CLD-5698 - Add e2e smoketests (#23590)
* Prepare: run E2E smoketests with GitHub actions (#23301)
* Port E2E testing scripts from cypress-ui-automation
* Move server to docker-compose, move E2E images to ecrpublic
* Integrate General channel renaming, fixes
* Add local automation-dashboard
 Add readme
* Add E2E smoketests
* Bump postgres to 12
* Fully rely on mattermostdevelopment images

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Saturnino Abril <saturnino.abril@gmail.com>
Co-authored-by: Antonis Stamatiou <stamatiou.antonis@gmail.com>
2023-06-12 11:56:33 +02:00
Ibrahim Serdar Acikgoz
4546a2eebb
[MM-47976] cmd/mattermost/db: add downgrade commands and enable plan saving (#21779) 2023-06-12 12:48:50 +03:00
Agniva De Sarker
efaa6264cc
MM-53032: Fix module path after repo rename (#23689)
It was a good decision in hindsight to keep the public module as 0.x
because this would have been a breaking change again.

https://mattermost.atlassian.net/browse/MM-53032
```release-note
Changed the Go module path from github.com/mattermost/mattermost-server/server/v8 to github.com/mattermost/mattermost/server/v8.

For the public facing module, it's path is also changed from github.com/mattermost/mattermost-server/server/public to github.com/mattermost/mattermost/server/public
```
2023-06-11 10:54:35 +05:30
Ben Schumacher
a6d1d38b27
[MM-50734] Add option to use German HPNS notification proxy (#23562)
* Add option to use German HPNS notification proxy

* Changes per feedback

* make use of const

* Fix privacy policy link

* Fix bug found via https://github.com/mattermost/mattermost/pull/23562\#issuecomment-1581456269

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-10 07:53:54 +02:00
Ibrahim Serdar Acikgoz
446b474489
[MM-49084] public/model/config: elasticsearch: add ingore option to some indexes to purge (#23571) 2023-06-10 00:50:08 +03:00
Harrison Healey
b9f52126c2
MM-53115 Fix ridiculous Babel bug by removing unused code (#23696)
* MM-53115 Fix ridiculous Babel bug by removing unused code

* Fix Playbooks clean script missing some files

* Turn on typescript-eslint/no-unused-vars ESLint rule for Playbooks
2023-06-09 16:39:48 -04:00
M-ZubairAhmed
adb248497d
MM-52797 : Drafts badge doesn't clear when parent message deleted and removed (#23636)
* yup

* int

* c

* ok

* Update posts.ts

* actual change

* a

* Update actions.ts

* ty

* Update drafts_link.tsx

* revert to old function name

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-09 16:22:45 -04:00
Andrey K
c0ee02356e
[GH-23555] Do not block global backspace key press for contenteditable's (#23626)
* [GH-23555] Backspace is forbidden globally

* [GH-23555] Backspace is forbidden globally (refactoring)

---------

Co-authored-by: Andrey Karavashkin <akaravashkin@stsoft.ru>
2023-06-09 16:01:57 -04:00
Devin Binnie
19f33f332c
[MM-52627] Only show the team/channel name on search items in the RHS (#23649)
* [MM-52627] Only show the team/channel name on search items in the RHS

* Remove additional date separator

* PR feedback
2023-06-09 13:01:41 -04:00
Agniva De Sarker
f4539bc65a
MM-53090: Do not run PG binary tests on master (#23688)
https://mattermost.atlassian.net/browse/MM-53090
```release-note
NONE
```
2023-06-09 21:37:49 +05:30
Jesse Hallam
8194817d54
disable coverage (#23686)
* disable coverage

This reduces runtime of the server test suite from ~30m to ~10m, and as far as I can see: we discarded the coverage output anyway.

* allow morph 60s to migrate when running tests
2023-06-09 12:29:08 +02:00
Harrison Healey
11c0a861b2
MM-52539 Unify versions of Babel used throughout web app and remove unneeded libraries (#23543)
* Remove unneeded Babel plugins and update Babel preset

* Remove unneeded babel/cli package

* Update and share Babel and presets

* Update and share babel-plugin-styled-components

* Update and share babel-plugin-formatjs

* Update and share babel-plugin-typescript-to-proptypes

* Update and share babel-loader

* Remove all Babel-related ESLint libraries

* Remove unused babel-jest from Playbooks

* MM-51968 Remove unused Babel libraries from Boards

* Update snapshots because of course I have to

* Update snapshot
2023-06-08 17:05:21 -04:00
Julien Tant
cbfc14b2b4
[MM-52922] Fix a possible nil call to subscription.LastInvoice (#23540)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-06-08 11:41:40 -07:00
Ibrahim Serdar Acikgoz
a9645b634a
server/Makefile: update morph usage in new-migration target (#23363) 2023-06-08 16:30:21 +03:00
Alejandro García Montoro
a195694896
Run the UPDATE only when needed (#23228) 2023-06-08 12:15:49 +02:00
Doug Lauder
ac3c0da8ff
Support json.RawMessage in configuration env overrides (#23610)
* support json.RawMessage in env overrides
2023-06-07 17:21:58 -04:00