Commit Graph

11708 Commits

Author SHA1 Message Date
Nikhil Ranjan
d7ee3553fa Plugin framework: add ability to install other plugins to the… (#12232)
* add ability to upload other plugins to the plugin API

* generated client rpc glue code

* fix UploadPlugin API signature

* generated plugin mocks

* added upload plugin test

* removed unused comment

* using single line to call InstallPlugin with file Reader

* fix minimum server version

* added successful plugin upload test

* renamed UploadPlugin to InstallPlugin
2019-10-17 14:57:55 -04:00
Joshua Bezaleel Abednego
db97b49e7a store/storetest: migrate command_store.go to use testify (#12797)
* Modify the calls to t.Fatal to using require package

* Fixes according to suggestions
2019-10-17 10:45:40 -07:00
Shobhit Gupta
4a6cf29d4e Migrate tests to use testify (#12811) 2019-10-17 10:41:45 -07:00
Michael Kochell
8c94f48991 [MM-18831] Trim whitespace of Display Name when channel is cre… (#12380) 2019-10-17 10:39:27 -06:00
Michael Kochell
83bab2c125 [MM-19102] Enable debug flag for plugin check tests (#12588) 2019-10-17 10:38:47 -06:00
Agniva De Sarker
ee1f458bb1 Fix CI config (#12771)
* Fix CI config

- -mod=vendor flag was not being passed during the build stage, forcing
it to download everything again.
- Optimize the git clone of webapp with --depth=1 and use GIT_SSH_COMMAND to clone.
- Add $(GOFLAGS) to some other places which got missed out.

* Remove GOFLAGS from go list command

It does not work for Go 1.12. Need to fix later.
2019-10-17 18:38:21 +02:00
Rohan Julka
b8f6b2022e Migrate tests from api4/system_test.go to use testify (#12812) 2019-10-17 17:25:13 +02:00
WonChul Heo
bbb7308124 [MM12767] - Migrate tests from "store/storetest/license_store.… (#12769) 2019-10-17 17:05:14 +02:00
Ogundele Olumide
47e3685419 MM-18270 Refactor "app/server.go" to use structured logging (#12505) 2019-10-17 17:04:57 +02:00
aqche
54181e4015 Migrate tests from 'store/sqlstore/utils_test.go' to use testify (#12815) 2019-10-17 07:24:06 -07:00
Peeyush Gupta
fffcef0b00 MM-19234 Migrate tests from model/team_member_test.go to use testify (#12642) 2019-10-17 09:22:55 -04:00
Jesse Hallam
ff160a4d32 MM-19048: avoid error spam during CI builds (#12626)
Detect the IS_CI flag and skip trying to rewrite subpaths that won't necessarily exist.
2019-10-17 09:55:02 -03:00
pqzx
1ad0cb646f Migrate tests from "store/storetest/session_store.go" to use t… (#12805) 2019-10-17 14:36:17 +02:00
Ben Sooraj
c7e2689926 mlog standardisation for app/import.go (#12741)
* mlog standardisation for app/import.go

* using the corrent mlog.Field type for the error
2019-10-17 11:18:08 +01:00
Eli Yukelzon
66c66eef0d MM-19371 - Reply count disappears from pinned and flagged conv… (#12753) 2019-10-17 11:10:49 +03:00
Martin Kraft
c742d18828 MM-17477: Truncates group display name upon linking. (#12751) 2019-10-16 11:50:24 -04:00
Eli Yukelzon
4225977966 MM-19154 - Fix flaky test TestGroupStore/MySQL/GetGroups/Get_g… (#12705) 2019-10-16 12:55:36 +03:00
Phillip Ahereza
42b011b81d Migrate tests from mfa_test.go to use testify (#12720) 2019-10-15 22:09:12 -05:00
Arjit Chaudhary
1a2197ec8e Refactor "app/export.go" to use structured logging #12727 (#12729)
* Refactor "app/export.go" to use structured logging #12727

* use mlog.String

* use mlog.Bool, mlog.string needs 2 values?

* Update export.go

* s/reaction_UserId/user_id
2019-10-15 17:31:46 -04:00
Ben Schumacher
ad474cb0d9 [MM-18592] Add IconPath field to plugin manifest (#12189) 2019-10-15 23:25:50 +02:00
Shodiq Muhammad
b43b84807e change t.Fatal to assert.Equal in post_list_test.go (#12678) 2019-10-15 23:05:58 +02:00
Jesper Hansen
bc1ae7e93e MM-19237: convert t.Fatal to use require calls (#12660) 2019-10-15 23:04:38 +02:00
Jesse Hallam
5d45aa81e0 MM-16888: fix missing indexes (#12746)
* MM-16888: fix missing indexes

As part of https://mattermost.atlassian.net/browse/MM-16888, we discovered and fixed a number of column and index mismatches between the canonical (i.e. created from scratch) and migrated schemas (i.e migrated from 5.0 through 5.16).

Unfortunately, the migration to fix same was added to `UpgradeDatabaseToVersion514` but never cherry picked to the pending v5.14 release at the time. Customers who upgraded to v5.14 or v5.15 and then get this code as part of v5.16 will never run that migration. Copy it to the UpgradeDatabaseToVersion516 accordingly.

* avoid fixing ChannelMembers.SchemeGuest on MySQL

* synchronize .circleci/config.yml with scripts/mysql-migration-test.sh

* fix circleci invocation

* additional logging on diff

* update build/Jenkinsfile.pr too!
2019-10-15 15:47:09 -03:00
Eli Yukelzon
eae1acef5f removed unsupported timezones (#12707) 2019-10-15 13:43:20 -03:00
Amine
d7d7216b0d Migrate tests from store/storetest/cluster_discovery_store.go to use testify (#12757) 2019-10-15 16:22:19 +02:00
jatinjtg
0ba6a791ef Fix typo (#12655) 2019-10-15 15:45:46 +02:00
Fares Rihani
69c8f89057 Update Contributing Code link in README.md (#12735) 2019-10-15 15:33:41 +02:00
Saturnino Abril
65dc760f01 add option to generate deactivated users via sampledata (#12772) 2019-10-15 21:25:31 +08:00
Ben Sooraj
710c732349 mlog standardisation for app/channel.go (#12738) 2019-10-15 15:25:12 +02:00
Irzhy Ranaivoarivony
d97afa72cb MM-19352 - Migrated test in store/storetest/audit_store.go to… (#12739) 2019-10-15 09:10:40 -04:00
Carlos Tadeu Panato Junior
99f343f4ce remove -p=8 (#12799) 2019-10-15 13:24:46 +02:00
Ogundele Olumide
6b901773e6 MM-18274 Refactor "app/email.go" to use structured logging (#12504)
* chore: refactor to use structured logging

 - change fmt.sprintf method used in the logger to appropriate mlog
   method

* implement suggested changes by removing added line during merge conflict
2019-10-15 12:27:09 +02:00
Jesús Espino
441777a4e7 Only include the avatar attachment if is going to show a message in the invitation (#12747) 2019-10-15 11:16:31 +02:00
Sascha Andres
ade6044441 MM-19135 Migrate tests from "model/channel_member_test.go" to… (#12651) 2019-10-15 11:48:06 +03:00
Lev
7239f8da60 Bumped Jira plugin version to 2.2.2 (#12770)
* Bumped the Jira plugin to v2.2.0

* Bumped Jira plugin version to 2.2.1

* Bumped Jira plugin version to 2.2.2

* Bumped Jira plugin version to v2.2.2
2019-10-14 20:36:56 -07:00
Ibrahim Serdar Acikgoz
d5fa1297a9 services/filestore: migrate s3store_test to testify (#12685)
* services/filestore: migrate s3store_test to testify

* services/filestore: s3_store_test.go polished
2019-10-14 21:25:44 +02:00
Santosh Desani
dc05e81012 [MM-18277] Refactor plugin/health_check.go to use structured l… (#12734) 2019-10-14 12:00:23 -06:00
Scott Bishel
06866952b6 MM-16861: Support Guest Authentication via AD/LDAP (#12690)
* Add config settings for LDAPSettings GuestFilter

* make error unique

* Update model/config.go

Co-Authored-By: Martin Kraft <martin@upspin.org>

* add LdapSetting isempty_guest_attribute to diagnostics.go
2019-10-14 11:38:17 -06:00
Nikhil Ranjan
c5dcd85bc8 Converting to structured logging the file store/sqlstore/upgrade.go (#12628)
* Converting to structured logging the file store/sqlstore/upgrade.go

* changes as per review
2019-10-14 12:55:50 +02:00
Shodiq Muhammad
6f4f06f8d4 change t.Fatal to assertions in model/outgoing_webhook_test.go (#12693)
* change t.Fatal to assertions in model/outgoing_webhook_test.go

* user assert NotNilf and Nilf, remove backticks
2019-10-13 21:39:30 +02:00
George Felix
b860355f30 Convert model/channel_test.go validation calls into assert/require calls (#12605)
* Convert model/channel_test.go t.Fatal calls into assert/require calls

* Removed blank spaces

* Changes based on suggestions coming from related task https://github.com/mattermost/mattermost-server/pull/12602#pullrequestreview-296859312
2019-10-13 21:38:58 +02:00
Jairo Junior
babbe087ff Convert app/import_test.go t.Fatal calls into assert/require calls (#12228) 2019-10-13 21:38:28 +02:00
Mike Vanbuskirk
705090999b migrate t.Fatal to require.Fail (#12530)
* migrate t.Fatal to require.Fail

* remove nested if/else logic in tests, use bool

* correct bool eval on plugin tests
2019-10-13 21:38:06 +02:00
Vitalii Ananichev
2f5949d05e Migrate tests from "model/cluster_stats_test.go" to use testify (#12580) 2019-10-13 21:37:41 +02:00
Michael Kochell
467141ab69 [MM-19004] Change assertion in client4/system_test.go to be less flaky (#12586)
* avoid swallowing errors from websocket_client.SendMessage

* Revert "avoid swallowing errors from websocket_client.SendMessage"

This reverts commit 5f223e0996.

* test against app.TotalWebsocketConnections instead of hardcoding assertion
2019-10-13 20:37:34 +02:00
Karan Nadagoudar
fa8e57d91a [MM-19122] Migrate tests from "model/user_access_token_test.go" to use testify (#12581)
* Migrated to testify/require and testify/assert.
2019-10-12 12:09:27 +03:00
TPaschalis
946a5c1417 Mm 19027 (#12498)
* Migrate tests from model/websocket_request_test.go to use testifyy

* Migrate tests from model/websocket_request_test.go to use testify

* Update model/websocket_request_test.go

Co-Authored-By: Miguel de la Cruz <mgdelacroix@gmail.com>

* Update model/websocket_request_test.go

Co-Authored-By: Miguel de la Cruz <mgdelacroix@gmail.com>
2019-10-11 23:00:23 +02:00
Marc Argent
97496d4e29 Migrate tests from model/search_params_test.go to use testify (#12650) 2019-10-11 19:54:04 +02:00
WonChul Heo
68fc1b6e5e Migrate assert (#12643) 2019-10-11 16:25:31 +02:00
Ogundele Olumide
867027117e MM-18281 Refactor "app/server_app_adapters.go" to use structured logging (#12503)
* chore: refactor to use structured logging

 - remove the unsed fmt package
 - convert the fmt.sprintt to the structured logging

* implement requested changes from iomodo

* implement feedback from willfrog
2019-10-11 16:24:54 +02:00