Commit Graph

10963 Commits

Author SHA1 Message Date
Jesús Espino
fb237cc624 Migrate User.Update method to sync by default (#10942) 2019-05-28 09:40:29 +02:00
Angela Chang
8e6a158449 [MM-8421] Special PR to have parseImages return nil when format is tiff (#10928) 2019-05-27 22:20:10 +02:00
Bolarinwa Balogun
674b6f2285 [MM-15803] Migrate "Session.AnalyticsSessionCount" to Sync by default (#10948)
* [MM-15803] Migrate "Session.AnalyticsSessionCount" to Sync by default

* Use Explict Async for sessionChan in analytics.go
2019-05-27 18:54:46 +02:00
Andres Orozco
ff0d3ab00b MM-15354: Migrate Channel.Save to sync by default (#10871)
* MM-15354: Migrate Channel.Save() to sync by default

* MM-15354: fix unchanged Channel().Save() methods

* fix typo

* fix nil reference bug and update tests for channels

* fix err shadowing bug

* MM-15354 fix support for sync version of Save
2019-05-27 17:54:04 +02:00
Woolim Cho
d28f56c61e Migrate Preference.DeleteCategoryAndName to Sync by default (#10940) 2019-05-27 11:40:49 -04:00
Saturnino Abril
28b057c972 add /test post command to post a message as different user to a channel/team (#10798) 2019-05-27 10:21:49 -04:00
Ishank Gulati
fb6c1debf0 [MM-15296] Migrate "Preference.Save" to Sync by default (#10866)
* response format changes

* Generated mocks
Fixed all references of Preferences.Save

* Remove old code from store.go (incorrect merge)

* Review change - Add validations on count and error

* Review change - return from root level

* Review change - return 0 as nil value for int

* fix initialisation of err in preference_store
2019-05-26 15:06:33 +02:00
Tsilavina Razafinirina
c05cf5b033 [MM-11287] Add support for plus sign and period/dot in custom URL schemes (#9155) (#10852) 2019-05-25 21:47:06 +02:00
Daniel Schalla
2d97f01781 [MM-15639] Add config setting to explicitly define which IP headers are trusted (#10907)
* Add config setting to explicitly define which IP headers are trusted

* fix variable shadowing

* Optimize code flow; Add Ratelimit test for header set

* Extend Ratelimit tests

* Add additional unit tests

* Structured logging
2019-05-24 20:22:13 +02:00
Martin Kraft
e8af4872c6 MM-15422: Adds new parameters for retrieving pages of channels. (#10903)
* MM-15422: Adds new parameters for retrieving pages of channels and searching channels.

* MM-15422: Appends excluded channel names with defaults. Adds separate struct for data-tier option parameter.
2019-05-24 11:28:42 -04:00
Jesús Espino
124b371312 Add support for tracing in LDAP (#10920) 2019-05-24 09:55:07 -04:00
Jesús Espino
1269db8691 Migrate User.PermanentDelete to Sync by default (#10876) 2019-05-24 15:16:15 +02:00
Jesús Espino
5a8c07412b Fixing Elasticsearch indexing (#10919) 2019-05-24 14:46:46 +02:00
farhadab
6158adb5b4 [MM-15305] Migrate Preference.CleanupFlagsBatch to Sync by default (#10858)
* [MM-15305] Migrate Preference.CleanupFlagsBatch to Sync by default

* clean up code in CleanupFlagsBatch
2019-05-24 09:46:07 +02:00
Andres Orozco
88005fbf54 MM-15662: Rename "CreateBotAccounts" config.json setting to "EnableBotAccountCreation" (#10875)
* MM-15662 change conflig flag to EnableBotAccountCreation

* undo changes to i18n

* MM-15662: Change config flag for bot creation

adds newline to i18n

* MM-15662 Update diagnostics.go to use new config flag
2019-05-23 13:03:22 -07:00
Christopher Poile
693d11304b * stop exposing plugin's SettingsSchema in api/v4/plugins/webapp (#10911) 2019-05-23 12:34:59 -07:00
Harrison Healey
869e8eae26 MM-15542 Change getPostsBefore/After to include all posts in each thread (#10859)
* MM-15542 Add new tests for GetPostsBefore and GetPostsAfter

* MM-15542 Change getPostsBefore/After to include all posts in each thread
2019-05-23 15:19:49 -04:00
Martin Kraft
a5cbe97d31 MM-15741: Omit Reply-To email header if EmailSettings.ReplyToAddress … (#10910)
* MM-15741: Omit Reply-To email header if EmailSettings.ReplyToAddress is blank.

* MM-15741: Adds tests.

* MM-15741: Changes interface name because the '-er' convention doesn't apply.

* MM-15741: Combines two structs and un-exports.

* MM-15741: Switches to table test.

* MM-15741: Renames test.

* MM-15741: Unexport interface.

* MM-15741: Change to allow test cacheing.
2019-05-23 12:46:35 -04:00
Jesús Espino
edd3cc890f MM-15480: Add server support for Range on files (#10892) 2019-05-23 16:46:28 +02:00
Jesús Espino
87ff64ea6d MM-15035: Read from file infos from master on post creation (#10899)
* MM-15035: Read from file infos from master on post creation

* Handling edit post cases for get files metadata
2019-05-23 14:29:41 +02:00
Eli Yukelzon
e59674cfdd MM-14721 - Add an identifier for compliance exports when a message is posted by a bot account (#10908) 2019-05-23 13:33:18 +03:00
Jesús Espino
a8caee330a MM-15728: Fixing not initialized SchemeGuest field on bulk indexing query (#10906)
* MM-15728: Fixing not initialized SchemeGuest field on bulk indexing query

* Fix typo
2019-05-22 12:31:26 +02:00
Jason Blais
fe3bad8643 Add missing diagnostics for 5.12 (#10868)
1. NotificationLogSettings added with 5b252e8736 (diff-2279f86634da3f787f279961af76713a)
1. ServiceSettings.CreateBotAccounts added with 30061df036 (diff-2279f86634da3f787f279961af76713a)
2. PluginSettings.EnableHealthCheck added with 43e95b0b2b (diff-2279f86634da3f787f279961af76713a)
3. Change "jira" state diagnostics to be consistent with NPS and Zoom plugins
2019-05-21 23:51:15 +02:00
Elias Nahum
5c75dc6770 MM-15707 include missing localized strings (#10904) 2019-05-21 22:07:11 +02:00
Daniel Schalla
d269891476 [MM-15490] Rework default password requirements (#10844)
* Rework default password requirements

* Update API Test Lib Default User PW

* Remove unused function; Disable password reqs in dev mode

* Disable strict password requirements for unit tests

* Update unit tests
2019-05-21 11:03:36 -07:00
PR
0b6acaa9ba GH-10761: Migrate Post.Get to sync by default (#10831)
* GH-10761: Migrate Post.Get to sync by default

* instantiate storeChannel with make

* fix go vet issue

* fix go vet issue

* use select for checking channel for value

* fix go vet shadow variable issue

* addressing review comments

* call post.Get() in goroutine

* refactor minor values to fix tests

* fix: remove err error type, it should be *model.AppErr
2019-05-21 11:01:30 -07:00
Gabe Jackson
8c048a6604 Review error logging (#10897)
This change lowers the levels of a few log messages in an attempt
to bring them more in line with the severity of the actual message.
2019-05-21 10:57:26 -07:00
Jesús Espino
f8a89a52fc Migrate System store to Sync by default (#10838) 2019-05-21 18:22:27 +02:00
Daniel Schalla
3e6fed8df4 [MM-15641] Set stricter caching policy for file downloads (#10857)
* Set stricter caching policy for file downloads

* Add private directive back to caching header for file downloads
2019-05-21 17:10:39 +02:00
jfrerich
726d723537 [MM-15067] Permit Bot accounts to create user access tokens if Enable Personal Access Tokens set to "false" (#10658)
* Permit Bot accounts to create user access tokens if
EnableUserAccessTokens config setting is set to false

* User is now outside of the go routine because we need user.IsBot for
this ticket.  This renders the goroutine and channel unnecessary

* move err check following user def
2019-05-21 06:44:29 -07:00
Elias Nahum
be935cee4e Revert "MM-10867 Split GetExplicitMentions function to several smaller ones (#10492)" (#10895)
This reverts commit fb01d37846.
2019-05-20 16:37:55 -03:00
Stylianos Rigas
713cf1ec36 MM-15494 Adding warning log when someone has configured a Mattermost push proxy with HTTP endpoint (#10869)
* MM-15494 Adding warning log when someone has configured a Mattermost push proxy with HTTP endpoint

* MM-15494 go fmt check

* MM-15494 Making function private

* MM-15494 Updating warning message
2019-05-20 17:39:57 +03:00
Devin Binnie
9652b49569 [MM-15300] Migrate "Preference.PermanentDeleteByUser" to Sync by default (#10860)
* [MM-15300] Migrate "Preference.PermanentDeleteByUser" to Sync by default

* [MM-15300] Fixed readability on the SQL statement
2019-05-20 13:46:41 +02:00
Eli Yukelzon
18612bf771 MM-14874 - Google SSO: Migrate user API endpoint from Google+ API to People API (#10833) 2019-05-19 10:31:29 +03:00
Jason Blais
fc672e988c Add two missing bot settings to default.json (#10867)
* Add two missing bot settings to default.json

`DisableBotsWhenOwnerIsDeactivated` was added to model/config.go by 06b579d18a (diff-2279f86634da3f787f279961af76713a)

`EnableBotAccountCreation` was added to model/config.go by 30061df036 (diff-2279f86634da3f787f279961af76713a)

* Update default.json

* Update diagnostics_test.go

* Revert accidental commit
2019-05-17 09:38:55 -07:00
Jesús Espino
6d1ac00330 Migrate Roles Layered store to Sync by default (#10790)
* Migrate Roles Layered store to Sync by default

* Fixing govet

* Addressing PR review comments
2019-05-17 12:03:04 -03:00
Giorgos Christos Dimitriou
fb01d37846 MM-10867 Split GetExplicitMentions function to several smaller ones (#10492) 2019-05-17 16:23:56 +02:00
Jerry Fireman
571a026a4e MM-11701 Log request ID for outgoing webhooks (#10513)
* "Log request ID"

* "Log request ID"

* "Update in response to comment"

* "Update in response to comment"

* "Run gofmt"
2019-05-17 06:48:32 -07:00
Martin Kraft
8d8a4d8614 MM-15485: In-channel system behaviour for at-mentions and slash commands for group-constrained channels. (#10855)
* MM-15108: Prevent non-group-members from being added to group-constrained channels.

* MM-15485: Updates ephemeral message when non-group member is invited to group-constrained channel.

* MM-15485: Prevent group-permitted members from being removed from group-constrained channels. Show custom ephemeral when attempting /kick or /remove.
2019-05-17 12:43:19 +01:00
PR
6d2fa0f3d2 Migrate Overwrite and GetMaxPostSize() in PostStore to sync by default (#10829)
* Migrate Overwrite and GetMaxPostSize() in PostStore to sync by default

* GH-10762: fix return type for mock func

* GH-10762: fix tests for MaxPostSize() mocks

* fix imports
2019-05-17 10:46:18 +02:00
Shota Gvinepadze
fab2e349b3 [MM-10768] Migrate "Channel.SaveDirectChannel" to Sync by default (#10846) 2019-05-16 22:04:58 +02:00
Lev
2d3e417833 MM-15632 DeleteEphemeralMessage to accept a postId string (#10853)
Before it was accepting `post *model.Post`, and returning one.
This is a breaking change for the giphy plugin and any other that rely
on the API.
2019-05-16 12:32:13 +02:00
Pradeep Murugesan
5d1ee9373f made the Restore and Delete store method to be sync (#10835) 2019-05-16 12:31:50 +02:00
Miguel de la Cruz
098dbc84cc [MM-14751] Adds group_constrained filter to user list and search endpoints (#10678) 2019-05-16 10:12:06 +01:00
Jesús Espino
beb7592c93 Migrate FileInfo store to Sync by default (#10837) 2019-05-15 22:07:03 +02:00
Harrison Healey
99ea780f20 MM-13142 Replace mlog.Any with mlog.Err (#10848) 2019-05-15 16:04:43 -04:00
Martin Kraft
1b78f9debc MM-14897: Changes to be able to add and remove groups from channels. (#10794)
* MM-15162: Changes for LDAP groups removals phase.

* MM-14897: Changes to be able to add and remove groups from channels.

* Update model/client4.go

* MM-14897: PR-requested change to string interpolation.
2019-05-15 12:03:47 -04:00
Andres Orozco
dd33bc13a7 MM-14723 add CreateBotAccounts to client.go (#10849) 2019-05-15 08:25:56 -07:00
Carlos Tadeu Panato Junior
9559de26cc update db to 5.11 (#10826) 2019-05-15 16:58:48 +02:00
Pradeep Murugesan
24a02b4168 made the preference store GetCategory method sync (#10847)
* made the preference store GetCategory method sync

* fixed the review comments
2019-05-15 07:56:42 -07:00