Agniva De Sarker 6f87eb991f MM-34786: Fix racy test TestStartServerTLSSuccess (#17387) ...

* MM-34786: Fix racy test TestStartServerTLSSuccess

There were a bunch of more tests which concurrently
updated config along with starting the server.

We apply the same fix as before in https://github.com/mattermost/mattermost-server/pull/17215

https://mattermost.atlassian.net/browse/MM-34786

```release-note
NONE
```

* Refactor newServer

* checking for error too

2021-04-13 21:12:48 +05:30

..

layer_generators

Extracting i18n functionality to i18n core library (#16914)

2021-02-26 08:12:49 +01:00

opentracing

[MM-32044] Reset SAML auth data (#17161)

2021-04-13 00:46:30 +02:00

plugin_api_tests

Fix initialism errors (PR-2) (#17032)

2021-04-03 12:43:22 +05:30

slashcommands

MM-32133 shared channel username collisions (#17347)

2021-04-13 10:40:12 -04:00

admin.go

[MM-34179] app: move cluster registeration to server creation (#17306)

2021-04-01 11:29:56 +03:00

analytics.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

app_iface.go

[MM-32044] Reset SAML auth data (#17161)

2021-04-13 00:46:30 +02:00

app_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

app.go

[MM-34179] app: move cluster registeration to server creation (#17306)

2021-04-01 11:29:56 +03:00

audit.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

authentication_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

authentication.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

authorization_test.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

authorization.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

auto_responder_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

auto_responder.go

Fix initialisms/app (#16818)

2021-02-05 11:22:27 +01:00

bot_test.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

bot.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

brand.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

busy_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

busy.go

MM-31063: Change constants to use CamelCase (#16608)

2021-01-04 11:32:29 +05:30

channel_category_test.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

channel_category.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

channel_test.go

Enable the errorAssertions govet check for mattermost-server code (#17346)

2021-04-12 12:51:31 +02:00

channel.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

cloud.go

[MM-28694] Add MM User information in the CWS request headers (#15824)

2021-03-05 09:23:39 +01:00

cluster_discovery_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

cluster_discovery.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

cluster_handlers.go

[MM-34179] app: move cluster registeration to server creation (#17306)

2021-04-01 11:29:56 +03:00

cluster.go

MM-25154: Fix data race in InvokeClusterLeaderChangedListener (#14610)

2020-05-22 23:52:25 +05:30

command_autocomplete_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

command_autocomplete.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

command.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

compliance.go

MM-30862: Fix racy test RunComplianceReports (#16377)

2020-11-24 21:36:34 +05:30

config_test.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

config.go

All Sections to SubSections (#16917)

2021-04-06 10:39:48 -04:00

constants.go

MM-31063: Change constants to use CamelCase (#16608)

2021-01-04 11:32:29 +05:30

context.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

data_retention.go

MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)

2020-02-13 13:26:58 +01:00

download_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

download.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

email_batching_test.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

email_batching.go

Extracting html templates into a library (#16946)

2021-03-12 18:46:43 +01:00

email_test.go

Extracting mail service into shared libs (#17030)

2021-03-15 11:50:13 +01:00

email.go

[MM-34240]-Cloud: Congratulations welcome email missing images (#17338)

2021-04-06 10:13:14 -04:00

emoji.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

enterprise_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

enterprise.go

[MM-32639] - Resend user invite emails (#17113)

2021-03-31 13:20:53 -04:00

expirynotify_test.go

[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)

2021-02-25 20:22:27 +01:00

expirynotify.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

export_converters.go

add support for exporting and importing props (#14034)

2020-03-23 09:21:05 -04:00

export_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

export.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

extract_plugin_tar_test.go

MM-21915: improve tar gz path traversal (#13675)

2020-01-27 11:33:11 -05:00

extract_plugin_tar.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

feature_flags.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

file_bench_test.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

file_test.go

Enable the errorAssertions govet check for mattermost-server code (#17346)

2021-04-12 12:51:31 +02:00

file.go

[MM-33826] add more detailed S3 error messages (#17182)

2021-04-09 18:16:30 +02:00

group_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

group.go

Revert "Fix initialism errors (PR-3) (#17062)" (#17202)

2021-03-23 10:32:54 +01:00

helper_test.go

MM-34002: Improve AddUserToChannel (#17174)

2021-04-02 14:33:23 +05:30

image.go

[MM-28638] Improve image thumbnail generation logic (#15534)

2020-10-09 08:47:20 +02:00

import_functions_test.go

[MM-32622] Remove app.WaitForChannelMembership() (#17048)

2021-03-31 09:40:35 +02:00

import_functions.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_test.go

[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)

2021-02-25 20:22:27 +01:00

import_types.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

import_utils_test.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_utils.go

[MM-33794] Improve password generation during bulk import (#17147)

2021-03-24 10:32:16 +01:00

import_validators_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

import_validators.go

Fix empty string comparison issues in the codebase (#16686)

2021-01-25 11:15:17 +01:00

import.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

integration_action_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

integration_action.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

job_test.go

All Sections to SubSections (#16917)

2021-04-06 10:39:48 -04:00

job.go

All Sections to SubSections (#16917)

2021-04-06 10:39:48 -04:00

ldap.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

license_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

license.go

[MM-32822] Improve JobServer state handling (#16959)

2021-03-26 10:32:16 +01:00

login_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

login.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

main_test.go

[MM-31094] Replication Lag (#16888)

2021-03-12 12:37:30 -05:00

migrations.go

Improve document extraction and including a document extraction command (#17183)

2021-04-07 13:27:20 +02:00

notification_email_test.go

Extracting html templates into a library (#16946)

2021-03-12 18:46:43 +01:00

notification_email.go

Extracting html templates into a library (#16946)

2021-03-12 18:46:43 +01:00

notification_push_test.go

Extracting i18n functionality to i18n core library (#16914)

2021-02-26 08:12:49 +01:00

notification_push.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

notification_test.go

MM-34002: Improve AddUserToChannel (#17174)

2021-04-02 14:33:23 +05:30

notification.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

oauth_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

oauth.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

opengraph_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

opengraph.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

options.go

[MM-32822] Improve JobServer state handling (#16959)

2021-03-26 10:32:16 +01:00

permissions_migrations_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

permissions_migrations.go

All Sections to SubSections (#16917)

2021-04-06 10:39:48 -04:00

permissions_test.go

unparam lint (#16771)

2021-02-04 11:08:05 +05:30

permissions.go

Fix empty string comparison issues in the codebase (#16686)

2021-01-25 11:15:17 +01:00

plugin_api_test.go

Extracting i18n functionality to i18n core library (#16914)

2021-02-26 08:12:49 +01:00

plugin_api.go

MM-33180: Extend Group APIs for plugins. (#17232)

2021-04-12 14:01:28 -03:00

plugin_commands_test.go

Extracting i18n functionality to i18n core library (#16914)

2021-02-26 08:12:49 +01:00

plugin_commands.go

[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)

2021-02-25 20:22:27 +01:00

plugin_context.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

plugin_deadlock_test.go

[MM-21378] Add mutex to model.Post to guard against race conditions on Post.Props (#13884)

2020-03-13 21:12:20 +01:00

plugin_event.go

MM-21898 - Part 1: Generate and use an interface instead of *A… (#13840)

2020-02-13 13:26:58 +01:00

plugin_health_check_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

plugin_hooks_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

plugin_install_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

plugin_install.go

Add feature flag for apps (#16851)

2021-03-29 15:53:31 +02:00

plugin_key_value_store.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

plugin_public_keys.go

[MM-20309] production public key (#13244)

2019-12-05 23:41:52 +04:00

plugin_requests_test.go

Save access on plugin env during ServePluginPublicRequest (#16854)

2021-02-17 12:23:30 +02:00

plugin_requests.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

plugin_shutdown_test.go

MM-26750: Remove instances of InitBasic when it's not required (#14984)

2020-07-13 19:34:05 +02:00

plugin_signature_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

plugin_signature.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

plugin_statuses.go

Fix GetPluginStatus in a non-cluster environment (#15363)

2020-09-22 10:57:08 +02:00

plugin_test.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

plugin.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

post_metadata_test.go

MM-29726 Allow disabling link previews from certain domains (#16869)

2021-03-09 12:54:54 -05:00

post_metadata.go

[MM-31899] Use a custom user-agent when previewing links (#17186)

2021-04-12 09:30:48 -04:00

post_test.go

Enable the errorAssertions govet check for mattermost-server code (#17346)

2021-04-12 12:51:31 +02:00

post.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

preference.go

Fix initialisms/app (#16818)

2021-02-05 11:22:27 +01:00

product_notices_test.go

[MM-32665] app/product_notices: support notice for deprecating elasticsearch (#16966)

2021-02-23 13:38:50 +03:00

product_notices.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

ratelimit_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

ratelimit.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

reaction_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

reaction.go

[Partial Fix #16623]: Fix initialism errors in codebase. (#16979)

2021-02-25 20:22:27 +01:00

remote_cluster_service_mock.go

MM-32133 shared channel username collisions (#17347)

2021-04-13 10:40:12 -04:00

remote_cluster_test.go

MM-32133 shared channel username collisions (#17347)

2021-04-13 10:40:12 -04:00

remote_cluster.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

response_transfer.go

Consistent license message for all the go files (#13235)

2019-11-29 12:59:40 +01:00

role_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

role.go

MM-28530 - Changes are not automatically propagated to system console when a permission is added/removed from a role (#15562)

2020-09-24 11:49:57 -04:00

saml.go

[MM-32044] Reset SAML auth data (#17161)

2021-04-13 00:46:30 +02:00

scheme.go

ChannelStore migration Part 3 (#15504)

2020-10-04 10:12:29 +05:30

searchengine.go

MM-27169: Remove uneeded fields from App (#15408)

2020-09-16 21:46:44 +05:30

security_update_check.go

Extracting mail service into shared libs (#17030)

2021-03-15 11:50:13 +01:00

server_license.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

server_test.go

MM-34786: Fix racy test TestStartServerTLSSuccess (#17387)

2021-04-13 21:12:48 +05:30

server.go

[MM-33826] add more detailed S3 error messages (#17182)

2021-04-09 18:16:30 +02:00

session_test.go

MM-32133 shared channel username collisions (#17347)

2021-04-13 10:40:12 -04:00

session.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

shared_channel_notifier_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

shared_channel_notifier.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

shared_channel_service_iface.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

shared_channel_test.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

shared_channel.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

slack_test.go

Fix initialisms/app (#16818)

2021-02-05 11:22:27 +01:00

slack.go

MM-30882: Fix read-after-write issue for demoting user (#16911)

2021-02-12 19:04:05 +05:30

status_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

status.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

svg_test.go

unparam lint (#16927)

2021-03-16 12:48:20 +05:30

svg.go

Fix empty string comparison issues in the codebase (#16686)

2021-01-25 11:15:17 +01:00

syncables_test.go

MM-34002: Improve AddUserToChannel (#17174)

2021-04-02 14:33:23 +05:30

syncables.go

MM-34002: Improve AddUserToChannel (#17174)

2021-04-02 14:33:23 +05:30

team_test.go

MM-33913: Fix read-after-write issues with team member (#17173)

2021-04-02 13:20:58 +05:30

team.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

terms_of_service.go

Fix initialisms/app (#16818)

2021-02-05 11:22:27 +01:00

upload_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

upload.go

Improve document extraction and including a document extraction command (#17183)

2021-04-07 13:27:20 +02:00

user_agent_test.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_agent.go

[MM-22167] Add mmctl to the User-Agent parser (#13894)

2020-03-19 11:18:17 +01:00

user_terms_of_service_test.go

Migration of UserTermsOfServiceStore to return plain errors (#14788)

2020-06-19 17:49:30 +05:30

user_terms_of_service.go

Fix initialisms/app (#16818)

2021-02-05 11:22:27 +01:00

user_test.go

Enable the errorAssertions govet check for mattermost-server code (#17346)

2021-04-12 12:51:31 +02:00

user_viewmembers_test.go

goimports (#16640)

2021-01-07 22:42:43 +05:30

user.go

Add missing wrapped errors (#17339)

2021-04-07 10:44:50 +02:00

web_conn_test.go

MM-34487: Add dead queue (#17307)

2021-04-01 15:31:19 +05:30

web_conn.go

MM-34487: Add dead queue (#17307)

2021-04-01 15:31:19 +05:30

web_hub_test.go

revertws (#17216)

2021-03-24 15:29:23 +05:30

web_hub.go

MM-27493 Shared channels (MVP) (#17301)

2021-04-01 13:44:56 -04:00

webhook_test.go

Replacing require.nil in app layer (#16905)

2021-02-16 12:00:01 +01:00

webhook.go

Moving mlog to corelibs (#16915)

2021-03-05 09:18:37 +01:00

webhub_fuzz.go

Extracting i18n functionality to i18n core library (#16914)

2021-02-26 08:12:49 +01:00

websocket_router.go

MM-34389: Reliable websockets: First commit (#17297)

2021-03-31 10:05:32 +05:30