mattermost/app/remote_cluster_test.go

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.

package app

import (
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/mattermost/mattermost-server/v5/model"
)

func TestAddRemoteCluster(t *testing.T) {
	t.Run("adding remote cluster with duplicate site url and remote team id", func(t *testing.T) {
		th := Setup(t).InitBasic()
		defer th.TearDown()

		remoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8065",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		_, err := th.App.AddRemoteCluster(remoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		remoteCluster.RemoteId = model.NewId()
		_, err = th.App.AddRemoteCluster(remoteCluster)
		require.NotNil(t, err, "Adding a duplicate remote cluster should error")
		assert.Contains(t, err.Error(), "Remote cluster has already been added.")
	})

	t.Run("adding remote cluster with duplicate site url or remote team id is allowed", func(t *testing.T) {
		th := Setup(t).InitBasic()
		defer th.TearDown()

		remoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8065",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		existingRemoteCluster, err := th.App.AddRemoteCluster(remoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		// Same site url but different remote team id
		remoteCluster.RemoteId = model.NewId()
		remoteCluster.RemoteTeamId = model.NewId()
		remoteCluster.SiteURL = existingRemoteCluster.SiteURL
		_, err = th.App.AddRemoteCluster(remoteCluster)
		assert.Nil(t, err, "Adding a remote cluster should not error")

		// Same remote team id but different site url
		remoteCluster.RemoteId = model.NewId()
		remoteCluster.RemoteTeamId = existingRemoteCluster.RemoteTeamId
		remoteCluster.SiteURL = existingRemoteCluster.SiteURL + "/new"
		_, err = th.App.AddRemoteCluster(remoteCluster)
		assert.Nil(t, err, "Adding a remote cluster should not error")
	})
}

func TestUpdateRemoteCluster(t *testing.T) {
	t.Run("update remote cluster with an already existing site url and team id", func(t *testing.T) {
		th := Setup(t).InitBasic()
		defer th.TearDown()

		remoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8065",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		otherRemoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8066",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		_, err := th.App.AddRemoteCluster(remoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		savedRemoteClustered, err := th.App.AddRemoteCluster(otherRemoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		savedRemoteClustered.SiteURL = remoteCluster.SiteURL
		savedRemoteClustered.RemoteTeamId = remoteCluster.RemoteTeamId
		_, err = th.App.UpdateRemoteCluster(savedRemoteClustered)
		require.NotNil(t, err, "Updating remote cluster with duplicate site url should error")
		assert.Contains(t, err.Error(), "Remote cluster with the same url already exists.")
	})

	t.Run("update remote cluster with an already existing site url or team id, is allowed", func(t *testing.T) {
		th := Setup(t).InitBasic()
		defer th.TearDown()

		remoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8065",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		otherRemoteCluster := &model.RemoteCluster{
			RemoteTeamId: model.NewId(),
			Name:         "test",
			SiteURL:      "http://localhost:8066",
			Token:        "test",
			RemoteToken:  "test",
			Topics:       "",
			CreatorId:    th.BasicUser.Id,
		}

		existingRemoteCluster, err := th.App.AddRemoteCluster(remoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		anotherExistingRemoteClustered, err := th.App.AddRemoteCluster(otherRemoteCluster)
		require.Nil(t, err, "Adding a remote cluster should not error")

		// Same site url but different remote team id
		anotherExistingRemoteClustered.SiteURL = existingRemoteCluster.SiteURL
		anotherExistingRemoteClustered.RemoteTeamId = model.NewId()
		_, err = th.App.UpdateRemoteCluster(anotherExistingRemoteClustered)
		assert.Nil(t, err, "Updating remote cluster should not error")

		// Same remote team id but different site url
		anotherExistingRemoteClustered.SiteURL = existingRemoteCluster.SiteURL + "/new"
		anotherExistingRemoteClustered.RemoteTeamId = existingRemoteCluster.RemoteTeamId
		_, err = th.App.UpdateRemoteCluster(anotherExistingRemoteClustered)
		assert.Nil(t, err, "Updating remote cluster should not error")
	})
}