IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed background update with "if".

Browse Source 
Cloned subrequests should inherit r->content_handler.  This way they will
be able to use the same location configuration as the original request
if there are "if" directives in the configuration.

Without r->content_handler inherited, the following configuration tries
to access a static file in the update request:

    location / {
        set $true 1;
        if ($true) {
            # nothing
        }

        proxy_pass http://backend;
        proxy_cache one;
        proxy_cache_use_stale updating;
        proxy_cache_background_update on;
    }

See http://mailman.nginx.org/pipermail/nginx/2017-February/053019.html for
initial report.
This commit is contained in:
Maxim Dounin
2017-02-27 22:36:15 +03:00
parent 56757fd968
commit 0f00d3365f
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/http/ngx_http_core_module.c
View File

@@ -2571,6 +2571,7 @@ ngx_http_subrequest(ngx_http_request_t *r,
sr->method_name = r->method_name; sr->method_name = r->method_name;
sr->loc_conf = r->loc_conf; sr->loc_conf = r->loc_conf;
sr->valid_location = r->valid_location; sr->valid_location = r->valid_location;
sr->content_handler = r->content_handler;
sr->phase_handler = r->phase_handler; sr->phase_handler = r->phase_handler;
sr->write_event_handler = ngx_http_core_run_phases; sr->write_event_handler = ngx_http_core_run_phases;