mirror of
https://github.com/nginx/nginx.git
synced 2026-10-24 14:47:45 -05:00
SSL: synced all session ticket keys to the worker process
The per-worker ticket key mirror is allocated with three slots (ngx_array_push_n(keys, 3)), matching the shared memory ticket_keys[3] array and the decrypt callback, which scans all keys->nelts slots by key name. Key rotation, however, synced only two slots from shared memory, leaving the third slot's name, hmac_key, and aes_key uninitialized. A ticket whose key name matched the uninitialized slot (which holds unspecified pool memory, all zero in the best case) could therefore be HMAC-verified and decrypted with uninitialized key material, allowing a forged session. Sync all keys->nelts slots, as ngx_ssl_ticket_keys_cleanup() already assumes. Reported by PhiNode Labs.
This commit is contained in:
1 parent
1c173a2d87
commit
1916f26e6c
1 file changed
+1
-1
@@ -5251,7 +5251,7 @@ ngx_ssl_rotate_ticket_keys(SSL_CTX *ssl_ctx, ngx_log_t *log)
|
||||
/* sync keys to the worker process memory */
|
||||
|
||||
ngx_memcpy(keys->elts, cache->ticket_keys,
|
||||
2 * sizeof(ngx_ssl_ticket_key_t));
|
||||
keys->nelts * sizeof(ngx_ssl_ticket_key_t));
|
||||
|
||||
ngx_shmtx_unlock(&shpool->mutex);
|
||||
|
||||
|
||||
Reference in new issue
Block a user