IntenseWebs/nginx
3
0
Fork 0
mirror of https://github.com/nginx/nginx.git synced 2024-12-19 13:43:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

SPDY: avoid sending RST_STREAM on WINDOW_UPDATE with unknown SID.

Browse Source 
There's a race condition between closing a stream by one endpoint
and sending a WINDOW_UPDATE frame by another.  So it would be better
to just skip such frames for unknown streams, like is already done
for the DATA frames.
This commit is contained in:
Valentin Bartenev 2014-04-21 19:21:17 +04:00
parent a57959b6cd
commit f79908af6e
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/http/ngx_http_spdy.c
View File

@ -1341,16 +1341,8 @@ ngx_http_spdy_state_window_update(ngx_http_spdy_connection_t *sc, u_char *pos,
stream = ngx_http_spdy_get_stream_by_id(sc, sid);
if (stream == NULL) {
ngx_log_error(NGX_LOG_INFO, sc->connection->log, 0,
"client sent WINDOW_UPDATE frame "
"for unknown stream %ui", sid);
if (ngx_http_spdy_send_rst_stream(sc, sid, NGX_SPDY_INVALID_STREAM,
NGX_SPDY_LOWEST_PRIORITY)
== NGX_ERROR)
{
return ngx_http_spdy_state_internal_error(sc);
}
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, sc->connection->log, 0,
"unknown spdy stream");
return ngx_http_spdy_state_complete(sc, pos, end);
}