2018-06-07 19:27:57 -05:00
|
|
|
package states
|
|
|
|
|
|
|
|
import (
|
|
|
|
"github.com/zclconf/go-cty/cty"
|
2018-07-20 19:15:29 -05:00
|
|
|
ctyjson "github.com/zclconf/go-cty/cty/json"
|
2018-06-07 19:27:57 -05:00
|
|
|
|
|
|
|
"github.com/hashicorp/terraform/addrs"
|
|
|
|
)
|
|
|
|
|
|
|
|
// ResourceInstanceObject is the local representation of a specific remote
|
|
|
|
// object associated with a resource instance. In practice not all remote
|
|
|
|
// objects are actually remote in the sense of being accessed over the network,
|
|
|
|
// but this is the most common case.
|
|
|
|
//
|
|
|
|
// It is not valid to mutate a ResourceInstanceObject once it has been created.
|
|
|
|
// Instead, create a new object and replace the existing one.
|
|
|
|
type ResourceInstanceObject struct {
|
2018-07-20 19:15:29 -05:00
|
|
|
// Value is the object-typed value representing the remote object within
|
|
|
|
// Terraform.
|
|
|
|
Value cty.Value
|
2018-06-07 19:27:57 -05:00
|
|
|
|
|
|
|
// Internal is an opaque value set by the provider when this object was
|
|
|
|
// last created or updated. Terraform Core does not use this value in
|
|
|
|
// any way and it is not exposed anywhere in the user interface, so
|
|
|
|
// a provider can use it for retaining any necessary private state.
|
2018-08-17 18:11:07 -05:00
|
|
|
Private []byte
|
2018-06-07 19:27:57 -05:00
|
|
|
|
|
|
|
// Status represents the "readiness" of the object as of the last time
|
|
|
|
// it was updated.
|
|
|
|
Status ObjectStatus
|
|
|
|
|
|
|
|
// Dependencies is a set of other addresses in the same module which
|
|
|
|
// this instance depended on when the given attributes were evaluated.
|
|
|
|
// This is used to construct the dependency relationships for an object
|
|
|
|
// whose configuration is no longer available, such as if it has been
|
|
|
|
// removed from configuration altogether, or is now deposed.
|
|
|
|
Dependencies []addrs.Referenceable
|
|
|
|
}
|
|
|
|
|
|
|
|
// ObjectStatus represents the status of a RemoteObject.
|
|
|
|
type ObjectStatus rune
|
|
|
|
|
|
|
|
//go:generate stringer -type ObjectStatus
|
|
|
|
|
|
|
|
const (
|
|
|
|
// ObjectReady is an object status for an object that is ready to use.
|
|
|
|
ObjectReady ObjectStatus = 'R'
|
|
|
|
|
|
|
|
// ObjectTainted is an object status representing an object that is in
|
|
|
|
// an unrecoverable bad state due to a partial failure during a create,
|
|
|
|
// update, or delete operation. Since it cannot be moved into the
|
|
|
|
// ObjectRead state, a tainted object must be replaced.
|
|
|
|
ObjectTainted ObjectStatus = 'T'
|
core: Prune placeholder objects from state after refresh
Prior to our refactoring here, we were relying on a lucky coincidence for
correct behavior of the plan walk following a refresh in the same run:
- The refresh phase created placeholder objects in the state to represent
any resource instance pending creation, to allow the interpolator to
read attributes from them when evaluating "provider" and "data" blocks.
In effect, the refresh walk is creating a partial plan that only covers
creation actions, but was immediately discarding the actual diff entries
and storing only the planned new state.
- It happened that objects pending creation showed up in state with an
empty ID value, since that only gets assigned by the provider during
apply.
- The Refresh function concluded by calling terraform.State.Prune, which
deletes from the state any objects that have an empty ID value, which
therefore prevented these temporary objects from surviving into the
plan phase.
After refactoring, we no longer have this special ID field on instance
object state, and we instead rely on the Status field for tracking such
things. We also no longer have an explicit "prune" step on state, since
the state mutation methods themselves keep the structure pruned.
To address this, here we introduce a new instance object status "planned",
which is equivalent to having an empty ID value in the old world. We also
introduce a new method on states.SyncState that deletes from the state
any planned objects, which therefore replaces that portion of the old
State.prune operation just for this refresh use-case.
Finally, we are now expecting the expression evaluator to pull pending
objects from the planned changeset rather than from the state directly,
and so for correct results these placeholder resource creation changes
must also be reported in a throwaway changeset during the refresh walk.
The addition of states.ObjectPlanned also permits a previously-missing
safety check in the expression evaluator to prevent us from relying on the
incomplete value stored in state for a pending object, in the event that
some bug prevents the real pending object from being written into the
planned changeset.
2018-08-31 18:42:07 -05:00
|
|
|
|
|
|
|
// ObjectPlanned is a special object status used only for the transient
|
|
|
|
// placeholder objects we place into state during the refresh and plan
|
|
|
|
// walks to stand in for objects that will be created during apply.
|
|
|
|
//
|
|
|
|
// Any object of this status must have a corresponding change recorded
|
|
|
|
// in the current plan, whose value must then be used in preference to
|
|
|
|
// the value stored in state when evaluating expressions. A planned
|
|
|
|
// object stored in state will be incomplete if any of its attributes are
|
|
|
|
// not yet known, and the plan must be consulted in order to "see" those
|
|
|
|
// unknown values, because the state is not able to represent them.
|
|
|
|
ObjectPlanned ObjectStatus = 'P'
|
2018-06-07 19:27:57 -05:00
|
|
|
)
|
2018-07-20 19:15:29 -05:00
|
|
|
|
|
|
|
// Encode marshals the value within the receiver to produce a
|
|
|
|
// ResourceInstanceObjectSrc ready to be written to a state file.
|
|
|
|
//
|
|
|
|
// The given type must be the implied type of the resource type schema, and
|
|
|
|
// the given value must conform to it. It is important to pass the schema
|
|
|
|
// type and not the object's own type so that dynamically-typed attributes
|
|
|
|
// will be stored correctly. The caller must also provide the version number
|
|
|
|
// of the schema that the given type was derived from, which will be recorded
|
|
|
|
// in the source object so it can be used to detect when schema migration is
|
|
|
|
// required on read.
|
|
|
|
//
|
|
|
|
// The returned object may share internal references with the receiver and
|
|
|
|
// so the caller must not mutate the receiver any further once once this
|
|
|
|
// method is called.
|
terraform: Ugly huge change to weave in new State and Plan types
Due to how often the state and plan types are referenced throughout
Terraform, there isn't a great way to switch them out gradually. As a
consequence, this huge commit gets us from the old world to a _compilable_
new world, but still has a large number of known test failures due to
key functionality being stubbed out.
The stubs here are for anything that interacts with providers, since we
now need to do the follow-up work to similarly replace the old
terraform.ResourceProvider interface with its replacement in the new
"providers" package. That work, along with work to fix the remaining
failing tests, will follow in subsequent commits.
The aim here was to replace all references to terraform.State and its
downstream types with states.State, terraform.Plan with plans.Plan,
state.State with statemgr.State, and switch to the new implementations of
the state and plan file formats. However, due to the number of times those
types are used, this also ended up affecting numerous other parts of core
such as terraform.Hook, the backend.Backend interface, and most of the CLI
commands.
Just as with 5861dbf3fc49b19587a31816eb06f511ab861bb4 before, I apologize
in advance to the person who inevitably just found this huge commit while
spelunking through the commit history.
2018-08-14 16:24:45 -05:00
|
|
|
func (o *ResourceInstanceObject) Encode(ty cty.Type, schemaVersion uint64) (*ResourceInstanceObjectSrc, error) {
|
2018-08-28 18:30:52 -05:00
|
|
|
// Our state serialization can't represent unknown values, so we convert
|
|
|
|
// them to nulls here. This is lossy, but nobody should be writing unknown
|
|
|
|
// values here and expecting to get them out again later.
|
|
|
|
//
|
|
|
|
// We get unknown values here while we're building out a "planned state"
|
|
|
|
// during the plan phase, but the value stored in the plan takes precedence
|
|
|
|
// for expression evaluation. The apply step should never produce unknown
|
|
|
|
// values, but if it does it's the responsibility of the caller to detect
|
|
|
|
// and raise an error about that.
|
|
|
|
val := cty.UnknownAsNull(o.Value)
|
|
|
|
|
|
|
|
src, err := ctyjson.Marshal(val, ty)
|
2018-07-20 19:15:29 -05:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
return &ResourceInstanceObjectSrc{
|
|
|
|
SchemaVersion: schemaVersion,
|
|
|
|
AttrsJSON: src,
|
|
|
|
Private: o.Private,
|
|
|
|
Status: o.Status,
|
|
|
|
Dependencies: o.Dependencies,
|
|
|
|
}, nil
|
|
|
|
}
|
2018-09-14 17:13:58 -05:00
|
|
|
|
|
|
|
// AsTainted returns a deep copy of the receiver with the status updated to
|
|
|
|
// ObjectTainted.
|
|
|
|
func (o *ResourceInstanceObject) AsTainted() *ResourceInstanceObject {
|
|
|
|
if o == nil {
|
|
|
|
// A nil object can't be tainted, but we'll allow this anyway to
|
|
|
|
// avoid a crash, since we presumably intend to eventually record
|
|
|
|
// the object has having been deleted anyway.
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
ret := o.DeepCopy()
|
|
|
|
ret.Status = ObjectTainted
|
|
|
|
return ret
|
|
|
|
}
|