Commit Graph

27478 Commits

Author SHA1 Message Date
Alisdair McDiarmid
6bacc7a73c
Merge pull request #27128 from hashicorp/alisdair/sensitivity-change-permadiff
terraform: Write state if sensitivity changes
2020-12-03 16:48:09 -05:00
Dmitry Tokarev
8d1c416a53
website: Fix link to external documentation "Git URLs" 2020-12-03 13:24:56 -08:00
Alisdair McDiarmid
50f4d79867 terraform: Write state if sensitivity changes
When applying, we return early if only sensitivity changed between the
before and after values of the changeset. This avoids unnecessarily
invoking the provider.

Previously, we did not write the new value for a resource to the state
when this happened. The result was a permanent diff for resource updates
which only change sensitivity, as the apply step is skipped and the
state is unchanged.

This commit adds a state write to this shortcut return path, and fixes a
test for this exact case which was accidentally relying on a value diff
caused by an incorrect manual state value.
2020-12-03 15:58:54 -05:00
Petros Kolyvas
2ce71ab43c
Upgrade guide link fix (#27124) 2020-12-03 15:21:58 -04:00
Masayuki Morita
93b6f15c9d
website: Fix typo in docs/commands/cli-config (#27038) 2020-12-03 14:30:24 -04:00
Petros Kolyvas
20a5db1c86
Website: 0.14 Upgrade guide additions (#27112)
* Update 0-14.html.markdown

Spelling again. Thanks @pselle
2020-12-03 14:21:31 -04:00
Nick Fagerlund
0c0749edcf
website: Fix several broken links (#27091) 2020-12-03 13:54:38 -04:00
Martin Atkins
323cd4364b website: Correct formatting for lists in dependency lock docs
I originally drafted these docs in a context where I was relying on
GitHub's Markdown renderer, and carelessly imported them into the
Terraform website without verifying that the website's Markdown renderer
could process it. This particular quirk has bitten us before: the website
Markdown parser expects follow-on paragraphs in a list item to be indented
at least four spaces, and with less than that it ignores the leading
whitespace altogether and just understands a normal paragraph.

This change will cause the follow-on paragraphs to now correctly render
as part of the bullet points they are intended to be attached to.
2020-12-03 09:16:58 -08:00
Mark Lewis
9935138e1c
Update for_each.html.md
minor grammar improvement.
2020-12-03 16:45:52 +00:00
Mark Lewis
ffea7a4cda
Update for_each.html.md 2020-12-03 16:45:04 +00:00
Connor Osborn
2c2ed53ff3
Fix apt install typo (#27074)
Apt install expects a `name=version` NOT `name==version`
2020-12-03 10:23:14 -04:00
Petros Kolyvas
5cb2d4894c
Anytrue alltrue docs clarification. (#27108)
* Anytrue alltrue docs clarification.

* Update alltrue.html.md

I can't spell.

* Update anytrue.html.md

Yes, I can't spell.
2020-12-03 10:13:20 -04:00
Nick Fagerlund
2119510669
Merge pull request #27089 from hashicorp/dec20_release_fixes_upstream_version
website: fix a few functional glitches
2020-12-02 14:19:01 -08:00
Nick Fagerlund
cca1bc91c3 website: fix bad layout in defaults function page
This layout no longer exists.
2020-12-02 14:11:44 -08:00
Nick Fagerlund
5cff04b3ab website: fix malformed yaml in a few function pages 2020-12-02 14:11:32 -08:00
James Bardin
b0ce552c90
Merge pull request #27088 from hashicorp/jbardin/un-legacy
don't use legacy import for the terraform.UIInput interface
2020-12-02 15:58:40 -05:00
James Bardin
dd5dae27f8 don't use legacy import for the UIInput interface
The import was switch for other types which has since been removed.
Point this at the correct package.
2020-12-02 15:44:58 -05:00
James Bardin
dcf0dba6f4
Merge pull request #27081 from hashicorp/jbardin/staticcheck
Fixes to pass static analysis
2020-12-02 15:43:10 -05:00
Kristin Laemmert
3fa063b8dc
command/format: concise diff is now the default (#27079)
* command/format: concise diff is no longer an experiment

Since state formatting goes through the "diff" printer, I have
repurposed the concise flag as a verbose flag, used only when printing
state. It's silly but it works!

* remove helper/experiment
With this experiment concluded, we no longer need helper/experiment. The
shadow experiment had not been touched in many years, so I removed all
references, and removed the package entirely. Any new experiments are
expected to be configuration experiments handled by our (other)
experiments package.

* check for the verbose flag consistently, in case we end up using it in plans in the future
2020-12-02 15:42:41 -05:00
James Bardin
6529659455 internal/providercache: staticcheck 2020-12-02 13:59:20 -05:00
James Bardin
313d3e5c4d builtin/provisioners/remote-exec: staticcheck 2020-12-02 13:59:20 -05:00
James Bardin
0b4c96fa92 command/jsonprovider: staticcheck 2020-12-02 13:59:20 -05:00
James Bardin
63b521b8b7 communicator/ssh: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
aeb96384fd configs/configload: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
9c3ece40f7 configs/configschema: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
82305bf1c8 configs: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
8925d94387 dag: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
89a8624d8c instances: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
d22e08bd32 internal/earlyconfig: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
f0c3ddf5a1 internal/getproviders: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
4ad7c41ab4 unused 2020-12-02 13:59:19 -05:00
James Bardin
276dfe634f internal/providercache: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
1f359bab03 internal/typeexpr: staticcheck
diagnostics were appended to diags shadowing the intended value.
2020-12-02 13:59:19 -05:00
James Bardin
e08422511e lang/funcs: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
a5f013830f plans: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
fa3e534142 plans/planfile: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
b5e5adda01 plugin/discovery: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
3deeb94aac registry: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
e347b012df registry/test: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
c6cea8efc3 states/statefile: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
c2f8b06594 states/statemgr: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
0fb7d19191 states/statemgr: t.Fatal from goroutine 2020-12-02 13:59:19 -05:00
James Bardin
3a6c32cb1c terraform: staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
41d4dd82d6 format staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
a1d41504f2 e2etest staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
1c58c6ba48 command staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
ccf0d8815f staticcheck 2020-12-02 13:59:19 -05:00
James Bardin
2016b6bd1c validate is no longer called from there 2020-12-02 13:59:19 -05:00
James Bardin
8b08ebc4b5 consistent recievers 2020-12-02 13:59:19 -05:00
James Bardin
6f577abc72 unused 2020-12-02 13:59:19 -05:00