Commit Graph

10524 Commits

Author SHA1 Message Date
Martin Atkins
b255c389e2 core: restore data resource creation diffs
cd0c452 contained a bug where the creation diff for a data resource was
put into a new local variable within the else block rather than into the
diff variable in the parent scope, causing a null diff to always be
produced.

This restores the expected behavior: a computed data resource appears in
the diff, so it can then be fetched during the apply walk.
2016-05-21 13:23:28 -07:00
Martin Atkins
d9c137555f core: test to prove that data diffs are broken
Apparently there's been a regression in the creation of data resource
diffs: they aren't showing up in the plan at all.

As a first step to fixing this, this is an intentionally-failing test
that proves it's broken.
2016-05-21 13:00:46 -07:00
Paul Stack
18803d9b93 Update CHANGELOG.md 2016-05-21 07:23:07 +01:00
dkalleg
c34ea953b0 provider/vSphere Disk Controller Type (#6785)
Gives the user the ability to specify the controller type they would
like to connect their disk to.  Supported options are scsi and ide.
2016-05-21 07:21:42 +01:00
clint shryock
6830993024 provider/aws: Update Security Group Docs 2016-05-20 17:18:51 -05:00
clint shryock
d87fc5a55a Merge branch 'master' of github.com:hashicorp/terraform
* 'master' of github.com:hashicorp/terraform:
  Update CHANGELOG.md
  Update CHANGELOG.md
  core: honor "destroy" diffs for data resources
  provider/azurerm: `azurerm_network_interface` diffs didn't match during apply
  providers/google: Don't fail deleting disks that don't exist.
2016-05-20 17:01:48 -05:00
clint shryock
a6f3614f09 provider/aws: Update Security Group docs for Classic/VPC
Fixes #5924
2016-05-20 17:01:13 -05:00
James Nugent
7945a6d7cf Update CHANGELOG.md 2016-05-20 17:00:17 -05:00
James Nugent
4b89e0802b Merge pull request #6689 from evandbrown/disk-delete
providers/google: Don't fail deleting disks that don't exist.
2016-05-20 16:58:17 -05:00
James Nugent
ab1551e863 Update CHANGELOG.md 2016-05-20 16:57:31 -05:00
James Nugent
3d8bd11e35 Merge branch 'master' of https://github.com/hashicorp/terraform 2016-05-20 16:56:25 -05:00
James Nugent
3356acc1f7 Merge pull request #6790 from hashicorp/b-arm-nic-iphash
provider/azurerm: `azurerm_network_interface` diffs didn't match during apply
2016-05-20 16:56:12 -05:00
Paul Stack
ccfca863c4 Update CHANGELOG.md 2016-05-20 22:43:55 +01:00
Paul Stack
2c8c587ca5 provider/azurerm: Add support for EnableIPForwarding to (#6807)
`azurerm_network_interface`

As requested in #6803

```

```
2016-05-20 22:43:18 +01:00
Clint
42c68645af provider/aws: Update documentation to use t2.micro, provide Classic options (#6801)
* provider/aws: Update documentation to use t2.micro, provide Classic options
2016-05-20 16:19:01 -05:00
James Nugent
50e095ddeb Merge branch 'b-data-resource-destroy' 2016-05-20 15:07:32 -05:00
Martin Atkins
cd0c4522ee core: honor "destroy" diffs for data resources
Previously the "planDestroy" pass would correctly produce a destroy diff,
but the "apply" pass would just ignore it and make a fresh diff, turning
it back into a "create" because data resources are always eager to
refresh.

Now we consider the previous diff when re-diffing during apply and so
we can preserve the plan to destroy and then ultimately actually "destroy"
the data resource (remove from the state) when we get to ReadDataApply.

This ensures that the state is left empty after "terraform destroy";
previously we would leave behind data resource states.
2016-05-20 15:07:23 -05:00
James Nugent
28ad394264 build: Update generated internal plugin list 2016-05-20 15:05:27 -05:00
Clint
8e3a284d10 Update CHANGELOG.md 2016-05-20 12:53:03 -05:00
Paul Stack
ec8c242ebf provider/aws: Add support for Skipping Final Snapshot in RDS Cluster (#6795)
* provider/aws: Add support for Skipping Final Snapshot in RDS Cluster
2016-05-20 12:52:26 -05:00
Paul Stack
890eebabc4 provider/aws: Add note to AWS DB Instance Documentation about skip_final_snapshot (#6799) 2016-05-20 12:33:25 -05:00
Paul Stack
8aff776ae1 Update CHANGELOG.md 2016-05-20 15:55:37 +01:00
James Rasell
e3352e855c provider/aws: Make 'stage_name' required in api_gateway_deployment (#6797)
When stage_name is not passed to the resource
aws_api_gateway_deployment a terraform apply will fail. This is
because the stage_name is required and not optional.
2016-05-20 15:55:08 +01:00
Paul Stack
fc022e8750 Update CHANGELOG.md 2016-05-20 10:21:19 +01:00
Martin Atkins
158a90b25b Grafana Provider, with Data Source and Dashboard resources (#6206)
* Grafana provider

* grafana_data_source resource.

Allows data sources to be created in Grafana. Supports all data source
types that are accepted in the current version of Grafana, and will
support any future ones that fit into the existing structure.

* Vendoring of apparentlymart/go-grafana-api

This is in anticipation of adding a Grafana provider plugin.

* grafana_dashboard resource

* Website documentation for the Grafana provider.
2016-05-20 10:20:17 +01:00
Paul Stack
3de2ab0437 Update CHANGELOG.md 2016-05-20 10:10:42 +01:00
stack72
a869d2f8a9 provider/azurerm: azurerm_network_interface diffs didn't match during
apply

The IP COnfiguration block of `azurerm_network_interface` didn't have a
hash created in a way that changes to the optional params were being
picked up:

```
~ azurerm_network_interface.test
    ip_configuration.273485505.name:                                       "testconfiguration1" => ""
    ip_configuration.273485505.private_ip_address_allocation:              "dynamic" => ""
    ip_configuration.273485505.subnet_id:                                  "/subscriptions/34ca515c-4629-458e-bf7c-738d77e0d0ea/resourceGroups/acctestrg/providers/Microsoft.Network/virtualNetworks/acctvn/subnets/acctsub" => ""
    ip_configuration.~273485505.load_balancer_backend_address_pools_ids.#: "" => "<computed>"
    ip_configuration.~273485505.load_balancer_inbound_nat_rules_ids.#:     "" => "<computed>"
    ip_configuration.~273485505.name:                                      "" => "testconfiguration1"
    ip_configuration.~273485505.private_ip_address:                        "" => "<computed>"
    ip_configuration.~273485505.private_ip_address_allocation:             "" => "dynamic"
    ip_configuration.~273485505.public_ip_address_id:                      "" => "${azurerm_public_ip.test.id}"
    ip_configuration.~273485505.subnet_id:                                 "" => "/subscriptions/34ca515c-4629-458e-bf7c-738d77e0d0ea/resourceGroups/acctestrg/providers/Microsoft.Network/virtualNetworks/acctvn/subnets/acctsub"
```

This caused the following error:

```
Error applying plan:

1 error(s) occurred:

* azurerm_network_interface.test: diffs didn't match during apply. This is a bug with Terraform and should be reported as a GitHub Issue.

Please include the following information in your report:
```

Notice that the hash didn't change. This change adds the remaining optional params to the hash so that the hash id will change.

```
~ azurerm_network_interface.test
    ip_configuration.4255411321.load_balancer_backend_address_pools_ids.#: "" => "<computed>"
    ip_configuration.4255411321.load_balancer_inbound_nat_rules_ids.#:     "" => "<computed>"
    ip_configuration.4255411321.name:                                      "" => "testconfiguration1"
    ip_configuration.4255411321.private_ip_address:                        "" => "<computed>"
    ip_configuration.4255411321.private_ip_address_allocation:             "" => "dynamic"
    ip_configuration.4255411321.public_ip_address_id:                      "" => "/subscriptions/34ca515c-4629-458e-bf7c-738d77e0d0ea/resourceGroups/acctestrg/providers/Microsoft.Network/publicIPAddresses/public-ip"
    ip_configuration.4255411321.subnet_id:                                 "" => "/subscriptions/34ca515c-4629-458e-bf7c-738d77e0d0ea/resourceGroups/acctestrg/providers/Microsoft.Network/virtualNetworks/acctvn/subnets/acctsub"
    ip_configuration.966273186.name:                                       "testconfiguration1" => ""
    ip_configuration.966273186.private_ip_address_allocation:              "dynamic" => ""
    ip_configuration.966273186.subnet_id:                                  "/subscriptions/34ca515c-4629-458e-bf7c-738d77e0d0ea/resourceGroups/acctestrg/providers/Microsoft.Network/virtualNetworks/acctvn/subnets/acctsub" => ""
```

This allows the Update to work as expected :)

```
azurerm_network_interface.test: Modifications complete

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
```
2016-05-20 09:34:40 +01:00
Devon Harvey
689cfc97c1 Fix typo in show command docs (#6784) 2016-05-20 09:07:17 +01:00
Ricard Clau
283e3ae6b5 fix sidebar + small rewordings (#6782) 2016-05-19 23:25:47 +01:00
James Nugent
f0b12b443b Update CHANGELOG.md 2016-05-19 11:36:20 -05:00
James Nugent
48b8b86580 Merge branch 'glasser/jsonencode-list-map' of https://github.com/meteor/terraform into meteor-glasser/jsonencode-list-map 2016-05-19 11:28:38 -05:00
James Nugent
d8eee357e3 Update CHANGELOG.md 2016-05-19 11:25:14 -05:00
clint shryock
c940cfe5e0 Update CHANGELOG.md 2016-05-19 11:24:34 -05:00
James Nugent
2abe8b6612 Merge pull request #6753 from hashicorp/b-output-destroy-fix
: core: Fix destroy w/module vars used in counts
2016-05-19 11:21:50 -05:00
Paul Stack
a1babc1743 Update CHANGELOG.md 2016-05-19 16:46:38 +01:00
Maxime Bury
bd073c539e Fixes terraform crash when using SSH keys with Azure VMs (#6766) 2016-05-19 16:45:58 +01:00
Paul Stack
427f73b10f Update CHANGELOG.md 2016-05-19 16:45:21 +01:00
Maxime Bury
b33bd427e1 Normalizes availability_set_id to lowercase to avoid spurious diffs (#6768) 2016-05-19 16:44:29 +01:00
Otto Jongerius
58e1c94335 provider/datadog Add test for no_data_timeframe. (#6765) 2016-05-19 14:51:27 +01:00
Joe Topjian
6ec8fc8675 Update CHANGELOG.md 2016-05-19 08:07:51 -05:00
Joe Topjian
dd1bbca407 Merge pull request #6764 from Fodoj/increase-openstack-timeouts
provider/openstack Increase timeouts for image resize, subnets and routers
2016-05-19 08:07:19 -05:00
Kirill Shirinkin
2dc254af13 provider/openstack Increase timeouts 2016-05-19 11:28:55 +02:00
Paul Stack
a2306ea7f0 Update CHANGELOG.md 2016-05-19 09:30:21 +01:00
Otto Jongerius
dc7a7219bf provider/datadog add 'require full window' and 'locked' (#6738)
* provider/datadog Update go-datadog-api.

* provider/datadog Add support for "require_full_window" and "locked".

* provider/datadog Update tests, update doco, gofmt.

* provider/datadog Add options to update resource.

* provider/datadog "require_full_window" defaults to True, "locked" to False. Use
those initial values as the starting configuration.

* provider/datadog Update notify_audit tests to use the default value for
testAccCheckDatadogMonitorConfig and a custom value for
testAccCheckDatadogMonitorConfigUpdated.

This catches a situation where the code ignores setting the option on creation,
and the update function merely asserts the default value, versus actually changing
the value.
2016-05-19 09:29:23 +01:00
Mitchell Hashimoto
55583baa7e
Merge branch 'f-aws-import' 2016-05-18 15:28:12 -06:00
Mitchell Hashimoto
24c0adb2d4
providers/aws: revert LC change 2016-05-18 15:28:01 -06:00
Mitchell Hashimoto
4967f3ff08
providers/aws: route53 delegation set import 2016-05-18 13:26:52 -06:00
Mitchell Hashimoto
801d342496
providers/aws: route53 health check import 2016-05-18 13:15:59 -06:00
Mitchell Hashimoto
1c0a6bc6d3
providers/aws: basic route 53 zone import 2016-05-18 13:09:56 -06:00
Mitchell Hashimoto
54df833406
website: add import command docs 2016-05-18 12:57:03 -06:00