Remove suppression Wno-delete-non-abstract-non-virtual-dtor (#16560)

* Remove suppression Wno-delete-non-abstract-non-virtual-dtor

* Fixed Allocator warning

* Suppress warning for GPU plugin

* Skip warning for GNA

* Fixed preprocessing

* Added virtual constructor for base plugin class

* Some fix for CPU

* Suppress for CPU

* Fixed any

* Fixed meta

* Disable warning for paddle

* Fixed Allocator tests

* Move suppress to paddle

* Fixed benchmark_app

cmake/developer_package/compile_flags/os_flags.cmake

@@ -455,14 +455,6 @@ else()
     endif()
 endif()
 
-# if(OV_COMPILER_IS_CLANG)
-#     ie_add_compiler_flags(-Wshorten-64-to-32)
-# endif()
-# TODO
-if(OV_COMPILER_IS_CLANG)
-    ie_add_compiler_flags(-Wno-delete-non-abstract-non-virtual-dtor)
-endif()
-
 check_cxx_compiler_flag("-Wsuggest-override" SUGGEST_OVERRIDE_SUPPORTED)
 if(SUGGEST_OVERRIDE_SUPPORTED)
     set(CMAKE_CXX_FLAGS "-Wsuggest-override ${CMAKE_CXX_FLAGS}")

samples/cpp/benchmark_app/statistics_report.hpp

@@ -98,6 +98,8 @@ public:
 
     enum class Category { COMMAND_LINE_PARAMETERS, RUNTIME_CONFIG, EXECUTION_RESULTS, EXECUTION_RESULTS_GROUPPED };
 
+    virtual ~StatisticsReport() = default;
+
     explicit StatisticsReport(Config config) : _config(std::move(config)) {
         _separator =
 #if defined _WIN32 || defined __CYGWIN__

src/common/preprocessing/src/ie_preprocess_data.hpp

@@ -48,7 +48,7 @@ public:
     virtual void isApplicable(const Blob::Ptr &src, const Blob::Ptr &dst) = 0;
 
 protected:
-    ~IPreProcessData() = default;
+    virtual ~IPreProcessData() = default;
 };
 
 OPENVINO_PLUGIN_API void CreatePreProcessData(std::shared_ptr<IPreProcessData>& data);

src/core/dev_api/meta_data.hpp

@@ -25,6 +25,11 @@ public:
      * @return const ov::AnyMap with meta information
      */
     virtual operator const ov::AnyMap&() const = 0;
+
+    /**
+     * @brief Destructor
+     */
+    virtual ~Meta() = default;
 };
 
 }  // namespace ov

src/core/include/openvino/core/any.hpp

@@ -496,7 +496,7 @@ class OPENVINO_API Any {
         }
 
     protected:
-        ~Base() = default;
+        virtual ~Base() = default;
     };
 
     template <class T, typename = void>

src/core/include/openvino/runtime/allocator.hpp

@@ -58,7 +58,7 @@ struct OPENVINO_DEPRECATED("Do not inherit from AllocatorImpl. This class will b
     virtual bool is_equal(const AllocatorImpl& other) const = 0;
 
 protected:
-    ~AllocatorImpl() = default;
+    virtual ~AllocatorImpl() = default;
 };
 
 class Tensor;
@@ -92,7 +92,7 @@ class OPENVINO_API Allocator {
         virtual bool is_equal(const Base& other) const = 0;
 
     protected:
-        ~Base() = default;
+        virtual ~Base() = default;
     };
 
     template <typename A>

src/frontends/CMakeLists.txt

@@ -8,22 +8,18 @@ if(ENABLE_TESTS)
     add_subdirectory(tests)
 endif()
 
+if(ENABLE_OV_IR_FRONTEND)
+    add_subdirectory(ir)
+endif()
+
 if(ENABLE_OV_ONNX_FRONTEND)
     add_subdirectory(onnx)
 endif()
 
-if(ENABLE_OV_PADDLE_FRONTEND)
-    add_subdirectory(paddle)
-endif()
-
 if(ENABLE_OV_PYTORCH_FRONTEND)
     add_subdirectory(pytorch)
 endif()
 
-if(ENABLE_OV_IR_FRONTEND)
-    add_subdirectory(ir)
-endif()
-
 if(ENABLE_OV_TF_FRONTEND OR ENABLE_OV_TF_LITE_FRONTEND)
     add_subdirectory(tensorflow_common)
 endif()
@@ -35,3 +31,7 @@ endif()
 if (ENABLE_OV_TF_LITE_FRONTEND)
     add_subdirectory(tensorflow_lite)
 endif()
+
+if(ENABLE_OV_PADDLE_FRONTEND)
+    add_subdirectory(paddle)
+endif()

src/frontends/paddle/src/CMakeLists.txt

@@ -4,6 +4,8 @@
 
 if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     ie_add_compiler_flags(/wd4305)
+elseif(OV_COMPILER_IS_CLANG)
+    ie_add_compiler_flags(-Wno-delete-non-abstract-non-virtual-dtor)
 endif()
 
 ov_add_frontend(NAME paddle

src/inference/dev_api/cpp_interfaces/interface/ie_iplugin_internal.hpp

@@ -316,7 +316,7 @@ public:
 
 protected:
     IInferencePlugin();
-    ~IInferencePlugin() = default;
+    virtual ~IInferencePlugin() = default;
 
     /**
      * @brief Creates an executable network from a parsed network object, users can create as many networks as they need

src/inference/include/ie/ie_iexecutable_network.hpp

@@ -159,7 +159,7 @@ public:
     virtual StatusCode GetContext(RemoteContext::Ptr& pContext, ResponseDesc* resp) const noexcept = 0;
 
 protected:
-    ~IExecutableNetwork() = default;
+    virtual ~IExecutableNetwork() = default;
 };
 
 _IE_SUPPRESS_DEPRECATED_END_GCC

src/inference/include/ie/ie_iinfer_request.hpp

@@ -202,7 +202,7 @@ public:
     virtual InferenceEngine::StatusCode SetBatch(int batch_size, ResponseDesc* resp) noexcept = 0;
 
 protected:
-    ~IInferRequest() = default;
+    virtual ~IInferRequest() = default;
 };
 
 _IE_SUPPRESS_DEPRECATED_END_GCC

src/inference/src/dev/converter_utils.cpp

@@ -227,6 +227,9 @@ public:
         _isNewAPI = plugin->is_new_api();
         _executorManager = InferenceEngine::create_old_manager(plugin->get_executor_manager());
     }
+
+    virtual ~IInferencePluginWrapper() = default;
+
     std::string GetName() const noexcept override {
         return m_plugin->get_device_name();
     }
@@ -840,6 +843,7 @@ private:
 
 public:
     IRemoteContextWrapper(const std::shared_ptr<InferenceEngine::RemoteContext>& context) : m_context(context) {}
+    virtual ~IRemoteContextWrapper() = default;
     const std::shared_ptr<InferenceEngine::RemoteContext>& get_context() {
         return m_context;
     }

src/inference/src/dev/icompiled_model_wrapper.hpp

@@ -13,6 +13,7 @@ namespace InferenceEngine {
 class ICompiledModelWrapper : public ov::ICompiledModel {
 public:
     ICompiledModelWrapper(const std::shared_ptr<InferenceEngine::IExecutableNetworkInternal>& model);
+    virtual ~ICompiledModelWrapper() = default;
     std::shared_ptr<ov::IAsyncInferRequest> create_infer_request() const override;
 
     void export_model(std::ostream& model) const override;

src/inference/src/dev/iplugin_wrapper.hpp

@@ -21,6 +21,11 @@ public:
      */
     IPluginWrapper(const std::shared_ptr<InferenceEngine::IInferencePlugin>& ptr);
 
+    /**
+     * @brief Destructor
+     */
+    virtual ~IPluginWrapper() = default;
+
     /**
      * @brief Create compiled model based on model and properties
      *

src/plugins/intel_cpu/CMakeLists.txt

@@ -16,6 +16,8 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     ie_add_compiler_flags(/wd4244)
     # mkldnn headers: '<<': result of 32-bit shift implicitly converted to 64 bits
     ie_add_compiler_flags(/wd4334)
+elseif(OV_COMPILER_IS_CLANG)
+    ie_add_compiler_flags(-Wno-delete-non-abstract-non-virtual-dtor)
 endif()
 
 if (WIN32)

src/plugins/intel_cpu/src/utils/shape_inference/shape_inference_cpu.hpp

@@ -26,7 +26,7 @@ public:
     };
 
 public:
-    ~IShapeInfer() = default;
+    virtual ~IShapeInfer() = default;
 
     /**
      * @brief This method actually performs all the necessary shape inference computations

src/plugins/intel_gpu/CMakeLists.txt

@@ -12,6 +12,10 @@ if(CMAKE_COMPILER_IS_GNUCXX)
     ie_add_compiler_flags(-Wno-strict-aliasing)
 endif()
 
+if(OV_COMPILER_IS_CLANG)
+    ie_add_compiler_flags(-Wno-delete-non-abstract-non-virtual-dtor)
+endif()
+
 if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     # 4267 4244 conversion from 'XXX' to 'YYY', possible loss of data
     ie_add_compiler_flags(/wd4244)