IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748

Browse Source
This commit is contained in:
Nikhil Mohite 2020-08-25 12:31:58 +05:30 committed by Akshay Joshi
parent 7f947f146c
commit b3d49c61a5
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en_US/release_notes_4_26.rst
View File

@ -19,4 +19,5 @@ Housekeeping
Bug fixes Bug fixes
********* *********
| `Issue #5748 <https://redmine.postgresql.org/issues/5748>`_ - Fixed incorrect reverse engineering SQL for Foreign key when creating a table.
| `Issue #5754 <https://redmine.postgresql.org/issues/5754>`_ - Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. | `Issue #5754 <https://redmine.postgresql.org/issues/5754>`_ - Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping.

4
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
View File

@ -1117,7 +1117,7 @@ class BaseTableView(PGChildNodeView, BasePartitionTable):
sql += '\n' + exclusion_constraint_sql sql += '\n' + exclusion_constraint_sql
return sql return sql
def _check_for_foreign_key(self, data): def _check_fk_constraint(self, data):
if 'foreign_key' in data: if 'foreign_key' in data:
for c in data['foreign_key']: for c in data['foreign_key']:
schema, table = fkey_utils.get_parent( schema, table = fkey_utils.get_parent(
@ -1250,7 +1250,7 @@ class BaseTableView(PGChildNodeView, BasePartitionTable):
data = column_utils.parse_format_columns(data) data = column_utils.parse_format_columns(data)
data = BaseTableView.check_and_convert_name_to_string(data) data = BaseTableView.check_and_convert_name_to_string(data)
self._check_foreign_key(data) self._check_fk_constraint(data)
partitions_sql = self._check_for_partitioned(data) partitions_sql = self._check_for_partitioned(data)