IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2025-02-25 18:55:31 -06:00
Code Issues Packages Projects Releases Wiki Activity
6,925 Commits 9 Branches 109 Tags 342 MiB
25074e46b4
Commit Graph

1860 Commits

Author SHA1 Message Date
Aditya Toshniwal
dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states. 
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
 2021-09-28 10:24:25 +05:30
Nikhil Mohite
48a5143485 Fixed an issue where SQL is not getting generated for Foreign table options. Fixes #6813 2021-09-28 10:21:25 +05:30
Khushboo Vashi
483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
zhangjie2@fujitsu.com
d983225683 Correct the variable names in the error messages for the Domain node. 2021-09-27 15:09:17 +05:30
Rahul Shirsat
d8d88b948a Fixed an issue where Schema icon is not visible in the drop-down of General tab. Fixes #6806 2021-09-27 13:36:13 +05:30
Nikhil Mohite
2320370fd2 1) Fixed an issue where for constraint trigger only After event should be displayed, 
also fixed the Incorrect values for Constraint trigger, Deferrable, Deferred. Fixes #6803
2) Fixed an issue where the user was unable to create the trigger for views. Fixes #6804
 2021-09-27 11:31:52 +05:30
Nikhil Mohite
9d2f3b5ee9 Ensure that RLS names should not be editable in the collection node of properties tab. Fixes #6759 2021-09-27 10:57:08 +05:30
Aditya Toshniwal
0228d16990 Partition related fixes: 
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
 2021-09-24 16:28:55 +05:30
Akshay Joshi
c32a325c11 Fixed html help for foreign server dialog. 2021-09-24 13:32:13 +05:30
Aditya Toshniwal
d28f8bc7ee Fixed exclusion constraint issues: 
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing

Fixes #6771
 2021-09-23 19:28:35 +05:30
Nikhil Mohite
a6dce27ffa Fixed an issue where options are missing in the trigger function's Security tab. Fixes #6792 2021-09-23 19:23:08 +05:30
Pradip Parkale
6d08d9aa9f Fixed Cast node related issues. Fixes #6741 2021-09-23 19:19:34 +05:30
Akshay Joshi
b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...' 
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
 2021-09-23 16:17:39 +05:30
Aditya Toshniwal
0e6794f2f5 Fixed issue where modified SQL not loading Unique Constraint dialog. Fixes #6772 2021-09-23 14:47:31 +05:30
Aditya Toshniwal
9179b7464b Fixed following issues after React Porting: 
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
 2021-09-23 14:46:10 +05:30
Akshay Joshi
25c98f8054 Fixed API test case. 2021-09-23 12:09:24 +05:30
Aditya Toshniwal
78c8fbbe00 Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778 2021-09-23 10:42:50 +05:30
Nikhil Mohite
f192be3667 Added flag to check before adding 'IF NOT EXISTS' and 'OR REPLACE' clause to the SQL. While creating any object the respective clause should not be added. 2021-09-22 19:14:19 +05:30
Nikhil Mohite
05ce3445b5 Fixed incorrect privileges value in Materialize View. Fixes #6781 2021-09-22 18:46:43 +05:30
Aditya Toshniwal
a1aa080956 Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766 2021-09-22 18:23:40 +05:30
Aditya Toshniwal
a8c8ea69e3 Foreign Key fixes: 
1. Auto FK related fixes.
2. Properties tab not showing columns.
3. Toggle button is editable even if set to read-only.
4. Dropdown placeholder should be blank for read-only/disabled.
5. Input control help text color on a dark theme.

Fixes #6770
 2021-09-22 18:18:09 +05:30
Aditya Toshniwal
fc86faf51e Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size. 2021-09-22 18:11:50 +05:30
Akshay Joshi
f538546c4d Fixed validation issue in Synonyms dialog. Fixes #6767 2021-09-22 13:34:11 +05:30
Pradip Parkale
7330b3520f Fixed jasmine test cases. 2021-09-21 17:42:18 +05:30
Aditya Toshniwal
08009f8edc 1) Make default values column read-only for inherited columns when creating table. 
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.

Fixes #6763
 2021-09-21 16:56:29 +05:30
Akshay Joshi
b60bd73f88 Fixed an issue where Refresh view options are not working for materialized view. Fixes #6736. 2021-09-21 16:48:10 +05:30
Aditya Toshniwal
af230c812b Synchronises the column's primary key flag and primary key constraint. Fixes #6762 2021-09-21 15:27:48 +05:30
Aditya Toshniwal
5f104b0e0e Fixed an issue where ERD table dialog is failing to open after React Porting 2021-09-21 15:11:17 +05:30
Akshay Joshi
56a17f7c8e Fixed RESQL test cases for Partition table using COLLATE. 2021-09-20 20:10:24 +05:30
Rahul Shirsat
c142296f3f Fixed following issues for Type dialog: 
1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue.
2. Range Type - Loading icons are shown in different drop-down tabs.

Fixes #6744
 2021-09-20 13:12:23 +05:30
Nikhil Mohite
7aa213a5ce 1) Port Grant Wizard to react. Fixes #6687 
2) Fixed an issue where grant wizard is unresponsive if the database size is huge. Fixes #2097
 2021-09-20 13:02:41 +05:30
Rahul Shirsat
346ee6ba5f Fixed an issue where privileges not shown in catalog nodes for Properties tab. Fixes #6743 2021-09-17 20:50:29 +05:30
Pradip Parkale
89d40d38d9 Fixed jasmine test cases. 2021-09-15 11:42:23 +05:30
Akshay Joshi
460c66ab3f Fixed an issue where the drop cascade button enables for Databases. Fixes #6724 2021-09-10 18:27:16 +05:30
Pradip Parkale
dbf78bf214 Added support to create the Partitioned table should be created using COLLATE and opclass. Fixes #2546 2021-09-09 16:26:23 +05:30
Akshay Joshi
eeff75ba20 Remove GPDB support completely. Fixes #6692 2021-09-09 13:09:53 +05:30
Aditya Toshniwal
f7b8969c72 Stability and bug fixes for the react schema view framework. 2021-09-09 13:09:53 +05:30
Aditya Toshniwal
74cec6594e Port the partitions node. 2021-09-09 13:09:52 +05:30
Aditya Toshniwal
2a76027cce - Fix codemirror cursor issue. - Fix foreign table jasmine test cases. 2021-09-09 13:09:30 +05:30
Pradip Parkale
c8026873b4 Fixed code coverage and RESQL test cases for Cast, Publication and Subscription. 2021-09-09 13:08:11 +05:30
Akshay Joshi
7ffe71d12f Added support for OWNED BY clause for sequences. Fixes #4211 2021-09-09 13:07:53 +05:30
Aditya Toshniwal
c02705c53c - Fix all the jasmine test case failures. - Show default value column in Table->Columns grid. Fixes #4353. 2021-09-09 13:06:24 +05:30
Pradip Parkale
2074534b72 Port Procedure and Function node to react. Fixes #6632 #6677 2021-09-09 13:06:24 +05:30
Aditya Toshniwal
27e446a0b0 Fixed following: - Dropdown selected menu color - CodeMirror render on properties tab - Placeholders on select control - Codemirror borders 2021-09-09 13:06:24 +05:30
Akshay Joshi
4bfffa3806 Port FTS Configurations node to react. Fixes #6638 2021-09-09 13:06:24 +05:30
Nikhil Mohite
42eac6f846 Port Foreign Table node to react. Fixes #6678. 2021-09-09 13:06:24 +05:30
Aditya Toshniwal
261cec1d20 Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint. 2021-09-09 13:05:57 +05:30
Rahul Shirsat
725d9b4bbf Port package and it’s child node to React. Fixes #6675 2021-09-09 13:04:42 +05:30
Akshay Joshi
b7105093e2 1) Port Compound Trigger node to react. Fixes #6674 2) Remove 'inSchema' method and create a generic method 'inCatalog'. 2021-09-09 13:03:54 +05:30
Aditya Toshniwal
9274df0f11 - Fix Jasmine test cases failing in framework. - More stability fixes and enhancements. 2021-09-09 13:03:54 +05:30
Nikhil Mohite
351cb3e6ca Port Triggers node to react. Fixes #6672 2021-09-09 13:03:54 +05:30
Rahul Shirsat
e3992527fb Port Index node to react. Fixes #6661 2021-09-09 13:03:54 +05:30
Akshay Joshi
1b7a77f5cb Port pgAgent and it's child nodes to react. Fixes #6645 2021-09-09 13:03:54 +05:30
Nikhil Mohite
f742c5eb8a Port Role node to react. Fixes #6651 2021-09-09 13:03:54 +05:30
Nikhil Mohite
169d8fa480 Port Trigger Functions node to react. Fixes #6665 2021-09-09 13:03:54 +05:30
Rahul Shirsat
08f2121544 Port Schema & Catalog node to react. Fixes #6655 2021-09-09 13:01:53 +05:30
Nikhil Mohite
40879a5784 Port RLS node to react. Fixes #6660 2021-09-09 13:01:53 +05:30
Nikhil Mohite
977d148c40 Port Rule node to react. Fixes #6659 2021-09-09 13:01:52 +05:30
Pradip Parkale
1f430227aa Port Subscriptions node to react. Fixes #6634 2021-09-09 13:01:52 +05:30
Rahul Shirsat
1e07ef13cf Port Types node to react. Fixes #6602 2021-09-09 13:01:18 +05:30
Nikhil Mohite
10d8135dcc Port Materialized View node to react. Fixes #6592. 2021-09-09 13:00:36 +05:30
Nikhil Mohite
6021e07761 Revisit all the CREATE and DROP DDL's to add appropriate 'IF EXISTS', 'CASCADE' and 'CREATE OR REPLACE'. Fixes #5741 2021-09-09 13:00:35 +05:30
Aditya Toshniwal
377fe80046 - Add VaccumSettings schema. - Allow collection to have fixed rows. - Changes in data change comparison and add state utils context. - Fixed jasmine test cases. 2021-09-09 13:00:33 +05:30
Akshay Joshi
eb48765a5a 1) Fixed 'Material-UI: You are providing a disabled button child to the Tooltip' 2) Fixed InputToggle value issue. 3) Fixed jasmine test for Language. 4) Remove unused code from the view node. 2021-09-09 13:00:03 +05:30
Aditya Toshniwal
09db3ddd5c Use isFullTab instead of noLabel for full space code field spec. 2021-09-09 13:00:03 +05:30
Akshay Joshi
39765903d4 Port Tablespace node to react. Fixes #6644. 2021-09-09 13:00:03 +05:30
Nikhil Mohite
d9cfbf592e Port View node to react. Fixes #6637 2021-09-09 12:59:26 +05:30
Akshay Joshi
6d18842dd3 Port Domain and Domain Constraints node to react. Fixes #6330 2021-09-09 12:59:26 +05:30
Akshay Joshi
438d591d5b Port FTS Dictionaries node to react. Fixes #6636 2021-09-09 12:59:26 +05:30
Pradip Parkale
c474ca2c5f Port Publications node to react. Fixes #6610 2021-09-09 12:55:56 +05:30
Akshay Joshi
be04bea2b6 Port Resource Group node to react. Fixes #6629 2021-09-09 12:55:56 +05:30
Pradip Parkale
621426ac55 Port Language node to react. Fixes #6581 2021-09-09 12:52:54 +05:30
Yogesh Mahajan
6fe83d1f06 Port Collation node to react. Fixes #6584. 2021-09-09 12:50:32 +05:30
Akshay Joshi
5c1ce23780 Port Synonyms node to react. Fixes #6599 2021-09-09 12:50:32 +05:30
Akshay Joshi
5dd1ada8dd Fixed linter error. 2021-09-09 12:50:32 +05:30
Pradip Parkale
c94fc73c11 Port Cast node to react. Fixes #6566. 2021-09-09 12:50:32 +05:30
Akshay Joshi
d846ae64ea Port Sequences node to react. Fixes #6598 2021-09-09 12:50:32 +05:30
Rahul Shirsat
f16b18371e Port FTS Template, FTS Parsers nodes to react. Fixes #6587. 2021-09-09 12:48:58 +05:30
Akshay Joshi
4b8e655948 Port Foreign Data Wrapper, Foreign Server and User Mapping nodes to react. Fixes #6583 2021-09-09 12:48:24 +05:30
Nikhil Mohite
793dbc6e7f Port Event Triggers node to react. Fixes #6578 2021-09-09 12:44:37 +05:30
Aditya Toshniwal
873deaa92d Changed getNodeListByName to add params obj in parameters. 2021-09-09 12:40:54 +05:30
Nikhil Mohite
78ac1ee69c Port Catalog Object node to react. Fixes #6569 2021-09-09 12:40:54 +05:30
Yogesh Mahajan
5a27961102 Port Extension node to react. Fixes #6582 2021-09-09 12:40:53 +05:30
Aditya Toshniwal
b20558cb99 Some changes to the core code that will be helpful for other nodes. 2021-09-09 12:20:59 +05:30
Aditya Toshniwal
764677431f Added React framework for the properties dialog and port Server Group, Server, and Database dialogs. 
Following changes done for the framework:
 - Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone.
 - The new framework and components will use MaterialUI as the base. Previously, Bootstrap/Backform/jQuery components were used.
 - The new code uses JSS instead of CSS since material UI and most modern React libraries also use JSS. In the future, this will allow us to change the theme in real-time without refresh.
 - 90% code covered by 80-85 new jasmine test cases.
 - Server group node UI Schema migration to new, with schema test cases.
 - Server node UI Schema migration to new, with schema test cases.
 - Database node UI Schema migration to new, with schema test cases.
 - Few other UI changes.

Fixes #6130
 2021-09-09 12:20:59 +05:30
Akshay Joshi
fcfe7fae54 Fixed an issue where whitespace in function bodies was not applied while generating the script using Schema Diff. Fixes #6620 2021-09-02 14:51:50 +05:30
Nikhil Mohite
87c86beb38 Fixes RESQL test cases. 2021-08-31 16:21:32 +05:30
Nikhil Mohite
620e3a803d Fixed an issue where Revoke all is not displayed if the user change privilege. 
refs #4567
 2021-08-31 14:08:56 +05:30
Nikhil Mohite
b764046587 Fixed an issue where privileges were revoked using SQL query on objects like tables that do not correctly show in SQL tab. Fixes #4567 2021-08-27 12:54:14 +05:30
Aditya Toshniwal
d38f520805 Added support for the truncate table with restart identity. Fixes #2538 2021-08-27 12:41:29 +05:30
Nikhil Mohite
b30a42ab9e Ensure that deleting a database should not automatically connect to the next database. Fixes #6685 2021-08-25 17:01:48 +05:30
Aditya Toshniwal
c543930ac4 Fixed RESQL test cases. 2021-08-25 16:56:12 +05:30
Aditya Toshniwal
e39838455e Ensure that trigger function SQL should have 'create or replace function' instead of 'create function' only. Fixes #5849 2021-08-24 18:23:32 +05:30
Akshay Joshi
7798584e1c Fixed an issue where columns with sequences get altered unnecessarily with a schema diff tool. Fixes #6564 2021-08-18 19:33:01 +05:30
Aditya Toshniwal
9d985d3d8f Fixed potential bug in the table node. 2021-07-30 13:28:07 +05:30
Rahul Shirsat
2dd88e5a4e Ensure that all the required options should be loaded when the Range data type 
is selected while creating a custom data type.

Fixes #6643
 2021-07-29 10:43:27 +05:30
Aditya Toshniwal
2452d90300 Fixed incorrect tablespace options in the drop-down for move objects dialog. Fixes #6586 2021-07-27 17:28:38 +05:30
Akshay Joshi
3f67f512ec Fixed incorrect binary path issue when the user deletes the binary path from the preferences. Fixes #6619 2021-07-26 11:49:48 +05:30
zhangjie2@fujitsu.com
3a3eea0320 Correct the string for shared server test case. 2021-07-23 12:44:16 +05:30
Khushboo Vashi
36086722b3 RESQL testcase fixes for Triggers. 2021-07-07 17:56:30 +05:30
Rahul Shirsat
8edd5946e5 1) Modified some labels and controls. 
2) Fixed issue where the same user is showing in SQL query.

3) Added SQL tab in the dialog.

refs #3893
 2021-07-07 10:44:02 +05:30
Identifier Anonymous
39a845ad31 Remove extra brackets in CREATE script and DDL comparison for trigger node. 2021-07-06 19:07:35 +05:30
Khushboo Vashi
48ca83f31d Added support for OAuth 2 authentication. Fixes #5940 
Initial patch sent by: Florian Sabonchi
 2021-07-06 13:22:58 +05:30
Rahul Shirsat
5fe52b9cfe Added support for Reassign/Drop Owned for login roles. Fixes #3893 2021-06-28 18:55:52 +05:30
Pradip Parkale
e095d382b3 Fixed an issue where incorrect column name listed in the properties of Index. Fixes #6557 2021-06-27 19:00:16 +05:30
Ashesh Vashi
9574f43f87 Refactor the registry class logic and remove duplicate code for the same functionality. 2021-06-24 11:30:11 +05:30
Libor M
cc989c5c08 Added missing gettexts and text space improvements. 2021-06-24 11:15:50 +05:30
Dave Page
4e067835c3 Revert "Fixed API test cases for PG/EPAS 9.6" per Khushboo. 
This reverts commit 37278f2cd3.
 2021-06-17 13:27:33 +01:00
Khushboo Vashi
37278f2cd3 Fixed API test cases for PG/EPAS 9.6 2021-06-17 16:22:53 +05:30
Akshay Joshi
0dbfbd8dfc 1) Fixed Selenoid test cases. 
2) Fixed RESQL test case failing on Jenkins.
 2021-06-11 15:34:12 +05:30
Akshay Joshi
c86a2b643a 1) Binary path set to the default location in which we install the binaries. 
2) Validate path not working if there is a space in the binary path.
3) Handle the case when the path contains '$DIR'. 

refs #5370
 2021-06-10 22:49:05 +05:30
Yogesh Mahajan
b2042f48cd Added RESQL/MSQL test cases for Table and its child nodes. Fixes #4622 2021-06-09 18:16:50 +05:30
Nikhil Mohite
93ddc4a5ba Ensure that the user should be able to add members in Login/Role group while creating it. Fixes #6466 2021-06-08 19:33:03 +05:30
Akshay Joshi
5a086a9173 Fixed API test cases failed due to wrong handling of default binary path. 2021-06-08 13:24:17 +05:30
Akshay Joshi
07eb541806 1) Added logic to set the appropriate default binary path if DEFAULT_BINARY_PATH is 
set in the config and the user not updated the preferences.
2) Remove 'gpdb' from DEFAULT_BINARY_PATH.
3) Fixed API test cases. 

refs #5370
 2021-06-07 20:36:34 +05:30
Akshay Joshi
4bc4ca1ba9 1) Added browse button to select the binary path in the Preferences. Fixes #1561 
2) Added support to set the binary path for the different database server versions. Fixes #5370
 2021-06-04 17:55:35 +05:30
Rahul Shirsat
9ac08c263b Fixed duplicate SQL issue for tables with more than one partition. Fixes #6478 2021-05-31 12:46:07 +05:30
Nikhil Mohite
3ddf941cd7 Added support to launch PSQL for the connected database server. Fixes #2341 2021-05-25 20:12:57 +05:30
Pradip Parkale
4676d7ef02 Fixed an issue where the Help message not displaying correctly on Login/Group role. Fixes #6414 2021-05-17 13:08:38 +05:30
Aditya Toshniwal
b7c0914f33 Fixed 'No password supplied' error occurring on auto-detected servers. 2021-05-14 15:14:18 +05:30
Khushboo Vashi
7275ce906e 1) Fixed an issue where the user is not warned if Kerberos ticket expiration 
is less than 30 min while initiating a global backup. Fixes #6444

2) Ensure that proper identification should be there when the server is
   connected using Kerberos or without Kerberos. Fixes #6445
 2021-05-14 12:33:01 +05:30
Akshay Joshi
4842d589a6 Added missing validation for data type. Fixes #6407 2021-05-11 18:21:53 +05:30
huangj.fnst@fujitsu.com
fe6f9aae61 Fix a number of typos. 2021-05-11 11:16:38 +01:00
Yogesh Mahajan
b0df4d3604 Added support for the creation of Nested Table and Varying Array Type for Advanced Server. Fixes #6407 2021-05-07 12:39:54 +05:30
Akshay Joshi
b13627398b Fixed API test cases 2021-05-05 13:12:20 +05:30
Khushboo Vashi
b30ec71098 Ensure that while connecting to the server using SSPI login, it should not prompt for the password. Fixes #5776 2021-05-05 11:40:48 +05:30
Akshay Joshi
7e79814cb0 Added 'IF NOT EXISTS' clause while creating tables and partition tables which is convenient while using the ERD tool. Fixes #6397 2021-05-04 15:59:34 +05:30
Khushboo Vashi
72f3730c34 Added support to connect PostgreSQL servers via Kerberos authentication. Fixes #6158 2021-05-03 16:10:45 +05:30
Akshay Joshi
aa9a4c30d3 Fixed an issue where duplicate columns are visible in the browser tree, which is owned by two sequences. Fixes #6413 2021-05-03 14:53:21 +05:30
Akshay Joshi
e718be72e3 Added comment column in the properties panel for View and Materialized View collection node. Fixes #6416 2021-04-28 18:44:28 +05:30
Pradip Parkale
7bab200e4d Added more checks so that it will pick the correct shared server. 
refs #6385
 2021-04-27 11:58:47 +05:30
Rahul Shirsat
f5ef022ef5 Fixed an issue where indexes showing TABLESPACE pg_default for partition SQL, which should not be shown. 
refs #6329
 2021-04-27 11:54:56 +05:30
Akshay Joshi
7d6f077cf8 Fixed an issue where schema diff does not create DROP DEFAULT statement for columns. Fixes #6377 2021-04-26 16:41:20 +05:30
Rahul Shirsat
b853bda2a2 Fixed an issue where the wrong SQL is showing for the child partition tables. Fixes #6329 2021-04-26 14:32:34 +05:30
Pradip Parkale
abdd3190fe Fixed some SonarQube issues. 2021-04-22 17:40:41 +05:30
Pradip Parkale
8ae8fea6d2 Ensure that Backup and Restore should work on shared servers as some cases were failing due to initial changes. 
Fixes #6385
 2021-04-22 17:29:04 +05:30
Yogesh Mahajan
dc65cbb08c Fixed an issue where foreign data wrapper properties are not visible if the host option contains two host addresses. Fixes #6379 2021-04-19 11:08:21 +05:30
Pradip Parkale
cb7bcaf939 Ensure that Backup and Restore should work on shared servers. Fixes #6385 2021-04-14 12:11:55 +05:30
Rahul Shirsat
f07463024c Fixed flickering issue of the input box on check constraints. Fixes #6107 2021-04-12 12:34:36 +05:30
Pradip Parkale
0ed47fcd2b Fixed an issue where the Save button is enabled by default when open the table's properties dialog on PG 9.5. Fixes #6367 2021-04-12 11:36:16 +05:30
Pradip Parkale
ffdd58ffb4 Fixed some SonarQube issues. 2021-04-08 12:27:03 +05:30
Akshay Joshi
7f59463e3b Corrected the syntax for 'CREATE TRIGGER', use 'EXECUTE FUNCTION' instead of 'EXECUTE PROCEDURE' from v11 onwards. Fixes #6220 2021-04-07 12:01:37 +05:30
Akshay Joshi
c84df9cc0f Ensure that while comparing domains check function dependencies should be considered in schema diff. Fixes #6327 2021-04-01 16:31:12 +05:30
Pradip Parkale
566f03beca Ensure that the query tool tab should be closed after server disconnection when auto-commit/auto-rollback is set to false. Fixes #5519 2021-04-01 11:58:59 +05:30
Akshay Joshi
07f2df7e66 Fixed cannot unpack non-iterable response object error when selecting any partition. Fixes #6344 2021-03-31 12:08:01 +05:30
Rahul Shirsat
f0c86741a4 Improve code coverage and API test cases for Server module. Fixes #5319 2021-03-30 11:12:33 +05:30
Akshay Joshi
a29890368c Fixed an issue where the procedure creation is failed when providing the Volatility option. Fixes #6293 2021-03-30 10:58:32 +05:30
Nikhil Mohite
15b8d4711e Hide the checkbox on the role property tab for 'Members of' and 'Members'. 
refs #5404
 2021-03-19 15:48:05 +05:30
Pradip Parkale
24dc7f4a91 Fixed some issues reported by SonarQube. 2021-03-19 11:56:12 +05:30
Rahul Shirsat
f5cc1d1c7e Fixed cognitive complexity reported by SonarQube. 2021-03-19 11:51:45 +05:30
Pradip Parkale
ff06a18155 1) Fixed an issue where the incorrect values visible in the dependents tab for publication. Fixes #6307 
2) Ensure that the primary key should be visible properly in the table dialog. Fixes #6316
 2021-03-16 11:43:27 +05:30
Nikhil Mohite
7bad4ca535 Show the login roles that are members of a group role be shown when examining a group role. Fixes #5404 2021-03-12 13:11:09 +05:30
Rahul Shirsat
9d8360641f Use schema qualification while accessing the catalog objects. 
refs #3976
 2021-03-12 11:17:25 +05:30
Pradip Parkale
d6ee715d83 Ensure that autovacuum and analyze scale factors should be editable with more than two decimals. Fixes #4784 2021-03-09 18:48:32 +05:30
Akshay Joshi
0f62fecca2 Fixed an issue where the dependent tab throwing an error when selecting any login/group role. Fixes #6294 2021-03-09 14:32:16 +05:30
Rahul Shirsat
a2be30d257 Use schema qualification while accessing the catalog objects. Fixes #3976 2021-03-09 13:18:45 +05:30
Nikhil Mohite
d70dea5072 Ensure that the template database should be visible while creating the database. Fixes #6286 2021-03-04 17:48:52 +05:30
Akshay Joshi
8c7417b735 Fixed regressions from the last commit. 2021-03-03 11:46:47 +05:30
Huangj
9225493a93 Fixed an issue where schema diff showing wrong SQL when comparing triggers with different when clause. Fixes #6281. 2021-03-01 13:20:43 +05:30
Pradip Parkale
4267207c7f 1) Fixed an issue where the user is unable to create a subscription if the host/IP address for connection is 127.0.0.1. Fixes #6253 
2) Ensure that proper error message should be shown on the properties and statistics tab in case of insufficient privileges for a subscription. Fixes #6259
3) Fixed an issue where the 'Create Slot' option is disabled in case of the same IP/host provided but the port is different. Fixes #6260
 2021-03-01 12:08:33 +05:30
Rahul Shirsat
5a5a9314f3 Fixed an issue where the Save button is enabled for functions/procedures by default when open the properties dialog. Fixes #5073 2021-02-26 13:15:29 +05:30
Pradip Parkale
291e645d77 1) Updated documentation for SSL support in Subscription dialog. 
2) Fixed API test cases.

refs #6201
 2021-02-22 11:02:16 +05:30
Pradip Parkale
731ba32e81 1) Added SSL support for creating a subscription. Fixes #6201 
2) Fixed an issue where the user is not able to create the subscription. Fixes #6230
3) Fixed a couple of issues raised during testing of logical replication.
 2021-02-19 14:56:45 +05:30
Pradip Parkale
e5a91d30bf Fixed API test cases. 2021-02-15 18:29:49 +05:30
Akshay Joshi
3fc0cc3e92 Fixed SonarQube issues 2021-02-15 17:31:20 +05:30
Pradip Parkale
44cc7a308a Added publication and subscription support in Schema Diff. Fixes #6153 2021-02-15 16:05:40 +05:30
Rahul Shirsat
2036e9d9a8 Fixed an issue where the user is unable to update column-level privileges from the security tab. Fixes #6117 2021-02-10 17:56:26 +05:30
Aditya Toshniwal
1317e4254b Updated the JS dependencies to the latest 
1) Migrate from webpack 4 to webpack 5. This had a lot of breaking changes,
   so updated multiple webpack plugins and changed the config accordingly.
2) Replaced iconfont-webpack-plugin with a more maintained webfonts-loader.
3) Replaced deprecated babel-eslint with @babel/eslint-parser.
4) Replaced optimize-css-assets-webpack-plugin with a more maintained css-minimizer-webpack-plugin.
5) Updated all other JS packages and made the required code changes.

Fixes #6207
 2021-02-10 12:47:52 +05:30
Pramod Ahire
9e90350e44 Fixed jasmine test cases and added some missing messages for disabled menus. 2021-02-03 12:15:37 +05:30
Akshay Joshi
eca8e706dd Fixed SearchObjectsApiSearch test cases failed for EPAS 9.5 and 9.6 2021-02-02 19:47:06 +05:30
Pramod Ahire
b948f43dda Added Quick Search functionality for menu items and help articles. Fixes #6148 2021-02-02 14:47:58 +05:30
Khushboo Vashi
f7214b7cfe Fixed dependency tab loading issue when database name having special characters. 
refs #6087
 2021-02-02 11:49:51 +05:30
Pradip Parkale
bf56a6723b Added support for Logical Replication. Fixes #5912 2021-02-01 15:12:43 +05:30
Akshay Joshi
179bac3fd0 Fixed API test cases failed due to SonarQube fixes. 2021-01-31 18:19:14 +05:30
Aditya Toshniwal
a0271c7656 Fixed an issue while downloading ERD images in Safari and Firefox. Fixes #6177 2021-01-29 12:19:24 +05:30
Akshay Joshi
358af42c50 Fixed an issue where the dependencies tab showing multiple owners for the objects having shared dependencies. Fixes #6087 2021-01-29 12:10:21 +05:30
Rahul Shirsat
ab642344d4 Ensure that username should be visible in the 'Connect to Server' popup when service and user name both specified. Fixes #5871 2021-01-29 11:32:27 +05:30
Rahul Shirsat
e230787f21 Fixed SonarQube issues. 2021-01-29 11:06:59 +05:30
Akshay Joshi
3e09f1bf40 Ensure that the current value of the sequence should be ignored while comparing using schema diff. Fixes #6144 2021-01-21 14:18:06 +05:30
Dave Page
a2f626046a Fix labels. 2021-01-20 15:47:41 +00:00
Nikhil Mohite
da9f9017a9 Fixed cognitive complexity reported by SonarQube. 2021-01-19 13:34:14 +05:30
Khushboo Vashi
c0ef0a893d 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-18 16:32:10 +05:30
Aditya Toshniwal
0c8226ff39 Added ERD Diagram support with basic table fields, primary key, foreign key, and DDL SQL generation. Fixes #1802 2021-01-16 17:06:50 +05:30
Nikhil Mohite
a2edf317a9 Ensure that the user should be able to specify an older date for the account expiration of the role/user. Fixes #6120 2021-01-15 11:38:08 +05:30
Akshay Joshi
f86f58dc56 Revert "Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120" 
This reverts commit 9a47e574e3.
 2021-01-14 14:47:52 +05:30
Akshay Joshi
f0debdd513 Revert "1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457" 
This reverts commit 6ead597b43.
 2021-01-14 14:46:59 +05:30
Khushboo Vashi
6ead597b43 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-14 13:46:48 +05:30
Nikhil Mohite
9a47e574e3 Ensure that the account expiration date for role/user can’t be older than the current date. Fixes #6120 2021-01-14 12:09:03 +05:30
Rahul Shirsat
d55555c544 Fixed an issue where sequences are not created. Fixes #6128 
refs #6084
 2021-01-11 17:29:08 +05:30
Nikhil Mohite
f8497d4e7a Fixed an issue where the database list in the new connection window is not visible. Fixes #6121 2021-01-11 13:03:15 +05:30
Akshay Joshi
b372f08a59 Update copyright notices for 2021 2021-01-04 15:34:45 +05:30
Aditya Toshniwal
5198a881b7 Added 'Count Rows' option to the partition sub tables. Fixes #5282 2021-01-04 15:25:05 +05:30
Aditya Toshniwal
233736897d Added 'CREATE TABLE' SQL missed in the last patch for #5571 
refs #5571
 2021-01-04 15:06:28 +05:30
Nikhil Mohite
cd5243ac6d Fixed RESQL test cases for schema 2020-12-31 13:54:19 +05:30
Yogesh Mahajan
d1f5511566 Improve code coverage and API test cases for pgAgent. Fixes #5338 2020-12-31 13:52:14 +05:30
Nikhil Mohite
26bbc0e877 Fixed RESQL test cases for Column. 2020-12-30 12:25:07 +05:30
Aditya Toshniwal
f9087475d4 Fixed RESQL test cases for exclusion constraints. 
refs #5571
 2020-12-24 14:03:07 +05:30
Rahul Shirsat
4c9853f10d Fixed an issue where pressing the back button will show another instance of the main page inside of the Query Tool tab. Fixes #4892 2020-12-24 13:13:57 +05:30
Aditya Toshniwal
5448de2d3f Added support for expression in exclusion constraints. Fixes #5571 2020-12-24 12:50:57 +05:30
Nikhil Mohite
a92595012f Fixed extra parentheses issue around joins for Views. Fixes #6061 2020-12-23 13:02:16 +05:30
Rahul Shirsat
3def9792be Added appropriate help message and a placeholder for letting users know about the account password expiry for Login/Group Role. Fixes #5973 2020-12-17 12:02:32 +05:30
Rahul Shirsat
cb0a914099 Ensure that the 'template1' database should not be visible after pg_upgrade. Fixes #5875 2020-12-16 11:37:19 +05:30
Akshay Joshi
21333490ef 1. Added check to skip debugger test case if the plugin is not installed. 
2. Added code to delete the existing "pldbgapi" extension and create a new extension.
3. Updated a few test cases that are falling on specific servers.
4. Fixed test cases for pgAgent.

Fixed by: Nikhil & Yogesh
 2020-12-16 11:25:16 +05:30
Nikhil Mohite
794bd50ed1 Improve code coverage and API test cases for Debugger. Fixes #5343 2020-12-03 10:31:24 +05:30
Yogesh Mahajan
26b3bc3f74 Fixed an issue where an illegal argument is showing for trigger SQL when a trigger is created for View. Fixes #6003 2020-12-02 10:55:23 +05:30
Akshay Joshi
64e6570f00 Fixed an issue where schema diff doesn't show the result of compare if source schema has tables with RLS. Fixes #5998 2020-12-01 13:46:19 +05:30
Yogesh Mahajan
783b7516a7 Fixed false error is shown while adding a new foreign key from the table dialog when a foreign key already exists with Auto FK Index set to true. Fixes #5886 2020-12-01 11:35:01 +05:30
Yogesh Mahajan
b54cf2edca Improve code coverage and API test cases for Foreign Tables. Fixes #5328 2020-11-26 11:52:06 +05:30
Yogesh Mahajan
ce14696165 Improve code coverage and API test cases for Views and Materialized Views. Fixes #5337 2020-11-20 10:04:30 +05:30
Rahul Shirsat
be386e77f2 1) Fixed an issue where the process watcher dialog throws an error for 
the database server which is already removed. Fixes #5985
2) Fixed cognitive complexity reported by SonarQube.
 2020-11-12 17:47:21 +05:30
Nikhil Mohite
a026f339c3 Fixed cognitive complexity reported by SonarQube. 2020-11-12 17:20:58 +05:30
Pradip Parkale
25fcdab9db Fixed an issue where a mismatch in the value of 'Estimated row' for functions. Fixes #5914 2020-10-30 15:09:40 +05:30
Akshay Joshi
b76bb58378 Added support to compare schemas and databases in schema diff. Fixes #5891 2020-10-27 16:36:10 +05:30
Libor M
7648bd9646 Added missing gettext. 2020-10-27 10:51:35 +05:30
Nikhil Mohite
275d13d40f Following issues have been resolved for the new connection feature: 
1. Show servers with server groups in the dropdown.
  2. Highlighted current selected connection in the new connection dropdown.
  3. Notify the user before changing the connection.

refs #3794
 2020-10-21 17:14:59 +05:30
Pradip Parkale
3413a42af4 Ensure that some fields should be disabled for the trigger in edit mode. Fixes #4639 
Fixed illegal argument issue in the trigger for EPAS servers. Fixes #5799
 2020-10-20 16:18:34 +05:30
Pradip Parkale
7b9504bdfb Fixed an issue where the suffix for Toast table size is not visible in the Statistics tab. Fixes #5895 2020-10-20 15:57:32 +05:30
Pradip Parkale
1bb510cdd4 Fixed following issues in the function module: 
1) The volatility option is not reflecting. It stays volatile always when creating the function.
2) Set "Returns as set" to true and enter estimated rows like 12. Now set returns as set to false and save.
   It gives ERROR: ROWS is not applicable when the function does not return a set.
   Need to clear estimated rows when returns as set is false.
3) If estimated rows are added and support function is selected then SQL looks ugly.

Fixes #5843
 2020-10-12 14:01:04 +05:30
Akshay Joshi
556278dbc5 Added support to view trigger function under the respective trigger node. Fixes #2519 2020-10-12 13:49:54 +05:30
Akshay Joshi
f27527a614 Fixed API test cases failed for PG 9.5 due to change in the order of ACL. 2020-10-07 08:41:21 +05:30
Pradip Parkale
82e912ffad Fixed 'can't execute an empty query' message if the user change the option of Auto FK Index. Fixes #5835 2020-10-06 17:20:43 +05:30
Akshay Joshi
6c4049f29a Added RESQL/MSQL test cases for Functions. Fixes #5395 
Initial patch sent by Nikhil Mohite.
 2020-10-06 17:13:41 +05:30
Pradip Parkale
e4029cca04 Ensure that the user should be able to change the start value of the existing sequence. Fixes #5855 2020-10-05 16:38:16 +05:30
Akshay Joshi
542be2b2d4 Fixed issues where the 'pg_pltemplate' system catalog is removed from PG 13 and it gives error while creating the language. 2020-10-05 14:35:48 +05:30
Pradip Parkale
9a77d4dc1a Allow users to modify the option settings of the procedure. 
refs #5843
 2020-10-05 09:02:27 +05:30
Nikhil Mohite
be7bb81a19 Allow user to change the database connection from an open query tool tab. Fixes #3794 2020-10-01 13:29:46 +05:30
Pradip Parkale
656e239e55 Fixed API test cases introduce in the commit for #5867. 
refs #5867
 2020-10-01 13:29:46 +05:30
Pradip Parkale
b097cec45e Fixed an issue where some properties are not being updated correctly for the shared server. Fixes #5867 2020-09-30 12:29:59 +05:30
Akshay Joshi
1c70a43b91 Fixed code smells 'Define a constant instead of duplicating this literal' reported by SonarQube. 2020-09-29 15:08:14 +05:30
Akshay Joshi
952197f130 Added support to ignore the owner while comparing objects in the Schema Diff tool. Fixes #5200. 2020-09-28 15:22:46 +05:30
Akshay Joshi
68588fbb44 Fixed an issue where schema diff is showing identical table as different due to default vacuum settings. Fixes #5826 2020-09-24 13:24:25 +05:30
Pradip Parkale
c1d04747a1 Ensure that the 'Remove Server' option should be visible in the context menu. Fixes #5861 2020-09-24 10:58:30 +05:30
Pradip Parkale
f8611416ec Added the 'PARALLEL UNSAFE' option to the missing SQL files. 
refs #5843
 2020-09-24 10:47:42 +05:30
Pradip Parkale
2e55b1f660 Fixed an issue where the 'PARALLEL UNSAFE' option is missing from reverse engineering SQL of function/procedure node. Fixes #5843. 2020-09-23 13:21:50 +05:30
Nikhil Mohite
43d97b0e6f Improve code coverage and API test cases for Functions. Fixes #5330 2020-09-22 14:43:46 +05:30
Pradip Parkale
458036ad6b Fixed an issue where the server is not able to connect using the service. Fixes #5841 2020-09-22 13:14:40 +05:30
Ganesh Jaybhay
b0475566ca Fixed reverse engineering SQL where parenthesis is not properly arranged for View/MView definition. Fixes #5830 2020-09-21 11:05:56 +05:30
Akshay Joshi
3489f94ca7 Ensure that multiple extensions can be dropped from the properties tab. Fixes #5839. 2020-09-21 10:09:41 +05:30
Aditya Toshniwal 
a25e808e06 Remove maximum length on the password field in the server dialog. Fixes #5802 2020-09-17 20:21:00 +05:30
Aditya Toshniwal 
95a5b1e459 Some more accessibility fixes. 
refs #5732
 2020-09-17 20:16:38 +05:30
Akshay Joshi
55b5080c77 Fixed and improve API test cases for the schema diff tool. Fixes #5417 2020-09-17 20:10:01 +05:30
Akshay Joshi
324e3e74be Fixed an issue where custom sequences are not visible when show system objects are set to false. Fixes #5833 2020-09-15 12:58:43 +05:30
Akshay Joshi
5eb1c57320 1) Correct the reverse engineering SQL of the collation node for database server version < 10. 
2) Added 'rngcollation' and 'attnum' in the ignore list of Types node and fixed an issue occurs due to SonarQube fix.
 2020-09-14 16:12:20 +05:30
Akshay Joshi
a7d40e238e Ensure that the 'CREATE SCHEMA' statement should be present in the generated script if the schema is not present in the target database. Fixes #5816 2020-09-11 19:06:56 +05:30
Akshay Joshi
1bd0a0edf5 Remove illegal argument from trigger function in trigger DDL statement. Fixes #5779 2020-09-10 17:27:01 +05:30
Akshay Joshi
1bc1ef7f17 Fixed an issue where vacuum options not consider in Schema Diff. It's a regression. 2020-09-09 15:34:50 +05:30
Akshay Joshi
ffb829e80c Fixed an issue while refreshing Resource Group. Fixes #5820 2020-09-09 14:34:14 +05:30
Pradip Parkale
98e86a8160 Fixed an issue where the server icon getting change to the shared server icon in desktop mode. 
refs #4979
 2020-09-08 10:09:16 +05:30
Pradip Parkale
9e5487d5ad Fixed SQL for Row Level Security which is incorrectly generated. Fixes #5764 2020-09-07 18:40:49 +05:30
Pradip Parkale
4da4a05611 Fixed code smell 'Remove duplicates string literals'. 2020-09-07 17:56:02 +05:30
Akshay Joshi
eaa90ee8eb Fixed primary key/unique constraint icon issue. 2020-09-03 18:53:40 +05:30
Khushboo Vashi
31bbdd6a12 Fixed code smell 'String literals should not be duplicated'. 2020-09-03 18:35:58 +05:30
Akshay Joshi
a67f6e4f9c Fixed API test cases failed due to commit for #4979. 2020-09-03 14:20:45 +05:30
Pradip Parkale
b562ab7681 Added shared server support for admin users. Fixes #4979 2020-09-03 12:59:28 +05:30
Yogesh Mahajan
3e35dc95e5 Improve code coverage and API test cases for Tables. Fixes #5774. 2020-09-03 12:35:56 +05:30
Aditya Toshniwal
8f3bdf1cf3 Fixed cognitive complexity issues reported by SonarQube. 2020-09-02 14:39:54 +05:30
Cyril Jouve
5a253f9053 Change the following to replace Python 2 code with Python 3: 
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
 2020-08-31 16:45:31 +05:30
Aditya Toshniwal
11d5613866 Fixed RESQL test cases for Roles module. 2020-08-28 18:22:25 +05:30
Yogesh Mahajan
3984544bdb Fixed code smell 'String literals should not be duplicated'. 2020-08-28 18:17:27 +05:30
Yogesh Mahajan
e226b2fa75 Adjusted the height of jobstep code block to use maximum space. Fixes #5426. 2020-08-28 14:00:49 +05:30
Aditya Toshniwal
28b637c99c Fixed RE-SQL test cases failed due to the previous commit. 
Introduces a new key - replace_regex_pattern to synchronize the
expected SQL with the backend SQL based on the regex string
 2020-08-27 19:08:00 +05:30
Aditya Toshniwal
53a5410337 Fixed cognitive complexity issues and added some more RESQL test cases for roles module. 2020-08-27 13:09:22 +05:30
Yogesh Mahajan
f3bde7b5f1 Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216 2020-08-26 18:16:16 +05:30
Yogesh Mahajan
8fcf527632 Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332 2020-08-26 12:35:22 +05:30
Dave Page
4eb17afe4e Warn the user when connecting to a server that is older than pgAdmin supports. Fixes #5772 2020-08-25 17:18:43 +01:00
Nikhil Mohite
d2577e32e6 Fixed cognitive complexity issues reported by SonarQube. 2020-08-25 18:13:01 +05:30
Akshay Joshi
e2ac6187dc Fixed Jenkins build failure due to API test case failed. 2020-08-25 14:14:48 +05:30
Akshay Joshi
df9aaf19c2 Fixed string indices must be integers issue for PostgreSQL < 9.3. Fixes #5766 2020-08-25 13:38:24 +05:30
Aditya Toshniwal
275c671576 Fixed cognitive complexity issues reported by SonarQube. 2020-08-25 12:39:14 +05:30
Pradip Parkale
86bbc3a9e8 Ensure that the user should be able to drop the database even if it is connected. Fixes #5722 2020-08-25 12:37:50 +05:30
Nikhil Mohite
b3d49c61a5 Fixed incorrect reverse engineering SQL for Foreign key when creating a table. Fixes #5748 2020-08-25 12:31:58 +05:30
Pradip Parkale
7f947f146c Fixed cognitive complexity issues reported by SonarQube. 2020-08-25 12:28:55 +05:30
Akshay Joshi
52d0241a17 Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754 2020-08-24 12:11:09 +05:30
Neel Patel
b53de0c31d Updated some more font awesome icons for v5 2020-08-21 14:15:18 +05:30
Nikhil Mohite
19491d79a5 Fixed cognitive complexity issues reported by SonarQube. 2020-08-21 13:52:05 +05:30
Akshay Joshi
fbbbc36221 Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube. 2020-08-20 20:26:51 +05:30
Rahul Shirsat
7f3e8596e3 Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube. 2020-08-20 18:34:49 +05:30
Akshay Joshi
103b08c9c5 Define constants for preferences label to fix SonarQube issues. 2020-08-20 17:58:37 +05:30
Khushboo Vashi
cc5a7ea334 Fixed code smell 'String literals should not be duplicated'. 
Create a constant.py file which contains the common Constants.
 2020-08-19 14:16:02 +05:30
Nikhil Mohite
4b56962c1b Fixed cognitive complexity issues reported by SonarQube. 2020-08-19 13:41:53 +05:30
Akshay Joshi
63df19ee1c Fixed following schema diff issues: 
1) Avoid template databases from the Database drop-down list.
 2) Exclude system schemas while comparing two databases.
 3) Escape group name for XSS.
 2020-08-13 14:12:37 +05:30
Nikhil Mohite
93adf6884f Upgrade font awesome from v4 to v5. Fixes #5731 2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6 The 'str' object never has attribute decode in Python3, so remove the dead code. 2020-08-12 18:55:35 +05:30
Aditya Toshniwal
7dd313f5fc Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123 2020-08-12 14:24:40 +05:30
Aditya Toshniwal
8129df42da Fixed cognitive complexity issues reported by SonarQube. 2020-08-11 15:13:35 +05:30
Akshay Joshi
082b968bbc Fixed following schema diff issues: 
1) Wrong SQL generated for the columns having different data type.
  2) Added 'castfunc' in the ignore list.
 2020-08-11 14:42:32 +05:30
Rahul Shirsat
2907a79dd7 Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791 2020-08-11 11:30:47 +05:30
Akshay Joshi
46af290b85 Fixed API test cases for packages. 2020-08-10 18:13:00 +05:30
Nikhil Mohite
9d006d0ec5 Fixed cognitive complexity issues reported by SonarQube. 2020-08-10 16:30:07 +05:30
Cyril Jouve
7a0bfecfc5 Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses. 2020-08-10 15:57:25 +05:30
Rahul Shirsat
604937cf66 Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664 2020-08-10 15:27:57 +05:30
Akshay Joshi
4f74609ecf Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126 2020-08-10 15:13:34 +05:30
Nikhil Mohite 
9ad7476a34 Corrected DROP SQL syntax for catalog. Fixes #5713 2020-08-07 16:58:38 +05:30
Akshay Joshi
518b13c779 Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689 2020-08-07 16:30:03 +05:30
Aditya Toshniwal
d6400bbcae Replace the generic exception class with a more specific one. 2020-08-07 12:37:00 +05:30
Nikhil Mohite 
1122e06f48 Fixed cognitive complexity issues reported by SonarQube. 2020-08-06 12:38:35 +05:30
Nikhil Mohite
6a406f466d Fixed cognitive complexity issues reported by SonarQube. 2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2 Replace the generic exception class with a more specific one to fix SonarQube issues. 2020-08-05 12:41:28 +05:30
Akshay Joshi
5ce2773658 Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429 2020-08-04 15:48:20 +05:30
Akshay Joshi
87d08de3a0 Corrected the syntax as per jinja standards. refs #5632 2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a Fixed following SonarQube issues: 
- Remove this assignment to the local variable, the value is never used.
  - Rename local variables to match the regular expression
  - Add logic to this except clause or eliminate it and rethrow the exception automatically.
  - Rename fields to match the regular expression
  - Extract this nested conditional expression into an independent statement.
  - Change this default value to "None" and initialize this parameter inside the function/method.
  - Update this function so that its implementation is not identical to __repr__
  - Refactor this method to not always return the same value
  - Reraise this exception to stop the application as the user expects
  - Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
  - Remove this redundant continue.
  - Remove this unused function declaration
  - Remove this identity check; it will always be False.
 2020-08-03 12:59:51 +05:30
Satish V
318d712c4f Improve code coverage and API test cases for Schemas. Fixes #5327 2020-08-03 12:38:38 +05:30
Aditya Toshniwal
56cf64ad22 Fixed following SonarQube issues: 
- Refactor functions to not always return the same value.
  - Rename "cls" to "self" or add the missing "self" parameter.
  - Remove useless assignment to variables.
 2020-07-30 14:04:22 +05:30
Akshay Joshi
dd7eb54e90 Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710 2020-07-30 13:57:00 +05:30
Nikhil Mohite
89fa85d650 Fixed cognitive complexity issues reported by SonarQube. 2020-07-29 18:29:04 +05:30
Rahul Shirsat
74fd5dfe96 Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632 2020-07-29 16:22:11 +05:30
Satish V
287a6628ed Improve code coverage and API test cases for Types. Fixes #5336 2020-07-29 15:41:04 +05:30
Aditya Toshniwal
a0893fe43b Fixed code smell 'variable shadows a builtin' reported by SonarQube. 2020-07-28 16:20:26 +05:30
Akshay Joshi
fb0bc65ced Fixed following SonarQube issues: 
1) Define a constant instead of duplicating this literal.
  2) Reduce cognitive complexity (Patch by Aditya)
 2020-07-27 16:31:03 +05:30
Cyril Jouve
f93cfe8c4c Remove old Python 2 compatibility code. Fixes #5700 2020-07-27 11:03:13 +01:00
Akshay Joshi
7a22cff28c Fixed 'cannot unpack non-iterable Response object' issue. 2020-07-24 14:59:50 +05:30
Satish V
4cf8c2f300 Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324 2020-07-24 14:14:13 +05:30
Rahul Shirsat
937877e841 Ensure that RLS Policy node should be searchable using search object. Fixes #5646 2020-07-24 13:47:39 +05:30
Yogesh Mahajan
dd27e08a98 Fixed code smell 'Unused local variables should be removed'. 2020-07-24 12:15:29 +05:30
Nikhil Mohite
1fbf298d30 Fixed cognitive complexity issues reported by SonarQube. 2020-07-24 12:03:05 +05:30
Aditya Toshniwal
505a3ac960 1) Fixed cognitive complexity issues reported by SonarQube. 
2) Fixed code smell 'Add a nested comment explaining why this method is
   empty, or complete the implementation'.
 2020-07-24 11:46:30 +05:30
Pradip Parkale
28a4359020 Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686 2020-07-21 18:14:49 +05:30
Nikhil Mohite
7edcca9b07 Added High Contrast theme support. Fixes #5653 
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
 2020-07-20 11:51:21 +05:30
Nikhil Mohite
4e2c4b0498 Fixed cognitive complexity issues reported by SonarQube. 2020-07-17 15:31:04 +05:30
Akshay Joshi
703faf3b15 Fixed following SoanrQube issues 
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
  2) Define a constant instead of duplicating this literal.

Solution:
  1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
  2) Declare the constant in PGChildNodeView for SQL files.
 2020-07-16 19:39:55 +05:30
Akshay Joshi
5d8c79da38 Added docstrings for some newly created functions. 2020-07-15 18:07:54 +05:30
Akshay Joshi
11c4877859 Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647 2020-07-15 14:52:14 +05:30
Rahul Shirsat
d6893f9d8a Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569. 2020-07-14 19:16:33 +05:30
Akshay Joshi
4f34bc0f0e Added missing dependencies/dependent and corrected some wrongly identified. Fixes #5666 2020-07-14 18:34:50 +05:30
Satish V
a91e4d8a7f Improve code coverage and API test cases for Foreign Data Wrapper. Fixes #5323. 2020-07-14 15:58:22 +05:30
Nikhil Mohite
0013a3b047 Fixed cognitive complexity issues reported by SonarQube. 2020-07-14 15:33:54 +05:30
Akshay Joshi
d3eaac8609 Reverted fix for #5569 due to a couple of issues. 2020-07-11 20:32:57 +05:30
Rahul Shirsat
29175d7ec4 Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 2020-07-11 16:23:31 +05:30
Rahul Shirsat
e8b81db977 Fixed cognitive complexity issues reported by SonarQube. 2020-07-10 11:44:33 +05:30
Nikhil Mohite
7420673a0f Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329. 2020-07-10 11:40:08 +05:30
Nikhil Mohite
e1168f8de0 Fixed code smell to reduce cognitive complexity. 2020-07-09 18:41:13 +05:30
Pradip Parkale
916182f80f Fixed code smell for variable naming convention. 2020-07-09 18:28:08 +05:30
Pradip Parkale
c58fda0a70 Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633 2020-07-09 18:04:32 +05:30
Akshay Joshi
b4c25bdc0a Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube. 2020-07-07 19:39:06 +05:30
Pradip Parkale
36a2c073bd Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622 2020-07-07 17:55:05 +05:30
Nikhil Mohite
aee6bac5ef Fixed cognitive complexity code smell reported by SonarQube. 2020-07-07 15:19:47 +05:30
Aditya Toshniwal
45a03dd663 Fixed 'convention' related code smell reported by SonarQube. 2020-07-06 11:48:23 +05:30
Murtuza Zabuawala
cb1cdd1b23 Modified EPAS templates to support schema restriction. 2020-07-03 18:42:17 +05:30
Akshay Joshi
0d92059155 Fixed code smells having rule 'Functions, methods and lambdas should not have too many parameters'. 2020-07-03 18:37:37 +05:30
Yogesh Mahajan
80ab596992 Fixed the SoanrQube code smell 'Variables should not be shadowed'. 2020-07-03 14:33:30 +05:30
Khushboo Vashi
b5f0190799 Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'. 2020-07-03 14:24:54 +05:30
Aditya Toshniwal
341c3aded6 Fixed dark theme-related CSS and modify the color codes. Fixes #5287 
Fixed backgrid row hover issue where on hover background color is set for edit and delete cell only. Fixes #5470
 2020-07-03 11:47:40 +05:30
Nikhil Mohite
1ab257d512 Fixed Cognitive Complexity code smell reproted by SonarQube. 2020-07-03 11:15:41 +05:30
Yogesh Mahajan
1802f8a3f8 Ensure that the referenced table should be displayed on foreign key constraints. Fixes #5530 2020-07-02 16:21:56 +05:30
Pradip Parkale
8b10315e2a Added hints for 'Using' and 'With check' options of RLS Policy node. 2020-07-02 16:21:56 +05:30
Akshay Joshi
0850db2a9b Fixed database connection issue, regression of SonarQube fixes. 2020-07-01 17:32:22 +05:30
Akshay Joshi
a881e4e3f8 Fix PEP8 2020-07-01 15:33:51 +05:30
Nikhil Mohite
192a446131 Fixed API test cases failing due to updating the server manager instance. 2020-07-01 15:29:59 +05:30
Pradip Parkale
b30c590866 Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'. 2020-07-01 13:50:51 +05:30
Yogesh Mahajan
6dd3ca31be Fixed SonarQube code smell 'Variables should not be shadowed'. 2020-07-01 13:43:00 +05:30
Pradip Parkale
979f806161 1) Added RLS Policy support in Schema Diff. Fixes #5601 
2) Fixed 'cant execute empty query' issue when remove the value of
   'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631
 2020-07-01 12:44:28 +05:30
Ashesh Vashi
21d57b1f10 Do not let browser autocomplete the password field while connecting a 
database server.

Set the autocomplete attribute of the password field to 'new-password'
to let browser know, we require a new password for the password, and do
not autocomplete it.
 2020-07-01 11:26:52 +05:30
Nikhil Mohite
c873218c32 Added support for schema level restriction. Fixes #5583 
Allow user to edit the connection properties when the database server
is already connected.
 2020-06-30 19:15:23 +05:30
Nikhil Mohite
6713bc068b Fixed SonarQube code smells 'Refactor this function to reduce its Cognitive Complexity'. 2020-06-30 17:06:55 +05:30
Akshay Joshi
46d26cd029 Remove extra brackets from reverse engineering SQL of RLS Policy. Fixes #5621 2020-06-30 16:11:02 +05:30
Zhang Jie
88db5ec4d5 Remove extra brackets from reverse engineering SQL of trigger. 2020-06-30 16:07:55 +05:30
Rahul Shirsat
7add777b21 Add proper indentation to the code while generating functions, procedures, and trigger functions. Fixes #3851 2020-06-29 12:36:28 +05:30
Akshay Joshi
b91f6f0f5c Fixed an issue where the semicolon is misplaced in RLS Policy SQL. 
Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'.
 2020-06-26 19:24:54 +05:30
Nikhil Mohite
115657a465 Fixed following SonarQube issues: 
1) Refactor function to reduce its Cognitive Complexity.
 2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$.
 2020-06-26 15:03:50 +05:30
Satish V
8e28e0a32b Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326 2020-06-26 14:15:09 +05:30
Khushboo Vashi
c7a16a4bd5 Fixed code smells having rule 'Nested blocks of code should not be left empty'. 2020-06-26 13:18:27 +05:30
Yogesh Mahajan
707ff450b5 Fixed following SonarQube issues: 
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation, 
6. A while loop should be used instead of a 'for' loop.
 2020-06-26 13:12:07 +05:30
Diego Augusto Molina
6a63279396 Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions. 2020-06-26 12:28:36 +05:30
Aditya Toshniwal
d3b3d07f2e Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed. 2020-06-25 11:09:43 +05:30
Satish V
a1fd9ea3ce Fixed issue related to extra semicolons and function naming convention reported by SonarQube. 2020-06-24 16:16:12 +05:30
Nikhil Mohite
db9d684524 Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube. 2020-06-24 16:08:14 +05:30
Akshay Joshi
d265ed9729 Fixed an issue while creating RLS Policy with the name having space. Fixes #5620 2020-06-23 14:28:21 +05:30
Murtuza Zabuawala
c064eb0795 Fix an issue where RLS Policy dialog help is not working. 2020-06-23 14:13:08 +05:30
Pradip Parkale
6012f49919 Added policy event 'ALL' in events drop-down list. 2020-06-22 17:09:10 +05:30
Satish V
daad16ea93 Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube. 2020-06-22 12:58:48 +05:30
Aditya Toshniwal
6620f9263d Fixed issues reported by SonarQube with tag 'bad-practice'. 2020-06-22 12:18:59 +05:30
Yogesh Mahajan
6d3f13076f Fixed 'Comma operator should not be used' issue reported by SonarQube. 2020-06-18 16:17:55 +05:30
Satish V
905be1d894 Replace if-then-else statement by a single return statement, issue reported by SonarQube. 2020-06-18 15:51:01 +05:30
Aditya Toshniwal
f0490a54b7 Fixed redundant tagged issue reported by SonarQube. 2020-06-18 11:14:56 +05:30
Akshay Joshi
5ed1e1e5b6 Fixed some sonarqube issues. 2020-06-17 19:30:56 +05:30
Aditya Toshniwal
df05efd7d9 Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. 2020-06-17 17:15:09 +05:30
Yogesh Mahajan
7c12ade161 Fixed issue related to shadowing variables reported by SonarQube. 2020-06-17 17:08:23 +05:30
Akshay Joshi
cb268075c2 1) Added option to ignore the whitespaces while comparing objects in schema diff. Fixes #5468 
2) Added server group name while selecting servers in schema diff. Fixes #5500
3) Fixed an issue where two identical tables showing different by schema diff tool. Fixes #5584
 2020-06-17 16:27:51 +05:30
Satish V
d43518cb3c Fixed following issues reported by SonarQube: 
1) Replace this if-then-else statement by a single return statement. (clumsy)
2) 'switch' statements should have at least 3 'case' clauses. (bad practice)
 2020-06-16 15:00:51 +05:30
Aditya Toshniwal
3e00fe2b0f Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube 2020-06-16 11:14:57 +05:30
Yogesh Mahajan
697f4aec95 Fixed issue related to shadowing variables reported by SonarQube. 2020-06-16 10:47:40 +05:30
Akshay Joshi
a21e6448ce Fixed RESQL test cases, regression of RLS policy. 2020-06-15 17:10:25 +05:30
Satish V
eb1b17b636 Fix 'expressions evaluated to true/false always' issue reported by SonarQube. 2020-06-15 16:50:07 +05:30
Mishika Singh
38cd3327f3 Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592 2020-06-15 16:50:07 +05:30
Khushboo Vashi
8ab358ccec Fix following issues reported by SonarQube: 
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
 2020-06-15 16:50:07 +05:30
Aditya Toshniwal
641f7bbe9d Some clumsy coding related fixes reported by SonarQube. 2020-06-15 16:50:07 +05:30
Pradip Parkale
18277543b6 Added support of Row Security Policies. Fixes #5516 2020-06-15 15:44:59 +05:30
Aditya Toshniwal
8c20f0c0d2 Some clumsy coding related fixes reported by SonarQube. 2020-06-12 15:24:17 +05:30
Satish V
ee1ea47e88 Fixed issue 'expects 4 arguments, but 5 were provided' reported by SonarQube. 2020-06-12 15:15:07 +05:30
Satish V
82c4a4a03e Improve code coverage and API test cases for Collations. Fixes #5325 2020-06-11 11:12:41 +05:30
Dave Page
5c60dcd501 Remove blank line at EOF. 2020-06-10 17:02:39 +01:00
Dave Page
85e89c869a Cleanup some code smells identified by SonarQube. 2020-06-10 16:42:59 +01:00
Satish V
726ecd79e6 Fixed import statements. 
refs #3669
 2020-06-03 12:49:05 +05:30
Satish V
d22e276586 Ensure that proper error should be displayed for the deleted node. Fixes #3669 2020-06-03 11:26:26 +05:30
Akshay Joshi
9b8902dfb8 Fixed the SQL help issue for EDB Postgres Advanced Server. Fixes #4099 2020-05-22 14:11:58 +05:30
Yogesh Jain
7b1cac6914 Fixed an issue where clicking on Select All button, not selecting all the options in pgAgent job scheduler. Fixes #5496 2020-05-19 13:54:21 +05:30
Yogesh Mahajan
9f445dc052 Improve code coverage and API test cases for Indexes. Fixes #5333 2020-05-18 12:29:33 +05:30
Pradip Parkale
6d6cd19b37 Improve code coverage and API test cases for Triggers and Compound Triggers. Fixes #5335 2020-05-15 12:50:50 +05:30
Akshay Joshi
073d90c4a6 Fixed internal server error when clicking on Triggers -> 'Enable All' for partitions. Fixes #5052 2020-05-11 15:18:39 +05:30
Yogesh Mahajan
1294c089a8 Implement Selenium Grid to run multiple tests across different browsers, operating systems, and machines in parallel. Fixes #5255 2020-05-11 12:11:31 +05:30
Aditya Toshniwal
b64896f558 Fixed generated SQL issue for auto vacuum options. Fixes #5398 
Fixed some more issues:

 1) pgAdmin allows only true or false values for autovacuum_enabled,
    and there is no way to reset it individually without disabling a custom auto vacuum.
    To fix this, the control is changed from the switch to three state buttons.
 2) Setting any vacuum options to zero made the option disappear from the SQL.
 3) Right-click on a table with vacuum options set and create a new table.
 4) The parameters tab will have the options prefilled.
 5) Changed the UI a bit to remove unnecessary space around. Added "Autovacuum" before enabled.
    The SQL generated was appending a ".0" to decimal vacuum options. Changed to remove the leading ".0".
 2020-05-08 14:30:30 +05:30
Ashesh Vashi
e73e2d2502 Fixed the errors, and warnings reported by pylama. 
TODO::
- Don't use unicode in Python 3 for removing the support of Python 2 (
  psycopg2 driver - __init__.py, server_manager.py).
- Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion.
 2020-05-08 14:13:38 +05:30
Pradip Parkale
057a2b2312 Improve code coverage and API test cases for the Rules module. Fixes #5334 2020-05-07 16:27:58 +05:30
Akshay Joshi
6ad46e1860 Fixed invalid literal issue when removing the connection limit for the existing role. Fixes #5001 2020-05-07 13:14:45 +05:30
Akshay Joshi
a0940fd145 Typecast the object to 'text' before using it in length() function, so that correct length function gets called. 2020-05-06 17:34:18 +05:30
Ganesh Jaybhay
5fe7813f9f Fixed an issue where select2 hover is inconsistent for the SSL field in create server dialog. Fixes #5469 2020-05-04 13:19:13 +05:30
Satish V
d61b8eb1b3 Gracefully informed the user that the database is already connected when they click on 'Connect Database...'. Fixes #3694 2020-05-04 13:08:56 +05:30
Murtuza Zabuawala
0fc2afb829 Add Reverse Engineered and Modified SQL tests for Column and Type. 2020-05-04 12:48:24 +05:30
Khushboo Vashi
5656f756e6 Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422 2020-05-04 12:23:18 +05:30
Akshay Joshi
ad80217593 Remove Python2 references from the source code. 
refs #5443

Initial patch: Neel Patel
 2020-04-30 17:22:48 +05:30
Dave Page
86afec860f Remove Python 2 support from the Python tests. 
refs #5443
 2020-04-30 12:56:45 +05:30
Khushboo Vashi
88aebb64f9 Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447 
It's a regression of #5213
 2020-04-28 11:00:23 +05:30
Pradip Parkale
18748846ef Fixed the regression where initial changes make the Save button enabled when the table dialog is opened. Fixes #4504 2020-04-27 18:48:44 +05:30
Murtuza Zabuawala
76eb3e9b67 Fixed an issue when the user performs refresh on a large size materialized view. Fixes #5213 2020-04-27 17:30:23 +05:30
Pradip Parkale
ef58d277ca Fixed an issue where like options should be disabled if the relation is not selected while creating a table. Fixes #4504 2020-04-24 18:22:11 +05:30
Aditya Toshniwal
aec64aa582 Fixed following issues for 1257: 
1. For synonyms, the property is shown as "Public Synonym".
 2. For system procedure, the flag should be True but it is displaying as False.
 3. For both views and materialized views, the property is "System View".
 4. For FTS templates, the property is showing as "System FTS Parser".

Fixes #1257
 2020-04-24 16:35:59 +05:30
Aditya Toshniwal
dfb74904ed Ensure all object types have a System XXX? property. Fixes #1257 2020-04-23 17:31:40 +05:30
Akshay Joshi
2b5c90e379 A warning message will be displayed only when the package header is changed for EPAS packages. Fixes #5410 2020-04-23 17:14:01 +05:30
Khushboo Vashi
6e5dbf7beb Added multiple drop/delete functionality for the table constraints. Fixes #3900 2020-04-22 18:47:13 +05:30
Ashesh Vashi
858294f36e Fixed validation errors in view/materialized view javascript to 
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.

Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.

Fixes #5053
 2020-04-22 17:19:18 +05:30
Akshay Joshi
4c616f32eb 1) Fixed feature test and API test cases. 
2) Added logic to exclude RESQL test cases.
 2020-04-22 13:57:32 +05:30
Neel Patel
07f72252d7 Added job step and job schedule disable icons to identify it quickly within the browser tree. Fixes #4636 
Add Reverse Engineered and Modified SQL tests for pgAgent jobs. Fixes #4623
Fixed modified SQL issue while adding an exception in pgAgent job schedule. Fixes #5356
 2020-04-21 17:00:21 +05:30
Akshay Joshi
f289dfb762 Fixed following issues for packages: 
1) Removing the package header removes the body as well.
  2) Schema is not visible on the properties dialog.
  3) Reverse engineering SQL and Create script not showing schema-qualified packages.

Fixes #5410
 2020-04-21 16:49:23 +05:30
Akshay Joshi
4692b21bcf Fixed an issue where schema diff marks an identical table as different. Fixes #5350 
Fixed an issue where schema diff showing changes in the identical domain constraints. Fixes #5315

Ignore the keys from the source and target list and also sort both the lists.
 2020-04-20 18:04:16 +05:30
Libor M
36a3d4e53b Some more gettext() usage fixes: 
- fixed `%` vs. `.format()`
  - unified texts and usage `%s` vs. `{}`/`{0}`
  - improved text sentences for translate
  - added gettext for next texts
 2020-04-20 11:19:09 +05:30
Akshay Joshi
d8ad0b8faf Fixed validation issue in Synonyms node. Fixes #5409 2020-04-17 14:50:38 +05:30
Akshay Joshi
c6deb9393c Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410 2020-04-17 13:06:07 +05:30
Aditya Toshniwal
dc1e32a632 Fixed internal server error when the database server is logged in with non-super user. Fixes #5400 2020-04-16 15:05:17 +05:30
Murtuza Zabuawala
eec2cfd5dd Fixed an issue where the Mode cell of argument grid does not appear completely in the Functions dialog. Fixes #5375 2020-04-16 13:16:07 +05:30
Shubham Agarwal
d6cab7b421 Ensure the DROP statements in reverse engineered SQL are properly quoted for all objects. Fixes #4440 2020-04-16 13:06:50 +05:30
Libor M
8254e9f030 Some minor gettext and format fixes. 2020-04-16 12:55:19 +05:30
Ganesh Jaybhay
7493649893 Added schema-qualified dictionary names in FTS configuration to avoid confusion of duplicate names. Fixes #4709 2020-04-16 12:47:00 +05:30
Khushboo Vashi
738c421edf Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957 2020-04-16 12:38:20 +05:30
Aditya Toshniwal
31a929388b Make changes to use gettext() function correctly. 2020-04-15 16:23:17 +05:30
Aditya Toshniwal
0424f7d962 Fixed following issues for Procedures: 
1) Change comments on the procedure with arguments as a procedure can be overloaded.
     Note that on EPAS servers, procedure overloading works only for v11+.
  2) The save button of a procedure dialog is enabled without any change.
  3) Fixed formatting of the reverse-engineered SQL.
  4) On EPAS servers, the parameters set were not displayed in the SQL generated.
     They are visible only if set to edbsql.
  5) Changing the volatility option of any existing procedure was not working.
  6) Changing the parallel option (EPAS v9.6+) was not working.
  7) Added RE-SQL test cases for procedures.

Fixes #4620, Fixes #4873
 2020-04-15 13:54:17 +05:30
Shubham Agarwal
8654d6cf43 Fixed an issue where the mode is not shown in the properties dialog of functions/procedures if all the arguments are IN arguments. Fixes #5387 2020-04-15 12:33:54 +05:30
Ashesh Vashi
3a4641889c Using 'is_valid_ipaddress' utility function everywhere 2020-04-14 18:51:48 +05:30
Ashesh Vashi
6c5883bce0 We don't need to pass gettext for inline CSS transforation 2020-04-14 18:43:04 +05:30
Ashesh Vashi
d226ffbd1f [Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects 
5 positional arguments.

Also,
- Using 'gettext' instead of '_'.
- Using constant string for 'foreign_key not found' error message.
 2020-04-14 18:40:15 +05:30
Ganesh Jaybhay
12530cd973 Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007 2020-04-14 14:02:33 +05:30
Khushboo Vashi
a0fcb38e68 Fixed syntax error while refreshing the existing synonyms. Fixes #5383 2020-04-14 13:43:56 +05:30
Pradip Parkale
a05acb4f99 Fixed tab key navigation for some dialogs. Fixes #5371 2020-04-14 13:32:03 +05:30
Shubham Agarwal
41521a9b98 Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445 2020-04-14 13:02:58 +05:30
Akshay Joshi
781b766ac4 Fixed an issue where difference SQL is not seen in the schema diff tool for Types. Fixes #5302 2020-04-13 20:24:12 +05:30
Akshay Joshi
df11f28593 Fixed an issue where the identical packages and sequences visible as different in the schema diff tool. Fixes #5362 2020-04-13 18:06:20 +05:30
Khushboo Vashi
030741bba5 Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053 2020-04-13 16:00:01 +05:30
Murtuza Zabuawala
4de6b93ba8 Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813 2020-04-10 17:03:04 +05:30
Libor M
6a9af07f7a Fixed gettext usage: 
- fixed gettext usage with .format() only for original text with %s
  - fixed typos
  - fixed translation yes/no buttons in the dialog.
  - improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js,
     word 'cancel' needs to be translated in the Czech language as 'zrušit' but in another sentence as 'zrušení')
  - added gettext for text translations.
 2020-04-10 14:52:41 +05:30
Khushboo Vashi
e238ecf182 Ensure that OID should be shown in properties for Synonyms. Fixes #5270 2020-04-10 13:19:52 +05:30
Akshay Joshi
31f255b541 Added support of Foreign Tables to the Schema Diff. Fixes #5263 2020-04-09 21:03:28 +05:30