Commit Graph
51 Commits
Author SHA1 Message Date
Joao De Almeida Pereira 46d4bf027d Ensure sql for Role should be visible in SQL panel for GPDB. Fixes #3578 2018-08-17 14:50:16 +05:30
Joao Pedro De Almeida Pereira 155f82676d Fix the RE-SQL generation for GreenPlum external tables. Fixes #3431 2018-06-19 20:01:45 -04:00
Joao De Almeida Pereira e5048b4d0b Disable ACLs for the database objects for the Greenplum due to
performance issue.

Reviewed By: Ashesh
Fixes #3415
2018-06-12 10:07:23 +05:30
Joao De Almeida Pereira 7dd6372eeb Extract the tests and refactor some of the methods.
Extract some of the ACI Tree functionalities, and decouple it from the
main source. Also - create some abstractions from the repeated code
around the enable/disable the schema children object create/edit/delete
functionalities, and also created the dialog wrappers for backup and
restore dialogs.

Reviewed by: Khushboo and Ashesh
Refactored by: Ashesh
2018-06-05 16:42:59 +05:30
Joao De Almeida Pereira bc4d16eb83 Initial version of the new tree implementation.
This is the first version of our Tree implementation. At this point is a
very simple tree without no abstractions and with code that eventually
is not very performant, but this is only the first iteration and we are
trying to follow the 'Last Responsible Moment Principle' [1].

Implemention details:
- Creation of PGBrowser.treeMenu
- Initial version of the Tree Adaptor 'pgadmin/static/js/tree/tree.js'
- TreeFake test double that can replace the Tree for testing purposes
- Tests, As an interesting asside because Fake’s need to behave like
  the real object you will noticed that there are tests for this type
  of double and they the same as of the real object.

[1] https://medium.com/@aidanjcasey/guiding-principles-for-an-evolutionary-software-architecture-b6dc2cb24680

Patched by: Victoria && Joao
Reviewed by: Khushboo & Ashesh
2018-05-14 18:00:23 +05:30
Joao De Almeida Pereira b8f49daeb8 Change the order of the shims in the shims file.
Patch by: Victoria && Joao
Reviweb by: Khushboo
2018-05-10 12:06:43 +05:30
Joao De Almeida Pereira 31e73f4096 Ensure the JS-linter is running on all the tests files. 2018-04-30 17:50:51 +05:30
Joao Pedro De Almeida Pereira 201f6d359f Cleanup some old code that was failing CI. 2018-04-26 16:21:46 +01:00
Joao De Almeida Pereira 966279c1b3 Fixed issue where icon for Partitioned tables was the same as Non Partitioned tables for GreenPlum database. Fixes #3308 2018-04-26 17:05:56 +05:30
Joao De Almeida Pereira 2ace6a60f3 Fixed display SQL of table with index for GreenPlum database. Fixes #3306 2018-04-25 12:36:41 +05:30
Joao Pedro De Almeida Pereira 94e1e46201 Show more granular timing info in the query tool history panel. Fixes #3244 2018-04-03 14:11:11 +01:00
Joao Pedro De Almeida Pereira 35b0ab2fe1 Update Karma to 2.0 with plugins. Fixes #3222 2018-03-20 09:31:38 +00:00
Joao Pedro De Almeida Pereira 3c4359270e Fix trim function which was causing some JS errors during Server Properties validation. Victoria & Joao 2018-03-14 17:58:01 -04:00
Joao Pedro De Almeida Pereira 876ce1799a Skip tests where appropriate on GPDB. Fixes #3190
Victoria & Joao @ Pivotal.
2018-03-13 15:32:35 -04:00
Joao Pedro De Almeida Pereira 83477224cb Use test methods with @patch rather than directly. 2018-03-09 13:25:35 +00:00
Joao Pedro De Almeida Pereira 3a6994f719 Final PEP-8 fixes 2018-03-08 09:33:43 +00:00
Joao Pedro De Almeida Pereira e7316e2181 Update Jasmine to v3. Fixes #3182 2018-03-07 16:01:04 +00:00
Joao Pedro De Almeida Pereira d1ab47c10c Disable function statistics on Greenplum. Fixes #3176 2018-03-07 11:52:02 +00:00
Joao Pedro De Almeida Pereira 427314cfdf Support for external tables in GPDB. Fixes #3168 2018-03-02 16:49:25 +00:00
Joao Pedro De Almeida Pereira 3be22383b8 Fix function reserve SQL for GPDB. Fixes #3150 2018-02-27 11:05:15 +00:00
Joao Pedro De Almeida Pereira 5ebd9ee8d3 Fix table statistics for Greenplum. Fixes #3059 2018-02-26 09:38:00 +00:00
Joao Pedro De Almeida Pereira 2332630af8 PEP8 fixes for the tools module. 2018-02-23 11:57:44 +00:00
Joao Pedro De Almeida Pereira ba70634e5f Hide tablespace node on GPDB. Fixes #3107 2018-02-20 17:40:56 +00:00
Joao Pedro De Almeida Pereira bcb6f37d6f Clarify which shortcut is being tested in the shortcut test. 2018-02-20 17:32:37 +00:00
Joao Pedro De Almeida Pereira 0677ad254a Un-vendorise React, now that it contains bug fixes we need. 2018-02-19 10:53:54 +00:00
Joao Pedro De Almeida Pereira 15862e903a Fix creation of tables and columns in GPDB. Fixes #3099 2018-02-19 10:40:10 +00:00
Joao Pedro De Almeida Pereira 9c382e4d23 Fix tests for Python 3.x 2018-02-09 14:39:39 +00:00
Joao Pedro De Almeida Pereira e16a952753 Support EXPLAIN on Greenplum. Fixes #3097
- Extract SQLEditor.execute and SQLEditor._poll into their own files and add test around them
 - Extract SQLEditor backend functions that start executing query to their own files and add tests around it
 - Move the Explain SQL from the front-end and now pass the Explain plan parameters as a JSON object in the start query call.
 - Extract the compile_template_name into a function that can be used by the different places that try to select the version of the template and the server type
2018-02-09 11:54:42 +00:00
Joao Pedro De Almeida Pereira e60a84c44f Update JS packages:
Add package:
     is-docker to select a specific setting when running the Chrome tests in Docker

Upgrade the version of:
    - babel-loader
    - extract-text-webpack-plugin
    - jasmine-core
    - jasmine-enzyme
    - moment
2018-02-09 11:09:04 +00:00
Joao Pedro De Almeida Pereira de1c767e88 Update the regression tests to fix issues with Python 3.5 and PG 9.2. Fixes #3057 2018-01-26 16:45:09 +00:00
Joao Pedro De Almeida Pereira 7c985695b7 Correct display of RE-SQL for partitioned tables in Greenplum. Fixes #3050 2018-01-25 12:37:17 +00:00
Joao Pedro De Almeida Pereira 65337daeba Display functions in Greenplum. Fixes #3044 2018-01-23 11:10:46 +00:00
Joao Pedro De Almeida Pereira 678699c408 Display partitions in Greenplum. Fixes #3036 2018-01-23 10:41:36 +00:00
Joao Pedro De Almeida Pereira 284adbbb90 Correctly display SQL of multiple objects on the SQL tab in GPDB. 2018-01-22 11:04:49 +00:00
Joao Pedro De Almeida Pereira 56e922f5ab Support Properties on Greenplum databases. Fixes #3015 2018-01-15 14:44:40 +05:30
Joao Pedro De Almeida Pereira ed3e374df6 Support server and database statistics on Greenplum. Fixes #3004 2018-01-12 10:02:46 +00:00
Joao Pedro De Almeida Pereira fe95b7670b Ensure the appropriate entry is focussed when entering the history tab. 2017-07-24 11:46:06 +01:00
Joao Pedro De Almeida Pereira d56f1d847c Update dialogue error styling to match alerts 2017-07-10 09:36:10 +01:00
Joao Pedro De Almeida Pereira 815c4b4c45 Improve spacing around delete icons in backform tables. 2017-07-07 16:06:51 +01:00
Joao Pedro De Almeida Pereira f2d2075d81 Update alertify alerts to use the styling defined in the styleguide (missed some files in the original commit). 2017-06-30 10:23:12 +01:00
Joao Pedro De Almeida Pereira 2a30a86e7d Update alertify alerts to use the styling defined in the styleguide. 2017-06-30 10:21:05 +01:00
Joao Pedro De Almeida Pereira ba3ab7b322 Add support for SCSS building in webpack. 2017-06-30 10:15:44 +01:00
Joao Pedro De Almeida Pereira 7f55412059 Overhaul the query history tab to allow browsing of the history and full query text. Fixes #2282
Patch by Joao and the team at Pivotal.
2017-06-27 10:55:57 -04:00
Joao Pedro De Almeida Pereira 4b846ae4e0 Fix the JS Bundler test to work when there are multiple servers defined in a test run. 2017-06-14 09:37:20 +01:00
Joao Pedro De Almeida Pereira a9ce9c9717 Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. Greenplum). 2017-06-13 10:27:09 +01:00
Joao Pedro De Almeida Pereira 3bf17d9df4 1) Splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.
2) Add Unit Tests for each file.
3) Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same order
4) Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1
5) Deleted unused __init__.py files.
2017-05-15 10:40:46 +05:30
Joao Pedro De Almeida Pereira f718e1f49c Only display the header row in SlickGrid where columns actually exist. 2017-04-24 20:26:59 +01:00
Joao Pedro De Almeida Pereira 3eb92f7ea3 Update test requirements for the latest rev of Chrome. 2017-04-24 13:07:04 +01:00
Joao Pedro De Almeida Pereira 70832286bc Update Chromedriver version for Chrome 58.
Note:
If you had previously installed the old driver you need to uninstall and install again it.

$ pip uninstall chromedriver_installer
$ pip install -r regression/requirements.txt
2017-04-21 09:54:18 +01:00
Joao Pedro De Almeida Pereira eb89998dc0 From a visual standpoint, grey highlight makes selection look deselected rather than selected. A brighter color would quickly provide visual feedback on an action.
With this patch the color of selected rows look more highlighted.
2017-03-30 22:56:13 -04:00
Joao Pedro De Almeida Pereira 6ad6bf5aab Update test requirements to include a version of Selenium that supports Chrome 57, and the chromedriver installer. 2017-03-16 09:53:26 +00:00