Commit Graph

483 Commits

Author SHA1 Message Date
Akshay Joshi
ec47a2aa66 Added a fix to the context menu and panel issue introduced by the SonarQube fixes. 2022-09-09 11:42:32 +05:30
Akshay Joshi
b73aa6d000 Fixed 'Remove the unnecessary boolean literals' code smell 2022-09-08 20:28:43 +05:30
Akshay Joshi
b8f63adf41 Fixes following code smell reported by SonarQube:
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
2022-09-08 19:56:02 +05:30
Akshay Joshi
7086719640 Fixed SonarQube issues. 2022-09-08 18:08:58 +05:30
Akshay Joshi
18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite
e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Yogesh Mahajan
ad59380676 Fixed an issue with the non-visibility of columns added prior to import/export data. Fixes #7649 2022-09-07 17:40:52 +05:30
Akshay Joshi
e58b9c767b Port search object dialog to React. Fixes #7622 2022-08-30 17:08:12 +05:30
Yogesh Mahajan
71a4b20d90 Fixed some SonarQube issues. 2022-08-30 14:21:33 +05:30
Aditya Toshniwal
c2b23465cc 1) Added support to show all background processes in separate panel. Fixes #3709
2) Port process watcher to React. Fixes #7404
2022-08-11 10:49:45 +05:30
Aditya Toshniwal
8b7ce2c276 Port change user password and 2FA dialog to React. Fixes #7568 2022-08-10 18:02:54 +05:30
Nikhil Mohite
9c418188ee Fixed SonarQube issues. 2022-08-10 15:05:20 +05:30
Yogesh Mahajan
fa6b77b42c Port Role Reassign dialog to React. Fixes #7344 2022-08-05 16:04:15 +05:30
Akshay Joshi
53887c32bf Port change ownership dialog to React. Fixes #7590 2022-08-05 14:11:17 +05:30
Akshay Joshi
81b0d1138b Remove Alertify dialog from Grant Wizard, Import/Export Servers and Cloud. 2022-07-28 10:14:04 +05:30
Aditya Toshniwal
4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Yogesh Mahajan
8f2bda2309 1) Preserve the settings set by the user in the import/export data dialog. Fixes #7428
2) Fixed the JSON editor issue of hiding the first record. Fixes #7520
2022-07-18 10:54:03 +05:30
Akshay Joshi
02b0f35442 1) Port change password dialog to React. Fixes #7341
2) Port named restore point dialog to React. Fixes #7546
2022-07-11 13:39:09 +05:30
Nikhil Mohite
64e6700228 Changed the default position of the dialog. 2022-07-05 18:46:49 +05:30
Aditya Toshniwal
239e3bb6f1 Some more theme related fixes. 2022-07-04 14:26:33 +05:30
Nikhil Mohite
b283c0ba18 Port Master Password dialog to React. Fixes #7342 2022-07-04 12:16:23 +05:30
Pradip Parkale
e59471d87d Ensure that dashboard graph API is not called after the panel has been closed. Fixes #7518 2022-07-04 12:03:18 +05:30
Aditya Toshniwal
86b30b3c83 Theme component usage has been fixed, a component should never be wrapped in multiple Theme components. 2022-06-30 15:18:20 +05:30
Nikhil Mohite
d90b2621da Fixed an issue where passwords entered in the 'Connect To Server' dialog were truncated. Fixes #7440 2022-06-22 17:35:22 +05:30
Akshay Joshi
93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Pradip Parkale
628e609e6a 1) Added the option 'Show template databases?' to display template databases regardless of the setting of 'Show system objects?'.
2) Ensure that the user should be able to create a template database using create dialog instead of updating it later.

Fixes #7351
2022-06-13 14:50:17 +05:30
Aditya Toshniwal
5e0dfff42a Ensure that the editor position should not get changed once it is opened. Fixes #7393 2022-05-18 13:52:09 +05:30
Akshay Joshi
53bd2c2dc6 Ensure that when the user presses the Enter key on the connect to server dialog, it should work. 2022-05-18 12:08:37 +05:30
Akshay Joshi
44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Akshay Joshi
6e2ee9a21f Port data filter dialog to React. Fixes #7340 2022-04-28 12:04:56 +05:30
Pradip Parkale
ab8e9a8ea5 Fixed an issue while creating a new database throwing an error that failed to retrieve data. Fixes #7322 2022-04-22 15:42:04 +05:30
Aditya Toshniwal
9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Akshay Joshi
86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30
Aditya Toshniwal
b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Pradip Parkale
8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow.
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
2022-04-05 13:40:22 +05:30
Pradip Parkale
b397ba7787 Fixed issues related to porting of properties collection and dashboard.
refs #7132
2022-04-04 17:42:42 +05:30
Akshay Joshi
38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Pradip Parkale
cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132
2) Added transaction start time to Server activity sessions view. Fixes #7215
2022-03-30 12:06:59 +05:30
Khushboo Vashi
e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal
bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Akshay Joshi
aa5b1d50b9 Fixed issues introduce by SonarQube fixes. 2022-02-01 14:11:18 +05:30
Nikhil Mohite
37d82d457c Fixed an issue where the F2 Function key removes browser panel contents. Fixes #7126 2022-01-28 10:55:23 +05:30
Akshay Joshi
0ce3434631 Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube. 2022-01-25 20:10:31 +05:30
Pradip Parkale
094129e2be Port Dependent, dependencies, statistics panel to React. Fixes #7016 2022-01-24 14:13:02 +05:30
Akshay Joshi
343c3ee49c Fixed following code smells reported by SonarQube:
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Akshay Joshi
1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Akshay Joshi
dabe64a8df Fixed enable/disable menu issue introduced by SonarQube fix. 2022-01-19 12:16:57 +05:30
Akshay Joshi
6adc1bfd42 Fixed context menu issue. 2022-01-18 18:43:34 +05:30
Akshay Joshi
9f836f5433 Fixed following code smells reported by SonarQube:
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi
e3807ec3d6 Fixed following code smells reported by SonarQube:
1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
2022-01-17 13:56:01 +05:30
Akshay Joshi
3f7e921cce Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 18:59:21 +05:30
Akshay Joshi
c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Nikhil Mohite
af6ff20020 Fixed SonarQube issues. 2022-01-07 19:58:19 +05:30
Rahul Shirsat
6528d086ba Fixed review comments:
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible

refs #7018
2022-01-06 16:46:44 +05:30
Akshay Joshi
2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Nikhil Mohite
191e2b6242 Fixed an issue where an operation error message pop up showing the database object's name incorrectly. Fixes #7078 2021-12-28 13:49:04 +05:30
Rahul Shirsat
603d91be0e Port Restore dialog to React. Fixes #7018 2021-12-28 13:45:59 +05:30
Nikhil Mohite
461c0abce1 Fixed an issue where Tablespace is created though an error is shown on the dialog. Fixes #6745 2021-12-21 18:07:17 +05:30
Akshay Joshi
92a997b16a Rearrange tools menu on the basis of usability and form groups of similar sub-menus. 2021-12-16 18:29:44 +05:30
Akshay Joshi
f24348b2b0 Fixed an issue where notifier not working when opening query tool in a new
window and then open it in the new tab.
2021-12-08 18:15:13 +05:30
Akshay Joshi
fd53e4f5f9 Replace Alertify alert and confirm with React-based model dialog. Fixes #7053 2021-12-07 18:52:40 +05:30
Ashesh Vashi
36c9eb3dfd Added support for Two-factor authentication for improving security. Fixes #6543 2021-12-02 16:47:18 +05:30
Akshay Joshi
c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Nikhil Mohite
61b440261f Ensure that sort order should be maintained when renaming a server group. Fixes #6955 2021-11-29 12:04:04 +05:30
Nikhil Mohite
3a30f27153 1. Updated notification message for the reset layout.
2. Added notification type in alertify which was missing.

refs #6988
2021-11-24 10:58:15 +05:30
Nikhil Mohite
3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Nikhil Mohite
cc91e5da94 Fixed an issue where properties of the database should not be visible after removing the database.
Fixes #6964
2021-11-18 12:36:39 +05:30
Nikhil Mohite
1408bad8ba Fixed an issue where reset layout message showing when the user opens the query tool.
refs #6988
2021-11-15 16:34:25 +05:30
Nikhil Mohite
8bf178b0a3 Reset the layout if pgAdmin4 detects the layout is in an inconsistent state. Fixes #6988 2021-11-12 11:50:37 +05:30
Pradip Parkale
a61a9e5b8f Fixed an issue where older server group name displayed in the confirmation
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Nikhil Mohite
f71e2e8040 Fixed an issue where pgAdmin is not opening properly. Fixes #6809 2021-10-29 16:17:36 +05:30
Akshay Joshi
7b85253465 Corrected some menu lables. 2021-10-27 11:05:23 +05:30
Pradip Parkale
35b1e1d0d2 Fixed pgAdmin freezing issue by providing the error message for the operation
that can't perform due to lock on the particular table. Fixes #5427
2021-10-27 10:51:52 +05:30
Rahul Shirsat
711ea3bfa1 Fixed an issue where properties panel is not updated when any object is added from the browser tree. Fixes #6859 2021-10-27 10:31:49 +05:30
Aditya Toshniwal
9de1489322 Ensure that only the table node should be allowed to drop on the ERD tool. Fixes #6929 2021-10-19 12:01:43 +05:30
Khushboo Vashi
9e3165c0ff 1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
2021-10-19 11:56:44 +05:30
Aditya Toshniwal
7f3c3fa6f9 Added support to allow tables to be dragged to ERD Tool. Fixes #6241 2021-10-16 12:43:39 +05:30
Nikhil Mohite
476d7c5fc9 Fixed background colour issue in the browser tree. Fixes #6890 2021-10-16 12:40:57 +05:30
Aditya Toshniwal
7787def660 The nodes index, RLS policy, rules, triggers are failing to save for partitions.
refs #6868
2021-10-06 16:51:46 +05:30
Aditya Toshniwal
dce5038ffd 1. Unable to create trigger for partition table. Fixes #6867.
2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868.
2021-10-06 14:54:01 +05:30
Akshay Joshi
1ed6272e7b Ensure that SQL help should work for EPAS servers. Fixes #6834 2021-10-06 14:54:01 +05:30
Khushboo Vashi
a693014371 1) Table Dialogue does not close on addition/deletion of partition. Fixes #6863
2) Nodes are loaded multiple times in server mode on 'Reset Layout'. Fixes #6861
2021-10-05 17:33:50 +05:30
Khushboo Vashi
44e1a405f0 1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839
2) Internal server error displayed if disconnect the server. Fixes #6852
2021-10-03 12:12:02 +05:30
Khushboo Vashi
5e0c113c7b Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833 2021-09-30 18:21:43 +05:30
Khushboo Vashi
aa8854db53 1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
2021-09-29 17:18:55 +05:30
Akshay Joshi
7d07770244 Reverting 'Two-factor authentication' support as it cause OSX and docker build failures.
This reverts commit 787a441343.
2021-09-29 13:24:18 +05:30
Ashesh Vashi
787a441343 Added support for Two-factor authentication for improving security. Fixes #6543 2021-09-28 17:47:00 +05:30
Aditya Toshniwal
dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Khushboo Vashi
483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
Aditya Toshniwal
0228d16990 Partition related fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
2021-09-24 16:28:55 +05:30
Akshay Joshi
ecaaa8a1b5 Fixed scrollbar issue and used flex layout in grant wizard. 2021-09-23 16:59:59 +05:30
Akshay Joshi
b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Nikhil Mohite
15a494c189 Fixed review comments for Grant Wizard.
refs #6687
2021-09-23 14:40:38 +05:30
Aditya Toshniwal
08009f8edc 1) Make default values column read-only for inherited columns when creating table.
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.

Fixes #6763
2021-09-21 16:56:29 +05:30
Nikhil Mohite
7aa213a5ce 1) Port Grant Wizard to react. Fixes #6687
2) Fixed an issue where grant wizard is unresponsive if the database size is huge. Fixes #2097
2021-09-20 13:02:41 +05:30
Rahul Shirsat
346ee6ba5f Fixed an issue where privileges not shown in catalog nodes for Properties tab. Fixes #6743 2021-09-17 20:50:29 +05:30
Aditya Toshniwal
32e97b6422 Fixed the CSS issue causing extra space at the bottom of maintenance backup dialog. 2021-09-17 20:47:03 +05:30
Aditya Toshniwal
ae49b556ce - Properties tab should refresh if node is updated. - Error should be hierarchical and not just id based. 2021-09-09 13:09:41 +05:30
Aditya Toshniwal
261cec1d20 Port Table, Column, Primary key, Foreign key, Check constraint, Unique constraint, Exclusion constraint. 2021-09-09 13:05:57 +05:30
Aditya Toshniwal
9274df0f11 - Fix Jasmine test cases failing in framework. - More stability fixes and enhancements. 2021-09-09 13:03:54 +05:30