Aditya Toshniwal
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
Akshay Joshi
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
Rahul Shirsat
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
Akshay Joshi
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
Aditya Toshniwal
26a758a0d6
Fixed an issue where copying and pasting a cell with multiple line data
...
will result in multiple rows. Fixes #5526
Fixed an old issue where quotes are not escaped when copying the cells.
As per CSV standards, if the string is in double quotes and there are
double quotes inside the string then they should be escaped with extra double-quotes.
2020-08-10 16:53:32 +05:30
Nikhil Mohite
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
Cyril Jouve
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
Rahul Shirsat
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
Akshay Joshi
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
Yogesh Mahajan
3672013ddc
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670
2020-08-07 17:17:51 +05:30
Nikhil Mohite
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
Pramod Ahire
23a12efd29
Added make file target for the coverage of JS files.
2020-08-07 16:36:48 +05:30
Akshay Joshi
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
Dave Page
d9c20de31f
Clarify some of the differences when running in server mode in the docs. Fixes #5724
2020-08-07 10:07:28 +01:00
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Pramod Ahire
68a5027d15
Added ability to generate code coverage reports for java script files.
2020-08-07 12:27:12 +05:30
Akshay Joshi
48ec4085d2
Update the sshtunnel version to v0.1.5.
...
refs #4361
2020-08-06 17:17:27 +05:30
Aditya Toshniwal
e494b1520d
Fixed an issue where ajax call continues to fire even after disconnect the database server. Fixes #5716
2020-08-06 16:52:16 +05:30
Akshay Joshi
aac0da4cbc
Fixed ssh tunnel hang issue when the user tries to disconnect the server. Fixes #4361
2020-08-06 16:16:37 +05:30
Yogesh Mahajan
48737e6a02
Fixed code smell 'String literals should not be duplicated' reported by SonarQube.
2020-08-06 12:42:19 +05:30
Nikhil Mohite
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
Yogesh Mahajan
e3dfe03a2a
Fixed an issue where the user is not able to insert the data if the table and columns name contains special characters. Fixes #4387
2020-08-06 12:30:10 +05:30
Nikhil Mohite
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Murtuza Zabuawala
d2621282dc
Change the scope of '.dashboard-graph-body' CSS class to prevent it from affecting other places.
2020-08-05 12:30:09 +05:30
Akshay Joshi
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
Yogesh Mahajan
43e127de31
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
2020-08-03 13:18:04 +05:30
Akshay Joshi
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Nikhil Mohite
eb2c554601
Fixed cognitive complexity issues reported by SonarQube.
2020-08-03 12:46:34 +05:30
Satish V
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
Shubham Agarwal
32d904058a
Fixed SonarQube issues.
2020-08-03 11:44:27 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
Akshay Joshi
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
Nikhil Mohite
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
Akshay Joshi
099fea15ae
Fixed code smells in runtime code reported by SonarQube.
2020-07-29 18:26:41 +05:30
Rahul Shirsat
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
Satish V
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
Akshay Joshi
510dd5c047
1) Fixed pgAdmin hang issue when the user clicks on 'View Log' menu option.
...
2) Fixed some code smell in runtime code.
2020-07-29 15:31:38 +05:30
Aditya Toshniwal
f715373218
Replace charting library Flotr2 with ChartJS using React. Fixes #3904
2020-07-29 14:49:22 +05:30
Dave Page
5820b9521e
Make sure the version check is compatible with older versions of Qt
2020-07-29 09:36:27 +01:00
Dave Page
6fc6ec1cda
Correct TLS certificate filename in the container deployment docs. Fixes #5708
2020-07-29 09:26:12 +01:00
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Dave Page
46ba0310fa
Make the runtime configuration dialog non-modal. Fixes #5490
...
Major refactoring of the runtime code, Specifically:
- Move the bulk of the core code from main() into a new Runtime class.
- Break up the mass of code that was main() into a number of relatively simple functions.
- Make the Configuration dialog synchronous so the Log dialog can be properly viewed.
- Enable/disable menu options at the right time.
- Remove support for Qt < 5.0.
- Remove the application name constant and hardcode the name to simplify the code.
- Improve log messages.
- Replace the sdbm hashing with Qt's MD5 hashing.
2020-07-28 16:13:05 +05:30
Akshay Joshi
ed0dc62b69
Fixed incorrect import statement for urlopen.
...
refs #5700
2020-07-27 17:33:44 +05:30
Akshay Joshi
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
Dave Page
f57558fdb2
Add a --yes command line option to setup-web.sh to allow non-interactive use. Fixes #5610 .
2020-07-27 06:29:01 -04:00
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Akshay Joshi
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
Yogesh Mahajan
043025d1eb
Fixed an issue where the user is not able to save the new row if the table is empty. Fixes #4810
2020-07-24 14:30:22 +05:30