Commit Graph

932 Commits

Author SHA1 Message Date
Pravesh Sharma
43022b7aa2 Fixed 'ternary operators should not be nested' code smell. 2022-09-10 14:00:22 +05:30
Yogesh Mahajan
cbf5886430 Fixed the following code smells:
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.
2022-09-10 13:48:14 +05:30
Akshay Joshi
3b95a416ca Fixed 'Remove the unnecessary boolean literals' code smell. 2022-09-09 15:23:18 +05:30
Akshay Joshi
b73aa6d000 Fixed 'Remove the unnecessary boolean literals' code smell 2022-09-08 20:28:43 +05:30
Akshay Joshi
b8f63adf41 Fixes following code smell reported by SonarQube:
1) Replace this if-then-else flow by a single return statement
 2) Remove the unnecessary boolean literals.
2022-09-08 19:56:02 +05:30
Akshay Joshi
7086719640 Fixed SonarQube issues. 2022-09-08 18:08:58 +05:30
Yogesh Mahajan
603ce21d24 Fixed an issue where textarea of the JSON Editor does not resize with dialog. Fixes #7656 2022-09-08 15:31:36 +05:30
Nikhil Mohite
0c9c57e608 1. Resolved resize window issue for DDL result panel.
2. Updated the Screenshots.
3. Updated server group title to bold.

refs #6133
2022-09-08 15:24:43 +05:30
Akshay Joshi
18b77f15dd Remove Alertify from pgAdmin completely. Fixes #7619 2022-09-08 15:16:48 +05:30
Nikhil Mohite
e1942d8c9e 1) Port schema diff to React. Fixes #6133
2) Remove SlickGrid.
2022-09-07 19:20:03 +05:30
Aditya Toshniwal
0f46f070ed Port the remaining components of the ERD Tool to React. Fixes #7343
1. Make use of MUI styles and remove SCSS.
2. Use the new common components for buttons and tooltips, so that they are consistent.
3. UI design should be aligned with the query tool.
4. Remove tippyjs and Alertify dependencies.
2022-09-06 18:09:13 +05:30
Akshay Joshi
e58b9c767b Port search object dialog to React. Fixes #7622 2022-08-30 17:08:12 +05:30
Yogesh Mahajan
71a4b20d90 Fixed some SonarQube issues. 2022-08-30 14:21:33 +05:30
Akshay Joshi
af1e9210b9 Fixed some security hotspots. 2022-08-26 18:58:16 +05:30
Yogesh Mahajan
41a3345101 Fixed an issue where the cursor was not visible in the code tab of the trigger dialog. 2022-08-23 18:45:43 +05:30
Nikhil Mohite
5c04f1aa2e 1) Ensure that the autofocus is on the input control for the master password and server password dialogs. Fixes #7633
2) Fixed an XSS vulnerability in the Hostname/Address control in the Server Connection dialog.
2022-08-22 15:58:17 +05:30
Aditya Toshniwal
09e2c0eac0 1. Explain plan crashes query tool after SonarQube fixes.
2. Fix XSS issue in query tool.
3. Process details for cloud process not showing complete command.
4. Confirm dialog before removing processes.
2022-08-18 18:42:03 +05:30
Aditya Toshniwal
306b184e11 1. Fixed an issue where Alt-Shift-Q didn't work after creating a new query. Fixes #7575
2. Fixed an issue where the Query Editor loses focus when saving a query (Alt+s). Fixes #7521
3. Ensure that an error is thrown if clipboard access is not provided and change the copy rows shortcut. Fixes #7452
2022-08-17 17:23:44 +05:30
Aditya Toshniwal
b12c1f8740 1. Stop process of Process details dialog not working.
2. When a server of an in progress cloud deployment is expanded, it is throwing a failed error.
3. Close the process notification on clicking View Processes.

Fixes #3709
2022-08-16 17:58:02 +05:30
Akshay Joshi
ef91207669 1) Fixed an issue where an existing user is deleted and recreated again in the User Management dialog. Fixes #7618
2) Fixed preferences issue when changing themes.
3) Added validation for user names that already exist.
2022-08-16 17:28:45 +05:30
Akshay Joshi
1e94c3bd81 Fixed Security Hotspot reported by SonarQube. 2022-08-14 07:09:45 +05:30
Aditya Toshniwal
c2b23465cc 1) Added support to show all background processes in separate panel. Fixes #3709
2) Port process watcher to React. Fixes #7404
2022-08-11 10:49:45 +05:30
Akshay Joshi
271b6d91fc Port User Management dialog to React. Fixes #7345 2022-08-11 10:25:52 +05:30
Aditya Toshniwal
8b7ce2c276 Port change user password and 2FA dialog to React. Fixes #7568 2022-08-10 18:02:54 +05:30
Nikhil Mohite
9c418188ee Fixed SonarQube issues. 2022-08-10 15:05:20 +05:30
Aditya Toshniwal
f5793e9a7a Fixed SonarQube issues. 2022-08-09 15:42:16 +05:30
Akshay Joshi
d1c94ac73d Fixed SonarQube issues. 2022-08-05 18:58:03 +05:30
Akshay Joshi
53887c32bf Port change ownership dialog to React. Fixes #7590 2022-08-05 14:11:17 +05:30
Akshay Joshi
95312f2d14 1) Ensure that autocomplete does not appear when navigating code using arrow keys. Fixes #7573
2) Fixed an issue where autocomplete is not working after clearing the query editor. Fixes #7563
2022-08-01 14:38:32 +05:30
Akshay Joshi
81b0d1138b Remove Alertify dialog from Grant Wizard, Import/Export Servers and Cloud. 2022-07-28 10:14:04 +05:30
Akshay Joshi
81f52a82c8 Port About dialog to React. Fixes #7567 2022-07-28 10:11:40 +05:30
Aditya Toshniwal
a7fd7d67b3 1. Intermittently failing test cases.
2. Dialog vertical position should be more on the upper side.
3. File not supported error is not showing.

refs #7313
2022-07-25 11:48:27 +05:30
Aditya Toshniwal
4808df5e95 1) Port the file/storage manager to React. Fixes #7313
2) Allow users to delete files/folders from the storage manager. Fixes #4607
3) Allow users to search within the file/storage manager. Fixes #7389
4) Fixed an issue where new folders cannot be created in the save dialog. Fixes #7524
2022-07-19 15:27:47 +05:30
Akshay Joshi
4585597388 Added option to trigger autocomplete on key press in the query tool. Fixes #4488 2022-07-19 11:55:37 +05:30
Akshay Joshi
9cdcad7a88 1) Keep the selected columns for the X and Y-axis.
2) Lighten the color of the stacked line chart.
2022-07-06 18:58:15 +05:30
Yogesh Mahajan
59f5c0d955 Added support for Azure PostgreSQL deployment in server mode. Fixes #7522 2022-07-06 11:43:49 +05:30
Akshay Joshi
7414394ceb Fixed the following issues in the Graph Visualiser:
1) Change all theme's color codes.
 2) Bar graph for the first and last labels on the X-axis does not display all the bars.
 3) Make the graphs always start from zero on the Y-axis.
2022-07-05 18:44:20 +05:30
Akshay Joshi
8b62cd1f04 Added support for visualise the graph using a Pie chart in the query tool. Fixes #7487 2022-07-05 10:47:17 +05:30
Nikhil Mohite
b283c0ba18 Port Master Password dialog to React. Fixes #7342 2022-07-04 12:16:23 +05:30
Aditya Toshniwal
86b30b3c83 Theme component usage has been fixed, a component should never be wrapped in multiple Theme components. 2022-06-30 15:18:20 +05:30
Akshay Joshi
b92e2fcfc9 Added support for visualizing the graphs using Stacked Line, Bar, and Stacked Bar charts in the query tool. Fixes #7486 2022-06-30 12:38:48 +05:30
Akshay Joshi
b804f7db03 Reset the zoom before destroying the chart. 2022-06-28 14:31:08 +05:30
Nikhil Mohite
45adff6087 Set the position of the dialog to the center of the screen. 2022-06-24 15:14:10 +05:30
Akshay Joshi
2556771c32 The following issues were fixed in Graph Visualiser:
1) Allow the user to set the row limit and chart line width.
2) Zoom should only be applied to X-axis, not both.
3) On clicking the 'Generate' button, the chart should return to its original zoom level.
4) Negative values are not displayed.

refs #7485
2022-06-23 14:52:11 +05:30
Nikhil Mohite
d90b2621da Fixed an issue where passwords entered in the 'Connect To Server' dialog were truncated. Fixes #7440 2022-06-22 17:35:22 +05:30
Akshay Joshi
93bc1f3c57 Added support for visualise the graph using a Line chart in the query tool. Fixes #7485 2022-06-22 17:18:51 +05:30
Nikhil Mohite
2adca6bbc4 1) Added mouse over indication for breakpoint area in the Debugger. Fixes #2647
2) Added search text option to the Debugger panel. Fixes #2648
3) Port Debugger to React. Fixes #6132
2022-06-15 11:37:54 +05:30
Yogesh Mahajan
7e1e068370 Added capability to deploy PostgreSQL servers on Microsoft Azure. Fixes #7178 2022-06-15 11:22:42 +05:30
Akshay Joshi
3381516013 Upgrade Chartjs to the latest 3.8.0. Fixes #7469 2022-06-13 17:26:17 +05:30
Aditya Toshniwal
725726f083 Ensure that the Query Editor should be focused when switching between query tool tabs. Fixes #7441 2022-06-13 14:26:01 +05:30
Aditya Toshniwal
ea3203f466 Fixed and issue where 'Use spaces' not working in the query tool. Fixes #7443 2022-06-13 11:46:09 +05:30
Khushboo Vashi
e1c5a06bf0 Fixed some cloud deployment issues:
- Added High Availability option
 - Server group renamed to pgAdmin server group
 - Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.
2022-06-09 14:07:05 +05:30
Nikhil Mohite
e3225b6565 Fixed the browser tree overlapping nodes and expansion issue. Fixes #6962 2022-05-28 13:26:17 +05:30
Pradip Parkale
a5ad956088 Ensure that when Authentication buttons are disabled their text is visible in the Dark and High contrast theme. Fixes #7347 2022-05-24 17:12:37 +05:30
Khushboo Vashi
345cfd7c60 Ensure that unwanted APIs should not be getting called for BigAnimal. Fixes #7368
Updated the BigAnimal icon.
2022-05-24 11:34:23 +05:30
Akshay Joshi
4f7bcc2919 Added the ability to detect and warn users about bidirectional Unicode characters. Fixes #7002 2022-05-23 16:04:21 +05:30
Pradip Parkale
11cfea3860 Added the ability to resize columns on dashboard tables. Fixes #7364 2022-05-18 17:49:54 +05:30
Nikhil Mohite
ae0624ae8a Fixed an issue where Preferences are not saved when the dialog is maximized. Fixes #7383 2022-05-17 11:06:14 +05:30
Akshay Joshi
44f9ba4a57 Port connect server password dialog to React. Fixes #7337 2022-05-16 16:21:14 +05:30
Aditya Toshniwal
ca8e14455f Fixed the following issues:
1. Feature test cases for the new query tool.
 2. Query tool panel rename is not persisting.
2022-05-12 18:29:09 +05:30
Aditya Toshniwal
1135821870 Fix Query tool issues:
1. Warning/Confirm dialogs should be inside the query tool.
2. The Help button in View/Edit data should open the corresponding help page.
3. Disable execute options when query tool in transaction.
4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then.
5. NOTICE messages should not be part of Notifier success popups.

Fixes #7350
2022-05-09 12:39:29 +05:30
Aditya Toshniwal
64ffed0ddb 1. Filter dialog doesn't work in edit mode (getting back end errors), reverting it back to create mode of SchemaView.
2. Enable the copy button when a cell is selected.
3. Exclude, Include related fixes.
2022-04-29 16:29:46 +05:30
Pradip Parkale
a0c85431dc Ensure that the Dashboard column sort order should be remembered when the refresh button is clicked. Fixes #7339 2022-04-29 10:26:24 +05:30
Aditya Toshniwal
bd799ea51a Autofocus CodeMirror SQL input to the first element of a form. 2022-04-28 14:09:27 +05:30
Pradip Parkale
7c61017f57 Fixed an issue where the Dashboard Server Activity was showing old queries as active. Fixes #7305 2022-04-28 12:10:42 +05:30
Khushboo Vashi
7d91cca14d 1) Fixed linter error.
2) Fixed an issue where a password popup will appear on disconnecting from the server.
2022-04-26 18:16:33 +05:30
Khushboo Vashi
5677b1e5f8 Added capability to deploy PostgreSQL servers on EDB BigAnimal. Fixes #7179 2022-04-26 16:41:10 +05:30
Aditya Toshniwal
0795b22ae6 Fixed the following issues for the new query tool:
1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.
2022-04-26 16:27:53 +05:30
Aditya Toshniwal
25b89f7624 Fixed the following issues for the new query tool:
1) Failed to fetch query history error sometimes.
 2) In copy paste row, if a copied row has [null], then those are pasted as an empty string.
 3) When Data output is empty, show an empty grid.
 4) Schema diff generates a script button resulting in an empty window. Fixes #7306.
 5) Detach the DataOutput panel > Try editing text cell > Text editor is hidden behind the data output panel

refs #6131
2022-04-25 18:11:39 +05:30
Aditya Toshniwal
c5ca394cec 1. Add min width to panels.
2. Fix issues related to New connection in query tool. Also fixed some existing bugs related to this.

refs #6131
2022-04-22 18:17:01 +05:30
Aditya Toshniwal
e5ef6a7b21 Fixed following issues for Query Tool (after React Porting):
1) Find/Replace both opens the same dialogue box.(by clicking menu option)
2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)
3) Fixed CSS issues of slickgrid at various places.
4) C should be captial in ’<New connection…>'
5) In pop title for New Connection, all words should be capital.(Add new connection)
6) Explain > Analaysis tab > Column heading missing ROWS PLAN with cost & In explain only.
7) Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number.
8) Boolean default is not considered while ading new row.(try table from feature test defaults)
9) In query history , when not query history present, warning icon size big. Match it to warning message - No history found
10) Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown. Existing issue, fixed.
11) Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited.

refs #6131
2022-04-20 19:02:16 +05:30
Aditya Toshniwal
9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Pradip Parkale
131ff4de48 Ensure that sorting should be preserved on refresh for Server Activity. Fixes #7308 2022-04-14 11:11:45 +05:30
Khushboo Vashi
0b7bde2775 Fixed an issue where the Browser panel is not completely viewable. Fixes #7026 2022-04-13 17:37:34 +05:30
Akshay Joshi
86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30
Aditya Toshniwal
a91762fb30 Ensure that Columns should always be visible in the import/export dialog. Fixes #7252 2022-04-11 17:25:19 +05:30
Pradip Parkale
c2f1a7bdc5 Ensure the database and schema restriction controls are not shown as a drop-down. Fixes #7255 2022-04-09 12:09:35 +05:30
Aditya Toshniwal
b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Pradip Parkale
8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow.
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
2022-04-05 13:40:22 +05:30
Aditya Toshniwal
953a9d7fd1 Fixes some issues and improves the PgTable component. 2022-04-05 12:10:51 +05:30
Nikhil Mohite
56a4263a5c Fixed an issue in loading user details on the properties panel. Fixes #7287 2022-04-05 11:19:24 +05:30
Aditya Toshniwal
4fff26c571 Makes some improvements/restructurings to the PgTable component. 2022-04-04 19:06:43 +05:30
Pradip Parkale
b397ba7787 Fixed issues related to porting of properties collection and dashboard.
refs #7132
2022-04-04 17:42:42 +05:30
Akshay Joshi
38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Nikhil Mohite
07527ba69b Fixed maximize button issue on the preferences dialog.
refs #7149
2022-04-03 12:27:47 +05:30
Pradip Parkale
fe416c838b Fixed an issue where the browser tree state was not preserved correctly. Fixes #7176 2022-03-31 18:28:36 +05:30
Nikhil Mohite
74c620e478 Fixes the arrow key issue in the preferences tree. Fixes #7274
Ensure that the select folder dialog should be on top when selecting the binary path. Fixes #7276
2022-03-31 11:46:34 +05:30
Pradip Parkale
cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132
2) Added transaction start time to Server activity sessions view. Fixes #7215
2022-03-30 12:06:59 +05:30
Nikhil Mohite
931a399890 Fixed issues in the Preferences:
1) Show a single note in the binary path.
  2) Resolved issue in the keyboard shortcut.

refs #7149
2022-03-29 16:27:33 +05:30
Nikhil Mohite
08e00ccebc Fixed an issue where the newly added table is not visible under the Tables node on refresh. Fixes #7239 2022-03-29 14:40:54 +05:30
Aditya Toshniwal
903b300b9e 1) Added support for unique keys in ERD. Fixes #7249
2) Fixed an issue where foreign key relationships do not update when the primary key is modified. Fixes #7197
2022-03-28 16:26:43 +05:30
Nikhil Mohite
0b4a874f30 Fixed an issue where unexpected error messages are displayed when users change the language via preferences. Fixes #7267 2022-03-24 16:08:13 +05:30
Aditya Toshniwal
7f2e87b27d Fixed Jasmine test cases. 2022-03-24 12:05:59 +05:30
Nikhil Mohite
2f37f0ca51 Fixes for the preferences dialog
1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in Query Tool -> Result grid.
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149
2022-03-23 13:28:35 +05:30
Nikhil Mohite
74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Aditya Toshniwal
f9707a8bf5 Allow users to scroll and enter input when there is a validation error. Fixes #7172 2022-03-04 17:25:36 +05:30
Khushboo Vashi
69069e9af3 The following issues related to cloud deployment have been resolved:
- Masking the credentials input fields
- The loading symbol doesn't work while reloading the options in the select control
- Reduce the wizard opening timeout
- urllib library upgrade impacts host IP fetch

refs #7177
2022-03-02 19:04:15 +05:30
Aditya Toshniwal
44b2f49839 Enhances the modal provider to make it more reusable. 2022-02-23 14:27:48 +05:30
Khushboo Vashi
e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal
bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30