Commit Graph

1839 Commits

Author SHA1 Message Date
Murtuza Zabuawala
c15d814268 Clear the messages tab when running EXPLAIN/EXPLAIN ANALYZE. Fixes #2974 2018-01-03 15:19:56 +00:00
Murtuza Zabuawala
e21f1e3291 Prevent multiple connections to new slow-to-respond servers being initiated in error. Fixes #2928 2018-01-03 14:49:08 +00:00
Khushboo Vashi
49dfd6fe31 Ensure invalid options can't be selected on triggers on views. Fixes #2945 2018-01-03 14:32:00 +00:00
Khushboo Vashi
90629da524 Close user language preference drop down when it loses focus. Fixes #2956 2018-01-03 13:36:49 +00:00
Murtuza Zabuawala
1dd1c10255 Do not decrypt the password when the password is 'None'. Fixes #2765
This should avoid the common but harmless exception "ValueError: IV must be 16 bytes long while decrypting the password."
2018-01-03 13:19:58 +00:00
Khushboo Vashi
e64bc2a821 Show complete SQL for FTS dictionaries. Fixes #2949 2018-01-03 13:16:11 +00:00
Harshal Dhumal
88bcd3b512 Make the query tool datatype test easily configurable and extendable and add support for multi-dimensional arrays and enums. 2017-12-18 15:10:47 +00:00
Begina Felicysym
ebd096f5cc Updated Polish translation from Begina. Extract/update/compile as well for completeness. Current status:
1480 of 1857 messages (79%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1692 of 1857 messages (91%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1827 of 1857 messages (98%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1829 of 1857 messages (98%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1435 of 1857 messages (77%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-12-18 10:08:03 +00:00
Murtuza Zabuawala
3fe655e944 Allow selection of validation error text. Fixes #2954 2017-12-18 10:03:39 +00:00
Murtuza Zabuawala
eae6f05b7c Allow files to be opened by double clicking on them. Fixes #2810 2017-12-18 09:48:14 +00:00
Murtuza Zabuawala
36d779df5d Add tab indexes for debugger controls. 2017-12-18 09:23:11 +00:00
Murtuza Zabuawala
bceb6aef3c Don't try to render security URLs in desktop mode. Fixes #2952. Fixes #2922 2017-12-18 09:15:36 +00:00
Murtuza Zabuawala
937984f2dc Don't un-comment code with alt+. in the query tool. It's only supposed to respond to ctrl/cmd+. Fixes #2769 2017-12-13 15:58:00 +00:00
Khushboo Vashi
107795db10 Ensure column collation isn't lost when changing field size. Fixes #2779 2017-12-13 15:44:10 +00:00
Murtuza Zabuawala
96a2987ef6 Prevent attempts to select directories as files in the file dialogue. Fixes #2937 2017-12-13 15:35:08 +00:00
Murtuza Zabuawala
c5d1fc8189 Ensure the datatype cache is updated when a domain is added. Fixes #2778 2017-12-13 15:17:17 +00:00
Dave Page
b2e844c0ad Fix label inconsistency spotted by Susan. 2017-12-13 14:59:15 +00:00
Murtuza Zabuawala
4246a3b22f Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720 2017-12-13 13:28:07 +00:00
Harshal Dhumal
55254a649f Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. 2017-12-13 11:53:27 +00:00
Khushboo Vashi
0c5a5ba9c2 Add support for editing data in tables with OIDs but no primary keys. Fixes #2849.
This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh.
2017-12-13 10:28:31 +00:00
Dave Page
4bcec932a3 Correct names for the Japanese translators:
Junichi Tado
Kosuke Kida
Nozomi Anzai
2017-12-07 21:31:46 +09:00
Murtuza Zabuawala
22c38e4562 Fix a reference before assignment error in the file dialogue. Fixes #2934 2017-12-06 13:42:05 +09:00
Murtuza Zabuawala
f5718b9d56 Misc fixes for the pgAgent module:
1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921

2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749

3) Fixed UI issue where validation error was not displaying properly for Datetime control.
2017-12-06 12:25:45 +09:00
Chethana Kumar
c74b348bac Update EXPLAIN icons. Fixes #2936 2017-12-06 11:45:02 +09:00
Murtuza Zabuawala
7fab041623 Prevent the user pressing the select button in the file manager when it is supposed to be disabled. Fixes #2923 2017-12-05 13:43:02 +09:00
Murtuza Zabuawala
136ed0d3e2 Fix debugging of self-referencing functions. Fixes #2524 2017-12-05 13:32:06 +09:00
Murtuza Zabuawala
bac9c77c4e Cleanup some inconsistent error dialog titles. Fixes #2098 2017-12-02 05:12:40 +00:00
Harshal Dhumal
1a4e21e6dd Fix regression tests for password reset in server mode 2017-11-30 13:16:59 +00:00
Harshal Dhumal
f3256aef71 Don't login the user with every request in desktop mode. Just do it once. Fixes #2922 2017-11-30 12:02:41 +00:00
Harshal Dhumal
35a5cf22d5 Refuse password changes (and tell the user) if the notification email cannot be sent. Fixes #2892 2017-11-30 11:16:38 +00:00
Murtuza Zabuawala
2995d6e9c5 Fix the width of Role dialogue so tabs don't wrap. 2017-11-30 10:58:27 +00:00
Murtuza Zabuawala
389cf01af7 Cleanup the layout of the filter data dialogue. Fixes #2924 2017-11-30 10:53:48 +00:00
Ashesh Vashi
d54c35d74f Fixing the lint error messages in javascript using 'eslint --fix'
command.
2017-11-30 13:01:41 +05:30
Akshay Joshi
ea82d92e41 Do not show success message, when there is an error saving the data in
the DataGrid.

Fixes #2907
2017-11-30 13:01:30 +05:30
Akshay Joshi
281b6c91b5 Using the correct type name (along with the internal name) while
generating the query for update/insert table data (Data grid).

Modified by Ashesh for array support.

Fixes #2830
2017-11-30 13:01:30 +05:30
Murtuza Zabuawala
f10733e8d4 Ensure the auto-complete selection list can display longer names. Fixes #2726 2017-11-29 11:14:24 +00:00
Murtuza Zabuawala
362bd15c8e Format JSON/JSONB nicely when displaying it in the grid editor pop-up. Fixes #2748 2017-11-28 14:21:31 +00:00
Khushboo Vashi
5bfa450a5f Allow form validation messages to be close in case the eclipse anything on the form. Fixes #2859 2017-11-28 14:10:12 +00:00
Murtuza Zabuawala
9ae4a03784 Allow changing of the users password without leaving the app. Fixes #2891 2017-11-28 10:55:54 +00:00
Navnath Gadakh
035c134fed Cleanup properly after running the Foreign Table test cases. 2017-11-28 09:44:28 +00:00
Harshal Dhumal
7db7da5b0e Display process output as it happens. Fixes #2811 2017-11-27 13:00:47 +00:00
Navnath Gadakh
80c4a3fb1a Use sufficiently long random strings in test objects to avoid conflicts. 2017-11-27 12:01:50 +00:00
Murtuza Zabuawala
fe7cfa35df Attempt to decode database errors based on lc_messages. Fixes #2806. Fixes #2821 2017-11-27 11:53:25 +00:00
Murtuza Zabuawala
d614c88ada Ensure we don't show the full path on the server when using virtual filesystem roots in server mode for SSL certs. Fixes #2866 2017-11-27 11:25:50 +00:00
Harshal Dhumal
05a00f4ac8 Make the "Save Changes" prompts in the query tool optional. Fixes #2845 2017-11-23 09:20:59 +00:00
Murtuza Zabuawala
38f111d969 Ensure the scroll location is retains in the query tool data grid if the user changes tab and then returns. Fixes #2875 2017-11-23 09:07:46 +00:00
Murtuza Zabuawala
fdb4fa454a Honour whitespace properly in the data grid. Fixes #2880 2017-11-22 16:48:36 +00:00
Murtuza Zabuawala
1bc318f091 Ensure newly added rows cannot be editted until we have key values. Fixes #RM2886 2017-11-22 16:38:18 +00:00
Murtuza Zabuawala
f0db93cefd Improve clarity of the boolean checkbox. 2017-11-22 16:28:08 +00:00
Murtuza Zabuawala
930dd8af1f Some browsers don't properly support tri-state checkboxes, so create our own control to handle true/false/null. Fixes #2848 2017-11-21 17:22:25 +00:00
Murtuza Zabuawala
b284572afe Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 2017-11-21 16:28:01 +00:00
Harshal Dhumal
9212699936 When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 2017-11-21 15:59:44 +00:00
Murtuza Zabuawala
dd8e2fe8a6 Quote the owner name when creating types. Fixes #2787 2017-11-21 11:32:27 +00:00
Murtuza Zabuawala
a85538a1fc Remove the artificial limit of 4000 characters from text areas. Fixes #2877 2017-11-21 11:02:21 +00:00
Neel Patel
5b5363e2c4 _blank is the correct HTML target for anchors, not _new. Fixes #2679. 2017-11-21 10:19:11 +00:00
Khushboo Vashi
4568fe22f7 Decode the field separator and quote char if needed. 2017-11-20 16:28:13 +00:00
Khushboo Vashi
0c566f132e Allow configuration of CSV and clipboard formatting of query results. Fixes #2781 2017-11-20 13:50:47 +00:00
Murtuza Zabuawala
2579458091 Fix support for time without timezone. Fixes #2881 2017-11-20 13:36:50 +00:00
Murtuza Zabuawala
5fd3a7dd3d Display relevant error messages when access is denied creating a schema. Fixes #2094 2017-11-20 13:31:03 +00:00
Harshal Dhumal
051788d040 Fix a referenced before assignment bug in connection management. Fixes #2868 2017-11-16 12:40:00 +00:00
Murtuza Zabuawala
537f6f0ab1 Display long names appropriately in dialogue headers. Fixes #2278 2017-11-16 11:56:05 +00:00
Murtuza Zabuawala
af2722faa3 Focus on the filter textarea when opening filter options in the query tool. 2017-11-16 11:01:40 +00:00
Alexander Lakhin
8f070f6095 Fix utility output capture encoding. Fixes #2854 2017-11-09 08:51:56 -05:00
Alexander Lakhin
3e1caa61e1 Russian translation update. 2017-11-09 08:45:56 -05:00
Dave Page
35b57477de Remove data grid icon for consistency with other menu options. 2017-11-07 21:20:01 -05:00
Murtuza Zabuawala
be0e637718 Prevent error messages covering the last row in a grid. Fixes #2850 2017-11-07 21:07:30 -05:00
Khushboo Vashi
88cd68c2b9 Add an option to manually count rows in tables to render the properties. Fixes #2846 2017-11-07 20:27:10 -05:00
Murtuza Zabuawala
8b543a58fe Fix a number of graphical explain rendering issues. Fixes #2824. Fixes #2842. Fixes #2843. 2017-11-06 19:59:01 -05:00
Alexander Lakhin
187ab22d90 Further missing translation fixes. Stats now:
1481 of 1831 messages (80%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1831 messages (92%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1748 of 1831 messages (95%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1831 messages (95%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1831 messages (78%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-06 19:49:20 -05:00
Chethana Kumar
2be418706d Updated colours of tree view icons, which is to be more comfortable in identifying. 2017-11-06 13:03:03 +05:30
Begina Felicysym
62e70f3c4f Update Polish translation.
1748 of 1750 messages (99%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
2017-11-05 08:36:24 -05:00
Alexander Lakhin
f15f46592a Tag some translations that were not, well, tagged. Current stats:
1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1472 of 1777 messages (82%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1750 of 1777 messages (98%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1777 messages (80%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-05 08:32:26 -05:00
Dave Page
b2186db562 Revert "Fix a number of cases where strings were not properly marked for translation."
This reverts commit 1f23838a4c due to unintended side
effects it caused - specifically, expanding Databases on the treeview displayed
Servers again
2017-11-03 16:45:20 +00:00
Alexander Lakhin
1f23838a4c Fix a number of cases where strings were not properly marked for translation. 2017-11-03 13:10:42 +00:00
Khushboo Vashi
f73ce2dfc3 Ensure estimated rows are included correctly in CREATE script for functions. Fixes #2651 2017-11-02 09:47:31 +00:00
Murtuza Zabuawala
897bf4857a Fix counted rows display in table properties. Fixes #2836 2017-11-02 09:35:44 +00:00
Alexander Lakhin
2dcd2cc77f Update Russian translation. 2017-11-01 20:23:59 +00:00
Dave Page
70d31be496 Another message catalog update. Stats:
1481 of 1750 messages (84%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1694 of 1750 messages (96%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1472 of 1750 messages (84%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1706 of 1750 messages (97%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1436 of 1750 messages (82%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-01 15:19:19 +00:00
Alexander Lakhin
23d431fb54 Remove more exclamation marks from error messages. 2017-11-01 15:18:07 +00:00
Dave Page
635d944e03 Message catalog update. Current stats look like:
1503 of 1756 messages (85%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po
1716 of 1756 messages (97%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po
1494 of 1756 messages (85%) translated in pgadmin/translations/pl/LC_MESSAGES/messages.po
1728 of 1756 messages (98%) translated in pgadmin/translations/ru/LC_MESSAGES/messages.po
1458 of 1756 messages (83%) translated in pgadmin/translations/zh/LC_MESSAGES/messages.po
2017-11-01 13:01:02 +00:00
Alexander Lakhin
9be1364d1a Various string improvements and fixes. 2017-11-01 12:58:19 +00:00
Dave Page
6a5ac730a0 Update translations 2017-10-31 09:10:17 +00:00
Alexander Lakhin
706ef38e95 Add a Russian translation 2017-10-31 09:10:00 +00:00
Alexander Lakhin
8860bc3c3e Saved user language was not being picked up in case of non-server mode.
Because - the get_locale(...) function was being executed before any
request, and user login after first request. Hence - the values for
the labels in the Preferences are not being translated properly.

Fetch the raw value of user_language from configuration in case of
runtime/non-server mode to fix the issue.
2017-10-30 18:20:41 +05:30
Dave Page
bc0320d21e Add a Japanese translation created by:
Junichi Tado
Nozomi Amzai
Kouske Kida
2017-10-27 14:00:09 +02:00
Dave Page
61e809b636 Update message catalogs. 2017-10-27 13:59:03 +02:00
Alexander Lakhin
0a1cf30abb Return the translations, and not empty array from the
'translations.js'.

It was regression of the commit-id:
4a91bcde30
2017-10-24 18:50:26 +05:30
Ashesh Vashi
c53c6d2f48 Using 'categroy_id' instead of 'cid' in the preferences Backbone.Model,
as it is used by the Backbone.Collection to get the object by id.
2017-10-24 18:47:36 +05:30
Dave Page
890fece73a Fix check constraint regression tests. 2017-10-16 16:01:07 +01:00
Murtuza Zabuawala
784f3f59d8 Fix name of 'check-constraints' to follow the usual singular convention. 2017-10-16 15:40:15 +01:00
Murtuza Zabuawala
0cb57848f8 Ensure auto-indent honours the spaces/tabs config setting. Fixes #2780 2017-10-16 15:37:03 +01:00
Murtuza Zabuawala
ce5f5015b3 Use HTTPS for accessing help docs. 2017-10-16 09:21:02 +01:00
Neel Patel
56e1fd85f4 Ensure line numbers form CodeMirror don't appear on top of menus. Fixes #2738 2017-10-12 10:07:18 +01:00
Harshal Dhumal
04beec1309 Fix various issues that could cause an exception on startup. Fixes #2713 2017-10-10 09:50:47 +01:00
Murtuza Zabuawala
2f5a2b2392 Only allow specification of a pgpass file if libpq >= 10. Fixes #2768 2017-10-10 09:31:27 +01:00
Murtuza Zabuawala
63103c7a48 Remove panels for www.pgadmin.org and www.postgresql.org as they won't work with X-Frame-Options: SAMEORIGIN which is used now. 2017-10-10 09:16:23 +01:00
Khushboo Vashi
91406d2879 Ensure HTMLMIN is only used with Python 2.7+ 2017-10-10 09:14:23 +01:00
Murtuza Zabuawala
f2929046fa Refactor to remove duplicate code for the cancel/terminate buttons in the dashboard. 2017-10-09 09:18:46 +01:00
Ashesh Vashi
5860de838a Changed the wording for 'Terminated session successfully' 2017-09-29 20:20:27 +05:30
Ashesh Vashi
4b2b08174c Do not show the terminate session icon in red as per Dave 2017-09-29 20:17:51 +05:30
Ashesh Vashi
2b64834179 Allow to terminate a session from the server, and database dashboard. 2017-09-29 20:10:33 +05:30
Ashesh Vashi
0d754fc39f Remove the reference of font-mfizz completely. 2017-09-29 11:26:45 +05:30
Ashesh Vashi
9c6c32e936 Resolved the logo issue.
For some unknown reason, font-mfizz was showing the slonik icon in
italic. Even after upgrading it to the latest version of font-mfizz, the
problem was not resolved.

So - instead of using the vector font, using the PostgreSQL SVG logo as
the application icon, and documentation link on dashboard now.
2017-09-29 11:07:26 +05:30
Surinder Kumar
bcce574e83 Using the correct path for the font-mfizz stylesheet.
Reported by: Neel Patel
2017-09-29 09:17:39 +05:30
Akshay Joshi
5a132a547f Ensure using an alternate role to connect to a database doesn't cause an error when checking recovery state. Fixes #2742 2017-09-28 15:09:49 +01:00
Dave Page
8ea85221f0 Update message catalogs. 2017-09-28 10:29:46 +01:00
Dave Page
739d8e2f1f Dead code cleanup. 2017-09-28 10:16:49 +01:00
Murtuza Zabuawala
f855ed88ce Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 2017-09-28 10:02:33 +01:00
Chethana Kumar
62c9376546 Improve icon alignment. 2017-09-22 14:29:34 +01:00
Dave Page
354679e69b Fix an issue where we were executing SELECT statements in transactions in query tool which probably is not required because SELECT statements are already protected from dirty reads. Fixes #2683 2017-09-20 11:59:37 +01:00
Murtuza Zabuawala
64159d11ce Fix font on alertify dialogues 2017-09-20 11:42:16 +01:00
Akshay Joshi
13665f68d8 Fix validation message styling on thegrant wizard. Fixes #2673 2017-09-20 11:34:01 +01:00
Murtuza Zabuawala
2ddbddba33 Improve display of error messages in the query tool. Fixes #2700 2017-09-20 11:29:24 +01:00
Akshay Joshi
fe757c384b Filtered Rows dialog not opened from the context menu. Fixes #2699 2017-09-19 11:46:51 +05:30
Dave Page
62d7a1044e Remove unused import that was causing a hard error on Windows 2017-09-18 16:54:43 +01:00
Harshal Dhumal
f0ad26ba7a Fix for Exception when the server is restarted. Fixes #2713
This issue was caused because we recently added session_write_delay in session.
So session won't be written/updated to disk from memory until specified seconds are elapsed.

However we must forcefully write/update session to disk if user loges in or out irrespective of session_write_delay to keep sessions from memory and disk in sync as user logged in status is kept in session.
2017-09-18 14:39:43 +01:00
Akshay Joshi
bdc08d94c4 Fix View Data option and column config for Foreign Tables. Fixes #2691 2017-09-18 14:32:17 +01:00
Murtuza Zabuawala
8bededa859 Fix disable trigger menu option. Fixes #2707 2017-09-18 12:37:59 +01:00
Murtuza Zabuawala
e64c52a446 Fix tablespace move prompt message. Fixes #2708 2017-09-18 12:36:04 +01:00
Murtuza Zabuawala
5ebfd88f11 Correct alignment of the X button on dismissable alerts. 2017-09-18 11:57:44 +01:00
Murtuza Zabuawala
bc5a5a5b45 Fix error message regexp in the query tool that could fail in some cases. Fixes #2700 2017-09-18 11:55:04 +01:00
Harshal Dhumal
da40573f0b Fix user manager role handling. Fixes #2641 2017-09-18 11:45:57 +01:00
Harshal Dhumal
765e130336 Support Flask-Security 3.0 2017-09-18 11:40:09 +01:00
Surinder Kumar
026ef7b8b7 Support React v15.5 and later where the code fails to run because React's PropTypes is no more part of React Module. 2017-09-18 10:08:12 +01:00
Harshal Dhumal
30e7016077 Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 2017-09-18 12:07:15 +05:30
Murtuza Zabuawala
8150f93c06 Fix menu left-hand margin. 2017-09-15 14:45:02 +01:00
Atul Sharma
c3ea3b7bdf Replace the "Roboto" font family with "Open Sans" for alertify dialogs. 2017-09-15 14:08:29 +01:00
Murtuza Zabuawala
9cfb2f3cbe Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709 2017-09-15 13:50:06 +01:00
Ashesh Vashi
55e14e4d78 Handle the executor nodes, which are unknown to the Explain module,
gracefully by showing the 'ex_unknown.png' for such nodes.

Reported by: Murtuza
Refs #2706
2017-09-15 10:51:37 +05:30
Atul Sharma
788f7f3a69 Bundle fonts with pgAdmin so we have a standard set for all platforms.
Research by Shirley at Pivotal.
2017-09-13 16:01:14 +01:00
Chethana Kumar
ff79dfc186 Update cast icons with improved design. 2017-09-13 10:43:39 +01:00
Chethana Kumar
3779c36d0f Update server and database icons with a clearer design. 2017-09-13 09:59:07 +01:00
Murtuza Zabuawala
80ce889c3d Fix an issue in User mapping module where users were not listed. Fixes #2693 2017-09-13 09:53:25 +01:00
Murtuza Zabuawala
5891bda06a Fix an issue where base types are not displaying in the create/edit domain dialog, also corrected the condition to show hidden system types. Fixes #2692 2017-09-13 09:52:16 +01:00
Teng Zhang
512afd6618 Highlighting greenplum keywords in sql editor 2017-09-11 19:39:50 +05:30
Chethana Kumar
f79b7f26b1 Using the svg icons for domain constraint, and server browser nodes. 2017-09-11 18:24:04 +05:30
Ashesh Vashi
3bbd1a8a48 Remove icons from the menus to de-clutter the UI and make it more consistent with most OSs. 2017-09-11 09:51:26 +01:00
Ashesh Vashi
ac2512799e Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and
redefined in the database (instead of schema) javascript module, as it
is also used by the foreign-server node too.

Reported by: Neel Patel
2017-09-11 13:13:40 +05:30
Ashesh Vashi
8c8c0e78ca Miscellaneous fixes for icon sizing issue, missing tree nodes to be
webpacked, etc.

- Fixed the background-size for the svg icons to 20x20 px such that it
  does not adjust it's size when a context menu height is different due
  to length of the node label, also - it allows us to fix the issue of
  icons sizes in the Grant Wizard.

- Added two missing browser tree nodes in the webpack configuration
  i.e. Foreign Server, and User Mapping
- Removed a redundant javascript file foreign-server.js
- Fixed the missing context menu icons for Foreign Table, and Tablespace
  nodes.

Thanks EDB development team to find the regression added after the icon
changes in quick time.
2017-09-11 12:55:42 +05:30
Ashesh Vashi
4018562bc7 Changes in the stylesheets to support the svg icons for the browser
tree nodes.
2017-09-11 11:22:55 +05:30
Chethana Kumar
23a00f9614 Replacing existing browser tree node png icons with the svg icons. Made
it compatible with the pgAdmin 4 color combination.

TODO::
Icons for the following nodes are in PNG format.
- Domain Constraint (Only the invalid icon)
- pgAgent Job Steps
- Green Plum database server
- Server (Only server.png, which is used in the create/edit dialog)
2017-09-11 11:17:31 +05:30
Murtuza Zabuawala
8d248dab4c Fix quoting of index column names on tables. Fixes #2619 2017-09-07 16:36:35 +01:00
Murtuza Zabuawala
d5f60e1a47 Fix layout of password prompt dialogue. Fixes #2684 2017-09-07 16:27:02 +01:00
Harshal Dhumal
263aa42725 Reset query tool options before running tests. Fixes #2681 2017-09-05 16:25:15 +01:00
Surinder Kumar
c4393a7795 Fix Copy so it still works after query results have been copied. Fixes #2637 2017-08-31 14:50:39 +01:00
Akshay Joshi
47cf874460 1) Fixed error in alertify.pgNotifier when server connection is lost.
2) Change styling of alertify.pgNotifier as we did for success, error and info.
2017-08-31 18:02:03 +05:30
Dave Cramer
eae6f0427c Fix display of types in GPDB. 2017-08-31 09:57:27 +01:00
Harshal Dhumal
dbf760c6e7 Improve datamodel validations for default Validator if user (developer) do not implement validate function in datamodel. Fixes #2670 2017-08-31 09:54:31 +01:00
Murtuza Zabuawala
52840d68a8 Fix RE-SQL for triggers with a single arg. Fixes #2668 2017-08-31 09:39:09 +01:00
Teng Zhang
821442ed8f GPDB compatibility fixes:
When connected to a Greenplum database server
- Hide items that not work with GPDB, such as Triggers, FDW, FTS_*, etc
- Tables/Views/Catalogs/Language node can expand correctly
- Views/Languages/Catalogs can show properties dialog with correct information
- Show a greenplum icon at the server node

Teng Zhang & Hao Wang
2017-08-30 11:18:14 +01:00
Harshal Dhumal
048205ead5 Rename the debugger XSS test function to 'a_test_function' to ensure it appears near the top of the tree and not off-screen.
This should not be a permanent fix (the test should be able to scroll the treeview), but works for now to stop tests failing.
2017-08-30 11:12:27 +01:00
Surinder Kumar
7835da267b Allow pgAdmin to run with config database versions from the future. Fixes #2664 2017-08-29 15:03:02 +01:00
Harshal Dhumal
ceb9438000 Cleanup feature tests. Fixes #2586 2017-08-29 14:57:56 +01:00
Murtuza Zabuawala
401e13ca65 Fixed issue where 'backend_type' column is exist for database server version greater than 10.
Issue is regression of RM #2597.
2017-08-28 16:18:05 +05:30
Harshal Dhumal
b1ad89fb4a Using the proper python syntax to fetch the default binary path for
different servers types.
2017-08-26 09:59:57 +05:30
Ashesh Vashi
6b727c43b9 Define the utility path lable, and help message for the Greenplum
database server, shown in the preferences dialog.

Also, fixed the issue, when server type is not defined in the
DEFAULT_BINARY_PATHS, in the configuration.
2017-08-25 21:35:57 +05:30
Murtuza Zabuawala
74db837417 Allow queries to be cancelled from the dashboard, and display additional info in the subnode control. Fixes #2597 2017-08-25 16:57:33 +01:00
Teng Zhang
46c5df4e7b Greenplum specific DDL and Dashboard display changes.
Initial patch by Sarah McAlear<smcalear@pivotal.io>.
2017-08-25 17:53:03 +05:30
Murtuza Zabuawala
d3babd78aa Fixes #2560 - View is not fully qualified in Trigger definition. 2017-08-25 17:45:20 +05:30
Wenlin Zhang
5dd375dd20 Fix the feature tests failuers. 2017-08-25 17:16:36 +05:30
Navnath Gadakh
bd04cfaaa8 Properly cleanup after running the FTS test cases. 2017-08-25 09:32:46 +01:00
Akshay Joshi
fe6e4686a2 Unable to add/update variables for columns of a table. Fixes #2659 2017-08-23 17:11:30 +05:30
Surinder Kumar
ee20a10e94 Syntax error while saving changes for start/end time, weekdays, monthdays, month, hours, minutes while updating the pgAgent Job. Fixes #2657. 2017-08-23 14:05:54 +05:30
Surinder Kumar
cb9a05a7e7 Datetimepicker will expand from bottom instead of Top, because of that user won't be able to select start and end time properly. Fixes #2656 2017-08-23 11:26:24 +05:30
Sarah McAlear
b585063a26 Refactor keyboard shortcut functions in the query tool. Fix some incorrect keycodes and update docs.
Initial work by Sarah & Violet @ Pivotal, with additional tweaks by Murtuza @ EDB.
2017-08-21 15:27:29 +01:00
Murtuza Zabuawala
2e2ca26020 Ensure role names are escaped in the membership control. Fixes #2606 2017-08-21 14:00:33 +01:00
Murtuza Zabuawala
d757d8698d Fix connection string validation for pgAgent jobs. Fixes #2655 2017-08-21 13:20:07 +01:00
Surinder Kumar
6d7b54eb62 Update datetime picker. Fixes #2654 2017-08-21 13:17:35 +01:00
Atul Sharma
e6223c9a49 Fixes #2567 - Use the proper database connection to fetch the default
prileges in the properties tab of the database.

Reviewed by: Murtuza Zabuawala
2017-08-18 09:15:57 +05:30
Violet Cheng
d527769bf8 Extract the generate_url(..) function from node.js, and collection.js 2017-08-17 21:43:07 +05:30
Murtuza Zabuawala
e9b80dae9c User can not add New Server through Quick links. Fixes #2634 2017-08-17 18:14:06 +05:30
Sarah McAlear
dee5186f65 Fixed alertify notification messages where checkmark box disconnected from frame. Fixes #2644 2017-08-17 17:54:12 +05:30
Surinder Kumar
c7686dee05 Unset compression ratio if it is an empty string in Backup module. Fixes #2582 2017-08-17 16:35:42 +05:30
Surinder Kumar
bff48e0b2d Fixed the path reference of load-node.gif which was referencing to vendor directory. Fixes #2646 2017-08-17 15:27:09 +05:30
Murtuza Zabuawala
2df4625ce0 1) Connection Type cell was not honouring to 'Kind' option in Subnode control.
2) Kind option was not saved properly
3) User was not be able to update Kind option in edit mode.

Fixes #2633
2017-08-17 15:00:08 +05:30
Murtuza Zabuawala
2c6c4a16ce Use dict based data instead of 2d-array in Type module as we are adding keys on the fly.
Reviewed By: Harshal Dhumal
2017-08-17 13:07:39 +05:30
Khushboo Vashi
c4ca781ce2 Fixed some UX issue with the Import/Export tool.
- Couldn't click on the filename control once gets an error.
- Encoding is not in alphabetical order.
2017-08-09 16:52:43 +05:30
Hao Wang
5141debae7 UX improvements of the history in the query tool.
- Added copy button for query text.
- Historical queries are binned/grouped by day.

Patch By: Hao Wang, Sarah McAlear
2017-08-09 16:52:43 +05:30
Ashesh Vashi
845025db8f Some cosmetic changes.
- Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources'
  reference directory to be consistent with other files.
- Removed the 'pgadmin' reference from the base.html template.
- Renamed 'pgadmin.slickgrid.editors.js', and
  'pgadmin.slickgrid.formatters.js' as 'editors.js', and 'formatters.js'
  respectively, as they're already in the 'pgadmin/static/js/slickgrid'
  directory.
- Removed the duplicate entry of 'translations' from the webpack.shim.js
2017-08-09 16:52:12 +05:30
Akshay Joshi
e418cb8387 Changed the mapping of cell from 'numeric' to 'integer' for integer control as numeric cell has been removed from the code. Fixes #2631 2017-08-07 14:02:59 +05:30
Akshay Joshi
801a05891e Set the database name to blank('') when job type is set to batch, while creating pgAgent job. Fixes #2620 2017-08-04 19:31:17 +05:30
Murtuza Zabuawala
ef48c2ed91 Fixed issue in query tool where messages were not displaying from functions/procedures properly. Fixes #2555 2017-08-04 15:50:39 +05:30
Murtuza Zabuawala
bebfc62721 Fixed collation tests on Windows, replace use of default 'POSIX' collation with 'C' collation for testing. Fixes #2501 2017-08-03 16:46:20 +05:30
Murtuza Zabuawala
6717aff8f5 Domain create dialog do not open and Font size issue in Security label control. Fixes #2616 2017-08-01 16:37:17 +05:30
Akshay Joshi
e506fa1dbe Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself. 2017-07-31 18:59:44 +05:30
Akshay Joshi
a7f58e2b92 1) Added partition module in webpack config.
2) Fixed missing logic of partition from primary_key.js and unique_constraint.js as this two files are newly created for webpack.
3) Changed the node name from 'check_constraint' to 'check_constraints'. Also changed the same in test case url.
2017-07-31 18:25:04 +05:30
Ashesh Vashi
bdefdf5d4e Requests for statistics were not stopped even when Dashboard panel is
closed. It is a regression of webpack.
2017-07-31 16:48:52 +05:30
Surinder Kumar
6d5417709c Moved the javascripts of different modules from 'templates' to 'static' directory.
Moving the javascripts for the following modules:
 - About
 - Browser nodes
 - Dashboard
 - FileManager
 - Vendor/snap.svg
 - Preferences
 - Settings
 - Backup
 - Datagrid
 - Debugger
 - Sqleditor
 - Grant Wizard
 - Import & Export
 - Maintenance
 - Restore and
 - User Management
2017-07-27 17:25:08 +05:30
Harshal Dhumal
831c614a60 Store the file dialog view on toggle. 2017-07-26 14:35:43 +01:00
Harshal Dhumal
97cd74a373 Default the file browser view to list, and make it configurable. Fixes #2579 2017-07-26 13:09:52 +01:00
Khushboo Vashi
d1e7254fbd Handle control visibility properly in javascript strict mode. 2017-07-26 12:55:46 +01:00
Murtuza Zabuawala
1fa9648a21 Update keyboard shortcuts per discussion. Also, make the labels platform sensitive. 2017-07-26 12:50:42 +01:00
Harshal Dhumal
d339d6b816 Do not dump the session data on the disk on every request.
Session object is updated, everytime a request is being served, and
that was forcing the session object dumped on the dist on every request.

On windows, it was causing issues on slower system on startup. Because -
windows file system locks the file, when it is opened by any
application. And, frequent requests on the pgAdmin main UI rendering
was causing issues, because of that.

In order to resolve the issue, we will not write the session data on
disk for every request, but - only after certain delay (in seconds),
from it was last written. It can be configured using the attribute
'PGADMIN_SESSION_DISK_WRITE_DELAY' in the configuration file,
default vaule for the delay is 10.
(i.e. 10 seconds)
2017-07-25 15:52:32 +05:30
Murtuza Zabuawala
178d583bcd Fix paths under non-standard virtual directories. Fixes #2563 2017-07-25 10:15:18 +01:00
Murtuza Zabuawala
617e9dbb3a Allow queries to be cancelled from the dashboards. Fixes #1812 2017-07-24 12:13:24 +01:00
Joao Pedro De Almeida Pereira
fe95b7670b Ensure the appropriate entry is focussed when entering the history tab. 2017-07-24 11:46:06 +01:00
Sarah McAlear
2ebb409999 Fix test assertion. 2017-07-21 16:16:41 +01:00
Surinder Kumar
03657df82a Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 2017-07-21 16:15:03 +01:00
Harshal Dhumal
7182b59976 Ensure arrow keys work correctly when the pane is focused instead of the tab in the query tool history. 2017-07-21 13:33:59 +01:00
Atul Sharma
70418144cf Add a field to the Server Dialogue allowing users to specify a subset of databases they'd like to see in the treeview. Fixes #1918 2017-07-21 12:44:57 +01:00