Akshay Joshi
52d0241a17
Fixed an issue where schema diff is not working when providing the options to Foreign Data Wrapper, Foreign Server, and User Mapping. Fixes #5754
2020-08-24 12:11:09 +05:30
Neel Patel
b53de0c31d
Updated some more font awesome icons for v5
2020-08-21 14:15:18 +05:30
Nikhil Mohite
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
Akshay Joshi
dd6ae193ff
Replace 'fa-clock-o' with 'fa-clock' which is appropriate for font awesome v5
2020-08-21 13:44:29 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Rahul Shirsat
7f3e8596e3
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 18:34:49 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Dave Page
99a7ada58a
Cleanup a bunch of duplicated gettext calls.
2020-08-20 10:00:12 +01:00
Nikhil Mohite
6415294782
Improve code coverage and API test cases for Grant Wizard. Fixes #5344
2020-08-20 14:04:24 +05:30
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Khushboo Vashi
cc5a7ea334
Fixed code smell 'String literals should not be duplicated'.
...
Create a constant.py file which contains the common Constants.
2020-08-19 14:16:02 +05:30
Nikhil Mohite
4b56962c1b
Fixed cognitive complexity issues reported by SonarQube.
2020-08-19 13:41:53 +05:30
Yogesh Mahajan
0668a52c6b
Fixed following SonarQube issues:
...
1. String literals should not be duplicated.
2. Cognitive Complexity of functions should not be too high.
2020-08-19 13:22:17 +05:30
Libor M
3f73516f8c
Update Czech translation.
2020-08-17 17:53:55 +05:30
Akshay Joshi
e3b1ef0b80
Update version for release.
2020-08-17 17:29:19 +05:30
Khushboo Vashi
ae18b9a0ac
Fixed schema diff issue when selecting any identical node.
2020-08-17 17:26:58 +05:30
Akshay Joshi
b0af385ea0
Fixed an issue where the entire logs is in red text when the user runs backup and restore. Fixes #5604
2020-08-17 17:23:30 +05:30
Yogesh Mahajan
0122cf9aac
Fixed feature test failure due to updating font-awesome from v4 to v5.
2020-08-17 12:31:19 +05:30
Fred Escallier
ad0bcba99e
Update French translation.
2020-08-17 11:31:01 +05:30
Identifier Anonymous
7a05edc42a
Update Japanese translation.
2020-08-17 11:27:24 +05:30
Domenico Sgarbossa
d2f93d6fad
Update Italian translation.
2020-08-17 11:23:32 +05:30
Akshay Joshi
1466e414ec
Update message catalogs.
2020-08-14 17:26:42 +05:30
Akshay Joshi
8f61944386
1) Added special handling for the extension to resolve the dependency.
...
2) Added 'is_sys_obj' to the ignore list of Schema Diff.
3) Font awesome v5 fixes.
2020-08-13 17:48:04 +05:30
Akshay Joshi
63df19ee1c
Fixed following schema diff issues:
...
1) Avoid template databases from the Database drop-down list.
2) Exclude system schemas while comparing two databases.
3) Escape group name for XSS.
2020-08-13 14:12:37 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Akshay Joshi
26506a9727
Fix PEP8
2020-08-12 17:48:08 +05:30
Aditya Toshniwal
caeea7940a
Fixed errors occurring when saving preferences, regression of SonarQube fixes.
2020-08-12 17:42:53 +05:30
Khushboo Vashi
5b688cf949
Resolve schema diff dependencies by selecting the appropriate node automatically and maintain the order in the generated script. Fixes #5730
2020-08-12 17:36:48 +05:30
Aditya Toshniwal
7dd313f5fc
Fixed an issue where debugger doesn't work if the search path is set other than 'public'. Fixes #4123
2020-08-12 14:24:40 +05:30
Yogesh Mahajan
1f70385a4e
Fixed an issue where conversion of bytea to the binary string results in an error. Fixes #5567
2020-08-11 15:31:14 +05:30
Aditya Toshniwal
8129df42da
Fixed cognitive complexity issues reported by SonarQube.
2020-08-11 15:13:35 +05:30
Akshay Joshi
082b968bbc
Fixed following schema diff issues:
...
1) Wrong SQL generated for the columns having different data type.
2) Added 'castfunc' in the ignore list.
2020-08-11 14:42:32 +05:30
Rahul Shirsat
2907a79dd7
Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791
2020-08-11 11:30:47 +05:30
Akshay Joshi
46af290b85
Fixed API test cases for packages.
2020-08-10 18:13:00 +05:30
Aditya Toshniwal
26a758a0d6
Fixed an issue where copying and pasting a cell with multiple line data
...
will result in multiple rows. Fixes #5526
Fixed an old issue where quotes are not escaped when copying the cells.
As per CSV standards, if the string is in double quotes and there are
double quotes inside the string then they should be escaped with extra double-quotes.
2020-08-10 16:53:32 +05:30
Nikhil Mohite
9d006d0ec5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-10 16:30:07 +05:30
Cyril Jouve
7a0bfecfc5
Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses.
2020-08-10 15:57:25 +05:30
Rahul Shirsat
604937cf66
Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664
2020-08-10 15:27:57 +05:30
Akshay Joshi
4f74609ecf
Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126
2020-08-10 15:13:34 +05:30
Yogesh Mahajan
3672013ddc
Fixed an issue where the error message does not have a close button on utility dialogs. Fixes #5670
2020-08-07 17:17:51 +05:30
Nikhil Mohite
9ad7476a34
Corrected DROP SQL syntax for catalog. Fixes #5713
2020-08-07 16:58:38 +05:30
Akshay Joshi
518b13c779
Added the 'ORDER BY' clause for the privileges type to fix schema diff issue. Fixes #5689
2020-08-07 16:30:03 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Pramod Ahire
68a5027d15
Added ability to generate code coverage reports for java script files.
2020-08-07 12:27:12 +05:30
Aditya Toshniwal
e494b1520d
Fixed an issue where ajax call continues to fire even after disconnect the database server. Fixes #5716
2020-08-06 16:52:16 +05:30
Akshay Joshi
aac0da4cbc
Fixed ssh tunnel hang issue when the user tries to disconnect the server. Fixes #4361
2020-08-06 16:16:37 +05:30
Yogesh Mahajan
48737e6a02
Fixed code smell 'String literals should not be duplicated' reported by SonarQube.
2020-08-06 12:42:19 +05:30
Nikhil Mohite
1122e06f48
Fixed cognitive complexity issues reported by SonarQube.
2020-08-06 12:38:35 +05:30
Yogesh Mahajan
e3dfe03a2a
Fixed an issue where the user is not able to insert the data if the table and columns name contains special characters. Fixes #4387
2020-08-06 12:30:10 +05:30
Nikhil Mohite
6a406f466d
Fixed cognitive complexity issues reported by SonarQube.
2020-08-05 13:00:44 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Murtuza Zabuawala
d2621282dc
Change the scope of '.dashboard-graph-body' CSS class to prevent it from affecting other places.
2020-08-05 12:30:09 +05:30
Akshay Joshi
5ce2773658
Ensure that the Dictionaries drop-down shows all the dictionaries in the FTS configuration dialog. Fixes #5429
2020-08-04 15:48:20 +05:30
Yogesh Mahajan
43e127de31
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
2020-08-03 13:18:04 +05:30
Akshay Joshi
87d08de3a0
Corrected the syntax as per jinja standards. refs #5632
2020-08-03 13:08:29 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Nikhil Mohite
eb2c554601
Fixed cognitive complexity issues reported by SonarQube.
2020-08-03 12:46:34 +05:30
Satish V
318d712c4f
Improve code coverage and API test cases for Schemas. Fixes #5327
2020-08-03 12:38:38 +05:30
Shubham Agarwal
32d904058a
Fixed SonarQube issues.
2020-08-03 11:44:27 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
Akshay Joshi
dd7eb54e90
Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710
2020-07-30 13:57:00 +05:30
Nikhil Mohite
89fa85d650
Fixed cognitive complexity issues reported by SonarQube.
2020-07-29 18:29:04 +05:30
Rahul Shirsat
74fd5dfe96
Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632
2020-07-29 16:22:11 +05:30
Satish V
287a6628ed
Improve code coverage and API test cases for Types. Fixes #5336
2020-07-29 15:41:04 +05:30
Aditya Toshniwal
f715373218
Replace charting library Flotr2 with ChartJS using React. Fixes #3904
2020-07-29 14:49:22 +05:30
Aditya Toshniwal
a0893fe43b
Fixed code smell 'variable shadows a builtin' reported by SonarQube.
2020-07-28 16:20:26 +05:30
Akshay Joshi
ed0dc62b69
Fixed incorrect import statement for urlopen.
...
refs #5700
2020-07-27 17:33:44 +05:30
Akshay Joshi
fb0bc65ced
Fixed following SonarQube issues:
...
1) Define a constant instead of duplicating this literal.
2) Reduce cognitive complexity (Patch by Aditya)
2020-07-27 16:31:03 +05:30
Cyril Jouve
f93cfe8c4c
Remove old Python 2 compatibility code. Fixes #5700
2020-07-27 11:03:13 +01:00
Akshay Joshi
7a22cff28c
Fixed 'cannot unpack non-iterable Response object' issue.
2020-07-24 14:59:50 +05:30
Yogesh Mahajan
043025d1eb
Fixed an issue where the user is not able to save the new row if the table is empty. Fixes #4810
2020-07-24 14:30:22 +05:30
Satish V
4cf8c2f300
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324
2020-07-24 14:14:13 +05:30
Rahul Shirsat
937877e841
Ensure that RLS Policy node should be searchable using search object. Fixes #5646
2020-07-24 13:47:39 +05:30
Yogesh Mahajan
dd27e08a98
Fixed code smell 'Unused local variables should be removed'.
2020-07-24 12:15:29 +05:30
Nikhil Mohite
1fbf298d30
Fixed cognitive complexity issues reported by SonarQube.
2020-07-24 12:03:05 +05:30
Aditya Toshniwal
505a3ac960
1) Fixed cognitive complexity issues reported by SonarQube.
...
2) Fixed code smell 'Add a nested comment explaining why this method is
empty, or complete the implementation'.
2020-07-24 11:46:30 +05:30
Nikhil Mohite
5f619ae40a
Ensure that data output color is readable on row selection. Fixes #5687
2020-07-21 18:54:06 +05:30
Pradip Parkale
28a4359020
Fixed issue where the user was not able to update policy if the policy is created with space. Fixes #5686
2020-07-21 18:14:49 +05:30
Akshay Joshi
f177d54f21
Fixed AttributeError while creating the server group. Fixes #5688
2020-07-21 18:02:51 +05:30
Libor M
851c15b2d6
Update Czech translation.
2020-07-21 17:23:13 +05:30
Akshay Joshi
c0e30c93e5
Update version for release.
2020-07-20 16:18:36 +05:30
Khushboo Vashi
645517d22d
Added support for LDAP anonymous binding. Fixes #5650
2020-07-20 15:30:06 +05:30
Nikhil Mohite
3983e2c13c
Fix the following issues for High Contrast Theme:
...
1) Schema diff compare button icon is not visible on hover.
2) Schema diff for identical section text is not readable due to the same color as the background.
3) Removed extra variables used for set text color for explain - Analysis section (Issue related dark theme.).
4) Issue related to the disabled toggle button.
refs #5653
2020-07-20 15:12:46 +05:30
Identifier Anonymous
f29db1a9cd
Update Japanese translation.
2020-07-20 12:08:50 +05:30
Fred Escallier
c723b4584c
Update French translation.
2020-07-20 12:04:47 +05:30
Domenico Sgarbossa
b75c09d7c0
Update Italian translation.
2020-07-20 12:02:46 +05:30
Yogesh Mahajan
225c3e8f7e
Fixed feature tests
2020-07-20 11:59:28 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Akshay Joshi
2bfb7c20c8
Update message catalogs.
2020-07-17 18:02:50 +05:30
Dave Page
fb2178e5d3
Support configuration files that are external to the application installation. Fixes #5235
2020-07-17 17:54:12 +05:30
Nikhil Mohite
4e2c4b0498
Fixed cognitive complexity issues reported by SonarQube.
2020-07-17 15:31:04 +05:30
Satish V
64cdd509b0
Fixed save button enable issue when focusing in and out of numeric input field. Fixes #5137
2020-07-17 15:31:04 +05:30
Aditya Toshniwal
bd15d2d0f7
Fixed CSRF errors when pgAdmin opened in an iframe on safari browser. Fixes #5675
2020-07-17 15:31:04 +05:30
Aditya Toshniwal
9d0f3ce90b
Fixed code smell 'potential hiding of variables declared in an outer scope'.
2020-07-16 19:53:39 +05:30
Akshay Joshi
703faf3b15
Fixed following SoanrQube issues
...
1) Rename field "node_type" to prevent any misunderstanding/clash with field "NODE_TYPE" defined.
2) Define a constant instead of duplicating this literal.
Solution:
1) Rename the field "NODE_TYPE" and "COLLECTION_LABEL" to "_NODE_TYPE" and "_COLLECTION_LABEL"
2) Declare the constant in PGChildNodeView for SQL files.
2020-07-16 19:39:55 +05:30
Akshay Joshi
5d8c79da38
Added docstrings for some newly created functions.
2020-07-15 18:07:54 +05:30
Satish V
522ddad72b
Fixed code smell 'Variables should not be shadowed'.
2020-07-15 15:03:47 +05:30
Akshay Joshi
11c4877859
Fixed an issue where difference DDL is showing the wrong SQL when changing the policy owner. Fixes #5647
2020-07-15 14:52:14 +05:30
Akshay Joshi
2469032f15
Fixed an issue where fetching the schema throws an error if the database
...
is not connected in Schema Diff. Fixes #5673
Maintenance Database is selected by default in Schema Diff.
2020-07-15 13:07:28 +05:30