Murtuza Zabuawala
e6aa3e1494
Fix default values and SQL formatting for event triggers. Fixes #1229
2017-06-06 11:19:40 +01:00
Dave Page
4c2004d479
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113
2017-06-06 11:15:51 +01:00
Murtuza Zabuawala
4b74a5ff35
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116
2017-06-06 09:52:44 +01:00
Murtuza Zabuawala
0bc9997a95
Properly refresh the parent node when renaming children. Fixes #2355
2017-06-06 09:50:05 +01:00
Dave Page
9e98ded06c
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386
2017-06-05 17:11:21 +01:00
Murtuza Zabuawala
3f150f3f4e
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280
2017-06-05 17:04:55 +01:00
Murtuza Zabuawala
2c9af4784e
Allow creation of ENUM types with no members. Fixes #2426
2017-05-26 12:21:23 -04:00
Murtuza Zabuawala
45d423c0ce
Ensure the last placeholder is included when generating UPDATE scripts for tables. Fixes #2436
2017-05-26 10:59:09 -04:00
Murtuza Zabuawala
a45bb905f5
Pass the database ID to the query tool when using the Script options. Fixes #2435
2017-05-26 10:57:31 -04:00
Murtuza Zabuawala
e9da157cc7
Add numerous missing checks to ensure objects really exist when we think they do. Fixes #2427
2017-05-25 16:28:04 -04:00
Dave Page
04ce72a6ae
Fix RE-SQL for rules which got the table name wrong in the header and DROP statement. Fixes #2422
2017-05-19 12:21:29 +01:00
Murtuza Zabuawala
a3226b1eb5
Reverse engineer SQL for table-returning functions correctly. Fixes #1851
2017-05-17 15:49:56 +01:00
Murtuza Zabuawala
655d5888a6
Various FTS dictionary cleanups. Fixes #1126
2017-05-17 14:13:05 +01:00
Murtuza Zabuawala
2ad14b379e
Validate table presence in SQL and Properties route handles. Fixes #2395
2017-05-15 10:15:09 +01:00
Joao Pedro De Almeida Pereira
3bf17d9df4
1) Splits the SQL query used to retrieve the Dependents, Dependencies, and Roles SQL file into multiple versioned files.
...
2) Add Unit Tests for each file.
3) Add ORDER BY into Copy Selection Feature test to ensure the results are retrieved always in the same order
4) Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it for versions less than 9.1
5) Deleted unused __init__.py files.
2017-05-15 10:40:46 +05:30
Surinder Kumar
4f9628ed43
Improve handling of nulls and default values in the data editor. Fixes #2257
2017-05-12 10:53:57 +01:00
Murtuza Zabuawala
94cbd70370
Don't change the trigger icon back to "enabled" when the trigger is updated when it's disabled. Fixes #2271
2017-05-10 09:48:21 +01:00
Murtuza Zabuawala
9452e0699e
Allow creation of tables with pure numeric names. Fixes #2284
2017-05-10 09:40:32 +01:00
Khushboo Vashi
94b7fc483a
Fix sorting of sizes on the statistics views by sorting raw values and prettifying on the client side. Includes Jasmine tests for the prettyfying function. Fixes #2315
2017-05-08 11:29:13 +01:00
Murtuza Zabuawala
95f763463f
Fix an issue in NodeAjaxControl caching with cache-node field and add cache-node field in Trigger & Event trigger node so that whenever the user creates new Trigger Function we get new data from server in NodeAjaxControl. . Fixes #2242
2017-05-04 16:02:28 +01:00
Murtuza Zabuawala
6790bfd0c0
Fixed handling of default parameters ordering in functions. Fixes #2350
2017-04-25 18:40:44 +05:30
Akshay Joshi
a449be784e
Initial support for PG 10.0, per #2214 (missed some files)
2017-04-24 13:56:01 +01:00
Akshay Joshi
59834fba31
Initial support for PG 10.0, per #2214
2017-04-24 13:55:29 +01:00
Khushboo Vashi
8d6add13c0
Order foreign table columns correctly. Fixes #2318
2017-04-18 14:37:30 +01:00
Akshay Joshi
0d566a6f3a
Changed switch label from True/False to Show/Hide for 'Package Functions' and 'Package Procedures' node in Preferences dialog.
2017-04-14 14:57:38 +05:30
Navnath Gadakh
62716c4193
Include passed test results in the JSON output from the regression tests.
2017-04-12 13:11:53 +01:00
RAJASEKAR G
024b97479d
Recover properly if a database is renamed externally. Fixes #2077
2017-04-10 11:09:01 +01:00
RAJASEKAR G
3880bc7eb8
Fix validation on the table dialogue so the Save button isn't enabled if the name is removed and autovac custom settings are enabled. Fixes #2105
2017-04-06 09:56:52 +01:00
Jonas Thelemann
b8566a0127
Un-split some strings for translateability. And so begins the battle between gettext and pep8...
2017-04-05 15:05:11 +01:00
Jonas Thelemann
ddfa934357
Unified usage of "definition incomplete".
2017-04-05 13:55:00 +01:00
Jonas Thelemann
37120bf199
(De)Capitalized strings to fit the common/usual format, corrected spelling, removed unnecessary characters.
2017-04-05 13:50:49 +01:00
Jonas Thelemann
65f21a8cd7
Replace all occurrences of "can not" with "cannot".
2017-04-05 13:38:14 +01:00
Aravindraja Thinakaran
bb0bd8acc5
Properly handle truncated table names (> NAMEDATALEN). Fixes #2277
2017-04-01 02:57:48 -04:00
Jonas Thelemann
c391696054
Remove some unnecessary line breaks causing problems with translations.
2017-03-26 20:26:58 -04:00
Dave Page
6152d73f13
Fix some code inspection complaints
2017-03-25 22:04:52 -04:00
Dave Page
d205550b53
Fix Python 3 compatibility.
2017-03-23 13:43:24 +00:00
Atira Odhner
10920404e1
Re-organised the regression directory now we have multiple test suites: move test_utils.py into python_test_utils/
2017-03-23 11:59:31 +00:00
Atira Odhner
77007996ed
Support generation of DDL for tables in Greenplum DB. Fixes #2261
2017-03-23 11:40:06 +00:00
Atira Odhner
0ba0b25290
Move foreign key templates into a default directory.
2017-03-23 11:13:06 +00:00
Murtuza Zabuawala
145983d544
Add miissing braces to reverse engineered SQL header block for Functions. Fixes #2246
2017-03-17 12:48:58 +00:00
Atira Odhner
4464be6f43
Fix a typo and remove an unnecessary copy of the column properties template.
2017-03-17 10:02:52 +00:00
Dave Page
b2a74ad26d
Fix a bunch of file headers.
2017-03-16 14:27:55 +00:00
Dave Page
18d465e7bc
Fix some messages and update the Polish translation from Begina Felicysym
2017-03-09 09:23:19 +00:00
Dave Page
fb44ffffa0
Fix a couple of translation issues, and remove the test French translation files.
2017-03-08 10:13:15 +00:00
Jonas Thelemann
c34f5fd2d4
Use "could not" consistently, instead of "couldn't" which was used in some places.
2017-03-07 10:29:54 +00:00
Harshal Dhumal
ffa8d94e76
Better handling the non-ascii characters for different database objects.
...
Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2
driver for proper conversation of unicode characters. Also - adjusted
the string typecaster to take care of different character types (char,
character, text, name, character varying, and their array types).
Reviewed by: Dave Page, Murtuza Zabuawala & Akshay Joshi
2017-03-02 15:09:28 +05:30
Dave Page
59c6be534d
Typo fixes.
2017-03-01 12:49:15 +00:00
Khushboo Vashi
ddb8bad201
Fix Sequence ACL SQL for PG 9.3/9.2.
2017-03-01 12:46:58 +00:00
Navnath Gadakh
1f935d699e
Testsuite fixes for 9.3 and 9.2 support.
2017-02-28 14:22:10 +00:00
Harshal Dhumal
b961b2d929
Fix function arguments when generating create SQL. Fixes #2198
2017-02-24 12:42:25 +00:00
Khushboo Vashi
0ba9b7db43
Add PARALLEL SAFE|UNSAFE|RESTRICTED support. Fixes #2089
2017-02-24 12:21:05 +00:00
Harshal Dhumal
685b1ea12f
Fix renaming of check constraints when the table name is changed at the same time. Fixes #2201
2017-02-24 10:44:43 +00:00
Harshal Dhumal
5e33fe4e95
Properly handle event trigger functions in different schemas. Fixes #2200
2017-02-24 10:40:11 +00:00
Dave Page
03f292ce51
Tidy up the regression test output a little.
2017-02-16 11:40:54 +00:00
Surinder Kumar
833629d438
Fix exclusion constraint reverse engineered SQL. Fixes #2115
2017-02-16 10:54:21 +00:00
Surinder Kumar
cbaad81f00
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126
2017-02-16 10:47:28 +00:00
Dave Page
ae10da4371
Another Python 3.x compatibility fix.
2017-02-13 10:27:16 +00:00
Dave Page
14f181d2ba
Fix Python 3 compatibility.
2017-02-13 10:07:38 +00:00
Atira Odhner
ec9e8b79a3
Basic support for viewing tables in Greenplum. Patch from George & Tira @ Pivotal.
2017-02-13 10:02:20 +00:00
Murtuza Zabuawala
6887920295
Ensure FTS parsers and templates are removed prior to creating them when testing.
2017-02-09 12:05:55 +00:00
Murtuza Zabuawala
c34fdaf37d
Fix the issue with Jinja conditions in Foreign Data Wrappers, Foreign Servers, User Mapping.
...
I also did some re-formatting & re-factoring to code to remove all the duplicate code.
2017-02-09 12:05:09 +00:00
Murtuza Zabuawala
c96da34c28
Fix handling of "char" columns. Fixes #2152
2017-02-06 10:59:03 +00:00
Murtuza Zabuawala
3ea8a7b211
Fix column addition regression test.
2017-02-06 09:46:34 +00:00
Murtuza Zabuawala
bf8c3c4180
Handle sized time/timestamp columns correctly. Fixes #2076
2017-02-03 14:51:58 +01:00
Khushboo Vashi
f2ac6fc6a7
1) Wrong tablespace displayed in table properties. Fixes #2069
...
2) Message (Connection to the server has been lost.) displayed with Materialized view and view under sql tab. Fixes #2139
2017-02-03 16:13:07 +05:30
Murtuza Zabuawala
2d442da9ff
Properly handle setting comments and other options on databases with allowconn = False. Fixes #2024
2017-02-01 10:23:45 +00:00
George Gelashvili
6d05302ca1
Rename the 9.1_plus templates to "default" to more appropriately support Greenplum which is based on 8.3.
2017-02-01 09:57:49 +00:00
Murtuza Zabuawala
e8f0cf6d94
Resolve various trigger issues. Fixes #2015
...
- Allow changing of row/statement flag
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
2017-01-30 13:05:15 +00:00
George Gelashvili
19be3529f8
Create a template loader for SQL templates.
...
This will automatically find the correct version of a template for the server version, and allows us to remove templates that were previously duplicated for different server versions.
Patch by George & Tira at Pivotal. Review by me and Murtuza from EDB.
Discussion: https://www.postgresql.org/message-id/flat/CAHowoHaU9_pkCt%2B1g8dpY3hsXXZmsJZiJH-3-_Hd%2BC1MxiGhtA%40mail.gmail.com#CAHowoHaU9_pkCt+1g8dpY3hsXXZmsJZiJH-3-_Hd+C1MxiGhtA@mail.gmail.com
2017-01-30 11:25:03 +00:00
Surinder Kumar
e01cf748ea
Enable/disable NULLs and ASC/DESC options for index columns and exclusion constraints appropriately. Fixes #2061 . Fixes #1840 .
2017-01-25 13:21:39 +00:00
Murtuza Zabuawala
29a6f2e124
Fix Reset Statistics operation for which the popup messages weren't displaying correctly. Fixes #2091
2017-01-24 10:19:33 +00:00
Dave Page
801c7688a3
A little message cleanup.
2017-01-24 10:18:30 +00:00
Dave Page
ac4178233b
Revert "Handle comments on databases with datallowconn=False correctly. Fixes #2024 "
...
This reverts commit e431eb9d8e
2017-01-20 13:21:05 +00:00
Murtuza Zabuawala
28621999f2
Improve display of columns of exclusion contraints and foreign keys in the properties lists. Fixes #2065
2017-01-17 10:25:26 +00:00
Murtuza Zabuawala
e431eb9d8e
Handle comments on databases with datallowconn=False correctly. Fixes #2024
2017-01-16 15:42:25 +00:00
Murtuza Zabuawala
4c19f93b3b
Use the correct OID for retrieving properties of freshly created exclusion constraints. Fixes #1896
2017-01-09 15:05:22 +05:30
Khushboo Vashi
01b2288d57
Ensure columns with types that are not in pg_catalog are handled properly in the table dialog.
2017-01-09 08:05:51 +05:30
Navnath Gadakh
1325b30e0b
Various improvements to the regression tests, notably avoiding use of signals unavailable on Windows.
2017-01-08 18:48:04 +05:30
Neel Patel
2787c5c207
Reset the column list properly if the access method is changed on an index to ensure error handling works correctly. Fixes #2009
2017-01-08 15:27:58 +05:30
Murtuza Zabuawala
879a6bef53
Fix keyboard control of switches in the column grid. Fixes #1394
2017-01-08 15:27:58 +05:30
Dave Page
fe9bdc62a1
Fix copyright notices.
2017-01-04 13:35:38 +00:00
Dave Page
f221194bcc
Update copyright notices for 2017.
2017-01-04 13:33:32 +00:00
Khushboo Vashi
1d571902da
Fix regression when generating SQL for new databases, caused by an invalid check of datallowconn introduced in the fix for #1801 .
2016-12-16 13:12:12 +00:00
Murtuza Zabuawala
1431dfcb01
Show index columns in the correct order in RE-SQL. Fixes #1842
2016-12-16 11:59:37 +00:00
Khushboo Vashi
81841cdb3c
Treat databases with datallowconn=false appropriately. Fixes #1801
2016-12-09 11:59:13 +00:00
Anthony DeBarros
6ff2fe64b8
Fix various mis-spellings of VACUUM. Fixes #2005
2016-12-08 10:35:53 +00:00
Neel Patel
54e6336a58
Deal with Function arguments correctly in the properties dialogue. Fixes #1979
2016-11-25 10:55:10 +00:00
Murtuza Zabuawala
66b9e22d01
Handle the template property on databases appropriately. Fixes #1800
2016-11-25 10:11:40 +00:00
Murtuza Zabuawala
6e5126d571
Add newly created triggers to the treeview. Fixes #1747
2016-11-18 13:58:35 +00:00
Khushboo Vashi
6567669798
Ensure the check_option is only set when editing views when appropriate. Fixes #1924
2016-11-18 13:44:43 +00:00
Murtuza Zabuawala
00d2ab0338
Cast OIDs to oid not int, otherwise we lose half the range which results in objects not being accessible. Fixes #1951
2016-11-11 14:36:41 +00:00
Murtuza Zabuawala
f405cdf383
Ensure trigger function names are schema qualified in trigger RE-SQL. Fixes #1949
2016-11-11 13:46:06 +00:00
Navnath Gadakh
7b574b284d
Fix TypeError.
2016-11-10 12:48:38 +00:00
Murtuza Zabuawala
36c909b1f9
Generate mSQL for new schemas correctly. Fixes #1937
2016-11-09 15:13:17 +00:00
Murtuza Zabuawala
c345adaa52
Properly format arguments passed by triggers to functions. Fixes #1912
2016-11-09 15:00:35 +00:00
Murtuza Zabuawala
a3622a380a
Fix display of exclusion contraint dependencies. Partially fixes #1892 - requires icon display fix.
2016-11-01 11:35:09 +02:00
Murtuza Zabuawala
ca57323ad1
Properly schema qualify domains when reverse engineering SQL. Fixes #1865
2016-10-28 16:45:06 +01:00
Murtuza Zabuawala
67e5dfa5a7
Fix refreshing of Unique constraints. Fixes #1893
2016-10-28 16:40:27 +01:00
Murtuza Zabuawala
8c48be3b0c
Properly quote role names when specifying function ownership. Fixes #1899
2016-10-28 16:18:31 +01:00
Dave Page
c1c2fb9df9
Ensure sequence start value is shown in SQL and properties list. Fixes #1155
2016-10-24 09:27:16 +01:00
