IntenseWebs/pgadmin4
3
0
Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2026-09-03 20:52:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,176 Commits 30 Branches 126 Tags
c6424e3897a3476a0cd7563b20ab1c5f4b79e70b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Khushboo Vashi cc38bc132e Fixed scroll issue in the browser tree when navigating using the keyboard. 2021-11-15 18:26:16 +05:30
Khushboo Vashi e67bad3461 Ensure that the user should be able to navigate browser tree objects using arrow keys from keyboard. Fixes #6896 2021-11-15 11:17:42 +05:30
Khushboo Vashi d4697e8f1c Ensure that users should be able to modify the REMOTE_USER environment 
variable as per their environment by introducing the new config parameter
WEBSERVER_REMOTE_USER.

Fixes #6953
 2021-11-10 15:38:41 +05:30
Khushboo Vashi aff84103d9 Fixed an issue where database nodes are not getting loaded behind a reverse 
proxy with SSL. Fixes #6905
 2021-11-10 11:47:40 +05:30
Khushboo Vashi 9e3165c0ff 1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED 
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
 2021-10-19 11:56:44 +05:30
Khushboo Vashi a908ef7c61 Fixed browser tree sort order regression issue. Fixes #6912 2021-10-16 12:54:44 +05:30
Khushboo Vashi 5b411caabe Fixed an issue where each click to refresh the collection node, the number of objects decreasing by tens or more. Fixes #6908 2021-10-16 12:50:51 +05:30
Khushboo Vashi 2aac87569b Fixed an issue where the users are unable to load the databases behind an HTTP reverse proxy. Fixes #6905 2021-10-14 11:35:11 +05:30
Khushboo Vashi 9fd9ca2673 Added support for indent guides in the browser tree. Fixes #4596 2021-10-12 17:53:38 +05:30
Khushboo Vashi ac6c6fbf97 Fixed an issue where the browser tree doesn't show all contents on changing resolution. Fixes #6881 2021-10-12 15:02:46 +05:30
Khushboo Vashi a726635290 1) Added support for authentication via the web server (REMOTE_USER). Fixes #6657 
2) Fixed OAuth2 integration redirect issue. Fixes #6719

Initial patch for 6657 sent by: Tom Schreiber
 2021-10-12 14:52:30 +05:30
Khushboo Vashi ca40add29b Ensure that columns should be displayed in the order of creation instead of alphabetical order in the browser tree. Fixes #6882 2021-10-12 14:37:06 +05:30
Khushboo Vashi 9796f50362 Fixed an issue where the tree is not scrolling to the object selected from the search result. Fixes #6828 2021-10-07 17:23:21 +05:30
Khushboo Vashi a693014371 1) Table Dialogue does not close on addition/deletion of partition. Fixes #6863 
2) Nodes are loaded multiple times in server mode on 'Reset Layout'. Fixes #6861
 2021-10-05 17:33:50 +05:30
Khushboo Vashi 8faec3e0e9 Fixed loading issue of Partitions collection node. Fixes #6844 2021-10-04 16:15:49 +05:30
Khushboo Vashi 1ec1db1ecb Fixed an issue where label is not visible on hover, while hover on icon or expand arrow. refs #6847 2021-10-04 13:15:19 +05:30
Khushboo Vashi 65af8bcc5a Fixed an issue where the label is not visible when hovering on any tree node in the High Contrast theme. Fixes #6847 2021-10-04 12:35:08 +05:30
Khushboo Vashi 44e1a405f0 1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839 
2) Internal server error displayed if disconnect the server. Fixes #6852
 2021-10-03 12:12:02 +05:30
Khushboo Vashi 5e0c113c7b Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833 2021-09-30 18:21:43 +05:30
Khushboo Vashi aa8854db53 1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817 
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
 2021-09-29 17:18:55 +05:30
Khushboo Vashi 24399daefe 1) Browser panel turns blank on connecting/disconnecting the database when the 
server has multiple databases. Fixes #6817
2) Use a hand pointer instead of an arrow. Fixes #6820
 2021-09-28 17:50:54 +05:30
Khushboo Vashi 31c7f3eaba Fixed an error in browser tree when adding any node. 2021-09-28 15:08:59 +05:30
Khushboo Vashi 7b6101bc6d Fixed 'Save' button issue where dialog is not getting closed. 2021-09-28 15:04:37 +05:30
Khushboo Vashi 483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
Khushboo Vashi d1e823bf39 Informative error should be shown if Oauth2 profile does not have email id registered. Fixes #6590 2021-09-09 12:44:37 +05:30
Khushboo Vashi 3786954a65 Added support for OAuth 2 authentication. Fixes #5940 
Initial patch sent by: Florian Sabonchi
 2021-09-09 12:40:53 +05:30
Khushboo Vashi 78b041465e Fixed an issue where even if the user is locked, he can reset the password and can login into pgAdmin. Fixes #6664 2021-08-09 14:24:26 +05:30
Khushboo Vashi 3590c9172c Fixed an issue where the user unable to login with OAuth2 when LDAP & OAuth2 configured as login sources. Fixes #6594 2021-07-09 21:50:50 +05:30
Khushboo Vashi e981868246 Fixed an issue where the user unable to add server in Kerberos Authentication Mode with Master Password. Fixes #6595 2021-07-09 21:47:34 +05:30
Khushboo Vashi 5ee8045916 Informative error should be shown if Oauth2 profile does not have email id registered. Fixes #6590 2021-07-07 17:58:49 +05:30
Khushboo Vashi 36086722b3 RESQL testcase fixes for Triggers. 2021-07-07 17:56:30 +05:30
Khushboo Vashi 48ca83f31d Added support for OAuth 2 authentication. Fixes #5940 
Initial patch sent by: Florian Sabonchi
 2021-07-06 13:22:58 +05:30
Khushboo Vashi 37278f2cd3 Fixed API test cases for PG/EPAS 9.6 2021-06-17 16:22:53 +05:30
Khushboo Vashi 460fb7ec29 Fixed an issue where pgAdmin does not open after password reset in server mode. Fixes #6513 2021-06-10 22:55:31 +05:30
Khushboo Vashi 7275ce906e 1) Fixed an issue where the user is not warned if Kerberos ticket expiration 
is less than 30 min while initiating a global backup. Fixes #6444

2) Ensure that proper identification should be there when the server is
   connected using Kerberos or without Kerberos. Fixes #6445
 2021-05-14 12:33:01 +05:30
Khushboo Vashi 89b0028684 Update Kerberos docs for phase 2. 2021-05-10 10:20:47 +01:00
Khushboo Vashi b30ec71098 Ensure that while connecting to the server using SSPI login, it should not prompt for the password. Fixes #5776 2021-05-05 11:40:48 +05:30
Khushboo Vashi 72f3730c34 Added support to connect PostgreSQL servers via Kerberos authentication. Fixes #6158 2021-05-03 16:10:45 +05:30
Khushboo Vashi 437f0df0f3 Ensure that the strings in the LDAP auth module are translatable. Fixes #6274 2021-04-08 18:15:34 +05:30
Khushboo Vashi b973d6055d Ensure that toggle buttons are accessible by most screen readers. Fixes #6317 2021-03-19 11:44:57 +05:30
Khushboo Vashi f7214b7cfe Fixed dependency tab loading issue when database name having special characters. 
refs #6087
 2021-02-02 11:49:51 +05:30
Khushboo Vashi 88c0968cab Some minor updates to Kerberos documentation. 2021-01-25 19:32:53 +05:30
Khushboo Vashi 45fa74ae46 Updated Windows installer script for Kerberos support. 2021-01-21 16:29:03 +05:30
Khushboo Vashi c71315f8cd 1) Added RPM/DEB dependency for Kerberos to the server package. 
2) Handle the OSError while importing the gssapi, it fixes the Windows error.

refs #5457
 2021-01-20 18:09:07 +05:30
Khushboo Vashi 9bee91b6f6 1) Fixed an issue where the Save button is enabled by default in Macro. Fixes #5905 
2) Remove extra line after Manage Macros menu while clearing all macros. Fixes #5906
3) Ensure that 'Clear All Rows' should not work if there is no existing macro available and the user does not specify any value. Fixes #5907
4) Fixed an issue where the server is disconnected error message displayed if the user creates Macro with invalid SQL. Fixes #5929
 2021-01-20 13:52:00 +05:30
Khushboo Vashi c0ef0a893d 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-18 16:32:10 +05:30
Khushboo Vashi 6ead597b43 1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 
2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829
 2021-01-14 13:46:48 +05:30
Khushboo Vashi 29c3c0cf7f Fixed BatchProcessTest cases failing on Jenkins. 2020-11-19 18:09:35 +05:30
Khushboo Vashi 14a5d05b80 Ensure that non-superuser should be able to debug the function. Fixes #5760 2020-10-30 15:03:18 +05:30
Khushboo Vashi 9b4317fb25 Fixed Jasmine test cases. 2020-10-21 22:14:10 +05:30
Khushboo Vashi 6addd207af Ensure that macros should be run on the older version of Safari and Chrome. Fixes #5911 2020-10-15 15:59:53 +05:30
Khushboo Vashi 49b139bb75 Added escape and unescape for the strings used in query tool and new connection support. Fixes #5899. 2020-10-12 16:20:33 +05:30
Khushboo Vashi f4d6290b50 Update the macro help link. 2020-10-09 11:52:46 +05:30
Khushboo Vashi c28509ac28 Fixed an issue where the user is unable to change the macro name. Fixes #5885 2020-10-05 14:40:21 +05:30
Khushboo Vashi 228d4bb321 Fixed SQLAlchemy operation error with the boolean value as true/false for Python version < 3.7 2020-10-01 13:29:46 +05:30
Khushboo Vashi 4616a74029 Added Macro support. Fixes #1402 2020-09-28 15:26:45 +05:30
Khushboo Vashi 31bbdd6a12 Fixed code smell 'String literals should not be duplicated'. 2020-09-03 18:35:58 +05:30
Khushboo Vashi cc5a7ea334 Fixed code smell 'String literals should not be duplicated'. 
Create a constant.py file which contains the common Constants.
 2020-08-19 14:16:02 +05:30
Khushboo Vashi ae18b9a0ac Fixed schema diff issue when selecting any identical node. 2020-08-17 17:26:58 +05:30
Khushboo Vashi 5b688cf949 Resolve schema diff dependencies by selecting the appropriate node automatically and maintain the order in the generated script. Fixes #5730 2020-08-12 17:36:48 +05:30
Khushboo Vashi 645517d22d Added support for LDAP anonymous binding. Fixes #5650 2020-07-20 15:30:06 +05:30
Khushboo Vashi bd9dc97b4f Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube. 2020-07-14 19:23:50 +05:30
Khushboo Vashi 58b4c45d0c Added support for LDAP authentication with different DN by setting the dedicated user for the LDAP connection. Fixes #5484 2020-07-06 19:35:55 +05:30
Khushboo Vashi b5f0190799 Fixed the SonarQube Code smells having Rule 'Functions, methods and lambdas should not have too many parameters'. 2020-07-03 14:24:54 +05:30
Khushboo Vashi c7a16a4bd5 Fixed code smells having rule 'Nested blocks of code should not be left empty'. 2020-06-26 13:18:27 +05:30
Khushboo Vashi 8ab358ccec Fix following issues reported by SonarQube: 
1) Properties of variables with "null" or "undefined" values should not be accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types
 2020-06-15 16:50:07 +05:30
Khushboo Vashi d1bdb178e2 Fixed an issue where if LDAP_SEARCH_BASE_DN is not set then, the value for LDAP_BASE_DN will be considered. Fixes #5487 2020-05-18 12:35:34 +05:30
Khushboo Vashi 0f56c25893 Changed the user identity from email to username in the log file. 
refs #5452
 2020-05-18 11:01:20 +05:30
Khushboo Vashi a9a1a975a6 Added compatibility for Flask-Security-Too version 3.2 2020-05-13 16:02:38 +05:30
Khushboo Vashi d68e6bd892 Remove Python2 modules. 
refs #5443
 2020-05-08 12:28:21 +05:30
Khushboo Vashi 5656f756e6 Ensure that the dependencies tab shows correct information for Synonyms. Fixes #5422 2020-05-04 12:23:18 +05:30
Khushboo Vashi 88aebb64f9 Fixed failed to fetch utility error when click on refresh(any option) materialized view. Fixes #5447 
It's a regression of #5213
 2020-04-28 11:00:23 +05:30
Khushboo Vashi 0f6abcc7fa Fixed an issue where the user is not able to create a server if login with an LDAP account. Fixes #5439 
Improved LDAP error messages.
 2020-04-27 15:33:19 +05:30
Khushboo Vashi b0464500ca Ensure that the user should not be able to change the authentication source. Fixes #5419 
Ensure error should be handled properly when LDAP user is created with the same name. Fixes #5420
Fixed an issue where an internal user is not created if the authentication source is set to internal and ldap. Fixes #5432
 2020-04-22 18:47:13 +05:30
Khushboo Vashi 6e5dbf7beb Added multiple drop/delete functionality for the table constraints. Fixes #3900 2020-04-22 18:47:13 +05:30
Khushboo Vashi 738c421edf Ensure that Constraint Trigger, Deferrable, Deferred option should be disabled when the user selects EDB-SPL function for the trigger. Fixes #4957 2020-04-16 12:38:20 +05:30
Khushboo Vashi ed0a596286 Added alert message to Reset Layout if any of the panels from Query Tool failed to load. Fixes #5366 2020-04-15 16:23:54 +05:30
Khushboo Vashi a0fcb38e68 Fixed syntax error while refreshing the existing synonyms. Fixes #5383 2020-04-14 13:43:56 +05:30
Khushboo Vashi 030741bba5 Modified some logic for the EPAS server as the user can change the view definition without dropping it. Fixes #5053 2020-04-13 16:00:01 +05:30
Khushboo Vashi e238ecf182 Ensure that OID should be shown in properties for Synonyms. Fixes #5270 2020-04-10 13:19:52 +05:30
Khushboo Vashi f4607885e1 Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053 
PostgreSQL doesn't allow to change the view columns. So the view should be dropped first
and then recreate it and also the user will get a warning first.
 2020-04-08 11:29:03 +05:30
Khushboo Vashi f77aa3284f Added LDAP authentication support. Fixes #2186 2020-04-06 15:57:05 +05:30
Khushboo Vashi 3b1c8abd2f Fixed following issue of schema diff tool: 
1. Comparison result of 2 exact identical Trigger Functions is different
 2. EPAS 12: Table comparison with the compound trigger shown as different, but all SQL panels are blank
 3. Compound trigger properties panel is not opening
 4. The DDL difference of the table containing the foreign key is not accurate
 5. The DDL difference of the view which refers the table from schema is not accurate
 6. DDL comparison fails if we have procedure with plpgsql in source and edbsql in target
 2020-01-31 21:28:08 +05:30
Khushboo Vashi c418a9c9ca Fixed following schema diff issues: 
1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target.
  2) We should handle schema diff if the user stops the server after compare.
  3) The data type is not visible for column headers in the query tool/view data.
  4) Difference SQL is shown, though source & target SQL are same.
  5) Error is shown when the 'target only' table is selected & clicked on Generate Script.
  6) Difference SQL generated on deleting primary constraints from source throwing error on running from query tool.
  7) Copy button for Difference SQL does not work.
  8) Incorrect SQL is generated when check constraint from the source table is dropped.
  9) Difference SQL is NOT shown when 'Unique Constraint' is dropped from the source table.
 10) In case of difference, no message displayed related to copied successfully or not.
 11) create or replace trigger should be on the next line.
 12) Comparison Result of exactly identical tables having foreign key constraints is shown as different.
 13) The wrong SQL displayed in the difference tab for view and materialized view for the select statements.
 14) Wrong SQL displayed for the procedure in the difference section.
 15) If the user already opens the compare section of Schema diff tool and Disconnects the server then '<' not supported between instances of 'NoneType' and 'int' message displayed.
 16) When 'check constraint' is added on the source table which has already unique constraint & identical target table is created, all SQL panels remain empty.
 17) Difference SQL is NOT shown when after adding 'Foreign Key' constraint to existing source table.
 18) Incorrect SQL is generated when the existing index on the source table is modified.
 19) Wrong SQL displayed for function in difference section.
 20) Additional space is added before & after in difference SQL generated on the addition of an index to the source table.
 21) Difference SQL is NOT shown when tables have different permission/grants.
 22) Incorrect SQL is shown when the source had inherited table & target has a normal table.
 23) Exactly identical child(inherited) tables show difference SQL.
 24) Comparison is NOT working when the custom vacuum is enabled & one of the parameter modified & again custom vacuum is disabled.
 2020-01-28 14:53:17 +05:30
Khushboo Vashi d59816054f Schema Diff Improvements: 
1. Grid header should be center aligned vertically.
2. Increase the space between object counts.
3. The previous selected objects should not be re-selected on comparison.
 2020-01-13 18:19:07 +05:30
Khushboo Vashi 45f2e35a99 Added Schema Diff tool to compare two schemas and generate the difference script. 
Currently supported objects are Table, View, Materialized View, Function and Procedure.

Backend comparison of two schemas implemented by: Akshay Joshi

Fixes #3452.
 2020-01-10 15:42:09 +05:30
Khushboo Vashi f495af7a76 Refactored SQL of Views and Materialized Views. Fixes #5023. 2019-12-20 17:14:15 +05:30
Khushboo Vashi cb26ca0e46 Fix XSS issue in explain and explain analyze for table and type which contain HTML. Fixes #4947. 2019-12-09 18:00:56 +05:30
Khushboo Vashi d476343b99 Enhance the logic to change the label from 'Delete/Drop' to 'Remove' for the server and server group node. Fixes #4923 2019-12-03 11:52:02 +05:30
Khushboo Vashi ae2aadeede Fix an issue where pgAdmin4 unable to retrieve table node if the trigger is already disabled and the user clicks on Enable All. Fixes #4953. 2019-12-02 15:26:36 +05:30
Khushboo Vashi cccc6e5676 Added role=status attribute to all the status messages for accessibility. Fixes #4773. 2019-12-02 14:15:31 +05:30
Khushboo Vashi 56e00d74ad There is no option to Copy data with headers from Query Tool/View Data. 
Added drop-down 'Copy with headers' near to the copy button in Query Tool/View Data.

Fixes #3009
 2019-09-27 12:14:39 +05:30
Khushboo Vashi aa668856f7 1) Add Reverse Engineered and Modified SQL tests for Primary Keys. Fixes #4624. 
2) Ensure Primary Key should be created with Index. Fixes #4742.
 2019-09-16 12:05:29 +05:30
Khushboo Vashi ed76787b76 Fix the Transaction Status failed test cases. 2019-08-20 10:22:11 +05:30
Khushboo Vashi c29275011a Ensure the comment on a Primary Key constraint can be edited under the Table node. Fixes #4581 2019-08-08 09:52:10 +01:00
Khushboo Vashi f8afe2ef94 Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555 2019-08-05 16:25:55 +05:30
Khushboo Vashi adb5cd34bf Add support for planner support functions in PostgreSQL 12+ functions. Fixes #4333 2019-07-25 16:09:37 +01:00
Khushboo Vashi c019778a47 1) Fix an error while retrieving json data from the table. Fixes #4427 
2) Fix an issue where Explain and Explain Analyze are not working, it's regression of #1760. Fixes #4484
3) Fix an issue where Filter toolbar button is not working in view/edit data, it's regression of keyboard navigation. Fixes #4485
 2019-07-22 18:42:48 +05:30
Khushboo Vashi 8168f623c4 Add Reverse Engineered SQL tests for Constraints. Fixes #4475 2019-07-17 13:25:08 +01:00
Khushboo Vashi 79e6f4c008 Add Reverse Engineered SQL tests for Collations. Fixes #4464 
This also adds the ability to test the msql output in ALTER steps.
 2019-07-12 14:37:00 +01:00