Commit Graph

2261 Commits

Author SHA1 Message Date
Aditya Toshniwal
9c30d983bd Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
 2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
 3) Check sign beside options in Execute Option/Copy Header is little bit big
 4) In explain > Analysis tab does not show ROWS column
 5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
 6) Update new query tool connection tool tip. Fixes #7289
 7) Explain-Analyze > Loops column is empty.
 8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
 9) Explain-Analyze with all option checked > background colors are missing for timing.
 10) Explain-Analyze > Additional bullet is added before Hash Cond.
 11) Browser Tree > Filtered rows icon is not working.
 12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
 13) Disable execute options in View/Edit data.
 14) The Boolean column always shows null.
 15) In Query history Remove & Remove all buttons are stuck to each other.
 16) On Remove all, the right panel is empty.
 17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
 18) In query history - Select queries are suffixed by ’Save Data’ icon
 19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
 20) Clicking arrows after opening dropdown options, does not collapse dropdown.

refs #6131
2022-04-18 12:50:51 +05:30
Akshay Joshi
86a3696ab4 Remove aciTree and its references. 2022-04-13 17:35:01 +05:30
Khushboo Vashi
0c823455a0 Disable the master password requirement when using alternative authentication sources. Fixes #7012 2022-04-11 13:45:53 +05:30
Pradip Parkale
c2f1a7bdc5 Ensure the database and schema restriction controls are not shown as a drop-down. Fixes #7255 2022-04-09 12:09:35 +05:30
Aditya Toshniwal
b5b9ee46a1 1) Port query tool to React. Fixes #6131
2) Added status bar to the Query Tool. Fixes #3253
3) Ensure that row numbers should be visible in view when scrolling horizontally. Fixes #3989
4) Allow removing a single query history. Refs #4113
5) Partially fixed Macros usability issues. Ref #6969
6) Fixed an issue where the Query tool opens on minimum size if the user opens multiple query tool Window quickly. Fixes #6725
7) Relocate GIS Viewer Button to the Left Side of the Results Table. Fixes #6830
8) Fixed an issue where the connection bar is not visible. Fixes #7188
9) Fixed an issue where an Empty message popup after running a query. Fixes #7260
10) Ensure that Autocomplete should work after changing the connection. Fixes #7262
11) Fixed an issue where the copy and paste row does not work if the first column contains no data. Fixes #7294
2022-04-07 17:36:56 +05:30
Akshay Joshi
3b35398925 Ensure that the error message 'CRYPTKEY_NOT_SET' is not displayed. 2022-04-05 17:01:12 +05:30
Pradip Parkale
8f8adcf71b 1 Fixed the issue where db connection was getting disconnected for dashboard, if network is slow.
2 Fixed publication collection node properties issue which was missed during react node porting.
3 Removed unwanted variable from theme style sheet.
2022-04-05 13:40:22 +05:30
Pradip Parkale
b397ba7787 Fixed issues related to porting of properties collection and dashboard.
refs #7132
2022-04-04 17:42:42 +05:30
Akshay Joshi
38278c179e Ensure that the master password dialog is popped up if the crypt key is missing. Fixes #6960 2022-04-04 17:00:18 +05:30
Pradip Parkale
fe416c838b Fixed an issue where the browser tree state was not preserved correctly. Fixes #7176 2022-03-31 18:28:36 +05:30
Pradip Parkale
cb052f1988 1) Port Properties panel for collection node, Dashboard, and SQL panel in React. Fixes #7132
2) Added transaction start time to Server activity sessions view. Fixes #7215
2022-03-30 12:06:59 +05:30
Yogesh Mahajan
02e799c917 Fixed RESQL test cases for PG14. 2022-03-29 14:56:45 +05:30
Yogesh Mahajan
7f2ff5af5c Fixed an issue where SQL for revoke statements are not shown for databases. Fixes #4258 2022-03-28 17:35:54 +05:30
Aditya Toshniwal
903b300b9e 1) Added support for unique keys in ERD. Fixes #7249
2) Fixed an issue where foreign key relationships do not update when the primary key is modified. Fixes #7197
2022-03-28 16:26:43 +05:30
Akshay Joshi
9f992a9e5d Fixed schema diff issue where function's difference DDL was showing incorrectly when arguments had default values with commas. Fixes #7263 2022-03-28 13:33:35 +05:30
Akshay Joshi
d548a5bc50 Fixed schema diff issue in which the option 'null' doesn't appear in the DDL statement for the foreign table. Fixes #7265 2022-03-25 16:39:20 +05:30
Akshay Joshi
826d2d913c Fixed API and RESQL test case for Resource Groups. 2022-03-25 12:51:39 +05:30
Nikhil Mohite
0b4a874f30 Fixed an issue where unexpected error messages are displayed when users change the language via preferences. Fixes #7267 2022-03-24 16:08:13 +05:30
Akshay Joshi
473afd950c Ensure objects depending on extensions are not displayed in Schema Diff. Fixes #7221 2022-03-24 15:59:02 +05:30
Nikhil Mohite
2f37f0ca51 Fixes for the preferences dialog
1) Add server mode validation in the binary path.
  2) Updated preferences tree rendering to avoid using the ReactDOM render.
  3) Updated CSS for keyboard shortcuts checkbox border makes it consistent with input box border.
  4) Fixed jasmine test case and improved code coverage.
  5) Fixed SonarQube issues.
  6) Added validation to disable "Maximum column with" option if "Column sized by" option is set to "Column name" in Query Tool -> Result grid.
  7) Updated documentation with the latest screenshots.
  8) Correct typo in the documentation. Fixes #7261

refs #7149
2022-03-23 13:28:35 +05:30
Akshay Joshi
ba027e992e Ensure that the values of certain fields are prettified in the statistics tab for collection nodes. Fixes #7216 2022-03-22 14:53:12 +05:30
Nikhil Mohite
74e794b416 Port preferences dialog to React. Fixes #7149 2022-03-21 13:29:26 +05:30
Akshay Joshi
e256f734df Fixed a schema diff issue where difference SQL isn't generated when foreign key values for a table differ. Fixes #7220 2022-03-10 14:41:21 +05:30
Nikhil Mohite
1b7dce124b Fixes an issue where the connect server/database menu was not updated correctly. Fixes #7186 2022-03-07 15:28:28 +05:30
Akshay Joshi
1af431dcc2 Fixed a schema diff issue in which user mappings were not compared correctly. Fixes #6956 2022-03-04 17:21:30 +05:30
Dave Page
83660ec9ed Update EPAS server icon. 2022-03-02 13:30:59 +00:00
Akshay Joshi
cbd29cf45b Change the hostname validation to check only for leading and trailing spaces.
refs #7181
2022-02-18 11:39:11 +05:30
Akshay Joshi
b1221d5517 Ensure that the user should be able to add new server with unix socket connection. Fixes #7181 2022-02-16 13:20:40 +05:30
Akshay Joshi
5a8c916bc0 Added comments column for the functions collection node. Fixes #7152 2022-02-16 12:22:52 +05:30
Akshay Joshi
677221cd9c Rename the menu 'Disconnect Database' to 'Disconnect from database'. Fixes #7180 2022-02-15 18:34:31 +05:30
Khushboo Vashi
e61a1045f5 Added capability to deploy PostgreSQL servers on Amazon RDS. Fixes #7177 2022-02-14 12:13:48 +05:30
Aditya Toshniwal
bc4e8a3c82 Implemented utilities in React to make porting easier for pgAdmin tools. 2022-02-11 10:36:24 +05:30
Yogesh Mahajan
76a4dee451 Fixed the schema diff issue where tables have different column positions and a column has a default value. Fixes #7124 2022-02-11 10:21:43 +05:30
Akshay Joshi
6d1926bb63 Rename the menu 'Disconnect Server' to 'Disconnect from server'. Fixes #7163 2022-02-07 16:12:30 +05:30
Yogesh Mahajan
1141aeb524 1) Fixes the incorrect title shown for the error message in restore/backup.
2) Doc updates for webserver authentication.
3) Cleanup task for API tests.
2022-02-07 11:51:27 +05:30
Nikhil Mohite
4a195e7ef6 Fixed value error in the restore dialog. Fixes #7151 2022-02-03 17:44:54 +05:30
Akshay Joshi
78f0c9c4a5 Ensure that owner should be ignored while comparing extensions. Fixes #7145 2022-02-02 11:25:07 +05:30
Akshay Joshi
fddcbbff67 Fixed event trigger comparing issue in Schema Diff tool. Fixes #7146 2022-02-01 14:14:18 +05:30
Akshay Joshi
aa5b1d50b9 Fixed issues introduce by SonarQube fixes. 2022-02-01 14:11:18 +05:30
Aditya Toshniwal
bc0b25d995 1) Fixed an issue where a warning message was shown after database creation/modification. Fixes #7142.
2) Added error boundary to schema view which will improve the exception stack trace details.
3) Fixed Jasmine test cases.
2022-01-31 13:41:22 +05:30
Nikhil Mohite
37d82d457c Fixed an issue where the F2 Function key removes browser panel contents. Fixes #7126 2022-01-28 10:55:23 +05:30
Akshay Joshi
0ce3434631 Fixed code smell 'Update this function so that its implementation is not identical' reported by SonarQube. 2022-01-25 20:10:31 +05:30
Pradip Parkale
094129e2be Port Dependent, dependencies, statistics panel to React. Fixes #7016 2022-01-24 14:13:02 +05:30
Akshay Joshi
3e86ed5d21 Added validation for Hostname in the server dialog. Fixes #7127 2022-01-24 12:04:35 +05:30
Nikhil Mohite
41bcce09ce Remove the support of the 'Move object to another tablespace' feature. 2022-01-21 19:39:21 +05:30
Akshay Joshi
343c3ee49c Fixed following code smells reported by SonarQube:
1) Remove this redundant jump.
 2) Remove this commented out code.
 3) Variables should not be shadowed.
2022-01-21 18:54:23 +05:30
Yogesh Mahajan
c983aae881 Port Import/Export dialog to React. Fixes #7017. 2022-01-21 11:48:52 +05:30
Akshay Joshi
1013d7ccdd Fixed code smell reported by SonarQube. 2022-01-20 16:58:21 +05:30
Nikhil Mohite
d945c6f843 Fixed an issue where connections keep open to (closed) connections on the initial connection to the database server. Fixes #7035 2022-01-19 15:02:05 +05:30
Akshay Joshi
dabe64a8df Fixed enable/disable menu issue introduced by SonarQube fix. 2022-01-19 12:16:57 +05:30
Akshay Joshi
6adc1bfd42 Fixed context menu issue. 2022-01-18 18:43:34 +05:30
Akshay Joshi
9f836f5433 Fixed following code smells reported by SonarQube:
1) Immediately return this expression instead of assigning it to the temporary variable.
 2) Extract this nested ternary operation into an independent statement.
 3) Expected a `for-of` loop instead of a `for` loop with this simple iteration.
2022-01-18 14:49:54 +05:30
Akshay Joshi
e3807ec3d6 Fixed following code smells reported by SonarQube:
1) Boolean checks should not be inverted.
 2) Review this redundant assignment.
 3) Extract this nested ternary operation into an independent statement.
 4) Unexpected empty function.
 5) Immediately return this expression instead of assigning it to the temporary variable.
2022-01-17 13:56:01 +05:30
Akshay Joshi
3f7e921cce Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 18:59:21 +05:30
Akshay Joshi
4e414f57e6 Fixed code smell 'Default parameters should be last' reported by SonarQube. 2022-01-12 18:40:18 +05:30
Akshay Joshi
c98fb887cc Fixed code smell 'Unexpected empty arrow function' reported by SonarQube. 2022-01-12 17:32:20 +05:30
Nikhil Mohite
d2457f2a1d Ensure that Partitioned tables should be visible correctly when creating multiple partition levels. Fixes #7085 2022-01-12 16:29:13 +05:30
Akshay Joshi
e38c38cd58 Fixed following SonarQube code smells:
1) Remove this useless assignment to a variable.
2) Remove the unused local variable.
2022-01-12 14:53:19 +05:30
Nikhil Mohite
374c5e952f Fixed an issue where the Browser tree gets disappears when scrolling sequences. Fixes #7100 2022-01-11 18:03:11 +05:30
Nikhil Mohite
af6ff20020 Fixed SonarQube issues. 2022-01-07 19:58:19 +05:30
Rahul Shirsat
6528d086ba Fixed review comments:
1. Split the restore options/backup options into 2 tabs
2. Restore icon changes
3. feature tests issues
4. restore help link broken
5. Comment section not visible

refs #7018
2022-01-06 16:46:44 +05:30
Akshay Joshi
f56b4030f1 Fixed a schema diff issue where generated script adds unwanted line endings for Functions/Procedures/Trigger Functions. Fixes #7102 2022-01-06 13:08:50 +05:30
Akshay Joshi
2786f7ac5a Update copyright notices for 2022 2022-01-04 13:54:25 +05:30
Yogesh Mahajan
44ab4648a8 Fixed an issue in SQL generation for PostgreSQL-14 functions. Fixes #7081 2021-12-31 14:30:53 +05:30
Nikhil Mohite
19016c3733 Ensure that help should be visible properly for Procedures. Fixes #7075 2021-12-31 14:21:38 +05:30
Yogesh Mahajan
0ceb2e2767 Ensure that Truncate and Reset statistics should work. Fixes #7096 2021-12-30 12:19:33 +05:30
Nikhil Mohite
191e2b6242 Fixed an issue where an operation error message pop up showing the database object's name incorrectly. Fixes #7078 2021-12-28 13:49:04 +05:30
Rahul Shirsat
603d91be0e Port Restore dialog to React. Fixes #7018 2021-12-28 13:45:59 +05:30
Yogesh Mahajan
6d0ed91d31 Fixed an issue where the Owner is not displayed in the reverse engineering SQL for Procedures. Fixes #7077 2021-12-24 16:09:51 +05:30
Nikhil Mohite
461c0abce1 Fixed an issue where Tablespace is created though an error is shown on the dialog. Fixes #6745 2021-12-21 18:07:17 +05:30
Akshay Joshi
92a997b16a Rearrange tools menu on the basis of usability and form groups of similar sub-menus. 2021-12-16 18:29:44 +05:30
Aditya Toshniwal
6875d00e44 Fixed an issue where confirmation pop-up is hidden behind Reassign/Drop Owned Dialog. Fixes #7071 2021-12-14 16:42:06 +05:30
Akshay Joshi
bd545fd5b2 1) Fixed schema diff owner related issue. Fixes #6877
2) Fixed schema diff related some issues. Fixes #6957
2021-12-11 22:10:28 +05:30
Nikhil Mohite
9ec8d05a64 1) Ensure that the Owner should not be disabled while creating the procedure. Fixes #7064
2) Fixed an issue where Explain Analyze shows negative exclusive time. Fixes #7003
2021-12-09 16:59:43 +05:30
Akshay Joshi
f24348b2b0 Fixed an issue where notifier not working when opening query tool in a new
window and then open it in the new tab.
2021-12-08 18:15:13 +05:30
Rahul Shirsat
91a288c2bb Correct the SQL definition for function/procedure with the Atomic keyword in PG14. Fixes #7029 2021-12-08 12:31:59 +05:30
Akshay Joshi
fd53e4f5f9 Replace Alertify alert and confirm with React-based model dialog. Fixes #7053 2021-12-07 18:52:40 +05:30
Akshay Joshi
e327066523 Fixed RESQL test cases for EPAS-14 2021-12-07 11:48:27 +05:30
Ashesh Vashi
36c9eb3dfd Added support for Two-factor authentication for improving security. Fixes #6543 2021-12-02 16:47:18 +05:30
Akshay Joshi
c6424e3897 Replaced alertifyjs notifiers with React-based notistack. Fixes #7004 2021-12-02 16:05:52 +05:30
Akshay Joshi
2c02e6fc23 Ensure that the user should be allowed to set the schema of an extension while creating it. Fixes #6963 2021-11-29 15:27:44 +05:30
Nikhil Mohite
61b440261f Ensure that sort order should be maintained when renaming a server group. Fixes #6955 2021-11-29 12:04:04 +05:30
Akshay Joshi
fbd10ef4b6 Fixed an issue where reverse engineering SQL is wrong for Aggregate. Fixes #7024 2021-11-29 12:00:38 +05:30
Akshay Joshi
d644b4f94e 1) Replace Flask-BabelEx with Flask-Babel. Fixes #6088
2) Upgrade Flask to version 2. Fixes #7010
2021-11-24 17:22:57 +05:30
Nikhil Mohite
3a30f27153 1. Updated notification message for the reset layout.
2. Added notification type in alertify which was missing.

refs #6988
2021-11-24 10:58:15 +05:30
Nikhil Mohite
3afeb8ca46 Port Backup Global, Backup Server, and Backup object dialog in React. Fixes #6984 2021-11-22 11:20:44 +05:30
Akshay Joshi
a701e8c766 Fixed an issue where the Change Password menu option is missing for internal
authentication source when more than one authentication source is defined.

Fixes #6989
2021-11-22 11:02:26 +05:30
Nikhil Mohite
cc91e5da94 Fixed an issue where properties of the database should not be visible after removing the database.
Fixes #6964
2021-11-18 12:36:39 +05:30
Nikhil Mohite
3d5d507f4b Fixed an issue where referenced table drop-down should be disabled in
foreign key -> columns after one row is added.

Fixes #6906
2021-11-18 12:22:14 +05:30
Nikhil Mohite
1408bad8ba Fixed an issue where reset layout message showing when the user opens the query tool.
refs #6988
2021-11-15 16:34:25 +05:30
Pradip Parkale
33cc2a7514 Fixed an issue where SQL for index shows the same column multiple times. Fixes #6981 2021-11-15 16:31:40 +05:30
Akshay Joshi
0ca7dbccf6 Ensure that the Binary path for PG14 should be visible in the preferences. Fixes #6972 2021-11-15 12:44:33 +05:30
Nikhil Mohite
8bf178b0a3 Reset the layout if pgAdmin4 detects the layout is in an inconsistent state. Fixes #6988 2021-11-12 11:50:37 +05:30
Pradip Parkale
d4bf7164f9 Ensure that inherit table icon should be visible properly in the tree view. Fixes #6845 2021-11-11 12:55:38 +05:30
Nikhil Mohite
7468ca36ae Fixed SQL syntax error if select "Custom auto-vacuum" option and not set Autovacuum option to Yes or No. Fixes #6925 2021-11-11 12:36:19 +05:30
Pradip Parkale
a61a9e5b8f Fixed an issue where older server group name displayed in the confirmation
pop-up when the user removes server group. Fixes #6939
2021-11-10 11:17:51 +05:30
Pradip Parkale
eb8168285e Cover more scenarios for the pgAdmin freezing issue. Fixes #5427 2021-11-10 11:11:24 +05:30
Akshay Joshi
719f8c8fd2 Fixed API test case for DataTypeReader 2021-10-29 17:37:02 +05:30
Pradip Parkale
fa8b3edda5 Fixed an issue where user details are not shown when the non-admin user tries
to connect to the shared server. Fixes #6940
2021-10-29 16:26:11 +05:30
Nikhil Mohite
f71e2e8040 Fixed an issue where pgAdmin is not opening properly. Fixes #6809 2021-10-29 16:17:36 +05:30
Akshay Joshi
39992a817d Added support of Aggregate and Operator node in view-only mode. Fixes #3834 2021-10-29 16:14:33 +05:30
Akshay Joshi
7b85253465 Corrected some menu lables. 2021-10-27 11:05:23 +05:30
Pradip Parkale
35b1e1d0d2 Fixed pgAdmin freezing issue by providing the error message for the operation
that can't perform due to lock on the particular table. Fixes #5427
2021-10-27 10:51:52 +05:30
Rahul Shirsat
711ea3bfa1 Fixed an issue where properties panel is not updated when any object is added from the browser tree. Fixes #6859 2021-10-27 10:31:49 +05:30
Rahul Shirsat
8eb6f8061d Ensure that dialog should be opened when clicking on Reassign/Drop owned menu. Fixes #6949 2021-10-25 11:47:28 +05:30
Pradip Parkale
c7cd57db91 Ensure that columns should be merged if the newly added column is present in the parent table. Fixes #6780 2021-10-21 10:59:52 +05:30
Akshay Joshi
d2a7f7fffe Fixed API test cases for PG 14 2021-10-20 18:39:42 +05:30
Rahul Shirsat
27b6e07e21 Fixed object delete issue from the properties tab for the collection nodes. Fixes #6858 2021-10-19 17:21:46 +05:30
Akshay Joshi
ea0d3eb812 Fixed an issue where a blank string is stored instead of NULL in create mode in server dialog. Fixes #6915 2021-10-19 17:01:50 +05:30
Aditya Toshniwal
9de1489322 Ensure that only the table node should be allowed to drop on the ERD tool. Fixes #6929 2021-10-19 12:01:43 +05:30
Khushboo Vashi
9e3165c0ff 1) Ensure that the master password should be prompt when MASTER_PASSWORD_REQUIRED
is set to True and AUTHENTICATION_SOURCES is the webserver. Fixes #6928
2) Fixed an issue where the existing server group is disappeared on rename it. Fixes #6930
2021-10-19 11:56:44 +05:30
Akshay Joshi
b8072bd630 Fixed an issue where the blank string is stored instead of NULL in the server table of SQLite database. Fixes #6915 2021-10-18 15:50:42 +05:30
Aditya Toshniwal
7f3c3fa6f9 Added support to allow tables to be dragged to ERD Tool. Fixes #6241 2021-10-16 12:43:39 +05:30
Nikhil Mohite
476d7c5fc9 Fixed background colour issue in the browser tree. Fixes #6890 2021-10-16 12:40:57 +05:30
Rahul Shirsat
1377244e52 Fixed the issue of editing triggers for advanced servers. Fixes #6802 2021-10-16 12:36:25 +05:30
Pradip Parkale
173cb60691 Added support to enable/disable rules. Fixes #6794 2021-10-14 11:44:03 +05:30
Nikhil Mohite
fa21e25cb2 Ensure that the Dashboard should get updated after connecting to the server. Fixes #6876 2021-10-14 11:24:43 +05:30
huangj.fnst@fujitsu.com
8a21d9b500 Fixed some typos in the documentation and comments. 2021-10-14 11:13:16 +05:30
Aditya Toshniwal
8b7b63868f Added support for composite foreign keys in the ERD tool. Fixes #6891 2021-10-13 14:28:55 +05:30
Nikhil Mohite
96ce298789 Port columns node under the Catalog Objects in React. 2021-10-13 12:59:08 +05:30
Yogesh Mahajan
6c692df118 Changed the label 'Inherits Tables?' to 'Is inherited?' as it misleading in the properties panel. Fixes #6776 2021-10-13 11:41:21 +05:30
Nikhil Mohite
5b9383c880 Fixed an issue where the user is unable to create an index with concurrently keyword. Fixes #6790 2021-10-12 18:19:40 +05:30
Khushboo Vashi
a726635290 1) Added support for authentication via the web server (REMOTE_USER). Fixes #6657
2) Fixed OAuth2 integration redirect issue. Fixes #6719

Initial patch for 6657 sent by: Tom Schreiber
2021-10-12 14:52:30 +05:30
Aditya Toshniwal
a92c1b43a2 1) Added support for advanced table fields like the foreign key, primary key in the ERD tool. Fixes #6081
2) Added index creation when generating SQL in the ERD tool. Fixes #6529
2021-10-11 17:42:14 +05:30
Nikhil Mohite
d65930a8a6 Remove an extra blank line at the start of the SQL for function, procedure, and trigger function. Fixes #6797 2021-10-07 17:11:48 +05:30
Aditya Toshniwal
a92bad7909 Fixed indexes not loading in Primary constraint and Unique constraint dialog for partition.
refs #6868
2021-10-06 17:49:50 +05:30
Aditya Toshniwal
7787def660 The nodes index, RLS policy, rules, triggers are failing to save for partitions.
refs #6868
2021-10-06 16:51:46 +05:30
Aditya Toshniwal
dce5038ffd 1. Unable to create trigger for partition table. Fixes #6867.
2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868.
2021-10-06 14:54:01 +05:30
Akshay Joshi
1ed6272e7b Ensure that SQL help should work for EPAS servers. Fixes #6834 2021-10-06 14:54:01 +05:30
Khushboo Vashi
a693014371 1) Table Dialogue does not close on addition/deletion of partition. Fixes #6863
2) Nodes are loaded multiple times in server mode on 'Reset Layout'. Fixes #6861
2021-10-05 17:33:50 +05:30
Rahul Shirsat
bfb65e82aa Fixed dialog crash issue when added security label and changing the type to shell. Fixes #6744 2021-10-05 17:24:16 +05:30
Pradip Parkale
4bbc811aed 1) 'Only Table' should be disabled unless the table value is changed. Fixes #6862.
2) 'ALTER' statement should not be generated every time a user updates the password in edit mode. Fixes #6835
3) Connection timeout and sslmode value is getting updated after subscription update. Fixes #6835.
2021-10-05 17:19:22 +05:30
Aditya Toshniwal
400896c563 1. Operators dropdown disabled. Fixes #6771.
2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781.
2021-10-05 14:13:15 +05:30
Rahul Shirsat
2932ef770d Fixed an issue where adding security privileges and change type to shell crash the dialog. Fixes #6744 2021-10-04 19:34:41 +05:30
Aditya Toshniwal
7eaa3179ad Fixed an issue where the index is not loaded in the Unique Constraint dialog. Fixes #6857 2021-10-04 19:28:27 +05:30
Aditya Toshniwal
e77f933fe7 Foreign key issues in edit mode:
1. Couple of foreign key issues in edit mode. Fixes #6837
2. Table "Of type" related issues. Fixes #6825
2021-10-04 14:14:27 +05:30
Pradip Parkale
69109a19db Ensure that the user should be able to edit the publication in the subscription dialog. Fixes #6835 2021-10-04 14:11:57 +05:30
Aditya Toshniwal
038fd6ce21 Fixed Dark theme UI related issues. Fixes #6846 2021-10-04 12:41:48 +05:30
Khushboo Vashi
44e1a405f0 1) Newly added server/server group is not visible in the tree unless pgAdmin is refreshed. Fixes #6839
2) Internal server error displayed if disconnect the server. Fixes #6852
2021-10-03 12:12:02 +05:30
Aditya Toshniwal
357a020828 Table node related fixes:
1. File select control sets the value for all other to last selected file. Fixes #6814
2. Vacuum parameters-related issues. Fixes #6777
3. Exclusion removes all columns if one row is removed. Fixes #6771
2021-10-01 12:57:04 +05:30
Khushboo Vashi
5e0c113c7b Properties panel is not updated when any object is added/deleted from the browser tree. Fixes #6833 2021-09-30 18:21:43 +05:30
Pradip Parkale
8056e7e3e3 1) System procedure should not be visible in the properties tab for function.
2) The estimated cost option should be editable in edit mode for Procedure.
3) Should give an error when language is not specified.

Fixes #6838 #6841
2021-09-30 16:27:02 +05:30
Rahul Shirsat
1632e5287a Fixed some additional issues for the Type node.
refs #6744
2021-09-30 15:16:21 +05:30
Akshay Joshi
031167fbea Use the correct way to update the state variable using depChange method. 2021-09-30 10:57:39 +05:30
Akshay Joshi
8ac38a076b Fixed linter error. 2021-09-29 20:17:54 +05:30
Nikhil Mohite
c80ea7ae89 1) Fixed accessibility issues for Trigger functions. Fixes #6803
2) Fixed incorrect privileges value in Materialize View. Fixes #6781
2021-09-29 19:56:30 +05:30
Akshay Joshi
1b6ab6b3bb 1) Fixed pgAgent related issues. Fixes #6827
2) Added helpMessageMode parameter to hide help messages from properties panel.
2021-09-29 19:48:43 +05:30
Khushboo Vashi
aa8854db53 1) Browser panel turns blank on connecting disconnected database & server has multiple databases. Fixes #6817
2) The object is not selected/properties panel is not updated when the user moves to object with arrow keys. Fixes #6821
3) Object gets deselected after editing. Fixes #6824
2021-09-29 17:18:55 +05:30
Aditya Toshniwal
c57fc74e18 Fixed Jasmine test cases. 2021-09-29 16:36:49 +05:30
Aditya Toshniwal
28892bb07f Remove redundant empty option for Exclusion constraint access method name, Of type, and Like relations. Fixes #6825 2021-09-29 15:23:48 +05:30
Akshay Joshi
82935ad3be Fixed API test caes for Domain node. 2021-09-29 15:20:50 +05:30
Aditya Toshniwal
332351efaf 1. Date time control not working on firefox.
2. Replace moment with date-fns in date time control as date-fns is more maintained.

Fixes #6816
2021-09-29 13:43:05 +05:30
Pradip Parkale
d753719891 1) Ensure the edit dialog should not allow clearing owner in the Language node. Fixes #6815
2) Fixed an issue where the Language node is disabled for the functions for
   EPAS/PG 9.6 and 10. Fixes #6823
2021-09-29 13:40:10 +05:30
Akshay Joshi
7d07770244 Reverting 'Two-factor authentication' support as it cause OSX and docker build failures.
This reverts commit 787a441343.
2021-09-29 13:24:18 +05:30
Aditya Toshniwal
08706ba6b2 1. Make Unlogged switch in table as read only.
2. Fix a console warning when saving node data.

Fixes #6778
2021-09-28 17:48:09 +05:30
Ashesh Vashi
787a441343 Added support for Two-factor authentication for improving security. Fixes #6543 2021-09-28 17:47:00 +05:30
Nikhil Mohite
c4db223a64 Added appropriate 'IF EXISTS', 'CASCADE', 'IF NOT EXISTS' clause for the remaining nodes.
refs #5741
2021-09-28 16:05:46 +05:30
Aditya Toshniwal
be69470d55 Server and Database node fixes:
1. Unable to change shared server switch.
2. DB restriction and schema restriction have an empty option.
3. File select input control does not allow manual text input.
4. In the Parameters tab if the value is a switch control, then an empty value error should not come.
5. Values for parameters should be reset on changing parameters.
6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if the mode is supported.

Fixes #6814
2021-09-28 15:05:32 +05:30
Akshay Joshi
1569be7866 Fixed keyerror issue in schema diff for 'attnum' and 'edit_types' parameter. Fixes #6755 2021-09-28 15:03:28 +05:30
Akshay Joshi
2265ffc0a7 Handler and Validator should not allow selecting the empty options. Fixes #6810 2021-09-28 11:34:45 +05:30
Pradip Parkale
d616cb88aa 1. Syntax error displayed If the table is not available and the user tries to use the blank option. Fixes #6793
2. Not able to add Parameters for Functions and Procedures.
3. For the procedure, the Volatility option should be disabled in some cases. Fixes #6799
2021-09-28 10:37:47 +05:30
Rahul Shirsat
15ecf5d821 Fixed an issue for sort and null controls for the Index node. Fixes #6791 2021-09-28 10:32:00 +05:30
Aditya Toshniwal
dc8ab7cd2a 1. Switch control and CodeMirror control UI improvements for read-only and disabled states.
2. If a form input value changes to null, pass it as an empty string in URL params.
3. Use server_type instead of type from the server info.
2021-09-28 10:24:25 +05:30
Nikhil Mohite
48a5143485 Fixed an issue where SQL is not getting generated for Foreign table options. Fixes #6813 2021-09-28 10:21:25 +05:30
Khushboo Vashi
483e2ca8d0 Port browser tree to React. Fixes #6129 2021-09-27 16:44:26 +05:30
zhangjie2@fujitsu.com
d983225683 Correct the variable names in the error messages for the Domain node. 2021-09-27 15:09:17 +05:30
Rahul Shirsat
d8d88b948a Fixed an issue where Schema icon is not visible in the drop-down of General tab. Fixes #6806 2021-09-27 13:36:13 +05:30
Nikhil Mohite
2320370fd2 1) Fixed an issue where for constraint trigger only After event should be displayed,
also fixed the Incorrect values for Constraint trigger, Deferrable, Deferred. Fixes #6803
2) Fixed an issue where the user was unable to create the trigger for views. Fixes #6804
2021-09-27 11:31:52 +05:30
Nikhil Mohite
9d2f3b5ee9 Ensure that RLS names should not be editable in the collection node of properties tab. Fixes #6759 2021-09-27 10:57:08 +05:30
Aditya Toshniwal
0228d16990 Partition related fixes:
1. When attaching a partition, tables were not loading in the dropdown.
2. When adding a sub partition in a partition, collations were not loading in dropdown.
3. Fix some grid column widths in table node.

Fixes #6783
2021-09-24 16:28:55 +05:30
Akshay Joshi
c32a325c11 Fixed html help for foreign server dialog. 2021-09-24 13:32:13 +05:30
Aditya Toshniwal
d28f8bc7ee Fixed exclusion constraint issues:
1. Incorrect error message.
2. Properties panel Column Section data missing
3. Operator class value is missing

Fixes #6771
2021-09-23 19:28:35 +05:30
Nikhil Mohite
a6dce27ffa Fixed an issue where options are missing in the trigger function's Security tab. Fixes #6792 2021-09-23 19:23:08 +05:30
Pradip Parkale
6d08d9aa9f Fixed Cast node related issues. Fixes #6741 2021-09-23 19:19:34 +05:30
Akshay Joshi
ecaaa8a1b5 Fixed scrollbar issue and used flex layout in grant wizard. 2021-09-23 16:59:59 +05:30
Akshay Joshi
b9bc628189 1. Placeholder should be inside the controlProps. Change the placeholder from 'Select...' to 'Select an item...'
2. Updated grant wizard screenshot and documentation.
3. Remove '(Beta)' from ERD Tool and PSQL Tool.
2021-09-23 16:17:39 +05:30
Aditya Toshniwal
0e6794f2f5 Fixed issue where modified SQL not loading Unique Constraint dialog. Fixes #6772 2021-09-23 14:47:31 +05:30
Aditya Toshniwal
9179b7464b Fixed following issues after React Porting:
1. Unique constraint should not allow changing values for deferrable, deferred, included columns.
2. Primary keys should not allow changing values for deferrable, deferred, included columns.
3. Foreign keys should not allow changing match type. The referenced table name is empty.
4. Exclude - Column/Expression has incorrect values.
5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited.

Fixes #6777
2021-09-23 14:46:10 +05:30
Nikhil Mohite
15a494c189 Fixed review comments for Grant Wizard.
refs #6687
2021-09-23 14:40:38 +05:30
Akshay Joshi
25c98f8054 Fixed API test case. 2021-09-23 12:09:24 +05:30
Aditya Toshniwal
78c8fbbe00 Fixed an issue where the Properties panel was not loaded for catalog tables. Fixes #6778 2021-09-23 10:42:50 +05:30
Nikhil Mohite
f192be3667 Added flag to check before adding 'IF NOT EXISTS' and 'OR REPLACE' clause to the SQL. While creating any object the respective clause should not be added. 2021-09-22 19:14:19 +05:30
Nikhil Mohite
05ce3445b5 Fixed incorrect privileges value in Materialize View. Fixes #6781 2021-09-22 18:46:43 +05:30
Aditya Toshniwal
a1aa080956 Fixed an issue where unable to change the column properties from edit dialog. Fixes #6766 2021-09-22 18:23:40 +05:30
Aditya Toshniwal
a8c8ea69e3 Foreign Key fixes:
1. Auto FK related fixes.
2. Properties tab not showing columns.
3. Toggle button is editable even if set to read-only.
4. Dropdown placeholder should be blank for read-only/disabled.
5. Input control help text color on a dark theme.

Fixes #6770
2021-09-22 18:18:09 +05:30
Aditya Toshniwal
fc86faf51e Changed the layout for tables from block layout to flex layout to fix the width of the columns as per the dialog size. 2021-09-22 18:11:50 +05:30
Akshay Joshi
f538546c4d Fixed validation issue in Synonyms dialog. Fixes #6767 2021-09-22 13:34:11 +05:30
Pradip Parkale
7330b3520f Fixed jasmine test cases. 2021-09-21 17:42:18 +05:30
Aditya Toshniwal
08009f8edc 1) Make default values column read-only for inherited columns when creating table.
2) Default values not populated for inherited columns. The existing issue, API changed.
3) Options are not populated for Name in Column > Variable tab.
4) The empty check error message is changed from Label cannot be empty to Label in Collection cannot be empty for collections.

Fixes #6763
2021-09-21 16:56:29 +05:30
Akshay Joshi
b60bd73f88 Fixed an issue where Refresh view options are not working for materialized view. Fixes #6736. 2021-09-21 16:48:10 +05:30
Aditya Toshniwal
af230c812b Synchronises the column's primary key flag and primary key constraint. Fixes #6762 2021-09-21 15:27:48 +05:30
Aditya Toshniwal
5f104b0e0e Fixed an issue where ERD table dialog is failing to open after React Porting 2021-09-21 15:11:17 +05:30
Akshay Joshi
56a17f7c8e Fixed RESQL test cases for Partition table using COLLATE. 2021-09-20 20:10:24 +05:30
Rahul Shirsat
c142296f3f Fixed following issues for Type dialog:
1. Enum Type - Unable to delete rows for Enum type in Create Type dialogue.
2. Range Type - Loading icons are shown in different drop-down tabs.

Fixes #6744
2021-09-20 13:12:23 +05:30
Nikhil Mohite
7aa213a5ce 1) Port Grant Wizard to react. Fixes #6687
2) Fixed an issue where grant wizard is unresponsive if the database size is huge. Fixes #2097
2021-09-20 13:02:41 +05:30
Rahul Shirsat
346ee6ba5f Fixed an issue where privileges not shown in catalog nodes for Properties tab. Fixes #6743 2021-09-17 20:50:29 +05:30
Aditya Toshniwal
32e97b6422 Fixed the CSS issue causing extra space at the bottom of maintenance backup dialog. 2021-09-17 20:47:03 +05:30
Pradip Parkale
89d40d38d9 Fixed jasmine test cases. 2021-09-15 11:42:23 +05:30
Akshay Joshi
460c66ab3f Fixed an issue where the drop cascade button enables for Databases. Fixes #6724 2021-09-10 18:27:16 +05:30
Pradip Parkale
dbf78bf214 Added support to create the Partitioned table should be created using COLLATE and opclass. Fixes #2546 2021-09-09 16:26:23 +05:30