Aditya Toshniwal
ed3c692b1f
Fixed an issue where the query tool is not fetching more than 1000 rows for the table does not have any primary key. Fixes #5845
2020-09-21 15:36:19 +05:30
Pradip Parkale
8e132eab08
Fixed some accessibility issues. Fixes #5732
2020-09-15 13:03:18 +05:30
Rahul Shirsat
8029d9e65e
1) Fixed internal server error when clicking on the open new query tool button
...
from the View/Edit Data window. Fixes #5831
2) Fixed schema diff panel title issue on new tab.
2020-09-14 17:42:59 +05:30
Akshay Joshi
a7d40e238e
Ensure that the 'CREATE SCHEMA' statement should be present in the generated script if the schema is not present in the target database. Fixes #5816
2020-09-11 19:06:56 +05:30
Rahul Shirsat
7fac72cac5
Fixed an issue where alert message should get displayed on active browser window.
...
refs #4059
2020-09-10 12:09:56 +05:30
Rahul Shirsat
62e6848dc8
1) Added tooltip & keyboard shortcut for the query tool button.
...
2) Fixed TypeError issue.
refs #4059
2020-09-09 19:32:33 +05:30
Aditya Toshniwal
535739c0c7
Fixed cognitive complexity issues reported by SonarQube.
2020-09-09 11:25:43 +05:30
Aditya Toshniwal
f8f00b4ecf
Fixed an issue in the query tool when columns are having the same name as javascript object internal functions. Fixes #5765 .
2020-09-07 18:10:27 +05:30
Khushboo Vashi
31bbdd6a12
Fixed code smell 'String literals should not be duplicated'.
2020-09-03 18:35:58 +05:30
Aditya Toshniwal
974d395a48
Fixed cognitive complexity issues reported by SonarQube.
2020-09-03 18:10:57 +05:30
Cyril Jouve
5a253f9053
Change the following to replace Python 2 code with Python 3:
...
1) Replace the deprecated unit test method.
2) Wraps filter usage in a list call.
3) Converts the old metaclass syntax to new.
4) Use range instead of xrange method.
5) Change Unicode to str.
6) Several other transformations.
7) Fixed change password test cases.
8) Use simplejson instead of plain JSON.
2020-08-31 16:45:31 +05:30
Yogesh Mahajan
3984544bdb
Fixed code smell 'String literals should not be duplicated'.
2020-08-28 18:17:27 +05:30
Rahul Shirsat
e8b192be3e
Added a new button to the query tool toolbar to open a new query tool window. Fixes #4059
2020-08-28 13:53:08 +05:30
Chethana Kumar
8222bf6420
Modified the 'Commit' and 'Rollback' query tool button icons. Fixes #5662
2020-08-27 12:58:13 +05:30
Nikhil Mohite
19491d79a5
Fixed cognitive complexity issues reported by SonarQube.
2020-08-21 13:52:05 +05:30
Akshay Joshi
fbbbc36221
Fixed code smell 'Define a constant instead of duplicating this literal' reported by SonarQube.
2020-08-20 20:26:51 +05:30
Akshay Joshi
103b08c9c5
Define constants for preferences label to fix SonarQube issues.
2020-08-20 17:58:37 +05:30
Dave Page
99a7ada58a
Cleanup a bunch of duplicated gettext calls.
2020-08-20 10:00:12 +01:00
Dave Page
79e6480513
Added SQL Formatter support in Query Tool. Fixes #2042
2020-08-20 13:05:00 +05:30
Nikhil Mohite
93adf6884f
Upgrade font awesome from v4 to v5. Fixes #5731
2020-08-13 12:04:00 +05:30
Cyril Jouve
36574b25b6
The 'str' object never has attribute decode in Python3, so remove the dead code.
2020-08-12 18:55:35 +05:30
Aditya Toshniwal
26a758a0d6
Fixed an issue where copying and pasting a cell with multiple line data
...
will result in multiple rows. Fixes #5526
Fixed an old issue where quotes are not escaped when copying the cells.
As per CSV standards, if the string is in double quotes and there are
double quotes inside the string then they should be escaped with extra double-quotes.
2020-08-10 16:53:32 +05:30
Aditya Toshniwal
d6400bbcae
Replace the generic exception class with a more specific one.
2020-08-07 12:37:00 +05:30
Yogesh Mahajan
e3dfe03a2a
Fixed an issue where the user is not able to insert the data if the table and columns name contains special characters. Fixes #4387
2020-08-06 12:30:10 +05:30
Aditya Toshniwal
aa679e06b2
Replace the generic exception class with a more specific one to fix SonarQube issues.
2020-08-05 12:41:28 +05:30
Yogesh Mahajan
43e127de31
Ensure that the original file format should be retained when saving the same file in SQL editor. Fixes #3767
2020-08-03 13:18:04 +05:30
Aditya Toshniwal
536593bf8a
Fixed following SonarQube issues:
...
- Remove this assignment to the local variable, the value is never used.
- Rename local variables to match the regular expression
- Add logic to this except clause or eliminate it and rethrow the exception automatically.
- Rename fields to match the regular expression
- Extract this nested conditional expression into an independent statement.
- Change this default value to "None" and initialize this parameter inside the function/method.
- Update this function so that its implementation is not identical to __repr__
- Refactor this method to not always return the same value
- Reraise this exception to stop the application as the user expects
- Add missing parameters _w _PY3. This method overrides simplejson.decoder.JSONDecoder.decode.
- Remove this redundant continue.
- Remove this unused function declaration
- Remove this identity check; it will always be False.
2020-08-03 12:59:51 +05:30
Nikhil Mohite
eb2c554601
Fixed cognitive complexity issues reported by SonarQube.
2020-08-03 12:46:34 +05:30
Aditya Toshniwal
56cf64ad22
Fixed following SonarQube issues:
...
- Refactor functions to not always return the same value.
- Rename "cls" to "self" or add the missing "self" parameter.
- Remove useless assignment to variables.
2020-07-30 14:04:22 +05:30
Yogesh Mahajan
043025d1eb
Fixed an issue where the user is not able to save the new row if the table is empty. Fixes #4810
2020-07-24 14:30:22 +05:30
Nikhil Mohite
5f619ae40a
Ensure that data output color is readable on row selection. Fixes #5687
2020-07-21 18:54:06 +05:30
Nikhil Mohite
7edcca9b07
Added High Contrast theme support. Fixes #5653
...
Fixed text color issue in explain analyze for the Dark theme. Fixes #5677
2020-07-20 11:51:21 +05:30
Aditya Toshniwal
161c9b0fc7
Fixed code smell 'Variables should not be shadowed'.
...
Fixed all the duplicate CSS blocks issues raised by SonarQube.
2020-07-14 15:45:01 +05:30
Aditya Toshniwal
357a9179b1
Fixed convention related issues reported by SonarQube.
2020-07-09 18:55:33 +05:30
Yogesh Mahajan
2cefa9afca
Fixed code smell 'Variables should not be shadowed'.
2020-07-09 18:44:58 +05:30
Yogesh Mahajan
707ff450b5
Fixed following SonarQube issues:
...
1. Boolean checks should not be inverted.
2. The comma operator should not be used.
3. Arguments to built-in functions should match documented types.
4. Redundant pairs of parentheses should be removed.
5. A conditionally executed single line should be denoted by indentation,
6. A while loop should be used instead of a 'for' loop.
2020-06-26 13:12:07 +05:30
Aditya Toshniwal
d3b3d07f2e
Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed.
2020-06-25 11:09:43 +05:30
Aditya Toshniwal
f0490a54b7
Fixed redundant tagged issue reported by SonarQube.
2020-06-18 11:14:56 +05:30
Aditya Toshniwal
641f7bbe9d
Some clumsy coding related fixes reported by SonarQube.
2020-06-15 16:50:07 +05:30
Aditya Toshniwal
eb971a0320
Update Codemirror version to the latest which allows us to set screen reader labels on Codemirror editor.
...
refs #5197
2020-06-08 12:26:12 +05:30
Satish V
726ecd79e6
Fixed import statements.
...
refs #3669
2020-06-03 12:49:05 +05:30
Satish V
d22e276586
Ensure that proper error should be displayed for the deleted node. Fixes #3669
2020-06-03 11:26:26 +05:30
Yogesh Mahajan
e10f1274dc
Ensure that the query tool panel gets closed when clicking on the 'Don't Save' button. Fixes #5416
2020-05-28 16:39:26 +05:30
Akshay Joshi
b1cbcc7ef6
Fixed data truncation issue when updating the data of type character with length. Fixes #5481
2020-05-25 17:05:47 +05:30
Khushboo Vashi
d68e6bd892
Remove Python2 modules.
...
refs #5443
2020-05-08 12:28:21 +05:30
Akshay Joshi
ad80217593
Remove Python2 references from the source code.
...
refs #5443
Initial patch: Neel Patel
2020-04-30 17:22:48 +05:30
Dave Page
86afec860f
Remove Python 2 support from the Python tests.
...
refs #5443
2020-04-30 12:56:45 +05:30
Nagesh Dhope
17129b259b
Reverting patch for RM #3269 .
...
We observed that sometimes the browser is getting hanged and sometimes
the ViewData grid is getting disappear. We suspect its due to the number
of rows to update on the slick grid after fetching next of rows.
2020-04-24 11:13:13 +05:30
navnath gadakh
c76732e3e7
Ensure that default sort order should be using the primary key in View/Edit data. Fixes #5157
2020-04-22 18:47:13 +05:30
Nagesh Dhope
5e91ed2bb1
Fixed slider jump issue by making an API call to fetch the next batch of rows only after a user stops scrolling down. Fixes #3269
2020-04-22 18:47:13 +05:30