IntenseWebs/pgadmin4
3
0 Fork 0
mirror of https://github.com/pgadmin-org/pgadmin4.git synced 2026-10-12 16:11:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
923 Commits 16 Branches 127 Tags
f17c2e3b84015666267676b582c29f2bd59f77cf
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Murtuza Zabuawala 5560d5b334 Properly support the interval type. Fixes #1437 2016-07-18 09:40:45 +01:00
Murtuza Zabuawala d15dfac60f FIx a hang in the query tool that could occur if a column type couldn't be determined. Fixes #1438 2016-07-15 12:59:01 +01:00
Murtuza Zabuawala e94b14e7d7 Fix the issue in MATERIALIZED VIEW node where user was not able to add/update security label. Fixes #1458 2016-07-15 12:13:57 +01:00
Murtuza Zabuawala 517a797947 Fix query tool display of various types: 
date
reltime
abstime
time with timezone
time without timezone
 2016-07-15 11:59:45 +01:00
Murtuza Zabuawala 573abbe6ef Allow users to select a data type with the keyboard only when creating a column in the subnode grid. Sanitise the list of fields shown. 2016-07-15 10:12:23 +01:00
Murtuza Zabuawala fdcb9d2a57 Fix an issue in procedure node where users were not able to create a new procedure when they provide arguments. Fixes #1416 2016-07-13 14:57:08 +01:00
Murtuza Zabuawala f79ca32e45 Allow selection of 'PUBLIC' as a role in privileges. Fixes #1416 2016-07-13 14:51:25 +01:00
Murtuza Zabuawala ae692d2416 Display comments on languages. Fixes #1412 2016-07-13 14:45:34 +01:00
Murtuza Zabuawala 3ee8861d44 Fix JSON type rendering. Fixes #1404 2016-07-04 10:05:59 +01:00
Murtuza Zabuawala 8246fc56e8 Offer the various serial pseudo-types as column type options. Fixes #1393 2016-06-29 19:50:43 +01:00
Murtuza Zabuawala 4267545e08 Handle special chars and spaces properly in select2 controls. Fixes #1292 2016-06-24 14:09:32 +01:00
Murtuza Zabuawala 4bb849c58c Allow toggling of the Primary Key option in the un-expanded column grid when defining a table. Fixes #1235 2016-06-24 14:05:59 +01:00
Murtuza Zabuawala e9ad27678f Allow maintenance operations on Index/Primary key/Unique constraints. Fixes #1390 2016-06-24 13:59:16 +01:00
Murtuza Zabuawala e4ef927da3 Fix tablespace statistics. Fixes #1196 2016-06-23 13:06:05 +01:00
Murtuza Zabuawala 8b0e65dc57 Allow default ACLs to be specified when creating schemas. Fixes #1108. 2016-06-23 13:03:18 +01:00
Murtuza Zabuawala 97d49af43a Fix constraint on server table to allow port 65535 to be used. Fixes #1388 2016-06-23 11:43:50 +01:00
Murtuza Zabuawala e5ee592470 Don't offer an option to drop the current maintenance database. Fixes #1382 2016-06-23 11:37:32 +01:00
Murtuza Zabuawala 3210975568 Fix creation of exclusion constraints. Fixes #1301 2016-06-21 12:01:39 +01:00
Murtuza Zabuawala a1f65e981f Fix an issue in query tool where it was not able to handle special characters in editor title. 
Fixes #1381
 2016-06-21 09:30:34 +01:00
Murtuza Zabuawala 1a84c35628 Fix an issue where the save button was not getting enable when user revoke ADMIN option from Role privileges. 
Issue: validation callback was missing in the control model.

Fixes #1302
 2016-06-20 13:20:51 +01:00
Murtuza Zabuawala 01801e4acb Fix date validation while creating new role. 
Fixes #1370
 2016-06-20 10:11:42 +01:00
Murtuza Zabuawala ac37d60c03 Fix the issue in Materialized view where user was not able to create Materialized view with PPAS 9.5 due to incorrect template path. 
Fixes #1379
 2016-06-20 10:03:38 +01:00
Murtuza Zabuawala bc4703c5b7 Fix the issue in backup/restore while selecting section-> data option, it was throwing error.. Fixes #1219 2016-06-17 14:01:30 +01:00
Murtuza Zabuawala b94b47f021 Fix issue which was showing incorrect datetime in Backup/Restore dialog. Fixes #1377 2016-06-17 13:54:31 +01:00
Murtuza Zabuawala 014eb2a5c2 Don't allow creation of edbspl trigger functions (they should be created as part of the trigger). Fixes #1212. 2016-06-17 13:46:42 +01:00
Murtuza Zabuawala c702ef9c48 Fix password encryption with non-alpha passwords. Fixes #1371 2016-06-16 20:32:57 +01:00
Murtuza Zabuawala a800b19c87 Fix display of NaN and Bytea data. Fixes #1350. Fixes #1309 2016-06-16 11:20:00 +01:00
Murtuza Zabuawala d4e5d9c4f4 Add "Move objects..” functionality in tablespace node. Fixes #1286 2016-06-15 13:21:01 +01:00
Murtuza Zabuawala 71ec9ef914 Add stats on Sequences/Functions/Trigger functions collection nodes. Fixes #1299 2016-06-15 11:53:58 +01:00
Murtuza Zabuawala 62c1369938 Add "Move objects..” functionality to tablespace node. Fixes #1286 
Additionally I have removed pre_9.1 sql's & align SQL line indentation as well.
 2016-06-14 14:53:48 +01:00
Murtuza Zabuawala fe1c86cbbe Fix SSL mode selection. Fixes #1144 2016-06-14 12:26:07 +01:00
Murtuza Zabuawala 1f9d0ffc54 Fix comment removal for various nodes. Fixes #1331 2016-06-13 16:22:50 +01:00
Murtuza Zabuawala d9804ae2a2 Add a menu option to reset the layout. Fixes #1248 2016-06-10 16:55:58 +01:00
Murtuza Zabuawala fcd33162a9 Fix role valid until date handling. Fixes #1107 2016-06-10 16:12:51 +01:00
Murtuza Zabuawala d7f5e95b2b Fix unwanted space indentation issue in Database node. 2016-06-08 12:56:56 +01:00
Murtuza Zabuawala 47007076cc Fix validation issue causing statistics tab to break if no node is selected on browser tree and user clicks on statistics tab. 2016-06-08 12:48:34 +01:00
Murtuza Zabuawala 61037d4f60 Fix styling of statistics table. Fixes #1315 2016-06-08 09:30:53 +01:00
Murtuza Zabuawala 4ace8bb5b6 Statistics support remaining object types that support them. 2016-06-07 13:16:12 +01:00
Murtuza Zabuawala ac2612264c Fix validation of object before using it 2016-06-07 12:37:58 +01:00
Murtuza Zabuawala 20a22731e0 Fix incorrect condition checking for privileges. 2016-06-07 12:37:02 +01:00
Murtuza Zabuawala 9ed2530b1f Fixes #1110 - Proper validation for the security labels. 2016-06-06 18:07:13 +05:30
Murtuza Zabuawala 6dbfb7db7e Fixes #1273 - Resolved an issue setting privileges on the SHELL type. 2016-06-03 15:58:10 +05:30
Murtuza Zabuawala 6501f4cf36 Fixes #1280 - Resolved issue in json encoding while dealing with the 
date format.
 2016-06-03 15:54:04 +05:30
Murtuza Zabuawala c14ff8e15e Fixes #1300 - Honour show system object in the table dialog, and do not 
show catalog schema tables.
 2016-06-03 15:45:13 +05:30
Murtuza Zabuawala 9c8637cf0f Corrected the z-index of backgrid-filter so that - it does not take 
precedence over top panel.
 2016-06-03 15:43:06 +05:30
Murtuza Zabuawala 6036c431b0 Fixes #1283, #1287 - Do not show null description in the create mode, 
corrected the index expression on table node.

Reported by Thom Brown.
 2016-06-03 15:41:24 +05:30
Murtuza Zabuawala 8b54b59f2b Fixes #1285 - Update the comments (description) over the tablespace 
properly.
 2016-06-03 15:36:47 +05:30
Murtuza Zabuawala 9436542074 Fixes #1223 - Do not allow to drop user from non-super user. 
Also - fixed some javascript variable scope issue in the 'delete_obj'
function of nodes.
 2016-06-03 15:32:33 +05:30
Murtuza Zabuawala 1bd37d1f76 Fixes #1275 Issue with Query tool for PPAS - not showing the correct output 2016-06-03 14:34:50 +05:30
Murtuza Zabuawala 40ab0b7c88 Fixes #1298 - ACL for the SEQUENCE node were not parsed properly. 2016-06-03 15:23:14 +05:30
Murtuza Zabuawala c3e2f5f212 Resolve threading issue in the dashboards. 2016-06-03 09:16:11 +01:00
Murtuza Zabuawala 1f25e90fa4 Fixes #1276 - Resolved an issue - 'TypeError: c is undefined on removing 
member type from Type=composite'.
 2016-06-02 15:31:07 +05:30
Murtuza Zabuawala bf042d46a2 Check valid DOMElement existance before accessing it while updating the 
menu updation.
 2016-06-02 15:01:16 +05:30
Murtuza Zabuawala 60208b7ae5 Fixes an issue rendering the dashboard, when data object is missing. 
Also, fixed an issue checking the existence of the data object before
accessing it in schema javascript module.
 2016-06-02 14:58:14 +05:30
Murtuza Zabuawala d202366a5d Fixes #1185 - While connecting to the server, application becomes almost 
inaccessible.

In stand (without threaded) mode, flask application is not able to
process more than one request at a time. Hence - even the client
(browser) send multiple request, when connecting the server (which is
inaccessible), rest of operations get blocked, as making the connection
with the database server is blocking operation.

In order to fix the issue, we're starting the application with thread
support, in which it will create a separate thread of each request.
 2016-06-02 14:51:33 +05:30
Murtuza Zabuawala 4482bbb1ba Fixed a typo in Type node javascript module. 2016-05-31 23:29:50 +05:30
Murtuza Zabuawala afcb62cfd6 Fixes #1262 - Do not allow to delete the default server group. 2016-05-31 13:48:07 +05:30
Murtuza Zabuawala 70cca42d61 Fixes #1147 - 65536 is valid port for PostgreSQL. 2016-05-29 16:04:10 +05:30
Murtuza Zabuawala f4cb7d8f9c Fixes #1231, #1237 
* 'Of type' can't be used with 'Like'.
* 'Of type' usage conflicts with adding columns.
 2016-05-29 16:02:08 +05:30
Murtuza Zabuawala c96f28b66f Fixes #1123 - Options other than 'Create' are not available in the 
procedure node.

This patch also includes other fixes related 'procedure' node as below:
* Generate correct statement for dropping procedure.
* Fetch the missing schema name for the EXEC script.
* Removed the 'DROP CASCADE' menu options, as it is not supported by
  procedure.
 2016-05-29 15:28:17 +05:30
Murtuza Zabuawala 100f075510 Fixes #1142 - Update the comments in edit mode for the function, 
procedure, trigger function nod objects.
 2016-05-28 19:47:12 +05:30
Murtuza Zabuawala fd0d740acc Fixes #1143 - Update the comments in edit mode for the foreign data 
wrapper, and foreign table objects.
 2016-05-28 19:45:12 +05:30
Murtuza Zabuawala c81977d441 Fixes #1136 - do not to allow create a server group with same name. 2016-05-25 00:00:28 +05:30
Murtuza Zabuawala 42a3b784ba Fixes #1135 - resolved an issue dropping a role with special characters. 2016-05-24 23:56:26 +05:30
Murtuza Zabuawala af84ba5a4f Fixed all the review comments from Dave. 
* Moved the Columns, and Constraint to its repective tabs.
* Ensure all the labels only have a capital letter on the first word
  (except for keywords or acronyms).
* Resolve the typo in string - 'System table'.
* Error messages on fields should not be shown unless the field loses
  focus and has an error.
* "General" section should have a limited subset of information.
* Variables grids should not be on the Security tab.
* Fixes the field labels that imply a question.
* Privileges controls on the Properties lists should be in a "Security"
  group.

Apart from review comments improved few other areas too:
* Used in-place DepsCell functionality for columns in both index, and
  type node.
* Improved the error handling in constraint nodes.
* Added create, alert SQL Help for nodes associated with the table node.
 2016-05-24 23:29:55 +05:30
Murtuza Zabuawala aa1c283514 Added Insert/Delete/Update script functionality for foreign table objects 2016-05-24 12:41:00 +05:30
Murtuza Zabuawala d2eaa8b3dd Adding support for the trigger functions node. 2016-05-21 15:09:44 +05:30
Murtuza Zabuawala 077075c765 Renaming the label of the browser left node after editing the properties 
properly.
 2016-05-21 15:06:14 +05:30
Murtuza Zabuawala 5ca63fba48 Initial version for generationg the CREATE/SELECT/EXEC scripts for the 
selected node.
 2016-05-16 00:25:34 +05:30
Murtuza Zabuawala 174363c9a7 Fixed typo for acl in tablespace node 2016-05-13 13:43:35 +05:30
Murtuza Zabuawala 83b6a04763 Added input validation and title of the prompt for 'Named Restore point' functionality 2016-05-10 16:04:47 +05:30
Murtuza Zabuawala 40a9490382 Check for the connection status before executing the statement for 
checking the 'server in recovery' information.

Thanks Khushboo for reporting the issue.
 2016-05-12 13:23:24 +05:30
Murtuza Zabuawala 23f0cf07ca Allow creation of named restore points. 2016-05-11 16:13:14 +01:00
Murtuza Zabuawala ce043fbe07 Python 3 compatibility fix - iteritems() is deprecated. 2016-05-10 17:01:11 +01:00
Murtuza Zabuawala 3eb51e93e7 Allow Werkzeug to be configured to bind to adaptors other than localhost for testing. 2016-05-06 15:25:52 +01:00
Murtuza Zabuawala 94303867dd Fix a typo introduced in a merge. 2016-05-06 13:58:31 +01:00
Murtuza Zabuawala dac514a4ae Added a new control for rendering the notes to be used by different 
tools/utitilities dialog.

Modified a little bit by Ashesh Vashi.
 2016-04-28 11:52:06 +05:30
Murtuza Zabuawala 973e2b1b4a Match the border style of the inline-fieldset with the other control. 2016-04-25 13:34:51 +05:30
Murtuza Zabuawala 49e433db4f Type fixes: 
- Renaming or changing the schema for a shell type should not be allowed.

- I'm allowed to try to add ACL entries or security labels to an
existing shell type. This should be disallowed.

- Changing the schema on a (non-shell) type doesn't work - the type
name is omitted, e.g.

ALTER TYPE pem
    SET SCHEMA pemhistory;

Which should be:

ALTER TYPE pem.foo
    SET SCHEMA pemhistory;
 2016-04-14 15:46:25 +01:00
Murtuza Zabuawala c047abd8a4 Fix various issues with Types, per discussion 2016-04-14 12:37:19 +01:00
Murtuza Zabuawala 6e237d16ca Add canAddRow/canEditRow/canDeleteRow functionality for Backgrid. 
This will allow user to check condition on individual opration(add/edit/delete row) rather than only while rendering the control.
 2016-04-13 15:54:17 +01:00
Murtuza Zabuawala ca277bc8b6 Type support 2016-04-07 12:27:33 +01:00
Murtuza Zabuawala 3914f5095a Fix sub-node error display. 2016-04-07 11:51:16 +01:00
Murtuza Zabuawala f7e4e8bea0 Use separate editor for Select2Cell. 
This allows us to use the Backgrid key navigation as expected.

This has also resulted into an issue - related unresponsive scrollbar
issue in the SubNodeControl.
 2016-04-04 15:36:31 +05:30
Murtuza Zabuawala 1a5eb0c417 Updated the template for the NodeAjaxOptionsControl, which was not honouring 
the disabled attribute due to missing quotes around values.
 2016-04-01 15:17:31 +05:30
Murtuza Zabuawala 0e044e1216 Fixed the refresh issue when a server gets disconnected. 2016-03-23 16:52:21 +05:30
Murtuza Zabuawala 12a0cb1ba1 [Python 3] Fixed the issue loading the value for the session key from the sqlite. 2016-03-23 12:40:11 +05:30
Murtuza Zabuawala 530f58e66b Add support for inline fieldsets. 2016-03-18 16:54:43 +00:00
Murtuza Zabuawala 3432481f9a Properly name the dbo and sys catalogs in PPAS. 2016-03-18 15:16:18 +00:00
Murtuza Zabuawala 9220dcaa97 Fix an issue with uneditable text fields containing large amounts of data, 2016-03-14 09:31:36 +00:00
Murtuza Zabuawala b6f7202448 Add support for collations. 2016-03-11 13:40:28 +00:00
Murtuza Zabuawala b747a5b5eb Update ACL parsing for tablespaces to use newer infrastructure. 2016-03-11 09:05:58 +00:00
Murtuza Zabuawala 5347bdb886 Added support for the catalog objects under special catalogs. (also, 
added support for columns under it).
 2016-03-11 01:09:06 +05:30
Murtuza Zabuawala 8a7ec6b452 Update "parse_priv_to_db" function to return list a instead of a string. 
This will also allow us to operate on individual privileges & also we
needed this functionality for column nodes.

For example,

*Earlier:* priv was string

GRANT {{ priv }} ON {{ type }} TO {{ conn|qtIdent(role) }};

*Now:* priv will be List, which we need to handle in jinja templates.

GRANT *{{ priv|join(', ') }}* ON {{ type }} TO {{ conn|qtIdent(role) }};
 2016-03-09 17:10:03 +00:00
Murtuza Zabuawala fa97b5635e Enable/disable edit button functionality conditionally in backgrid. 2016-03-04 11:55:50 +00:00
Murtuza Zabuawala 6ed5e7183e Backform control enhancements: 
1) Unique collection control: we have added 'Edit' button in grid, earlier it was only delete button.
2) Sql field control: We have added control to disabled & visible functionality which were not available.
 2016-03-04 11:00:17 +00:00
Murtuza Zabuawala a02b1a4813 Adding validation for the previleges control. 2016-02-10 13:01:14 +05:30
Murtuza Zabuawala dc51baefcc Adding more jinja2 template macros for the default previleges. 2016-02-10 13:00:19 +05:30
Murtuza Zabuawala 359dff0f78 Fixed the NodeAjaxOtionsControl formatter, which was causing malformed 
string, when have special character.
 2016-02-03 16:41:28 +05:30
Murtuza Zabuawala 79cd9d518c Modified the variable jinja2 macros to allow to set/reset multiple 
options in a single command, instead of multiple commands.
 2016-02-03 16:35:46 +05:30