mirror of
https://github.com/sphinx-doc/sphinx.git
synced 2026-10-14 01:12:10 -05:00
Make sure extensions specified with -D override extensions in config file.
Previously, a comma separated list of extensions was read and parsed correctly. However, the value was then stored in config hashtable, which was overwritten when the config file was parsed. Now, the config file is parsed first, and the the entry in the config hashtable is updated with the overriding extension, if it exists. Signed-off-by: mulhern <amulhern@redhat.com>
This commit is contained in:
1 parent
83472acc97
commit
189494c27e
1 file changed
+6
-5
+6
-5
@@ -276,11 +276,6 @@ class Config(object):
|
||||
self.overrides = overrides
|
||||
self.values = Config.config_values.copy()
|
||||
config = {}
|
||||
if 'extensions' in overrides: # XXX do we need this?
|
||||
if isinstance(overrides['extensions'], string_types):
|
||||
config['extensions'] = overrides.pop('extensions').split(',')
|
||||
else:
|
||||
config['extensions'] = overrides.pop('extensions')
|
||||
if dirname is not None:
|
||||
config_file = path.join(dirname, filename)
|
||||
config['__file__'] = config_file
|
||||
@@ -299,6 +294,12 @@ class Config(object):
|
||||
# these two must be preinitialized because extensions can add their
|
||||
# own config values
|
||||
self.setup = config.get('setup', None)
|
||||
|
||||
if 'extensions' in overrides:
|
||||
if isinstance(overrides['extensions'], string_types):
|
||||
config['extensions'] = overrides.pop('extensions').split(',')
|
||||
else:
|
||||
config['extensions'] = overrides.pop('extensions')
|
||||
self.extensions = config.get('extensions', [])
|
||||
|
||||
# correct values of copyright year that are not coherent with
|
||||
|
||||
Reference in new issue
Block a user